As a part of cleaning up inactive members (those with no activity within
the past 18 months) from OWNERS files, this commit moves gmarek from an
approver to an emeritus_approver.
Not all instances of docker run has the --rm argument, which means that they'll
persist after they've finished. This can cause storage to remain occupied needlessly.
In order to use buildx with docker versions prior to v20.10 experimental
features must be enabled. Setting at build time ensures that they are
in case they have not already been at the environment scope.
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
The conformance test image previously used the `FROM --platform …`
syntax which is something we (SIG Release) consider as deprecated.
Therefore we now switch to `docker buildx`, which can specify the
`--platform` directly.
Signed-off-by: Sascha Grunert <mail@saschagrunert.de>
Both images are now sane multi-architecture images and should fix the
kube-proxy container image in the same way.
Signed-off-by: Sascha Grunert <mail@saschagrunert.de>
The currently used debian:stretch-slim does not support s390x arch in
its multi-arch build. We opt to use stable-slim instead of pulling in
different base images for each platform build.
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Updates conformance image Dockerfile to specify platform for BASEIMAGE
and sets correct ARCH in Makefile.
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Many README files and other docs contained a link to a an appspot
tracking app that is no longer active. Following the links leads to an
error about Go 1.9 no longer being supported. Go 1.9 support was dropped
in appspot in 2019 and disabled June 2020.
This also resulted in a broken image link displaying when viewing these
files on GitHub. Since the app is no longer functioning, and since it
causes a potentially (but granted, minor) confusing error to display,
this just removes those links as I don't believe they are needed
anymore.
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
And same for go_test_conditional_pure.
Instead of aliasing. Aliases are annoying in a number of ways. This is
specifically bugging me now because they make the action graph harder to
analyze programmatically. By using aliases here, we would need to handle
potentially aliased go_binary targets and dereference to the effective
target.
The comment references an issue with `pure = select(...)` which appears
to be resolved considering this now builds.
- use bash-static and avoid dragging in all of debian-base
- use distroless as the base image
- the shell script needs a `cp` utility, add a go based one for just
files (no support for directories!)
- Rework the calls to `mv` and recursive `cp` in the code
- we don't need to support windows in this container image
- the test case was slightly off as it was assuming that the old
directory was copied into the new directory, but the desired
functionality is that all files in the old directory should be in the
new directory.
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
