Commit Graph

249 Commits

Author SHA1 Message Date
Benjamin Elder
4454ce6f37 fix shellcheck failures in health-monitor.sh 2020-02-14 16:12:18 -08:00
Joakim Roubert
405609b920 Fix shellcheck warnings/errors in /build/lib/release.sh
With these changes, /build/lib/release.sh can be removed from
hack/.shellcheck_failures and included in the scripts that are checked
by hack/verify-shellcheck.sh.

Signed-off-by: Joakim Roubert <joakimr@axis.com>
2020-02-04 11:00:58 +01:00
Guangming Wang
faf27331bc fix shell checks errors in cluster/common.sh
handle local variable in cluster/common.sh

add comment for shellcheck disable line, and fix error change

fix error: "read" parameters -r position

update function comment

refactor function find-release-tars

rm lines in .shellcheck_failures

Continue to cleanup common.sh
2019-12-25 16:35:11 +08:00
Jacek Kaniuk
7eb6182a63 Revert "Fix shellcheck failure in log-dump/log-dump.sh"
This reverts commit e99a325d4e.
2019-12-03 18:17:54 +01:00
toyoda
e99a325d4e Fix shellcheck failure in log-dump/log-dump.sh 2019-11-12 16:51:09 +09:00
Kubernetes Prow Robot
2eef011c38
Merge pull request #81345 from k-toyoda-pi/fix_shellcheck_validate-cluster
Fix shellcheck failures in cluster/validate-cluster.sh
2019-10-17 03:18:38 -07:00
Kubernetes Prow Robot
8387de4b4f
Merge pull request #82237 from SataQiu/fix-shellcheck-20190902
Fix shellcheck failures of cluster/addons/addon-manager/kube-addons.sh
2019-10-04 02:45:59 -07:00
toyoda
d9c7255ab4 Fix shellcheck failures in cluster/validate-cluster.sh 2019-10-01 15:35:39 +09:00
Kubernetes Prow Robot
23ec5b6e9e
Merge pull request #82357 from beautytiger/fix_shellcheck_config-common.sh
fix shellcheck in cluster/gce/config-common.sh
2019-09-20 16:17:24 -07:00
Kubernetes Prow Robot
257040c472
Merge pull request #81882 from phenixblue/master
Updates to resolve shellcheck issues in hack/lib/test.sh
2019-09-18 20:43:00 -07:00
Guangming Wang
cd929a98a0 fix shellcheck in cluster/gce/config-common.sh
add comment for exported values
2019-09-19 00:03:16 +08:00
Kubernetes Prow Robot
1bebaea417
Merge pull request #81061 from k-toyoda-pi/fix_shellcheck_flexvolume_node_setup
Fix shellcheck failure in gce/gci/flexvolume_node_setup.sh
2019-09-16 14:43:54 -07:00
Joe Searcy
1b7ba643bb Updates to resolve shellcheck issues
Removed hack/lib/test.sh from /hack/shellcheck_failures
Removed  and }s to satisfy shellcheck SC2004
Added double quotes to satisfy shellcheck SC2086
Converted array reference to access all elements to satisfy shellcheck SC2128
Updates to satisfy shellcheck SC2143
Updates to satisfy shellcheck SC2178 & SC2124
Updates to satisfy shellcheck SC2128
Updates to satisfy shellcheck SC2207

Remove double quotes to allow expansion. Fixed piping to grep -q

Removed quotes to allow for expansion on flags
2019-09-13 11:32:54 -07:00
toyoda
5c724f6eaa fix shellcheck failure in gci/flexvolume_node_setup.sh 2019-09-03 16:56:25 +09:00
SataQiu
35a7924327 fix shellcheck failures of cluster/addons/addon-manager/kube-addons.sh 2019-09-02 19:18:51 +08:00
toyoda
5563e20a56 fix shellcheck failure in test/image/image-util.sh 2019-08-28 13:56:44 +09:00
Kubernetes Prow Robot
d5173ef87e
Merge pull request #80971 from k-toyoda-pi/fix_shellcheck_test-e2e
Fix shellcheck failure in cluster/test-e2e.sh
2019-08-16 17:02:21 -07:00
aaa
40bf494e3f fix shellcheck failures in hack/test-integration.sh and hack/verify-test-featuregates.sh 2019-08-14 13:07:46 -04:00
toyoda
3582400e4f fix shellcheck failure in cluster/test-e2e.sh 2019-08-05 13:24:05 +09:00
toyoda
eb0e064489 Fix shellcheck failures in hack/verify-test-featuregates.sh 2019-08-02 13:43:04 +09:00
Xiangyang Chu
313044abd7 Fix shellcheck failures in test/cmd/l.*.sh 2019-07-17 17:07:22 +08:00
Xiangyang Chu
3a344c7168 Fix shellcheck failures in test/cmd/d.*.sh 2019-07-17 17:07:22 +08:00
Benjamin Elder
30bf22c10e fix shellcheck failures in test/e2e_node/conformance/run_test.sh 2019-06-27 21:12:08 -07:00
Kubernetes Prow Robot
85aaf7ea36
Merge pull request #79407 from BenTheElder/super-minor-shellcheck
clarify elasticsearch script as bash
2019-06-27 18:53:45 -07:00
Kubernetes Prow Robot
d86823a75f
Merge pull request #79320 from BenTheElder/more-swagger
fix hack/lib/swagger.sh, hack/lib/init.sh, hack/lib/version.sh shellcheck failures
2019-06-27 18:53:33 -07:00
Benjamin Elder
59c4eb2a38 fix hack/lib/version.sh shellcheck failures 2019-06-26 09:20:17 -07:00
Benjamin Elder
6fe891b737 fix shellcheck failures in cluster/restore-from-backup.sh 2019-06-25 23:45:07 -07:00
Benjamin Elder
1a28fbde4d clarify elastisearch script as bash 2019-06-25 22:19:45 -07:00
Benjamin Elder
9b4b5098e1 fix hack/lib/init.sh shellcheck failures 2019-06-25 22:09:32 -07:00
Benjamin Elder
a101acc7eb fix hack/lib/swagger.sh shellcheck failures 2019-06-25 22:09:31 -07:00
Benjamin Elder
0fad8eb36c fix hack/make-rules/make-help.sh shellcheck failures 2019-06-25 09:49:45 -07:00
Kubernetes Prow Robot
38e95b1a78
Merge pull request #79317 from BenTheElder/yikeshell
fix test/e2e_node/gubernator.sh shellcheck failures
2019-06-25 01:15:29 -07:00
Benjamin Elder
7e96be30ca fix hack/verify-no-vendor-cycles.sh shellcheck failures 2019-06-24 11:43:04 -07:00
Benjamin Elder
1741d9393d fix hack/pin-dependency.sh shellcheck failures 2019-06-24 11:43:04 -07:00
Benjamin Elder
47daf195a4 fix hack/update-vendor.sh shellcheck failures 2019-06-24 11:43:04 -07:00
Benjamin Elder
21d1d273c8 fix test/e2e_node/gubernator.sh shellcheck failures 2019-06-23 17:01:54 -07:00
Kubernetes Prow Robot
0f2b01ab33
Merge pull request #78022 from xychu/fix-shellchecks-g
Fix shellcheck failures in test/cmd/g.*sh
2019-06-20 20:46:35 -07:00
Kubernetes Prow Robot
ab3b24ac0a
Merge pull request #77798 from xychu/fix-shellchecks-b
Fix shellchecks in test/cmd/{b,c}.*.sh
2019-06-20 10:00:52 -07:00
Xiangyang Chu
99b2184993 Fix shellcheck faulures in test/cmd
Including files after test/cmd/n*
2019-06-17 14:04:34 +08:00
Kubernetes Prow Robot
0f5650d68b
Merge pull request #75859 from k-toyoda-pi/fix_shellcheck_failure_make-rules
fix shellcheck failures in /hack/make-rules/test.sh
2019-06-13 20:36:47 -07:00
Kubernetes Prow Robot
8305729d7a
Merge pull request #74635 from xychu/fix-with-assert
Fix shellchecks follow the `${var:?}` pattern
2019-06-13 19:12:45 -07:00
Xiangyang Chu
81eb22900b Fix shellchecks in test/cmd/{b,c}.*.sh 2019-06-04 14:42:01 +08:00
Xiangyang Chu
eee32a6a88 Fix shellcheck failures in test/cmd/g.*sh 2019-05-17 15:40:14 +08:00
Kohei Toyoda
62d5eb524b
Merge branch 'master' into fix_shellcheck_failure_make-rules 2019-05-17 08:43:08 +09:00
Kubernetes Prow Robot
fe895f0411
Merge pull request #76420 from k-toyoda-pi/fix_shellcheck_failure_make-rules_3
fix shellcheck failures in /hack/make-rules/update.sh,verify.sh
2019-05-15 19:19:42 -07:00
Jordan Liggitt
43c8eb6c36 Revert "fix shellcheck failures of hack/verify-no-vendor-cycles.sh"
This reverts commit e25e5a63e7.
2019-05-13 19:14:03 -04:00
Kubernetes Prow Robot
1c18c3263a
Merge pull request #77386 from SataQiu/fix-shellcheck-20190503
Fix shellcheck failures of cluster/gce/upgrade-aliases.sh
2019-05-10 21:30:24 -07:00
Kubernetes Prow Robot
07e3b7cdca
Merge pull request #74639 from xychu/fix-shellchecks-a
Make test/cmd/a*.sh pass shellcheck
2019-05-10 10:38:12 -07:00
toyoda
bbe4a9fdc5 fix shellcheck failures in /hack/make-rules/clean.sh,test.sh,vet.sh 2019-05-09 13:40:35 +09:00
toyoda
9a5655c915 fix shellcheck failures in /hack/make-rules/update.sh,verify.sh 2019-05-07 14:27:26 +09:00