Commit Graph

11109 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
244fbf94fd Merge pull request #122698 from daniel-hutao/feat-1
Code Cleanup: Redundant String Conversions and Spelling/Grammar Corrections
2024-02-05 16:57:07 -08:00
Kubernetes Prow Robot
77775d4546 Merge pull request #123052 from jsafrane/clean-file-subpath
Fix cleanup of file subpaths
2024-02-05 11:42:58 -08:00
Kubernetes Prow Robot
980033ee81 Merge pull request #122999 from marosset/fix-windows-stats-cpu-nano-seconds-usage
fixing issue with GetCPUUsageNanoCores on Windows
2024-02-05 11:42:47 -08:00
Kubernetes Prow Robot
ce28021839 Merge pull request #121923 from saschagrunert/resources-windows
Enable pod container resources tests on Windows
2024-02-05 08:45:08 -08:00
Kubernetes Prow Robot
06cecaec52 Merge pull request #122819 from yanggangtony/clean-kubelet-server-codes
Clean unused code in kubelet server.
2024-02-05 07:21:36 -08:00
Hemant Kumar
d190fa3e7d Fix race condition between external-resizer and kubelet
This fixes the race condition that could happen because
resize controller just finished volume expansiona and has only
finished marking PV and yet to mark PVC.

The workaround proposed here should not be necessary once
RecoverVolumeExpansionFailure goes GA/beta.
2024-01-31 12:23:56 -05:00
Jan Safranek
593654eaa3 Fix cleanup of file subpaths
Allow kubelet orphan cleanup to delete both files and empty directories as
subpath mount points.

A pod does not need to use a directory as a subpath, it can use a file
(unix domain socket, pipe, ...) too. Therefore the cleanup should use
`os.Remove` that deletes both files and empty directories.
2024-01-31 15:13:03 +01:00
Tim Allclair
77f03c1744 Don't export single-use types 2024-01-30 12:02:23 -08:00
Tim Allclair
01155f59c3 Merge pkg/util/config into pkg/kubelet/config 2024-01-30 11:57:35 -08:00
Kubernetes Prow Robot
7abf6770fd Merge pull request #122147 from pohly/kubelet-context-support
kubelet: enhance context support
2024-01-27 05:16:17 -08:00
Daniel Hu
1baf7d4586 Corrected some spelling and grammatical errors
Signed-off-by: Daniel Hu <farmer.hutao@outlook.com>
2024-01-27 10:10:25 +08:00
Mark Rossetti
85684ec485 fixing issue with GetCPUUsageNanoCores on Windows 2024-01-26 10:37:21 -08:00
Kubernetes Prow Robot
3da22db11c Merge pull request #121499 from matte21/add-comments-to-cpu-accumulator
Improve understandability of kubelet's cpu accumulator code
2024-01-26 00:56:21 +01:00
yanggang
98054dd9d3 Clean unused code in kubelet server.
Signed-off-by: yanggang <gang.yang@daocloud.io>
2024-01-17 01:01:39 +00:00
Daniel Hu
d652596e42 Remove redundant string conversions in print statements
Signed-off-by: Daniel Hu <farmer.hutao@outlook.com>
2024-01-15 09:57:35 +08:00
KubeKyrie
9860e12d6e expected and actual field position adjustment
Signed-off-by: KubeKyrie <shaolong.qin@daocloud.io>
2024-01-13 12:16:14 +08:00
Kubernetes Prow Robot
ccb1d08162 Merge pull request #121834 from vaibhav2107/eviction-update
Added Imagefs inodes in default Eviction Hard
2024-01-09 21:18:16 +01:00
Akihiro Suda
2e999fff02 Fix compiling e2e.test on macOS
Fix issue 122650 (regression in PR 122552)

```
$ make WHAT=test/e2e/e2e.test
+++ [0109 10:06:53] Building go targets for darwin/amd64
    k8s.io/kubernetes/test/e2e/e2e.test (test)
package k8s.io/kubernetes/test/e2e
        imports k8s.io/kubernetes/test/e2e/common
        imports k8s.io/kubernetes/test/e2e/common/node
        imports k8s.io/kubernetes/pkg/kubelet
        imports github.com/opencontainers/runc/libcontainer/userns: C source files not allowed when not using cgo or SWIG: userns_maps.c
!!! [0109 10:06:54] Call tree:
!!! [0109 10:06:54]  1: /Users/suda/gopath/src/k8s.io/kubernetes/hack/lib/golang.sh:948 kube::golang::build_binaries_for_platform(...)
!!! [0109 10:06:54]  2: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
!!! [0109 10:06:54] Call tree:
!!! [0109 10:06:54]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
!!! [0109 10:06:54] Call tree:
!!! [0109 10:06:54]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
make: *** [all] Error 1
```

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2024-01-09 10:42:20 +09:00
Kubernetes Prow Robot
6427e2c9c8 Merge pull request #122578 from carlory/lock-default-ConsistentHTTPGetHandlers
lock GA feature-gate ConsistentHTTPGetHandlers to default
2024-01-04 18:00:52 +01:00
Kubernetes Prow Robot
0babde6bac Merge pull request #122475 from pacoxu/patch-9
fix nil pointer dereference when EventedPLEG is enabled
2024-01-04 18:00:43 +01:00
Kubernetes Prow Robot
2b1ccec47e Merge pull request #122087 from fatsheep9146/fix-kubelet-trace-broke
fix kubelet trace broke in 1.28
2024-01-04 17:59:39 +01:00
Kubernetes Prow Robot
e1576c8e43 Merge pull request #121924 from saschagrunert/leaky
Remove `leaky` package and move `PodInfraContainerName` to staging
2024-01-04 17:59:30 +01:00
Kubernetes Prow Robot
c96d7a5b5a Merge pull request #121774 from charles-chenzz/increase_timeout_in_dra_shouldTimeOut
increase timeout in fakeDraDriverGrpcServer to fix flake
2024-01-04 17:59:12 +01:00
Kubernetes Prow Robot
014149d66e Merge pull request #121565 from srivastav-abhishek/logs_test_datarace
[FLAKE] Fixed UT pkg/kubelet/kuberuntime/logs/TestReadRotatedLog caused due to data race
2024-01-04 16:49:23 +01:00
carlory
55c5db172e lock GA feature-gate ConsistentHTTPGetHandlers to default 2024-01-04 15:12:08 +08:00
Paco Xu
feb833f129 fix nil pointer dereference when EventedPLEG is enabled 2023-12-25 16:09:30 +08:00
Kubernetes Prow Robot
2b5c0c281d Merge pull request #122310 from weilaaa/use_buildin_max_min_instead
use build-in max and min func to instead of k8s.io/utils/integer funcs
2023-12-18 19:25:34 +01:00
Kubernetes Prow Robot
e6acd1caf5 Merge pull request #122330 from dims/remove-unused-code-in-kubelet
Remove unused code in kubelet - DockerContainer / ContainerInfo / SubcontainerInfo / WatchEvents
2023-12-16 23:46:02 +01:00
Davanum Srinivas
642574e964 WatchEvents seems useless
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-12-15 17:07:20 -05:00
Davanum Srinivas
aee1d54a0d Drop SubcontainerInfo
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-12-15 16:58:00 -05:00
Davanum Srinivas
c865ad532a fixing based on feedback in PR
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-12-15 16:51:15 -05:00
Kubernetes Prow Robot
c633ea71ed Merge pull request #122211 from gnufied/fix-uncertain-raw-block-devices
Fix device uncertain errors on reboot
2023-12-15 15:42:40 +01:00
Davanum Srinivas
d621e09a52 remove unused GetRawContainerInfo
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-12-15 05:56:22 -08:00
weilaaa
eb8f3f194f use build-in max and min func to instead of k8s.io/utils/integer funcs 2023-12-15 15:09:11 +08:00
Davanum Srinivas
e2cf9692fc Remove unused code in kubelet - take 1
spotted `DockerContainer` in types.go and pulling on whether we
really needed it found that a bunch of code is not really
required.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-12-14 13:31:38 -08:00
Hemant Kumar
e706b6ba14 Use a separate function for checking if device was reconstructed 2023-12-14 11:37:47 -05:00
Kubernetes Prow Robot
30bb24b1c3 Merge pull request #121913 from liggitt/testing-dep
Drop testing dependency from shipped binaries
2023-12-13 23:55:56 +01:00
Kubernetes Prow Robot
8cc47b64b2 Merge pull request #121795 from carlory/cleanup-after-blockvolume-featuregate-removed
cleanup todo after feature.BlockVolume gate was removed
2023-12-13 23:54:43 +01:00
Kubernetes Prow Robot
26e2cc5299 Merge pull request #119923 from cvvz/fix-119921
fix: Mount point may become local without calling `NodePublishVolume` after node rebooting
2023-12-13 21:25:51 +01:00
Kubernetes Prow Robot
3c1356bc9b Merge pull request #119764 from linxiulei/reservedTypo
Fix error message for invalid resource reservation
2023-12-13 21:25:42 +01:00
Hemant Kumar
56dd5ab10f Add tests for checking of uncertain device paths 2023-12-11 17:15:16 -05:00
Hemant Kumar
ed0facacfa Fix device uncertain errors on reboot 2023-12-06 22:19:14 -05:00
Ziqi Zhao
e92501b8fc optimize the comment
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-12-05 22:46:27 +08:00
Ziqi Zhao
51495bb4c5 optimize the unit test
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-12-05 08:02:03 +08:00
Ziqi Zhao
69c40a3396 fix lints
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-12-02 19:37:49 +08:00
Ziqi Zhao
24c4d6f7c9 add unit test for kubelet trace
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-12-02 17:09:01 +08:00
Patrick Ohly
d11511b1e8 kubelet: enhance context support
27a68aee3a introduced context support for events. Creating an event
broadcaster with context makes tests more resilient against leaking goroutines
when that context gets canceled at the end of a test and enables per-test
output via ktesting.

To use this in kubelet, a more thorough code update is needed. For now,
context.TODO serves as a reminder that this is necessary.
2023-12-01 10:15:01 +01:00
Ziqi Zhao
f035fea63a remove unnecessary code
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-11-29 09:59:53 +08:00
Ziqi Zhao
6d92b330e3 use ctx withoutcancel
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-11-28 23:43:33 +08:00
Ziqi Zhao
90fc108f6d fix kubelet trace broke in 1.28
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-11-28 20:02:23 +08:00