github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
96,061 Commits 1 Branch 31 Tags 1,019 MiB
acb43c7c4a
Commit Graph

5152 Commits

Author SHA1 Message Date
Cheng Xing
ef3d66b98b Parallelize attach operations across different nodes for volumes that allow multi-attach 2020-03-05 22:22:05 -08:00
Mike Danese
76f8594378 more artisanal fixes 
Most of these could have been refactored automatically but it wouldn't
have been uglier. The unsophisticated tooling left lots of unnecessary
struct -> pointer -> struct transitions.
 2020-03-05 14:59:47 -08:00
Mike Danese
aaf855c1e6 deref all calls to metav1.NewDeleteOptions that are passed to clients. 
This is gross but because NewDeleteOptions is used by various parts of
storage that still pass around pointers, the return type can't be
changed without significant refactoring within the apiserver. I think
this would be good to cleanup, but I want to minimize apiserver side
changes as much as possible in the client signature refactor.
 2020-03-05 14:59:46 -08:00
Mike Danese
c58e69ec79 automated refactor 2020-03-05 14:59:46 -08:00
Kubernetes Prow Robot
0836b583f7
Merge pull request #85289 from serathius/remove-prometheus-controller-endpointslice 
Remove prometheus references from pkg/controller/endpointslice
 2020-03-05 02:58:37 -08:00
Kubernetes Prow Robot
4d19c6f2ad
Merge pull request #87537 from uthark/oatamanenko/apiversion 
Fixes #87506 Add apiVersion to involvedObject
 2020-03-04 02:31:47 -08:00
Kubernetes Prow Robot
9d0cbb7503
Merge pull request #88673 from jsafrane/block-feature-ga 
Promote block volumes to GA
 2020-03-03 12:17:12 -08:00
Kubernetes Prow Robot
62dc3ea6d1
Merge pull request #87368 from 928234269/fix_staticcheck01 
fix staticcheck errors in pkg/controller/daemon.
 2020-03-03 12:15:28 -08:00
Kubernetes Prow Robot
c86aec0564
Merge pull request #88745 from mborsz/slice3 
Implement simple endpoint slice batching
 2020-03-03 03:03:38 -08:00
Maciej Borsz
49b11b5431 Implement simple endpoint slice batching 2020-03-03 08:16:42 +01:00
Jan Safranek
3af671011a Generated API 2020-03-02 22:21:42 +01:00
Kubernetes Prow Robot
62e993ce09
Merge pull request #88401 from gongguan/volume_binder 
refactor volume binder
 2020-03-02 09:16:44 -08:00
Julian V. Modesto
da3c3432d8 Add context and options to scale client 2020-03-02 00:03:26 -05:00
Marek Siarkowicz
4ea52da628 Remove prometheus references from pkg/controller/endpointslice 2020-02-29 15:10:23 +01:00
Kubernetes Prow Robot
03b7f272c8
Merge pull request #88246 from munnerz/csr-signername-controllers 
Update CSR controllers & kubelet to respect signerName field
 2020-02-28 23:38:39 -08:00
louisgong
c6b94e4606 refactor volume binder 2020-02-29 12:03:39 +08:00
Jan Safranek
2c1b743766 Promote block volume features to GA 2020-02-28 20:48:38 +01:00
Patrick Ohly
6329b17d2f volume scheduler: introduce special string type 
This makes it possible to search for the special strings more easily
(https://github.com/kubernetes/kubernetes/pull/88230#discussion_r382367043).
 2020-02-28 10:09:19 +01:00
Patrick Ohly
6eb0b034ac volume scheduler: move reason strings into volume code 
The scheduler doesn't really need to know in detail which reasons
rendered a node unusable for a node. All it needs from the volume
binder is a list of reasons that it then can present to the user.

This seems a bit cleaner. But the main reason for the change is that
it simplifies the checking of CSI inline volumes and perhaps later
capacity checking. Both will lead to new failure reasons, which then
can be added without changing the interface.
 2020-02-28 10:09:18 +01:00
James Munnelly
d5dae04898 certificates: update controllers to understand signerName field 
Signed-off-by: James Munnelly <james.munnelly@jetstack.io>
 2020-02-27 15:54:31 +00:00
James Munnelly
a983356caa Add signerName field to CSR resource spec 
Signed-off-by: James Munnelly <james.munnelly@jetstack.io>
 2020-02-27 10:17:55 +00:00
Kubernetes Prow Robot
f3d38fcd4f
Merge pull request #88516 from boddumanohar/issues/87447 
Use servicePatch methods from cloud-provider repo in service-controller
 2020-02-26 19:39:44 -08:00
Kubernetes Prow Robot
55f2d91c8c
Merge pull request #88447 from taesunny/pkg/controller 
Fix pkg/controller typos in some error messages, comments etc
 2020-02-26 19:39:19 -08:00
Kubernetes Prow Robot
a726c9c9cb
Merge pull request #88435 from andrewsykim/ccm-clean-up 
move well known cloud provider taints to k8s.io/cloud-provider/api
 2020-02-26 13:33:41 -08:00
Kubernetes Prow Robot
d98975217a
Merge pull request #88525 from mborsz/bench3 
Reorder conditions in FindMatchingVolume to avoid calling volumeutil.CheckNodeAffinity in trivial cases
 2020-02-26 09:46:40 -08:00
taesun_lee
79680b5d9b Fix pkg/controller typos in some error messages, comments etc 
- applied review results by LuisSanchez
- Co-Authored-By: Luis Sanchez <sanchezl@redhat.com>

genernal -> general
iniital -> initial
initalObjects -> initialObjects
intentionaly -> intentionally
inforer -> informer
anotother -> another
triger -> trigger
mutli -> multi
Verifyies -> Verifies
valume -> volume
unexpect -> unexpected
unfulfiled -> unfulfilled
implenets -> implements
assignement -> assignment
expectataions -> expectations
nexpected -> unexpected
boundSatsified -> boundSatisfied
externel -> external
calcuates -> calculates
workes -> workers
unitialized -> uninitialized
afater -> after
Espected -> Expected
nodeMontiorGracePeriod -> NodeMonitorGracePeriod
estimateGrracefulTermination -> estimateGracefulTermination
secondrary -> secondary
ShouldRunDaemonPodOnUnscheduableNode -> ShouldRunDaemonPodOnUnschedulableNode
rrror -> error
expectatitons -> expectations
foud -> found
epackage -> package
succesfulJobs -> successfulJobs
namesapce -> namespace
ConfigMapResynce -> ConfigMapResync
 2020-02-27 00:15:33 +09:00
Maciej Borsz
7d59ea8394 Reorder conditions in FindMatchingVolume to avoid checking NodeAffinity 
in trivial cases.
 2020-02-26 09:20:38 +01:00
Rob Scott
6a33727632
Adding AppProtocol to Service and Endpoints Ports 2020-02-25 17:42:34 -08:00
Manohar Reddy
7b2a0a4260 update bazel 2020-02-26 06:14:19 +05:30
Manohar Reddy
08473a4949 remote patch.go and patch_test.go files 2020-02-25 20:13:43 +05:30
Manohar Reddy
1c0a78a4fd Use servicePatch methods from cloud-provider repo in service-controller 2020-02-25 16:28:37 +05:30
andrewsykim
8c633356df move well known cloud provider taints to k8s.io/cloud-provider/api 
Signed-off-by: andrewsykim <kim.andrewsy@gmail.com>
 2020-02-23 19:54:59 -05:00
Andrew Sy Kim
8b490dea3a service controller: add OnAdd and OnDelete node event handlers 
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
 2020-02-20 12:56:47 -05:00
s-ito-ts
e6b9a7a309 Fix golint errors in pkg/controller/garbagecollector 2020-02-20 04:46:02 +00:00
Kubernetes Prow Robot
da9f47eadf
Merge pull request #88146 from gnufied/avoid-multiple-pv-delete 
Prevent deletion of PVs that are already deleted
 2020-02-19 12:40:48 -08:00
Kubernetes Prow Robot
3a24c32345
Merge pull request #87980 from tnqn/endpointslicetracker 
EndpointSliceTracker should track updated resource version
 2020-02-18 19:10:25 -08:00
Hemant Kumar
d9f7a1f311 Don't call delete for already deleted volumes 2020-02-18 15:59:47 -05:00
Nan Yu
89bb7d8454 Honor the RevisionHistoryLimit in StatefulSetSpec 
The StatefulSet controller cleans up ControllerRevisions at the end of
the reconcile loop. If something goes wrong during reconcile, it bails
out without actually performing this step. This commit moves the cleanup
to a deferred function call to guarantee it will be executed.

Fixes issue: https://github.com/kubernetes/kubernetes/issues/85690
 2020-02-18 10:42:38 -08:00
Kubernetes Prow Robot
1a0f923a65
Merge pull request #87712 from alena1108/jan30kubelet 
Ineffassign fixes for pkg/controller and kubelet
 2020-02-14 14:29:27 -08:00
Kubernetes Prow Robot
7fe64ccb82
Merge pull request #84984 from cofyc/fix84942 
apps/StatefulSets: Garbage collector should be able to orphan ControllerRevisions too
 2020-02-14 01:06:18 -08:00
David Zhu
81668cb887 Change migrated-to annoation key to follow best practices by removing beta and using 'pv' prefix 2020-02-12 10:33:08 -08:00
Quan Tian
c2d3e54551 EndpointSliceTracker should track updated resource version 
During EndpointSlice reconcilation, EndpointSliceTracker is supposed to
track expected EndpointSlice resource versions so that external changes
to them can be detected. But it actually tracked the stale resource
version and resulted in every Service was handled twice as it always
received an EndpointSlice update with a different resource version but
was actually created/updated by itself during the first processing.
 2020-02-10 21:47:07 +08:00
Yecheng Fu
bb2b50f3db Garbage collector should orphan ControllerRevisions too 
Signed-off-by: Yecheng Fu <fuyecheng@pingcap.com>
 2020-02-10 20:58:28 +08:00
Mike Danese
bfc75d9a5c manual fixes 2020-02-08 12:32:33 -05:00
Mike Danese
25651408ae generated: run refactor 2020-02-08 12:30:21 -05:00
Mike Danese
2637772298 some manual fixes 2020-02-07 18:17:40 -08:00
Mike Danese
3aa59f7f30 generated: run refactor 2020-02-07 18:16:47 -08:00
Kubernetes Prow Robot
8215619ba4
Merge pull request #87642 from pohly/volume-binder-testing 
volume binder testing
 2020-02-07 05:56:39 -08:00
Alexander Zimmermann
e0b1e9206d
Clarified comments 2020-02-07 09:09:49 +01:00
Kubernetes Prow Robot
9c1e124b15
Merge pull request #87823 from tallclair/test-tokens 
Ensure testing credentials are labeled as such
 2020-02-06 17:47:29 -08:00
Kubernetes Prow Robot
04e28b3674
Merge pull request #87098 from davidz627/feature/migratedRollback 
Add annotation updating for migration for PVs and PVCs
 2020-02-06 17:45:32 -08:00
Alexander Zimmermann
a1c837022c
Fixed Golint errors in pkg/controller/podautoscaler 2020-02-06 17:16:38 +01:00
Tim Allclair
9d3670f358 Ensure testing credentials are labeled as such 2020-02-04 10:36:05 -08:00
Kubernetes Prow Robot
fa4bc10ef1
Merge pull request #86793 from prameshj/gce-finalizer 
Attach a new finalizer in GCE ILB creation.
 2020-01-30 21:20:32 -08:00
Alena Prokharchyk
6c3093f970 Ineffassign fixes for pkg/controller and kubelet 2020-01-30 14:35:10 -08:00
Kubernetes Prow Robot
7164152844
Merge pull request #87664 from liggitt/revert-parallel-volume 
Revert "Merge pull request #87258 from verult/slow-rxm-attach"
 2020-01-29 22:12:01 -08:00
Jordan Liggitt
cd1059e3c4 Revert "Merge pull request #87258 from verult/slow-rxm-attach" 
This reverts commit 15c3f1b119, reversing
changes made to 52d7614a8c.
 2020-01-29 14:58:32 -05:00
Mike Danese
968adfa993 cleanup req.Context() and ResponseWrapper 2020-01-29 08:50:45 -08:00
Mike Danese
d55d6175f8 refactor 2020-01-29 08:50:45 -08:00
Patrick Ohly
a3c434510d volume binder: enable klog flags in test 
When debugging the test runs it is useful to increase the log level:

go test -v ./pkg/controller/volume/scheduling -args -v 5
 2020-01-29 10:37:39 +01:00
Patrick Ohly
5c8929d95e volume binder: convert to sub-tests 
Using t.Run() has some advantages:
- individual sub-tests can be selected with -run
- test failures are automatically associated with
  the scenario, therefore the test name no longer
  needs to be passed around

A "run" function is used primarily to avoid large indention changes,
but also because this can be used to extend the test with additional
parameters later on.
 2020-01-29 10:37:27 +01:00
Kubernetes Prow Robot
f5a008746a
Merge pull request #83526 from eloyekunle/feat/gengo-reverse-import 
import-boss reverse import
 2020-01-28 18:50:13 -08:00
Pavithra Ramesh
1de2327afc Attach a new finalizer in GCE ILB creation. 
Add logic in service_controller to skip create/update
if finalizer from a different controller is found.

The newly added finalizer will be checked by other controllers
implementing ILB services to determine if a given service is
already being managed by service_controller.

Moved finalizer check into cloudprovider code.

added unit test to verify new finalizer.

Modified existing unit test to create a fake service so that
attach/remove finalizer step can be tested.
 2020-01-28 15:02:19 -08:00
Oleg Atamanenko
427f0f9463 Add apiVersion to involvedObject 2020-01-28 09:24:08 -08:00
Elijah Oyekunle
07e3cca6d0 update existing import-restrictions files 2020-01-28 10:51:45 +01:00
David Zhu
b7817a2981 Add annotation annealing for migration for PVs and PVCs during syncVolume and syncClaim. This allows external-provisioners to pick up and delete volumes when they have been rolled up from previous kubernetes versions. 2020-01-27 16:14:53 -08:00
Cheng Xing
c6a03fa5be Parallelize attach operations across different nodes for volumes that allow multi-attach 2020-01-27 15:02:25 -08:00
Kubernetes Prow Robot
dc090f80d1
Merge pull request #87406 from haosdent/remove-algo 
Remove `scheduler/algorithm/priorities` in import-restrictions
 2020-01-23 11:34:24 -08:00
Kubernetes Prow Robot
c5d981583a
Merge pull request #87308 from KobayashiD27/fix-staticcheck 
Fix staticcheck in pkg/controller/podgc
 2020-01-23 11:34:11 -08:00
David Eads
5c2d2c5ef1 rename dynamic cert loading to be more accurate 2020-01-22 15:00:46 -05:00
David Eads
6ccfc3aecf add dynamic reloading for CSR signing controllers 2020-01-22 15:00:46 -05:00
Kubernetes Prow Robot
e4926e2d70
Merge pull request #85421 from terrytangyuan/patch-1 
Fix grammar: have -> has
 2020-01-22 08:40:58 -08:00
Haosdent Huang
b09e35257a Remove scheduler/algorithm/priorities in import-restrictions 2020-01-22 11:54:28 +08:00
yiyang5055
53aff819e0 fix static check failure in pkg/controller/disruption and pkg/controller/namespace/deletion 2020-01-20 09:10:46 +00:00
Sakura
203c7b4731
fix staticcheck errors in pkg/controller/daemon. 
Signed-off-by: Sakura <longfei.shang@daocloud.io>
 2020-01-19 21:09:05 +08:00
Kubernetes Prow Robot
073da1588a
Merge pull request #86801 from likakuli/fix_syncsts_orphanrevision 
fix a bug that orphan revision cannot be adopted and statefulset cannot be synced
 2020-01-19 00:07:35 -08:00
Kobayashi Daisuke
ed1381e35f Fix staticcheck in pkg/controller/podgc 2020-01-17 15:42:38 +09:00
Paul Morie
afaea605f4 Remove Brad Childs from OWNERS files 2020-01-16 15:21:34 -05:00
Jordan Liggitt
054e3846fc Use v1 subjectaccessreview API in controller-manager CSR approver 2020-01-13 15:55:52 -05:00
Kewei Ma
34fce9faee
Fix a comment in job_controller 2020-01-13 10:09:06 -06:00
Kubernetes Prow Robot
ace98e1382
Merge pull request #84433 from yamt/comment-typo 
Fix a comment typo in legacyNodeRoleBehaviorFeature
 2020-01-10 17:17:38 -08:00
Kubernetes Prow Robot
240782c7f7
Merge pull request #87043 from zjs/topic/propagate-providerid-errors 
Ensure a provider ID is set on a node if expected
 2020-01-10 14:33:50 -08:00
Zach Shepherd
2b554079af
Ensure a provider ID is set on a node if expected 
A transient issue might occur that causes an error to be returned by
InstanceID(). When this is ignored, the external cloud provider taint
will be removed and neither AddCloudNode() nor UpdateCloudNode() will
try to set a provider ID in the future.

By returning the error we can ensure that the external cloud provider
taint is not removed prematurely, allowing the operation to be retried
(until the provider ID can be set).

Preserve support for external cloud providers that do not use IDs by
continuing if a NotImplemented error is returned, making a distinction
between lack of support for provider IDs and an actual error.

Introduce pair of unit tests that show a provider ID will eventually
be set if an error is returned, unless that error is a NotImplemented,
in which case the external cloud provider taint will be removed.
 2020-01-10 11:00:54 -08:00
Kubernetes Prow Robot
3ccdad175a
Merge pull request #86210 from draveness/feature/remove-ga-flags 
feat: remove several feature gates in 1.18
 2020-01-09 13:28:50 -08:00
Kubernetes Prow Robot
1e0bfae887
Merge pull request #86871 from gosoon/master 
fix log message error in nodelifecycle
 2020-01-08 02:58:33 -08:00
likakuli
10864d3366 fix a bug that orphan revision cannot be adopted and sts cannot be synced 2020-01-08 17:56:41 +08:00
Kubernetes Prow Robot
f3df7a2fdb
Merge pull request #86727 from mattjmcnaughton/mattjmcnaughton/remove-recorder-PastEventf 
Remove `recorder.PastEventf` method
 2020-01-07 04:38:49 -08:00
tianfeiyu
fddf50cf88
fix log message error in nodelifecycle 2020-01-06 21:02:08 +08:00
Abdullah Gharaibeh
041e5b5560 addressed comments 2020-01-04 01:14:24 -05:00
Abdullah Gharaibeh
7d604c318c Break DS controller on scheduler predicates and predicate errors 2020-01-03 13:05:07 -05:00
mattjmcnaughton
92940fa80d
Remove recorder.PastEventf method 
The `recorder.PastEventf` method wasn't actually working as advertised.
It was supposed to accept a timestamp, which would be used when
generating the event. However, as the
[source code](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/record/event.go#L316)
shows, this `timestamp` was never actually used.

In other words, `PastEventf` is identical to `Eventf`.

We have two options: one would be to fix `PastEventf` so that it works
as advertised. The other would be to delete `PastEventf` and only
support `Eventf`.

Ultimately, I could only find one use of `PastEventf` in the code base,
so I propose we just delete `PastEventf` and convert all uses to
`Eventf`.
 2019-12-30 12:00:23 -05:00
Kubernetes Prow Robot
d4ba10ec80
Merge pull request #85703 from robscott/endpointslice-controller-race-fix 
Fixing Potential Race Condition in EndpointSlice Controller.
 2019-12-26 17:59:52 -08:00
Rob Scott
c75787bb77
Fixing Potential Race Condition in EndpointSlice Controller. 
This adds a new EndpointSlice tracker to keep track of the expected resource versions of EndpointSlices associated with each Service managed by the EndpointSlice controller. This should prevent a potential race where a syncService call could happen with an incomplete view of EndpointSlices if additions or deletions hadn't fully propagated to the cache yet. Additionally, this ensures that external changes to EndpointSlices will be handled by the EndpointSlice controller.
 2019-12-26 12:15:38 -08:00
danielqsj
5bc0e26c19 unify alias of api errors under pkg and staging 2019-12-26 16:42:28 +08:00
Alvaro Aleman
18fa7bdb6e Cloud node controller: Only call once into cloud provider 2019-12-17 20:03:27 +01:00
Kubernetes Prow Robot
42fe74cd2c
Merge pull request #86142 from raz-bn/add-complete-event 
Adding new job completed event
 2019-12-16 23:43:58 -08:00
raz-bn
0224c48120 Job completed event added 2019-12-16 21:41:15 +00:00
Kubernetes Prow Robot
69410eca4b
Merge pull request #86256 from liggitt/testapi 
Remove use of testapi package
 2019-12-13 12:55:50 -08:00
Jordan Liggitt
5d5b444c4d Remove use of testapi codecs, selflink, resourcepath functions 2019-12-13 11:56:29 -05:00
Kubernetes Prow Robot
f67d3b1a7d
Merge pull request #86229 from ahg-g/ahg-ds 
Remove daemonset controller's dependency on scheduler metadata
 2019-12-13 00:26:54 -08:00
Kubernetes Prow Robot
ae717afc0d
Merge pull request #86140 from yutedz/rs-rm-timeout 
Do not swallow timeout in manageReplicas
 2019-12-12 18:33:07 -08:00
Abdullah Gharaibeh
288609ecf5 remove ds dependeny on scheduler metadata 2019-12-12 19:04:36 -05:00
Ted Yu
9cff345770 Do not swallow timeout in manageReplicas 2019-12-12 11:27:36 -08:00
draveness
dcea6ff065 fix: remove TaintNodesByCondition feature gate in daemon controller 2019-12-12 18:17:14 +08:00
Kubernetes Prow Robot
928817a26a
Merge pull request #74525 from gliush/configurable-hpa-limits 
Configurable HorizontalPodAutoscaler
 2019-12-11 03:18:05 -08:00
Arjun Naik
8ab226263a Adds tests 
Signed-off-by: Arjun Naik <arjun@arjunnaik.in>
 2019-12-10 18:09:20 +01:00
Ivan Glushkov
27ffe439b6
Adds the algorithm implementation for the Configurable HPA 2019-12-10 20:37:33 +04:00
Kubernetes Prow Robot
fcc35b0468
Merge pull request #85899 from gongguan/slim_down_lister 
slim down some lister expansions
 2019-12-09 07:20:17 -08:00
louisgong
7f5076d8ee slim down some lister expansions 2019-12-07 08:27:06 +08:00
Nan Yu
1fb0dd4ec5 Rename PodDisruptionsAllowed to DisruptionsAllowed in type PodDisruptionBudgetStatus 2019-12-03 14:26:35 -08:00
Kubernetes Prow Robot
41757d673e
Merge pull request #85521 from gaorong/check-return-value 
check service status value returned by EnsureLoadBalancer
 2019-11-25 22:51:10 -08:00
Rob Scott
4229b99203
Deep copying EndpointSlices in reconciler before modifying them. 2019-11-23 20:57:50 -08:00
Rong Gao
99603e105a check service status value returned by EnsureLoadBalancer 
when service status returned by EnsureLoadBalancer is nil, return the
function directly to avoid NPE
 2019-11-22 09:19:06 +08:00
Benjamin Elder
cf510ac285 fix multiple node cidr masks in providerless build 2019-11-19 09:47:45 -08:00
Yuan Tang
dd308ca576
Fix grammar: have -> has 2019-11-18 11:17:58 -05:00
Kubernetes Prow Robot
c3f8d700ac
Merge pull request #85367 from aramase/node-cidr-followup 
[kube controller manager] add comments for compatibility
 2019-11-15 19:09:54 -08:00
Kubernetes Prow Robot
9c26a752a9
Merge pull request #85231 from davidz627/flags 
Flip CSIMigration and CSIMigrationGCE to Beta
 2019-11-15 17:57:41 -08:00
Kubernetes Prow Robot
9859e73433
Merge pull request #85361 from liggitt/endpoint-label 
Fix label mutation in endpoints controller
 2019-11-15 16:17:49 -08:00
Anish Ramasekar
128f33b26e
add comments for compatibility 2019-11-15 15:38:06 -08:00
Jordan Liggitt
08b5c809d2 Fix label mutation in endpoints controller 2019-11-15 16:24:10 -05:00
Rob Scott
7085d692b7
Reverting managed-by-setup annotation 
This ended up causing far more problems than it was worth, especially
given that it just attempted to provide backwards compatibility with
the alpha release.
 2019-11-15 11:50:58 -08:00
David Zhu
41c65f4740 Jump out of spec translation early if the spec is not migratable. Unit tests work after all! 2019-11-15 11:23:32 -08:00
David Zhu
6e716af89e Add CSINodes to AttachDetachControllerRecovery test 2019-11-15 11:23:32 -08:00
Travis Rhoden
0c5c3d8bb9
Remove pkg/util/mount (moved out of tree) 
This patch removes pkg/util/mount completely, and replaces it with the
mount package now located at k8s.io/utils/mount. The code found at
k8s.io/utils/mount was moved there from pkg/util/mount, so the code is
identical, just no longer in-tree to k/k.
 2019-11-15 08:29:12 -07:00
Kubernetes Prow Robot
ded6ee953c
Merge pull request #79993 from aramase/controller-manager-multiple-cidr 
Allow multiple node cidr masks in kube-controller-manager
 2019-11-14 23:23:42 -08:00
Kubernetes Prow Robot
372ebd24f5
Merge pull request #83098 from ddebroy/disable-intree 
CSI Migration phase 2: disable probing of in-tree plugins
 2019-11-14 20:51:42 -08:00
Anish Ramasekar
796faba4ac
Allow multiple node cidr masks in cm 
update tests

add comment

amend var name

update comment

add check for empty slice

fix tests

fix mask size in test

review feedback

add ipv4 and ipv6 flag for mask sizes

add to violation exception list

remove import alias

run update-openapi-spec

review feedback

run update-bazel

review feedback

review feedback
 2019-11-14 20:04:31 -08:00
YAMAMOTO Takashi
361cd7212e Fix a comment typo in legacyNodeRoleBehaviorFeature 2019-11-15 11:30:34 +09:00
Deep Debroy
129f15328b Disable in-tree plugins migrated to CSI 
Signed-off-by: Deep Debroy <ddebroy@docker.com>
 2019-11-14 17:28:21 -08:00
Kubernetes Prow Robot
ba9f7419f9
Merge pull request #84732 from khenidak/fix-disable-dualstack 
Fix a CM panic when ipam tries to lock an out of range pre existing cidr
 2019-11-14 11:19:35 -08:00
Kubernetes Prow Robot
5e30d32d2c
Merge pull request #83394 from bertinatto/convert_pv_no_affinity 
Convert existing PVs to use volume topology in VolumeBinderPredicate
 2019-11-13 21:45:56 -08:00
Kubernetes Prow Robot
565566f4b2
Merge pull request #85153 from codenrhoden/mount-no-exec-int 
Retire mount.Exec for k8s.io/utils/exec
 2019-11-13 17:28:32 -08:00
Kubernetes Prow Robot
072cf5bd58
Merge pull request #85023 from MrHohn/svc-lb-ga 
Promote service load balancer finalizer to GA
 2019-11-13 17:28:21 -08:00
Rob Scott
a7e589a8c6
Promoting EndpointSlices to beta 2019-11-13 14:20:19 -08:00
Travis Rhoden
367f879131
Retire mount.Exec for k8s.io/utils/exec 
This patch removes mount.Exec entirely and instead uses the common
utility from k8s.io/utils/exec.

The fake exec implementation found in k8s.io/utils/exec differs a bit
than mount.Exec, with the ability to pre-script expected calls to
Command.CombinedOutput(), so tests that previously relied on a callback
mechanism to produce specific output have been updated to use that
mechanism.
 2019-11-13 14:09:57 -07:00
Fabio Bertinatto
bbfc6ef450 Convert volume binder to use CSINode GA 2019-11-13 14:01:01 +01:00
Fabio Bertinatto
7cba40fb09 Use CSI translation lib in VolumeBinderPredicate 2019-11-13 14:01:01 +01:00
Zihong Zheng
0833e8840e Amend service controller code/test regarding finalizer GA 2019-11-12 15:04:07 -08:00
Rob Scott
0fa9981e01
Splitting IP address type into IPv4 and IPv6 for EndpointSlices 2019-11-12 09:03:53 -08:00
Kubernetes Prow Robot
5dc87d2919
Merge pull request #83965 from robscott/endpointslice-managed-by 
Adding new label to indicate what is managing an EndpointSlice
 2019-11-12 03:08:07 -08:00
Kubernetes Prow Robot
7d1f9b440e
Merge pull request #83815 from howardjohn/appprotocol 
Add appProtocol to EndpointSlice.Port
 2019-11-11 17:48:06 -08:00
Kubernetes Prow Robot
01e014c7d6
Merge pull request #85012 from alculquicondor/feat/predicate_factory 
Add MetadataProducerFactory for predicates
 2019-11-11 14:46:36 -08:00
Kubernetes Prow Robot
709a0c4f7b
Merge pull request #85067 from takanattie/fix_typo 
Fix a typo in pkg/controller
 2019-11-11 12:56:48 -08:00
Aldo Culquicondor
6a98c93f3c Add MetadataProducerFactory for predicates 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
 2019-11-11 11:27:44 -05:00
Kubernetes Prow Robot
b2fb0f77ad
Merge pull request #82572 from tnozicka/fix-rs-expectations 
Fix RS expectations for recreate case
 2019-11-11 05:49:42 -08:00
Tomas Nozicka
ce52643f12 Update Bazel 2019-11-11 09:11:43 +01:00
Tomas Nozicka
6754b93f6b Fix RS informer handlers and handling expectations on delete 2019-11-11 09:11:43 +01:00
Takashi Natsume
e5ad39fbe0 Fix a typo in pkg/controller 2019-11-10 11:24:10 +00:00
shibataka000
b7122770f8 Fix bug about unintentional scale out during updating deployment. 
During rolling update with maxSurge=1 and maxUnavailable=0,
len(metrics) is greater than currentReplcas
and it may cause unintentional scale out.
 2019-11-09 06:24:31 +00:00
Rob Scott
6b8b2ff975
Adding new label to indicate what is managing an EndpointSlice 
This adds a new Label to EndpointSlices that will ensure that multiple
controllers or entities can manage subsets of EndpointSlices. This
label provides a way to indicate the controller or entity responsible
for managing an EndpointSlice.

To provide a seamless upgrade from the alpha release of EndpointSlices
that did not support this label, a temporary annotation has been added
on Services to indicate that this label has been initially set on
EndpointSlices. That annotation will be set automatically by the
EndpointSlice controller with this commit once appropriate Labels have
been added on the corresponding EndpointSlices.
 2019-11-08 15:34:44 -08:00
Kubernetes Prow Robot
9cf309ed59
Merge pull request #82049 from andrewsykim/ga-node-instance-type-label 
Promote Node Instance Type Label to GA
 2019-11-08 13:47:58 -08:00
Khaled Henidak(Kal)
2de6b2e52c unit tests 2019-11-08 18:29:08 +00:00
Khaled Henidak(Kal)
e07402f7dc fix a panic when ipam tries to allocate an out of range pre-existing cidr 2019-11-08 18:29:08 +00:00
John Howard
d00794ca60 Add appProtocol to EndpointSlice.Port 2019-11-08 09:22:50 -08:00
Kubernetes Prow Robot
f0184f0921
Merge pull request #84933 from krzysied/node_controller_v_level 
Bumping up log level for not updated node
 2019-11-08 09:00:40 -08:00
Kubernetes Prow Robot
ae15368355
Merge pull request #84351 from wojtek-t/promote_node_lease_to_GA 
Promote node lease to GA
 2019-11-08 09:00:15 -08:00
Andrew Sy Kim
55e40b8dc1 cloud node controller: apply stable instance-type label with backfill to existing nodes 
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
 2019-11-08 10:50:52 -05:00
Kubernetes Prow Robot
d366d2eaa3
Merge pull request #84896 from RainbowMango/pr_migrate_custom_collector_scheduler 
Migrate custom collector for kube-scheduler
 2019-11-08 01:04:14 -08:00
Kubernetes Prow Robot
3ee195f0e9
Merge pull request #81431 from andrewsykim/ga-node-topology 
Promote Node Zone/Region Topology Labels to GA
 2019-11-07 22:00:20 -08:00
Andrew Sy Kim
07229d6c51 pkg/util/node: update GetZoneKey to check both beta and GA labels 
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
 2019-11-07 21:22:04 -05:00
Andrew Sy Kim
3032c81187 node controller: set both deprecated Beta and GA labels for Zone/Region topology 
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
 2019-11-07 20:08:11 -05:00
Rob Scott
0c7548f020
Setting Hostname from Pods on EndpointSlice to match Endpoints behavior. 
This was an oversight in the initial EndpointSlice release. This update
will ensure that Endpoints and EndpointSlices use the same logic to set
the Hostname attribute.
 2019-11-07 13:22:54 -08:00
Kubernetes Prow Robot
f7c3fa8324
Merge pull request #84860 from wojtek-t/remove_conversion_funcs_4 
Eliminate couple default conversions
 2019-11-07 09:05:30 -08:00
Kubernetes Prow Robot
06a7e9a1f3
Merge pull request #84763 from hwdef/fix-staticcheck6 
pkg/controller: fix staticcheck warning
 2019-11-07 09:05:17 -08:00
Krzysztof Siedlecki
4e63b9a032 bumping up log level for not updated node 2019-11-07 17:59:26 +01:00
Kubernetes Prow Robot
8841624982
Merge pull request #81167 from krzysied/node_controller_list 
Avoid listing pods in NodeLifecycleController
 2019-11-07 07:53:10 -08:00
Kubernetes Prow Robot
1183771545
Merge pull request #84748 from hvaara/fix-golint-controller-volume-persistentvolume-options 
Fix golint issues in pkg/controller/volume/persistentvolume/options
 2019-11-07 04:35:53 -08:00
Kubernetes Prow Robot
ca836256c4
Merge pull request #84573 from robscott/endpointslice-publishnotready 
Updating EndpointSlices to use PublishNotReadyAddresses from Services.
 2019-11-07 04:35:10 -08:00
Krzysztof Siedlecki
9406e5bf2a adding pods lister 2019-11-07 12:02:21 +01:00
hwdef
38256df718 pkg/controller: fix staticcheck warning 2019-11-07 16:46:47 +08:00
Kubernetes Prow Robot
24fb2c1afd
Merge pull request #84280 from gongguan/service_selector_cache 
add service selector cache in endpoint and endpointSlice controller
 2019-11-06 18:47:00 -08:00
RainbowMango
09dc221d7b Deal with auto-generated files. 
Update bazel by hack/update-bazel.sh
 2019-11-07 10:30:12 +08:00
RainbowMango
9efabe8124 Migrate custom collector to stablility framework 2019-11-07 10:26:27 +08:00
Kubernetes Prow Robot
46472773cb
Merge pull request #84836 from yuxiaobo96/k8s-checks 
Correct spelling mistakes
 2019-11-06 12:21:11 -08:00
Kubernetes Prow Robot
b09b962d96
Merge pull request #84746 from Huang-Wei/move-sched-constrants 
Move out const strings in pkg/scheduler/api/well_known_labels.go
 2019-11-06 12:20:06 -08:00
Rob Scott
ff3cbdb0ad
Updating EndpointSlices to use PublishNotReadyAddresses from Services. 
The Service spec includes a PublishNotReadyAddresses field which has
been used by Endpoints to report all matching resources ready. This may
or may not have been the initial purpose of the field, but given the
desire to provide backwards compatibility with the Endpoints API here,
it seems to make sense to continue to provide the same functionality.
 2019-11-06 09:11:31 -08:00
wojtekt
ccded14941 Eliminate some default conversions 2019-11-06 14:08:15 +01:00
yuxiaobo
81e9f21f83 Correct spelling mistakes 
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
 2019-11-06 20:25:19 +08:00
Wei Huang
019d7497a5
bazel files 2019-11-05 20:57:21 -08:00
Wei Huang
dd74205bcf
Move out const strings in pkg/scheduler/api/well_known_labels.go 2019-11-05 20:56:21 -08:00
louisgong
2133f9e9ff add service selector cache in endpoint controller and endpointSlice controller 2019-11-06 10:55:26 +08:00
Kubernetes Prow Robot
0c32aa8910
Merge pull request #83257 from robscott/endpointslice-metrics 
Adding initial EndpointSlice metrics.
 2019-11-05 15:30:31 -08:00
Kubernetes Prow Robot
268e331c70
Merge pull request #84527 from robscott/endpoint-util-owners 
Adding owners file for Endpoint controller utils
 2019-11-05 06:28:39 -08:00
wojtekt
ffad401b4e Promote NodeLease feature to GA 2019-11-05 09:01:12 +01:00
Kubernetes Prow Robot
aaa5707896
Merge pull request #84677 from mikedanese/cfssl 
remove cfssl dependencies
 2019-11-04 15:28:53 -08:00
Kubernetes Prow Robot
1d1385af91
Merge pull request #83474 from msau42/topology-ga 
CSI Topology ga
 2019-11-04 15:28:27 -08:00
Roy Hvaara
dffcf7c8cd
Fix golint issues in pkg/controller/volume/persistentvolume/options 2019-11-04 21:45:21 +01:00
Mike Danese
6a004d0c18 support URI SANs in local signer 2019-11-04 10:56:06 -08:00
Mike Danese
fe51712288 refactor into seperate authority package 2019-11-04 10:56:06 -08:00
Mike Danese
4bd2c3998f don't use cfssl in signer 2019-11-04 10:56:06 -08:00
Kubernetes Prow Robot
6a19261e96
Merge pull request #84123 from smarterclayton/terminating_cause 
Handle namespace deletion more gracefully in built-in controllers
 2019-11-04 07:55:41 -08:00
Kubernetes Prow Robot
5e33f3db5f
Merge pull request #84445 from krzysied/node_controller_retry_fix 
NodeLifecycleController - MarkPodsNotReady retry fix
 2019-11-03 20:15:40 -08:00
Kubernetes Prow Robot
b55440dcf8
Merge pull request #84637 from zhipengzuo/master 
fix log and note :cidr mask size must be <= node mask
 2019-11-03 18:53:40 -08:00
Kubernetes Prow Robot
d8ab3f26e7
Merge pull request #84323 from draveness/feature/remove-suspended-daemon-pods 
feat: remove suspendedDaemonPods from daemon controller
 2019-11-02 23:41:40 -07:00
Kubernetes Prow Robot
6e0c915f43
Merge pull request #84060 from yutedz/gc-ref-diff 
Traverse OwnerReference maps more efficiently
 2019-11-01 18:07:41 -07:00
zhipengzuo
1e0b019062 fix log and annotation :cidr mask size must be <= node mask 2019-11-01 17:26:23 +08:00
Krzysztof Siedlecki
3a82f50b2e adding test for retrying MarkPodsNotReady 2019-10-31 16:56:54 +01:00
Krzysztof Siedlecki
9759a982c5 MarkPodsNotReady retry fix 2019-10-31 16:56:54 +01:00
Ryan Phillips
f87da3fdfa fixes for tests to pass with FIPS compiler 
* use P256 ECDSA key since P224 is not supported
* regen test certs to be 2048bits
 2019-10-30 10:10:11 -05:00
Rob Scott
40423cf18e
Adding owners file for Endpoint controller utils 2019-10-29 11:01:49 -07:00
Andrew Sy Kim
897b8d7476 improve error handling in cloud node controller 
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
 2019-10-28 20:23:12 -04:00
Michelle Au
fb6dfeb718 Convert attach-detach controller to use v1.CSINode 2019-10-28 13:41:13 -07:00
wojtekt
ce499ac286 Migrate components to EndpointsLeases leader election lock 2019-10-28 09:09:03 +01:00
Kubernetes Prow Robot
d379ab2697
Merge pull request #84288 from wojtek-t/cleanup_conversions_registrations 
Cleanup conversions registrations
 2019-10-25 22:53:22 -07:00
draveness
dc437a7890 feat: remove suspendedDaemonPods from daemon controller 2019-10-25 09:16:48 +08:00
wojtekt
7b6bcdf780 Autogenerated code 2019-10-24 20:21:00 +02:00
Kubernetes Prow Robot
2c4cba8aa0
Merge pull request #82365 from jkaniuk/pod-gc 
Pod GC controller - use node lister
 2019-10-24 03:13:06 -07:00
Rob Scott
724b142f07
Adding initial EndpointSlice metrics. 2019-10-23 17:33:17 -07:00
Kubernetes Prow Robot
ed5a3847a2
Merge pull request #83856 from mrbobbytables/update-autoscaling-owners 
Prune inactive owners from autoscaling related OWNERS files.
 2019-10-23 15:53:34 -07:00
Kubernetes Prow Robot
4f63f61c36
Merge pull request #84193 from ahg-g/ahg-list 
Separate scheduler listers into their own package
 2019-10-23 12:51:30 -07:00
Kubernetes Prow Robot
7dc298af42
Merge pull request #82795 from draveness/feature/remove-schedule-daemonset-pods 
feat(scheduler): graduate ScheduleDaemonSetPods to GA
 2019-10-23 12:49:12 -07:00
Kubernetes Prow Robot
65fa4c979a
Merge pull request #82152 from misterikkit/disruption 
Fix retry logic in DisruptionController
 2019-10-23 12:48:58 -07:00
Jacek Kaniuk
39883f08bf Pod GC controller - use node lister 2019-10-23 16:54:54 +02:00
draveness
35d772e354 feat: graduate ScheduleDaemonSetPods to GA 2019-10-23 21:34:47 +08:00
Kubernetes Prow Robot
75cd65ae0e
Merge pull request #82145 from shivi28/fix-controller-nodeipam-ipam-cidrset 
nodeipam-controller:fix static check failures
 2019-10-22 23:18:26 -07:00
Cristian Dima
da759609dc in pkg/controller/service rename service_controller.go to controller.go 2019-10-23 01:52:19 +03:00
Cristian Dima
a18de39166 fix golint errors in pkg/controller/service 2019-10-23 01:52:19 +03:00
Abdullah Gharaibeh
d393804237 separate listers into their own package 2019-10-22 18:11:02 -04:00
Kubernetes Prow Robot
3c0fa84f92
Merge pull request #84075 from yutedz/replica-set-rolling 
Extract PodPhase map outside Less func
 2019-10-22 10:28:36 -07:00
Kubernetes Prow Robot
4984c6f000
Merge pull request #84049 from jsafrane/block-feature-gate-checks 
Add block feature gate checks to PV controller
 2019-10-21 21:12:09 -07:00
Ted Yu
7a4b98b896 Extract PodPhase map outside Less func 2019-10-21 14:32:20 -07:00
Clayton Coleman
bd9260711f
deployment: Ignore namespace termination errors when creating replicasets 
Instead of reporting an event or displaying an error, simply exit
when the namespace is being terminated. This reduces the amount of
controller churn on namespace shutdown. Unlike other controllers, we
drop the replica set create error very late (in the queue handleErr)
in order to avoid changing the structure of the controller
substantially.
 2019-10-20 18:39:01 -04:00
Clayton Coleman
c6e34e58c5
job: Ignore namespace termination errors when creating pods or jobs 
Instead of reporting an event or displaying an error, simply exit
when the namespace is being terminated. This reduces the amount of
controller churn on namespace shutdown. While we could technically
exit the entire processing loop early for very large jobs,
we should wait for more evidence that is an issue before changing
that logic substantially.
 2019-10-20 18:39:01 -04:00
Clayton Coleman
8f74c8970b
daemonset: Ignore namespace termination errors when creating pods 
Instead of reporting an event or displaying an error, simply exit
when the namespace is being terminated. This reduces the amount of
controller churn on namespace shutdown. While we could technically
exit the entire processing loop early for very large daemon sets,
we should wait for more evidence that is an issue before changing
that logic substantially.
 2019-10-20 18:39:00 -04:00
Clayton Coleman
2e8ace82eb
replicaset: Ignore namespace termination errors when creating pods 
Instead of reporting an event or displaying an error, simply exit
when the namespace is being terminated. This reduces the amount of
controller churn on namespace shutdown. While we could technically
exit the entire processing loop early for very large replica sets,
we should wait for more evidence that is an issue before changing
that logic substantially.
 2019-10-20 18:39:00 -04:00
Clayton Coleman
dc0c21c7d7
serviceaccount: If namespace is terminating, ignore create errors 
In some scenarios the service account and token controllers can
race with namespace deletion, causing a burst of errors as they
attempt to recreate secrets being deleted.

Instead, detect these errors and do not retry.
 2019-10-20 18:39:00 -04:00
Clayton Coleman
937ef77257
endpoints: If namespace is terminating, drop item immediately 
Avoid sending an event to the namespace that is being terminated,
since it will be rejected.
 2019-10-20 18:38:59 -04:00
walter
6991069e31 Push context up to cloud node controller. 
This adds context to the cloud node controller. It continues the propogation started in 59287.  Fixes 815.
Fixed test code calls.
 2019-10-20 11:20:49 -07:00
Ted Yu
0d704f1ce2 Traverse OwnerReference maps more efficiently 2019-10-19 17:56:11 -07:00
Kubernetes Prow Robot
aab740ffc2
Merge pull request #82703 from draveness/feature/graduate-taint-nodes-by-condition-to-ga 
feat: update taint nodes by condition to GA
 2019-10-18 20:01:37 -07:00
draveness
1163a1d51e feat: update taint nodes by condition to GA 2019-10-19 09:17:41 +08:00
Kubernetes Prow Robot
de9a7d863d
Merge pull request #83934 from wccsama/wcc-service-dev 
Convert error messages to use event recorder
 2019-10-18 12:37:46 -07:00
wccsama
18cf49e3df Convert error messages to use event recorder 
remove mix protocol validation
remove check nil
 2019-10-18 13:30:00 +08:00
Miciah Masters
980b6406b2 Prefer to delete doubled-up pods of a ReplicaSet 
When scaling down a ReplicaSet, delete doubled up replicas first, where a
"doubled up replica" is defined as one that is on the same node as an
active replica belonging to a related ReplicaSet.  ReplicaSets are
considered "related" if they have a common controller (typically a
Deployment).

The intention of this change is to make a rolling update of a Deployment
scale down the old ReplicaSet as it scales up the new ReplicaSet by
deleting pods from the old ReplicaSet that are colocated with ready pods of
the new ReplicaSet.  This change in the behavior of rolling updates can be
combined with pod affinity rules to preserve the locality of a Deployment's
pods over rollout.

A specific scenario that benefits from this change is when a Deployment's
pods are exposed by a Service that has type "LoadBalancer" and external
traffic policy "Local".  In this scenario, the load balancer uses health
checks to determine whether it should forward traffic for the Service to a
particular node.  If the node has no local endpoints for the Service, the
health check will fail for that node.  Eventually, the load balancer will
stop forwarding traffic to that node.  In the meantime, the service proxy
drops traffic for that Service.  Thus, in order to reduce risk of dropping
traffic during a rolling update, it is desirable preserve node locality of
endpoints.

* pkg/controller/controller_utils.go (ActivePodsWithRanks): New type to
sort pods using a given ranking.
* pkg/controller/controller_utils_test.go (TestSortingActivePodsWithRanks):
New test for ActivePodsWithRanks.
* pkg/controller/replicaset/replica_set.go
(getReplicaSetsWithSameController): New method.  Given a ReplicaSet, return
all ReplicaSets that have the same owner.
(manageReplicas): Call getIndirectlyRelatedPods, and pass its result to
getPodsToDelete.
(getIndirectlyRelatedPods): New method.  Given a ReplicaSet, return all
pods that are owned by any ReplicaSet with the same owner.
(getPodsToDelete): Add an argument for related pods.  Use related pods and
the new getPodsRankedByRelatedPodsOnSameNode function to take into account
whether a pod is doubled up when sorting pods for deletion.
(getPodsRankedByRelatedPodsOnSameNode): New function.  Return an
ActivePodsWithRanks value that wraps the given slice of pods and computes
ranks where each pod's rank is equal to the number of active related pods
that are colocated on the same node.
* pkg/controller/replicaset/replica_set_test.go (newReplicaSet): Set
OwnerReferences on the ReplicaSet.
(newPod): Set a unique UID on the pod.
(byName): New type to sort pods by name.
(TestGetReplicaSetsWithSameController): New test for
getReplicaSetsWithSameController.
(TestRelatedPodsLookup): New test for getIndirectlyRelatedPods.
(TestGetPodsToDelete): Augment the "various pod phases and conditions, diff
= len(pods)" test case to ensure that scale-down still selects doubled-up
pods if there are not enough other pods to scale down.  Add a "various pod
phases and conditions, diff = len(pods), relatedPods empty" test case to
verify that getPodsToDelete works even if related pods could not be
determined.  Add a "ready and colocated with another ready pod vs not
colocated, diff < len(pods)" test case to verify that a doubled-up pod gets
preferred for deletion.  Augment the "various pod phases and conditions,
diff < len(pods)" test case to ensure that not-ready pods are preferred
over ready but doubled-up pods.
* pkg/controller/replicaset/BUILD: Regenerate.
* test/e2e/apps/deployment.go
(testRollingUpdateDeploymentWithLocalTrafficLoadBalancer): New end-to-end
test.  Create a deployment with a rolling update strategy and affinity
rules and a load balancer with "Local" external traffic policy, and verify
that set of nodes with local endponts for the service remains unchanged
during rollouts.
(setAffinity): New helper, used by
testRollingUpdateDeploymentWithLocalTrafficLoadBalancer.
* test/e2e/framework/service/jig.go (GetEndpointNodes): Factor building the
set of node names out...
(GetEndpointNodeNames): ...into this new method.
 2019-10-17 11:52:32 -04:00
Miciah Masters
865c3c5670 TestGetPodsToDelete: Use field names in test cases 
* pkg/controller/replicaset/replica_set_test.go (TestGetPodsToDelete): Use
explicit field names in declarations of test cases.
 2019-10-17 11:50:09 -04:00
Jan Safranek
a689697519 Do not bind block PV/PVCs when block feature gate is off 2019-10-17 12:40:22 +02:00
Kubernetes Prow Robot
bdc3f96838
Merge pull request #83989 from wojtek-t/remove_coordination_v1beta1 
Swtich nodelifecyclecontroller to coordination/v1
 2019-10-17 01:47:29 -07:00
Kubernetes Prow Robot
6a5f0e6eda
Merge pull request #81348 from yastij/code-org-service-controller 
move service helpers to k8s.io/cloud-provider
 2019-10-17 00:20:38 -07:00
Kubernetes Prow Robot
064458de46
Merge pull request #83951 from zouyee/pdbtomeb 
add tombstones handle for pdb
 2019-10-16 09:36:36 -07:00
Kubernetes Prow Robot
78abdf5375
Merge pull request #83902 from gongguan/remove_duplicate_code 
remove duplicate code
 2019-10-16 09:34:22 -07:00
Yassine TIJANI
d796baea27 move service helpers to k8s.io/cloud-provider 
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
 2019-10-16 14:12:11 +02:00
wojtekt
cf9203501e Swtich nodelifecyclecontroller to coordination/v1 2019-10-16 10:59:02 +02:00
Kubernetes Prow Robot
112bdfb7c0
Merge pull request #83862 from mrbobbytables/update-controller-network-owners 
Prune inactive owners from pkg/controller/* network related OWNERS files
 2019-10-15 23:06:49 -07:00
zouyee
65ddf102ef add tombstoones handle for pdb 
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
 2019-10-15 22:02:18 +08:00
louisgong
9b7b50c9da remove duplicate function 2019-10-15 09:41:30 +08:00
Krzysztof Siedlecki
b1dfa83be6 using pod pointers in node lifecycle controller 2019-10-14 12:44:43 +02:00
Bob Killen
e37d702208
Prune inactive owners from autoscaling related OWNERS files. 2019-10-13 08:52:14 -04:00
Bob Killen
30053bb00f
Prune inactive owners from pkg/controller/* network related OWNERS files. 2019-10-13 08:50:18 -04:00
zouyee
a864fd2100 fix unsafe JSON construction 
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
 2019-10-10 09:44:54 +08:00
Kubernetes Prow Robot
a5dc1fffb0
Merge pull request #83543 from yutedz/attach-resync-comment 
Remove stale comment about resyncPeriod
 2019-10-09 13:17:50 -07:00
Kubernetes Prow Robot
4b002b3baa
Merge pull request #82123 from xiaoanyunfei/cleanup/take-effect-stateofworld-hashmap 
replace iteration with hashmap in *state_of_world
 2019-10-09 02:17:50 -07:00
Kubernetes Prow Robot
ac9390627e
Merge pull request #83536 from yutedz/del-volume-err 
Log the error return from store.Delete
 2019-10-08 19:59:50 -07:00
Kubernetes Prow Robot
72d052a444
Merge pull request #81797 from yastij/move-metrics-util 
move util/metrics to component-base
 2019-10-08 17:08:05 -07:00
Kubernetes Prow Robot
b00f009316
Merge pull request #82996 from tnqn/endpointslice-deletion 
Fix EndpointSliceController service deletion processing
 2019-10-08 15:42:27 -07:00
Kubernetes Prow Robot
b4489d1709
Merge pull request #82865 from tnqn/endpointslice 
Fix wrong comments and inaccurate logs in endpointslice_controller
 2019-10-08 15:42:16 -07:00
Yassine TIJANI
c1487840bc move util/metrics to component-base 
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
 2019-10-08 14:42:31 +02:00
Ted Yu
f0a6aa1e9b Log error from AddIndexers in NewAttachDetachController 2019-10-07 16:15:25 -07:00
Kubernetes Prow Robot
9f875de5d2
Merge pull request #83540 from cofyc/fix83343 
Fix volume scheduling error handling
 2019-10-07 01:53:09 -07:00
Kubernetes Prow Robot
48b90db9c3
Merge pull request #83495 from tanjunchen/fix-typo 
remove the repeat word in documents
 2019-10-06 15:05:08 -07:00
tanjunchen
de3cf23414 remove the repeat word in documents 2019-10-06 23:32:01 +08:00
Ted Yu
b81242b62e Remove stale comment about resyncPeriod 2019-10-06 05:02:07 -07:00
Yecheng Fu
b5889ee82c update internal error message 2019-10-06 14:37:31 +08:00
Ted Yu
56717a79ff Log the error return from store.Delete 2019-10-05 19:34:39 -07:00
Kubernetes Prow Robot
e0f651a0be
Merge pull request #83501 from yastij/remove-node-cond-dep 
remove Get/Set node condition dependency for the ccm controllers
 2019-10-04 16:31:26 -07:00
Kubernetes Prow Robot
74dc287490
Merge pull request #83420 from yutedz/sched-assume-cache 
Check the return value from store.Update
 2019-10-04 10:22:18 -07:00
Kubernetes Prow Robot
7fab683455
Merge pull request #83343 from yutedz/bind-vol-err 
Return proper error message when BindPodVolumes fails
 2019-10-04 08:50:30 -07:00
Yassine TIJANI
356e3d0d61 remove Get/Set node condition dependency for the ccm controllers 
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
 2019-10-04 16:52:36 +02:00
Ted Yu
94d4bf1287 Return proper error message when BindPodVolumes fails 2019-10-04 04:36:48 -07:00
shivi28
a0109f00df nodeipam-controller:fix static check failures 2019-10-04 12:40:09 +05:30
Ted Yu
c264338741 Check the return value from store.Update 2019-10-02 12:02:13 -07:00
Kubernetes Prow Robot
bd89dc462c
Merge pull request #83320 from krzysied/node_controller_delete_pods 
Adding pods to DeletePods and MarkPodsReady methods parameters
 2019-10-02 09:03:08 -07:00
Krzysztof Siedlecki
a07a3a6878 adding pods to MarkPodsNotReady parameters 2019-10-02 14:22:58 +02:00
Krzysztof Siedlecki
8f48896709 adding pods to DeletePods parameters 2019-10-02 13:11:23 +02:00
mengyang02
b116585b22 remove redundant quota.V1Equals 2019-10-02 01:02:09 +08:00
Kubernetes Prow Robot
c5440829d5
Merge pull request #83248 from krzysied/node_controller_test 
Adding fakeGetPodsAssignedToNode to node lifecycle controller tests
 2019-09-30 03:19:38 -07:00
Krzysztof Siedlecki
99eeab35a3 adding fakeGetPodsAssignedToNode 2019-09-30 11:03:36 +02:00
Kubernetes Prow Robot
14e5adfc85
Merge pull request #82683 from davidz627/fix/translationStruct 
Refactor CSI Translation Library into a struct that is injected into various components to simplify unit testing
 2019-09-29 10:11:37 -07:00
Kubernetes Prow Robot
74d2822662
Merge pull request #72535 from tallclair/content-type 
Always set content-type & nosniff
 2019-09-27 18:43:39 -07:00
David Zhu
92cb06a2e7 Refactor CSI Translation Library into a struct that is injected into various components to simplify unit testing in future 2019-09-27 12:59:53 -07:00
chenyaqi01
66be69bb0e replace bytes.Compare() with bytes.Equal() 2019-09-27 10:08:49 +08:00
Kubernetes Prow Robot
67d750bb28
Merge pull request #81916 from hwdef/fix-typo-pkg 
fix typo in pkg
 2019-09-26 08:35:24 -07:00
Kubernetes Prow Robot
d8a420c0d8
Merge pull request #82884 from krzysied/node_controller_cleanup3 
NodeLifecycleContorller - eviction processing refactor
 2019-09-26 04:03:08 -07:00
Kubernetes Prow Robot
37c3a4da97
Merge pull request #82855 from yutedz/alpha-node-role 
Defer the removal of labelAlphaNodeRoleExcludeBalancer to 1.18
 2019-09-25 23:59:19 -07:00
Kubernetes Prow Robot
4096a36bfd
Merge pull request #83079 from robscott/endpointslice-owners 
Adding owners for EndpointSlice controller
 2019-09-25 13:52:13 -07:00
Kubernetes Prow Robot
6555c34743
Merge pull request #83022 from mm4tt/controller_ref 
Optimize GetControllerOf method and add a benchmark for it
 2019-09-25 13:51:14 -07:00
Matt Matejczyk
01ccd2e19e Optimize GetControllerOf method 
In addition create a similar method that doesn't copy objects.

Benchmark for the new no-copy method vs the old one:
```
benchmark                       old ns/op     new ns/op     delta
BenchmarkGetControllerOf-12     214           14.8          -93.08%

benchmark                       old allocs     new allocs     delta
BenchmarkGetControllerOf-12     1              0              -100.00%

benchmark                       old bytes     new bytes     delta
BenchmarkGetControllerOf-12     80            0             -100.00%
```

Benchamrk for the new (copy) method vs the old one:
```
benchmark                       old ns/op     new ns/op     delta
BenchmarkGetControllerOf-12     128           114           -10.94%

benchmark                       old allocs     new allocs     delta
BenchmarkGetControllerOf-12     1              1              +0.00%

benchmark                       old bytes     new bytes     delta
BenchmarkGetControllerOf-12     80            80            +0.00%

```

Overall there is a 10% improvement for the old vs new (copy) method and
huge improvent (x10) for the old vs new (no-copy).

I changed the IsControlledBy and a few other methods to use the new (no-copy) method.
 2019-09-25 15:07:37 +02:00
Rob Scott
30d0eca19f
Adding owners for EndpointSlice controller 2019-09-24 11:45:15 -07:00
David Eads
4b44a9f067 make namespace-lifecycle controller more responsive 2019-09-23 13:22:51 -04:00
Quan Tian
db6bbf2375 Fix EndpointSliceController service deletion processing 
syncService shouldn't return error if the service doesn't exist which
means it's triggered by service deletion, otherwise the service would be
enqueued repeatedly even its cleanup has been executed successfully.

This patch makes syncService return nil if the error is NotFound when
getting the service, like the other controllers do.
 2019-09-22 10:01:29 -07:00
qingsenLi
d3a0c149a3 Remove some unused codes in stateful_set_utils.go 2019-09-21 22:24:48 +08:00
Kubernetes Prow Robot
658e57a157
Merge pull request #82797 from yutedz/rel-cidr-wrong-err 
Correct the error variable for releasing CIDR
 2019-09-20 14:13:26 -07:00
Kubernetes Prow Robot
259d6bf608
Merge pull request #82189 from deads2k/ns-resources 
add conditions for remaining object totals during ns termination
 2019-09-20 01:33:00 -07:00
Kubernetes Prow Robot
5f249fecb4
Merge pull request #82363 from yuxiaobo96/k8s-update3 
update spelling mistakes
 2019-09-20 00:08:59 -07:00
Kubernetes Prow Robot
db1f8da036
Merge pull request #82848 from yutedz/node-ctrl-hostname 
Break out of loop when NodeHostName is found
 2019-09-19 18:01:13 -07:00
Kubernetes Prow Robot
73505056fb
Merge pull request #82887 from yutedz/token-cleaner-type 
[v1.16.1] TokenCleaner#evalSecret should enqueue the key
 2019-09-19 14:21:20 -07:00
Kubernetes Prow Robot
94987143c6
Merge pull request #82882 from liggitt/cleanup-finalizer-delete 
Clean up redundant post-finalizer deletions
 2019-09-19 12:50:33 -07:00
Ted Yu
fd8f2bd91f Defer the removal of labelAlphaNodeRoleExcludeBalancer to 1.18 2019-09-19 12:06:55 -07:00
Kubernetes Prow Robot
d05183be41
Merge pull request #82858 from hwdef/del-unused-var 
delete unused var
 2019-09-19 11:05:49 -07:00
Kubernetes Prow Robot
11ce7da888
Merge pull request #82740 from hwdef/del-unuse-var1 
del unuse var in pkg/controller
 2019-09-19 11:05:15 -07:00
Ted Yu
1269b9e474 TokenCleaner#evalSecret should enqueue the key 2019-09-19 10:34:59 -07:00
Krzysztof Siedlecki
2f3e8463ef eviction processing refactor 2019-09-19 17:15:32 +02:00
Jordan Liggitt
000fffd3c7 Clean up redundant post-finalizer deletions 2019-09-19 10:35:58 -04:00
hwdef
4e7ef9ad36 delete unused var 2019-09-19 18:04:13 +08:00
Quan Tian
c35fd33f42 Fix wrong comments and inaccurate logs in endpointslice_controller 2019-09-19 15:02:02 +08:00
Ted Yu
68d8a5ae15 Break out of loop when NodeHostName is found 2019-09-18 16:57:39 -07:00
Shintaro Murakami
ad333ac421 Return error when failed to get storage class 2019-09-18 15:59:34 +09:00
Ted Yu
669dc0a9fd Correct the error variable for releasing CIDR 2019-09-17 09:58:08 -07:00
Kubernetes Prow Robot
2183a84feb
Merge pull request #82356 from m3ngyang/opt-podgc 
optimize gc_controller.gcTerminated
 2019-09-16 09:58:38 -07:00
mengyang02
b5f44d5aab optimize gc_controller.gcTerminated 2019-09-16 16:34:08 +08:00
hwdef
851eac6a97 del unuse var in pkg/controller 2019-09-16 15:05:24 +08:00
Kubernetes Prow Robot
7f084f07c3
Merge pull request #82626 from RainbowMango/pr_migrate_prom_bucket_for_volume 
Migrate prometheus bucket functionality to kube-metrics for volume
 2019-09-13 10:42:44 -07:00
Kubernetes Prow Robot
06609b77e8
Merge pull request #82489 from krzysied/node_controller_lock_map 
Adding lock to node data map
 2019-09-12 02:46:27 -07:00
Krzysztof Siedlecki
029b72b553 adding lock to node data map 2019-09-12 10:23:24 +02:00
RainbowMango
6bb1229f4b Update bazel by hack/update-bazel.sh 2019-09-12 16:05:21 +08:00
RainbowMango
d6fdac8c56 Migrate prometheus bucket functionality to kube-metrics. 2019-09-12 16:02:53 +08:00
Kubernetes Prow Robot
632e02768a
Merge pull request #82411 from josephburnett/patch-1 
Fix reviewer typo.
 2019-09-11 15:27:38 -07:00
Kubernetes Prow Robot
61b30b062e
Merge pull request #82329 from m3ngyang/node-ctrl-check 
don't start the cloud node controller if cloudprovider.Instances is not supported
 2019-09-11 15:26:08 -07:00
Kubernetes Prow Robot
1146e0c4ad
Merge pull request #82279 from deads2k/which-cert 
add identification for particular certificate controllers
 2019-09-11 15:25:00 -07:00
Tim Allclair
ef6cba0b36 Always set content-type & nosniff 2019-09-11 15:01:43 -07:00
Kubernetes Prow Robot
001f2cd2b5
Merge pull request #82255 from cofyc/avoid-import-cycle 
volume scheduling: move metrics to a separate package to avoid import cycle
 2019-09-11 10:43:20 -07:00
Tomas Nozicka
55843fc298 Add unit test for RS to correctly handle expectations on recreate 2019-09-11 16:58:29 +02:00
mengyang02
b4638519a9 init check for cloud node controller 2019-09-07 10:47:11 +08:00
David Eads
95ae353f3a squash: reaction to comments 2019-09-06 09:58:41 -04:00
David Eads
0355f4482b add conditions for remaining object totals during ns termination 2019-09-06 09:50:41 -04:00
Joseph Burnett
7bdb66f8d1
Fix reviewer typo. 2019-09-06 12:09:50 +02:00
Kubernetes Prow Robot
208cfaad25
Merge pull request #82288 from deads2k/ns-conditions 
fix namespace termination conditions to be consistent and correct
 2019-09-05 13:01:11 -07:00
Kubernetes Prow Robot
61ecdba9ca
Merge pull request #82289 from robscott/endpointslice-fixes 
Fixing bugs related to Endpoint Slices
 2019-09-05 09:03:10 -07:00
yuxiaobo
f6ce8f5789 update spelling mistakes 2019-09-05 17:59:36 +08:00
Rob Scott
8f9483d827
Fixing bugs related to Endpoint Slices 
This should fix a bug that could break masters when the EndpointSlice
feature gate was enabled. This was all tied to how the apiserver creates
and manages it's own services and endpoints (or in this case endpoint
slices). Consumers of endpoint slices also need to know about the
corresponding service. Previously we were trying to set an owner
reference here for this purpose, but that came with potential downsides
and increased complexity. This commit changes behavior of the apiserver
endpointslice integration to set the service name label instead of owner
references, and simplifies consumer logic to reference that (both are
set by the EndpointSlice controller).

Additionally, this should fix a bug with the EndpointSlice GenerateName
value that had previously been set with a "." as a suffix.
 2019-09-04 09:09:32 -07:00
Jonathan Basseri
c8d937c5f1 Add unit test for DisruptionController retry logic 
This tests the PDB status update path in DisruptionController and
asserts that conflicting writes (with eviciton handler) are handled
gracefully.

This adds the client-go fake.Clientset into our tests, because that is
the layer required for injecting update failures.

This also adds a TestMain so that DisruptionController logs can be
enabled during test. e.g.,

    go test ./pkg/controller/disruption -v -args -v=4
 2019-09-03 16:52:45 -07:00
Kubernetes Prow Robot
cedffee93e
Merge pull request #82239 from sttts/sttts-persistentvolume-controller-data-race 
persistentvolume-controller: fix data race of non-deepcopied objects in fake client
 2019-09-03 14:35:12 -07:00
David Eads
076bf949d7 fix namespace termination conditions to be consistent and correct 2019-09-03 15:33:17 -04:00
David Eads
e8b5781499 add identification for particular certificate controllers 2019-09-03 14:05:04 -04:00
Yecheng Fu
8a7607a308 volume scheduling: move metrics code into a separate pkg 2019-09-03 14:38:26 +08:00
Dr. Stefan Schimanski
7816ad7991 persistentvolume-controller: fix data race of non-deepcopied objects in fake client 2019-09-02 15:23:55 +02:00
Jonathan Basseri
8835f6bb00 Fix retry logic in DisruptionController 
This changes the retry logic in DisruptionController so that it
reconciles update conflicts. In the old behavior, any pdb status update
failure was retried with the same status, regardless of error.

Now there is no retry logic with the status update. The error is passed
up the stack where the PDB can be requeued for processing.

If the PDB status update error is a conflict error, there are some new
special cases:
- failSafe is not triggered, since this is considered a retryable error
- the PDB is requeued immediately (ignoring the rate limiter) because we
  assume that conflict can be resolved by getting the latest version
 2019-08-30 16:02:09 -07:00
Kubernetes Prow Robot
efaacf786a
Merge pull request #73405 from wozniakjan/namespace_status_conditions 
Add namespace status conditions
 2019-08-29 15:34:58 -07:00
Kubernetes Prow Robot
e6b6e4038c
Merge pull request #81601 from yastij/remove-keyfun 
use DeletionHandlingMetaNamespaceKeyFunc from client-go in service_controller
 2019-08-29 09:30:09 -07:00
Kubernetes Prow Robot
d6bc4eb853
Merge pull request #81624 from logicalhan/cm-migration 
migrate controller-manager metrics to stability framework
 2019-08-29 05:30:09 -07:00
Jan Wozniak
b0459feb7d Update generated files 
make generated_files UPDATE_API_KNOWN_VIOLATIONS=true
./hack/update-generated-protobuf.sh
./hack/update-openapi-spec.sh
./hack/update-bazel.sh
./hack/update-generated-swagger-docs.sh
./hack/update-generated-api-compatibility-data.sh
 2019-08-29 13:26:13 +02:00
sunxiaofei03
45d41ed9e5 replace iteration with hashmap in *state_of_world 2019-08-29 19:22:25 +08:00
Jan Wozniak
035e648fd7 Add tests for namespace status conditions 2019-08-29 13:21:15 +02:00
Jan Wozniak
94a5e8c3dc Add status conditions to namespaces 2019-08-29 13:21:15 +02:00
Yassine TIJANI
3fe7a57000 use directly DeletionHandlingMetaNamespaceKeyFunc from client-go 
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
 2019-08-29 11:51:14 +01:00
Rob Scott
75f6c24923
Adding EndpointSlice controller 2019-08-28 21:13:27 -07:00
Kubernetes Prow Robot
550fb1bfc3
Merge pull request #79386 from khenidak/phase2-dualstack 
Phase 2 dualstack
 2019-08-28 20:39:56 -07:00
Kubernetes Prow Robot
af54eae69a
Merge pull request #81612 from rikatz/issue81060 
Remove watching Endpoints of Headless Services
 2019-08-28 14:44:25 -07:00
Han Kang
59db3ac27e migrate controller-manager metrics to stability framework 2019-08-28 12:26:57 -07:00
Kubernetes Prow Robot
92a320aeb6
Merge pull request #80238 from smarterclayton/disable_node_role 
Clarify use of node-role labels within Kubernetes
 2019-08-28 12:01:27 -07:00
Khaled Henidak(Kal)
c27e0b029d phase 2: generated items 2019-08-28 16:11:46 +00:00