github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
120,136 Commits 1 Branch 31 Tags
ae185414f4e94e969399c40b23995af6f85fa37f
Commit Graph

446 Commits

Author SHA1 Message Date
Patrick Ohly
21d1bcd6b8 initialize logging after flag parsing 
It wasn't documented that InitLogs already uses the log flush frequency, so
some commands have called it before parsing (for example, kubectl in the
original code for logs.go). The flag never had an effect in such commands.

Fixing this turned into a major refactoring of how commands set up flags and
run their Cobra command:

- component-base/logs: implicitely registering flags during package init is an
  anti-pattern that makes it impossible to use the package in commands which
  want full control over their command line. Logging flags must be added
  explicitly now, something that the new cli.Run does automatically.

- component-base/logs: AddFlags would have crashed in kubectl-convert if it
  had been called because it relied on the global pflag.CommandLine. This
  has been fixed and kubectl-convert now has the same --log-flush-frequency
  flag as other commands.

- component-base/logs/testinit: an exception are tests where flag.CommandLine has
  to be used. This new package can be imported to add flags to that
  once per test program.

- Normalization of the klog command line flags was inconsistent. Some commands
  unintentionally didn't normalize to the recommended format with hyphens. This
  gets fixed for sample programs, but not for production programs because
  it would be a breaking change.

This refactoring has the following user-visible effects:

- The validation error for `go run ./cmd/kube-apiserver --logging-format=json
  --add-dir-header` now references `add-dir-header` instead of `add_dir_header`.

- `staging/src/k8s.io/cloud-provider/sample` uses flags with hyphen instead of
  underscore.

- `--log-flush-frequency` is not listed anymore in the --logging-format flag's
  `non-default formats don't honor these flags` usage text because it will also
  work for non-default formats once it is needed.

- `cmd/kubelet`: the description of `--logging-format` uses hyphens instead of
  underscores for the flags, which now matches what the command is using.

- `staging/src/k8s.io/component-base/logs/example/cmd`: added logging flags.

- `apiextensions-apiserver` no longer prints a useless stack trace for `main`
  when command line parsing raises an error.
 2021-09-30 13:46:49 +02:00
kerthcet
75a255d2ed remove scheduler component config v1beta1 
Signed-off-by: kerthcet <kerthcet@gmail.com>
 2021-09-28 13:13:17 +08:00
sanposhiho
77c1949326 add usage message only when parsing flags failed 2021-09-22 00:40:15 +09:00
Wei Huang
a689ad4cda sched: start dynamicInformerFactory along with regular informerFactory (#105016) 
* sched: start dynamicInformerFactory along with regular informerFactory

* fixup: start all informers and then wait for their syncs
 2021-09-16 19:33:00 -07:00
Kubernetes Prow Robot
c10be982d1 Merge pull request #96345 from ingvagabund/disable-insecure-port-in-scheduler 
refactor: disable insecure serving in kube-scheduler
 2021-09-14 08:01:09 -07:00
Jan Chaloupka
07af6697e9 refactor: disable insecure serving in kube-scheduler 2021-09-14 07:52:16 +02:00
wangyamei
50865679b9 Scheduler version should be printed out by default 2021-09-02 21:46:41 +08:00
sanposhiho
0252865601 Fix: set SilenceErrors and SilenceUsage not to change error message 2021-08-23 13:29:44 +09:00
sanposhiho
a06d6138b5 Fix: not change the error messages 2021-08-22 21:20:32 +09:00
sanposhiho
b8ae016ee6 Fix: return error instead of os.Exit when something goes wrong 2021-08-22 19:20:47 +09:00
Antonio Ojea
0cd75e8fec run hack/update-netparse-cve.sh 2021-08-20 10:42:09 +02:00
Dave Chen
5918869ed6 Revert 103327: "kube-scheduler: ensure the default config output of --write-to-config is usable" 
We don't need to maually disable all the default plugins anymore

Signed-off-by: Dave Chen dave.chen@arm.com
 2021-07-09 19:56:53 +08:00
Kubernetes Prow Robot
17f6f28621 Merge pull request #103468 from Huang-Wei/fix-sched-cc 
instantiates scheduler ComponentConfig after parsing feature gates
 2021-07-07 01:22:43 -07:00
Kubernetes Prow Robot
ea3bcbc205 Merge pull request #101946 from chendave/balance_allocation 
Support extended resource in NodeResourcesBalancedAllocation plugin
 2021-07-06 10:42:19 -07:00
Wei Huang
4c9c761bbb instantiates scheduler ComponentConfig after parsing feature gates 2021-07-06 10:39:12 -07:00
SataQiu
6c86c34457 kube-scheduler: ensure the default config output of --write-to-config is usable 2021-06-30 13:26:27 +08:00
Dave Chen
1fa673c15c Extent the NodeResourcesBalancedAllocation plugin to cover more resources 
Signed-off-by: Dave Chen <dave.chen@arm.com>
 2021-06-30 11:15:12 +08:00
Kubernetes Prow Robot
e0f66be1aa Merge pull request #101822 from yuzhiquan/NodeResourcesFit-score 
Add score func for NodeResourcesFit plugin
 2021-06-29 13:42:20 -07:00
yuzhiquan
deb14b995a Add score plugin for NodeResourcesFit 2021-06-29 13:16:55 -04:00
Abdullah Gharaibeh
b6a317aeaf add a function that returns default scheduler configuration 2021-06-24 11:48:35 -04:00
Abdullah Gharaibeh
265ef1741f Move scheduler plugin set and configuration defaulting to component config 2021-06-16 10:15:29 -04:00
Abdullah Gharaibeh
c13c3ebc79 Remove deprecated scheduler CLI flags hard-pod-affinity-symmetric-weight and scheduler-name 2021-06-11 10:01:42 -04:00
Kubernetes Prow Robot
8955463c17 Merge pull request #102745 from ahg-g/ahg-provider 
Remove SchedulerAlgorithmSource from scheduler's internal CC API
 2021-06-10 07:17:39 -07:00
Abdullah Gharaibeh
52f5ba3a58 Remove SchedulerAlgorithmSource from scheduler's internal CC API 2021-06-09 19:14:54 -04:00
Mengjiao Liu
a5825d6836 JSON log format registration for kube-scheduler 2021-06-10 06:59:59 +08:00
Adhityaa Chandrasekar
3c8e56bef9 scheduler: graduate CC to v1beta2, deprecate plugins 
Signed-off-by: Adhityaa Chandrasekar <adtac@google.com>
 2021-06-07 12:42:55 +00:00
Haleygo
2769e99dba remove scheduler deprecated algorithm-provider flag and clean up algorithmprovider pkg 2021-05-26 13:19:44 +08:00
Kubernetes Prow Robot
70f745a37a Merge pull request #100305 from ingvagabund/kube-scheduler-release-lock-on-cancel 
Release lock on cancel for scheduler
 2021-04-30 07:27:58 -07:00
BinacsLee
75dde4dce4 code cleanup: Abstract repetitive codes in cmd as a function 2021-04-22 23:35:04 +08:00
BinacsLee
f29d0b548e code cleanup: modify kube-scheduler, remove useless return value 2021-04-16 08:16:10 +08:00
Kubernetes Prow Robot
6d130d3b97 Merge pull request #100557 from chendave/validation_cleanup 
Validate plugin config for KubeSchedulerConfiguration
 2021-04-14 18:20:01 -07:00
Dave Chen
c6e65079c7 Validate plugin config for KubeSchedulerConfiguration 
Signed-off-by: Dave Chen <dave.chen@arm.com>
 2021-04-14 09:30:20 +08:00
Kubernetes Prow Robot
ed3e0d302f Merge pull request #100644 from Huang-Wei/sched-fwk-config 
Surface kube config in scheduler framework handle
 2021-04-12 19:12:49 -07:00
Kubernetes Prow Robot
89056f66c8 Merge pull request #100877 from lojies/schedulerlogstructured 
Structured Logging migration: modify logs of kube-scheduler
 2021-04-10 19:04:45 -07:00
Kubernetes Prow Robot
3deca5fe14 Merge pull request #100510 from Huang-Wei/cleanup-sched-init 
sched: dedupe logic of building kubeConfig
 2021-04-08 22:10:32 -07:00
Kubernetes Prow Robot
ff7ac96626 Merge pull request #99868 from tkashem/httplog-started-timestamp 
Use the 'request received timestamp' value inside httplog
 2021-04-08 16:00:08 -07:00
卢振兴10069964
98a03ae57b Structured Logging migration: modify logs of kube-scheduler 2021-04-07 15:53:06 +08:00
Wei Huang
e7f67b1a63 Surface kube config in scheduler framework handle 2021-03-30 11:54:59 -07:00
Kubernetes Prow Robot
b11d0fbdd5 Merge pull request #100171 from chenyw1990/fixGlobalFlagChange 
add normalize function to global FlagSet
 2021-03-23 22:08:04 -07:00
Wei Huang
b697cacf27 sched: dedupe logic of building kubeConfig 2021-03-23 17:15:45 -07:00
chenyw1990
e2020f62ac add normalize function to global FlagSet 2021-03-18 09:23:52 +08:00
Maciej Szulik
c5a5230d93 Release lock on cancel for scheduler 2021-03-16 19:04:44 +01:00
Dave Chen
d50c0aeb5f Enable scheduler_perf to support scheduler config file 
Signed-off-by: Dave Chen <dave.chen@arm.com>
 2021-03-16 23:13:40 +08:00
Abu Kashem
71199664be use request received timestamp in httplog 2021-03-05 15:34:17 -05:00
Benjamin Elder
56e092e382 hack/update-bazel.sh 2021-02-28 15:17:29 -08:00
Mengxue Zhang
4fb8e343c0 parse pod's node affinity once in preFilter 2021-02-25 00:21:32 +00:00
Kubernetes Prow Robot
838bb6a567 Merge pull request #98663 from gavinfish/sched-remove-plugin-pt 
Scheduler: change config.Plugins from pointers to objects
 2021-02-10 15:36:15 -08:00
drfish
74315f9c56 Change config.Plugins from pointers to objects 2021-02-10 23:45:59 +08:00
Kubernetes Prow Robot
356ee4c83a Merge pull request #98254 from changshuchao/scheduler-config-help-line 
Fix the kube-scheduler binary's description of the --config parameter…
 2021-02-02 19:40:28 -08:00
changshuchao
7d8e07bd17 Fix the kube-scheduler binary's description of the --config parameter is inaccurate 
Signed-off-by: changshuchao <chang.shuchao1@zte.com.cn>
 2021-01-29 18:04:57 +08:00