Commit Graph

1421 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
33beb81d8f
Merge pull request #122285 from sanposhiho/remove-qhint
Revert "scheduler/nodeaffinity: reduce pod scheduling latency"
2023-12-14 14:12:39 +01:00
Kubernetes Prow Robot
84b4972903
Merge pull request #122317 from pacoxu/revert-122058-scheduler-first-fit
Revert "Scheduler first fit"
2023-12-14 12:57:34 +01:00
Kubernetes Prow Robot
68ef2423e8
Merge pull request #122288 from sanposhiho/revert-qhint-nodeunschedulable
Revert "scheduler/NodeUnschedulable: reduce pod scheduling latency"
2023-12-14 10:49:19 +01:00
Paco Xu
1160521a4f
Revert "Scheduler first fit" 2023-12-14 17:27:25 +08:00
Kubernetes Prow Robot
7e4751964e
Merge pull request #122080 from SataQiu/clean-test-20231128
clean up unused parameters for volume zone unit test
2023-12-14 06:17:04 +01:00
Kubernetes Prow Robot
84424a8c19
Merge pull request #122068 from caohe/fix-multi-point
fix(scheduler): fix incorrect loop logic in MultiPoint to avoid a plugin being loaded multiple times
2023-12-14 05:10:37 +01:00
Kubernetes Prow Robot
517091cdc5
Merge pull request #122058 from aleksandra-malinowska/scheduler-first-fit
Scheduler first fit
2023-12-14 05:10:19 +01:00
Kubernetes Prow Robot
b155d51f97
Merge pull request #122041 from uniemimu/cleanup
remove unnecessary fmt.Sprintf call
2023-12-14 05:10:11 +01:00
Kubernetes Prow Robot
5322af7f9e
Merge pull request #122022 from sanposhiho/extender-fix
fix: requeue pods rejected by Extenders properly
2023-12-14 05:10:01 +01:00
Kubernetes Prow Robot
f708c47469
Merge pull request #122017 from sanposhiho/doc-shared-lister
fix(doc): elaborate the documentation of SnapshotSharedLister
2023-12-14 05:09:52 +01:00
Kubernetes Prow Robot
de2f38f8a8
Merge pull request #122014 from sanposhiho/owner
put storage related plugins under SIG-Storage reviewing
2023-12-14 05:09:43 +01:00
Kubernetes Prow Robot
f4240cbf92
Merge pull request #121953 from utam0k/not-found-pvc-lister
return not-found errors properly from fake listers
2023-12-14 03:53:45 +01:00
Kubernetes Prow Robot
fb011badd7
Merge pull request #121670 from kerthcet/bug/add-status-message
Fix empty status message in logging
2023-12-13 22:34:51 +01:00
Kubernetes Prow Robot
badc4102ac
Merge pull request #121572 from Prateek462003/myFeature
Added Logging for all the enabled plugins in each extension point
2023-12-13 22:34:06 +01:00
Kubernetes Prow Robot
e13f098c8e
Merge pull request #121387 from KunWuLuan/SidercarContainerChecking
move SidecarContainers featureGate checking
2023-12-13 21:26:09 +01:00
Kubernetes Prow Robot
74afd1a06f
Merge pull request #119539 from HirazawaUi/remove-not-register-event-code
remove unregistered event code
2023-12-13 21:25:33 +01:00
Kensei Nakada
7aeecc42a4 Revert "scheduler/NodeUnschedulable: reduce pod scheduling latency"
This reverts commit 28dbe8a34d.
2023-12-13 03:18:02 +00:00
Kensei Nakada
329b873e4e Revert "scheduler/nodeaffinity: reduce pod scheduling latency"
This reverts commit 1d88bf9789.
2023-12-13 02:57:45 +00:00
AxeZhan
210ed2ebbd add preScore for volumeBinding 2023-12-06 15:35:35 +08:00
caohe
1f5738df84 fix(scheduler): fix incorrect loop logic in MultiPoint to avoid a plugin being loaded multiple times
Signed-off-by: caohe <caohe9603@gmail.com>
2023-11-29 20:14:18 +08:00
Aleksandra Malinowska
199dc03bdd Don't evaluate extra nodes if there's no score plugin defined 2023-11-28 10:39:49 +01:00
SataQiu
c86189d1de clean up unused parameters for volume zone unit test 2023-11-28 11:37:41 +08:00
hub-Prateek
a601ebd6b6 Changed the log message 2023-11-26 11:41:42 +05:30
Ukri Niemimuukko
02b0dc98dd remove unnecessary fmt.Sprintf call
default_preemtion.go has an unnecessary fmt.Sprintf call which
triggers common code checkers. This removes it.

Signed-off-by: Ukri Niemimuukko <ukri.niemimuukko@intel.com>
2023-11-25 21:36:04 +02:00
hub-Prateek
eb45a8f2f5 Added comments 2023-11-24 11:01:15 +05:30
hub-Prateek
76be319571 Optimzed the code 2023-11-24 10:58:33 +05:30
hub-Prateek
5c99f3a24e Logged the return value of ListPlugins 2023-11-24 00:19:42 +05:30
Kensei Nakada
468e2dac81 fix: requeue pods rejected by Extenders properly 2023-11-23 13:20:02 +00:00
Kensei Nakada
03b8241fce put storage related plugins under SIG-Storage reviewing 2023-11-23 08:35:49 +00:00
Kensei Nakada
4d9df1134f fix(doc): elaborate the documentation of SnapshotSharedLister 2023-11-23 08:19:26 +00:00
hub-Prateek
9cb2d1cf6d Removed Comments 2023-11-22 22:32:19 +05:30
hub-Prateek
1dca49157a Utilized ListPlugins method 2023-11-22 02:13:55 +05:30
utam0k
aba817ac1d
return not-found errors properly from fake listeres
Signed-off-by: utam0k <k0ma@utam0k.jp>
2023-11-20 19:14:08 +09:00
Kensei Nakada
005e85c4d3
fix(framework): remove the mention about what happens with nil from EventsToRegister 2023-11-18 15:47:31 +09:00
lianghao208
34e620d18c Support score extension function in preemption. 2023-11-15 15:28:20 +08:00
Kubernetes Prow Robot
5ce0bd95cc
Merge pull request #121677 from kerthcet/cleanup/remove-evnet
Unregister events in schedulingGates for performance
2023-11-10 05:03:33 +01:00
kunwuluan
a00a610d15
move SidecarContainers featureGate checking
to PreFilter

Signed-off-by: KunWuLuan <kunwuluan@gmail.com>
2023-11-06 10:46:52 +08:00
kerthcet
f77a4543d1 Unregister events in schedulingGates plugin
Signed-off-by: kerthcet <kerthcet@gmail.com>
2023-11-06 10:01:13 +08:00
Patrick Ohly
2a23061f6c scheduler: fix performance regression at -v3 + contextual logging
The logging instrumentation for contextual logging that was added for 1.29
slowed down the scheduler (i.e. logging verbosity <= 3) by a significant
percentage (-28.66% for SchedulingBasic/5000Nodes at -v3) if (and only if!)
contextual logging was enabled.

Retrieving the logger from the context causes no measurable slowdown, it's only
the various WithName/WithValues calls which cause this.

By being more careful about when to use those, the performance impact can be
avoided:
- At -v3 or lower, only `WithValues("pod")` is used once per scheduling cycle.
  This has the intended effect that all log messages for the cycle include the
  pod information. Once contextual logging is GA, "pod" key/value pairs can
  be removed from all log calls.
- At -v4 or higher, richer log entries get produced where `WithValues` is also
  used for the node (when applicable) and `WithName` is used for the current
  operation and plugin.

With these changes, enabling contextual logging causes no measurable slowdown
at -v3 or lower. At -v4, the slowdown depends on the test case (-30.51%
throughput for SchedulingBasic/5000Nodes, no change for
SchedulingCSIPVs/5000Nodes). For some unknown reason (measuring bias?),
SchedulingCSIPVs/500Nodes has a ~3& *higher* throughput with contextual
logging.
2023-11-03 17:28:55 +01:00
kerthcet
5bf63036c7 Make EnablePodSchedulingReadiness public
Signed-off-by: kerthcet <kerthcet@gmail.com>
2023-11-03 11:44:56 +08:00
hub-Prateek
7b60e7e2a3 Added plugins enabled at each extension point 2023-11-01 23:03:13 +05:30
kerthcet
fade7463cd Add String() to framework status
Signed-off-by: kerthcet <kerthcet@gmail.com>
2023-11-01 17:01:36 +08:00
Kubernetes Prow Robot
d84ee0ba69
Merge pull request #121632 from kerthcet/fix/runscoreplugins
Fix panic when process RunScorePlugins for cap out of range
2023-10-31 13:14:32 +01:00
kerthcet
b02aad42fa Fix panic when process RunScorePlugins for cap out of range
Signed-off-by: kerthcet <kerthcet@gmail.com>
2023-10-31 16:02:16 +08:00
Kensei Nakada
c7842d9c63 narrow down the scope of EnqueueExtensions to subscribe less cluster events 2023-10-27 14:14:37 +00:00
Kubernetes Prow Robot
fd5c406112
Merge pull request #120933 from mengjiao-liu/contextual-logging-scheduler-remaining-part
kube-scheduler: convert the remaining part to use contextual logging
2023-10-27 10:30:58 +02:00
Kubernetes Prow Robot
53e91942bf
Merge pull request #117780 from sourcelliu/schedulinggates
Improve the performance of schedulinggates
2023-10-26 18:14:32 +02:00
Kubernetes Prow Robot
2749509f35
Merge pull request #121469 from sanposhiho/renamerename
cleanup: rename failedPlugin to plugin in framework.Status
2023-10-25 20:16:43 +02:00
Kensei Nakada
27bb66fd7b cleanup: rename failedPlugin to plugin in framework.Status 2023-10-25 12:03:56 +00:00
Kubernetes Prow Robot
9aa04752e7
Merge pull request #118463 from testwill/replace_loop
chore: slice replace loop
2023-10-24 15:04:39 +02:00