Commit Graph

11283 Commits

Author SHA1 Message Date
Davanum Srinivas
c865ad532a fixing based on feedback in PR
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-12-15 16:51:15 -05:00
Kubernetes Prow Robot
c633ea71ed Merge pull request #122211 from gnufied/fix-uncertain-raw-block-devices
Fix device uncertain errors on reboot
2023-12-15 15:42:40 +01:00
Davanum Srinivas
d621e09a52 remove unused GetRawContainerInfo
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-12-15 05:56:22 -08:00
weilaaa
eb8f3f194f use build-in max and min func to instead of k8s.io/utils/integer funcs 2023-12-15 15:09:11 +08:00
Davanum Srinivas
e2cf9692fc Remove unused code in kubelet - take 1
spotted `DockerContainer` in types.go and pulling on whether we
really needed it found that a bunch of code is not really
required.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-12-14 13:31:38 -08:00
Hemant Kumar
e706b6ba14 Use a separate function for checking if device was reconstructed 2023-12-14 11:37:47 -05:00
Kubernetes Prow Robot
30bb24b1c3 Merge pull request #121913 from liggitt/testing-dep
Drop testing dependency from shipped binaries
2023-12-13 23:55:56 +01:00
Kubernetes Prow Robot
8cc47b64b2 Merge pull request #121795 from carlory/cleanup-after-blockvolume-featuregate-removed
cleanup todo after feature.BlockVolume gate was removed
2023-12-13 23:54:43 +01:00
Kubernetes Prow Robot
26e2cc5299 Merge pull request #119923 from cvvz/fix-119921
fix: Mount point may become local without calling `NodePublishVolume` after node rebooting
2023-12-13 21:25:51 +01:00
Kubernetes Prow Robot
3c1356bc9b Merge pull request #119764 from linxiulei/reservedTypo
Fix error message for invalid resource reservation
2023-12-13 21:25:42 +01:00
Hemant Kumar
56dd5ab10f Add tests for checking of uncertain device paths 2023-12-11 17:15:16 -05:00
Hemant Kumar
ed0facacfa Fix device uncertain errors on reboot 2023-12-06 22:19:14 -05:00
Ziqi Zhao
e92501b8fc optimize the comment
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-12-05 22:46:27 +08:00
Ziqi Zhao
51495bb4c5 optimize the unit test
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-12-05 08:02:03 +08:00
Ziqi Zhao
69c40a3396 fix lints
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-12-02 19:37:49 +08:00
Ziqi Zhao
24c4d6f7c9 add unit test for kubelet trace
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-12-02 17:09:01 +08:00
Patrick Ohly
d11511b1e8 kubelet: enhance context support
27a68aee3a introduced context support for events. Creating an event
broadcaster with context makes tests more resilient against leaking goroutines
when that context gets canceled at the end of a test and enables per-test
output via ktesting.

To use this in kubelet, a more thorough code update is needed. For now,
context.TODO serves as a reminder that this is necessary.
2023-12-01 10:15:01 +01:00
Ziqi Zhao
f035fea63a remove unnecessary code
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-11-29 09:59:53 +08:00
Ziqi Zhao
6d92b330e3 use ctx withoutcancel
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-11-28 23:43:33 +08:00
Ziqi Zhao
90fc108f6d fix kubelet trace broke in 1.28
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-11-28 20:02:23 +08:00
Sascha Grunert
140abfc010 Remove leaky package and move PodInfraContainerName to staging
The variable can be reused in other projects like cadvisor or container
runtimes later on to identify the pod infra container. The `leaky`
package itself is actually not needed any more.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
2023-11-16 14:34:22 +01:00
Sascha Grunert
2076429e43 Enable pod container resources tests on Windows
PR https://github.com/kubernetes/kubernetes/pull/112599 merged so it
seems that we can now enable the tests on Windows.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
2023-11-16 14:13:06 +01:00
Jordan Liggitt
5164db066c Drop testing dependency from shipped binaries 2023-11-15 15:05:18 -05:00
vaibhav2107
1dadf576f2 Updated Added Imagefs inodes in default Eviction Hard 2023-11-15 22:18:53 +05:30
Antonio Ojea
b8533f7976 kubelet: add metric for the first pod with network latency
The first pod with network latency impact user workloads, however,
it is difficuly to understand where is the problem of this latency,
since it depends on the CNI plugin to be ready at the moment of the
pod creation.

Add a new internal metric in the kubelet that allow developers and cluster
administrator to understand the source of the latency problems on
node startups.

kubelet_first_network_pod_start_sli_duration_seconds

Change-Id: I4cdb55b0df72c96a3a65b78ce2aae404c5195006
2023-11-15 06:09:49 +00:00
Kubernetes Prow Robot
c3114b2789 Merge pull request #119652 from lixd/kubelet_image_gc
fix kubelet image gc
2023-11-13 17:36:15 +01:00
Talor Itzhak
ddd60de3f3 memorymanager:metrics: add metrics
As part of the memory manager GA graduation effort, we should add
metrics in order to iprove observability.

The metrics also mentioned in the PR https://github.com/kubernetes/enhancements/pull/4251 (which was not merged yet)

Signed-off-by: Talor Itzhak <titzhak@redhat.com>
2023-11-12 09:34:55 +02:00
payall4u
d6b8a660b0 Fix kubelet panic when allocate resource for pod.
Signed-off-by: payall4u <payall4u@qq.com>
2023-11-12 10:54:05 +08:00
vaibhav2107
30dc2f0773 Added Imagefs inodes in default Eviction Hard 2023-11-10 09:49:56 +05:30
carlory
1c0044594d cleanup todo after feature.BlockVolume gate was removed 2023-11-09 10:01:24 +08:00
charles-chenzz
abaf7a800d increase timeout in fakeDraDriverGrpcServer to fix flake in dra/manger_test 2023-11-07 19:38:27 +08:00
Benedikt Bongartz
099eba784b pass tracerprovider to kublet-readonly server
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
2023-11-07 06:15:45 +01:00
weizhichen
b91f07008c add ut 2023-11-06 08:20:42 +00:00
Kubernetes Prow Robot
9f319c3206 Merge pull request #113374 from ahmedtd/kep-3257-projected-types
Implement ClusterTrustBundlePEM projected volume
2023-11-04 01:44:56 +01:00
Kubernetes Prow Robot
953afbb328 Merge pull request #121193 from sohankunkerkar/kubelet-config-dir
Retarget drop-in kubelet configuration dir feature to Alpha
2023-11-03 23:59:29 +01:00
Sohan Kunkerkar
ee5578be52 cmd/kubelet: fix overriding default KubeletConfig fields in drop-in configs if not set
This commit resolves an issue where certain KubeletConfig fields, specifically:
- FileCheckFrequency
- VolumeStatsAggPeriod
- EvictionPressureTransitionPeriod
- Authorization.Mode
- EvictionHard
were inadvertently overridden when not explicitly set in drop-in configs. To retain the
original values if they were absent in the drop-in configs, mergeKubeletConfigurations
uses a JSON patch merge strategy to selectively merge configurations. It prevents essential
configuration settings from being overridden, ensuring a more predictable behavior for users.

Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
Co-authored-by: Peter Hunt <pehunt@redhat.com>
2023-11-03 17:48:29 -04:00
Taahir Ahmed
1ebe5774d0 kubelet: Support ClusterTrustBundlePEM projections 2023-11-03 11:40:48 -07:00
Kevin Hannon
26923b91e8 implementation of split disk kep 2023-11-01 14:46:33 -04:00
Kubernetes Prow Robot
375e9ee7c4 Merge pull request #120145 from LingyanYin/inplace_vpa_inprogress_custom_resource_fix
fix inplace VPA stuck in InProgress when custom resources are specified
2023-11-01 09:59:32 +01:00
Kubernetes Prow Robot
a8b7e1953f Merge pull request #121456 from kiashok/addRuntimeClassInCriFeatureGate
KEP 4216: Add changes for alpha version under RuntimeClassInImageCriApi feature gate
2023-11-01 03:52:38 +01:00
Kubernetes Prow Robot
960431407c Merge pull request #120715 from gjkim42/do-not-reuse-memory-of-restartable-init-containers
Don't reuse memory of a restartable init container
2023-11-01 01:50:45 +01:00
kiashok
252e1d2dfe Imagepull per runtime class alpha release changes
This commit does the following:
1. Add RuntimeClassInImageCriApi feature gate
2. Extend pkg/kubelet/container Image struct
3. Adds runtimeHandler string in the following CRI calls
   i.   ImageStatus
   ii.  PullImageRequest
   iii.  RemoveImage

Signed-off-by: kiashok <kiashok@microsoft.com>
2023-10-31 15:52:46 -07:00
Kubernetes Prow Robot
113f133b2a Merge pull request #121637 from dims/update-to-new-cadvisor-v0.48.1
Update to new cadvisor v0.48.1
2023-10-31 21:50:23 +01:00
Kubernetes Prow Robot
0c93f40374 Merge pull request #120995 from aroradaman/move-get-kernel-version
move GetKernelVersion out of pkg/proxy/ipvs
2023-10-31 20:23:41 +01:00
Davanum Srinivas
bd233a2aa5 typo/api change in cadvisor / updated unwanted-dependencies.json
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2023-10-31 14:30:57 -04:00
Kubernetes Prow Robot
d475c249da Merge pull request #120954 from HirazawaUi/deprecate-kubeProxyVersione-field
deprecate the kubeProxyVersion field of v1.Node
2023-10-31 19:16:20 +01:00
Kubernetes Prow Robot
ac6f707155 Merge pull request #120620 from tzneal/sidecar-termination-ordering
sidecars: terminate sidecars after main containers
2023-10-31 19:16:11 +01:00
Kubernetes Prow Robot
a5ff0324a9 Merge pull request #120461 from gjkim42/do-not-reuse-device-of-restartable-init-container
Don't reuse the device of a restartable init container
2023-10-31 19:15:53 +01:00
Kubernetes Prow Robot
2c300ef6b0 Merge pull request #120269 from gjkim42/fix-restart-containers-in-right-order-after-podsandbox-changed
Restart containers in right order with SidecarContainers enabled
2023-10-31 19:15:35 +01:00
Kubernetes Prow Robot
bfeb3c2621 Merge pull request #119447 from gjkim42/do-not-reuse-cpu-set-of-restartable-init-container
Don't reuse CPU set of a restartable init container
2023-10-31 19:15:26 +01:00