1. Decoding map with duplicate keys into struct or map produces error.
2. Decoding a map into a Go struct matches json field tag names case-sensitively.
3. When decoding a map into a Go struct, a case-insensitive match between a key and a json field tag
name is treated the same as no match.
Signed-off-by: Vu Dinh <vudinh@outlook.com>
Integration of a slog-based package into a Kubernetes application is completely
transparent when that package uses the global slog default logger because
component-base will set that. When the package wants to be passed a logger
instance, then one can be constructed with slogr.NewSlogHandler.
Integration of a Kubernetes package into an application which uses a slog
Logger is a bit more work when configuring logging. The main binary must call
klog.SetLogger and needs logr/slogr to convert a slog.Handler to a logr.Logger.
instead of waiting for the periodic loop of the node-controller to
go through all the nodes, use the sync logic to reconcile the node
labels each time that the node has changed after it has been
initialized.
This has the benefit that changes by external entities on this labels
are quickly reconciled.
Change-Id: I45cfc1e3f0b9eefdfdd67267229420d76132ab87
The node controller has two reconcilations loops:
1. workqueue receiving events from watchers, to implement
the node initialization
2. periodic loop to reconcile cloud-provider addresses and
node objects, since there is no watch for the cloud-provider
addresses. However, this loop can take O(xx) mins on large
clusters.
Before the external cloud providers were enabled by default,
the kubelet was in charge of setting the corresponding
providerID and zone and region labels during the node object
creation.
Once this logic was moved to the external cloud providers,
there are cases that the node controller may fail to add the
providerID value on the node object and this is never reconciled.
The problem is that there are many controllers and projects that
depend on this field to be set.
Checking at the code it is not possible to not have a ProviderID
in any cloud-provider, since it is always built from the provider name
and the instance. ProviderID is also inmutable once set, so we make
ProviderID a requirement for node initialization.
To avoid any possible problems, we rollout this change under a feature
gate in deprecated state, so cloud providers can opt-out to the new
behavior.
Change-Id: Ic5d9c23b6a286b12c9721d4a378485a8b81212d1
Change-Id: Iac8c7e7e47a3247553806ed7128b273bbef0a30b
