Adds the KUBE_BUILD_WINDOWS option to make release-images and quick-release-images,
which will allow it to build the a Windows kube-proxy image as well. That image can
then be used with Windows Host Process Containers to start the kube-proxy
service on Windows nodes.
With coreutils sed, the argument to -i must follow it immediately;
having a space here causes the command to look for a file with an
empty name, which fails.
Signed-off-by: Stephen Kitt <skitt@redhat.com>
We typically have plenty of skipped tests in an E2E run, which causes Ginkgo to
print many S characters (one for each skipped test). This easily fills up an entire
console window. Now the default is to silence that
output. GINKGO_SILENCE_SKIPS=n reverts to the previous behavior.
By default, Ginkgo prints all progress characters (S and o) in a single
line. Buffering in Prow causes that output to occur only after the run is over,
which defeats the purpose of having those characters. Now a newline is added
after each character, so there is visible progress in Prow while Ginkgo runs.
This commit will bump govulncheck version
1.0.1 -> 1.1.0
Additionally, handle govulncheck exit code returned
It will handle the govulncheck exit code returned
which returning 3 instead of 0 with the new v1.1.0
by adding `|| true` so that the verify job does not
fail but logs the go vulnerability found.
Signed-off-by: ArkaSaha30 <arkasaha30@gmail.com>
Remove useless admission plugin.
* It has been deprecated for years.
* All in-tree cloud providers were removed, so the admission plugin does not have
any way to get PV labels.
* There is a replacement in https://github.com/kubernetes-sigs/cloud-pv-admission-labeler
In a Prow job, the current work tree is the result of merging a PR into the
target. We want apidiff.sh from there, but then need to invoke it for two
specific revisions and compare.
While at it, output and usability get enhanced. The directory parameter(s) may
be absolute paths or lack the leading . that is required by apidiff.
The script failed in the Prow job with:
fatal: Not a valid object name origin/master
That came from "git merge-base origin/master HEAD", which isn't needed because
the Prow job intentionally sets -r explicitly.
Now the fallback is only tried if needed. While at it, the informational
messages get enhanced.
Pinning apidiff to a specific version shouldn't be necessary because, if past
experience in klog holds true, the latest version just works. This way we don't
have to remember to bump up the revision.
The downside of using "latest" is that a compromise of that version would give
an attacker the ability to run code in the CI and on developer machines.
apidiff can be invoked for a single internal package or iterate over
everything, including staging. The base to compare against can be specified via
-r (similar to verify-golangci-lint.sh), with the default the base revision on
master (similar to -a in verify-golangci-lint.sh).
