Commit Graph

103 Commits

Author SHA1 Message Date
Michal Wozniak
79fe37537c Adjust the validation to the current state 2024-03-08 17:43:24 +01:00
Yuki Iwai
e216742672 Job: Support for the JobSuccessPolicy (alpha)
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-03-08 05:49:09 +09:00
Michał Woźniak
e568a77a93
Support for the Job managedBy field (alpha) (#123273)
* support for the managed-by label in Job

* Use managedBy field instead of managed-by label

* Additional review remarks

* Review remarks 2

* review remarks 3

* Skip cleanup of finalizers for job with custom managedBy

* Drop the performance optimization

* imrpove logs
2024-03-05 09:25:15 -08:00
Kubernetes Prow Robot
1fceb815ac
Merge pull request #123437 from tenzen-y/fix-job-validatioin-test-name
Job: Fix test case names for the validations
2024-03-02 13:33:18 -08:00
Kubernetes Prow Robot
9fa043e769
Merge pull request #123181 from tenzen-y/job-avoid-casts-due-to-old-sets
Job: Use generic sets to avoid unnecessary string casts in valiations
2024-02-22 13:03:10 -08:00
Yuki Iwai
cc515bd8f1 Job: Fix test case names for the validations
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-02-22 15:13:38 +09:00
Yuki Iwai
1ef469343f Job: Use generic sets to avoid unnecessary string casts in valiations
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-02-08 08:02:00 +09:00
Yuki Iwai
71bf563034 Job: Stop unnecessary sting casts in validations
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-02-02 06:46:30 +09:00
Maciej Szulik
9a58f6c4fb
Forbid creating CronJob with TZ or CRON_TZ, but allow updates 2023-10-20 17:14:03 +02:00
kannon92
f73c253acc fix typos for pod replacement policy 2023-08-09 20:34:48 +00:00
kannon92
ce92952037 add podReplacementPolicy and terminating field to job api 2023-07-19 16:34:38 +00:00
Michal Wozniak
fcbfdc1710 Extend the Job API for BackoffLimitPerIndex 2023-07-18 11:28:15 +02:00
Kubernetes Prow Robot
bc6cbdabbe
Merge pull request #117852 from tenzen-y/replace-deprecated-sets
Job: Use generic Set in validation
2023-05-24 14:47:00 -07:00
Yuki Iwai
2e2afc7fd2 Job: Use generic Set in validation
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2023-05-12 03:26:25 +09:00
Kubernetes Prow Robot
367180d781
Merge pull request #117933 from tenzen-y/replace-deprecated-Prt-utils
Job: Replace deprecated pointer utils with supported ones
2023-05-11 09:59:14 -07:00
Yuki Iwai
de882f5193 Job: Replace deprecated pointer utils with supported ones
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2023-05-11 19:29:14 +09:00
Tim Hockin
ec3379a717
Do hostNet Pod-ports -> hostPorts in Pod defaults
Rather than doing it in PodSpec defaulting, which triggers in
Deployments and DaemonSets, do it only when a Pod is actually in play.
2023-05-09 18:10:20 -07:00
Yuki Iwai
235c261196 Job: Fix a misspelling
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2023-05-09 00:25:45 +09:00
Kubernetes Prow Robot
7add692580
Merge pull request #117633 from kannon92/remove-job-tracking-finalizers
remove tracking annotation from validation and webhooks
2023-05-04 10:34:43 -07:00
Tim Hockin
d55b67b349
Clean up brace whitespace in **/validation_test.go
This was making my eyes bleed as I read over code.

I used the following in vim.  I made them up on the fly, but they seemed
to pass manual inspection.

:g/},\n\s*{$/s//}, {/
:w
:g/{$\n\s*{$/s//{{/
:w
:g/^\(\s*\)},\n\1},$/s//}},/
:w
:g/^\(\s*\)},$\n\1}$/s//}}/
:w
2023-05-02 00:48:42 -07:00
kannon92
6a4cf352b8 remove tracking annotation from validation and webhooks 2023-04-26 17:16:05 +00:00
kannon92
aef8cbab89 Add batch.kubernetes.io to labels created in the Job controller. 2023-03-11 12:27:38 +00:00
Kubernetes Prow Robot
48e4052fc0
Merge pull request #114902 from TommyStarK/pkg-apis/replace-deprecated-pointer-function
pkg/apis: Replace deprecated pointer function
2023-03-09 21:34:15 -08:00
kannon92
3489ace708 generated code 2023-03-01 21:43:25 +00:00
kannon92
2da3e839b0 remove ValidateJobSpec and add more test cases to batch validation 2023-03-01 20:39:47 +00:00
ahg-g
5bca182544 Allow mutating schedulingGates in the Pod template for suspended Jobs 2023-02-24 18:10:26 +00:00
Daniel Vega-Myhre
8d31da4599 add validation test case for immutable completions on indexed jobs when AllowElasticIndexedJobs is false 2023-02-23 21:05:03 +00:00
Daniel Vega-Myhre
15077a0f28 plumb feature gate value through job validation opts and modify validateCompletions function to only check completions == parallelism after the update, not before 2023-02-23 18:09:47 +00:00
Daniel Vega-Myhre
c63f448451 change test names and address other comments 2023-02-23 03:25:17 +00:00
Daniel Vega-Myhre
d41302312e update validation logic so completions is mutable iff completions is modified in tandem with parallelsim so completions == parallelism 2023-02-23 03:25:16 +00:00
Claudiu Belu
ec753fcb55 unittests: Fixes unit tests for Windows (part 6)
Currently, there are some unit tests that are failing on Windows due to
various reasons:

- On Windows, consecutive time.Now() calls may return the same timestamp, which would cause
  the TestFreeSpaceRemoveByLeastRecentlyUsed test to flake.
- tests in kuberuntime_container_windows_test.go fail on Nodes that have fewer than 3 CPUs,
  expecting the CPU max set to be more than 100% of available CPUs, which is not possible.
- calls in summary_windows_test.go are missing context.
- filterTerminatedContainerInfoAndAssembleByPodCgroupKey will filter and group container
  information by the Pod cgroup key, if it exists. However, we don't have cgroups on Windows,
  thus we can't make the same assertions.
2023-01-31 11:49:26 +00:00
Jordan Liggitt
7e19850f31
Validate format of timeZone 2023-01-30 17:01:45 -05:00
Jurj Andrei George
4df989d719 Skip failing Windows unit tests
As discussed during the SIG Testing meeting on January 10, 2023, failing
Windows unit tests are now skipped.
These changes should be reverted when the unit tests wil get fixed.
Mentioned SIG Testing meeting:
https://docs.google.com/document/d/1z8MQpr_jTwhmjLMUaqQyBk1EYG_Y_3D4y4YdMJ7V1Kk/edit#heading=h.qwblxf2uhgoo
2023-01-18 14:18:41 +02:00
TommyStarK
c242e647ae pkg/apis: Replace deprecated pointer function
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
2023-01-08 13:14:37 +01:00
Michal Wozniak
c803892bd8 Enable the feature into beta 2022-11-09 09:02:40 +01:00
Jordan Liggitt
fc69084bf1
Update workload selector validation 2022-11-07 20:52:02 -05:00
Manjusaka
0843c4dfca
Add extra value validation for matchExpression field in LabelSelector 2022-11-07 20:48:21 -05:00
SataQiu
8dba9f782d remove GA featuregates IndexedJob and SuspendJob 2022-09-20 11:00:43 +08:00
Michal Wozniak
bf9ce70de3 Support handling of pod failures with respect to the specified rules 2022-08-04 18:39:08 +02:00
Maciej Szulik
130845c937
Change validation tests such that they accept valid values from a
provided TZ database and fail on any other values
2022-08-02 16:53:10 +02:00
Abirdcfly
ceceb96f3d
cleanup: skip a test validate time_zone letter case in darwin
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
2022-04-04 16:50:45 +08:00
Ross Peoples
dbb3906a09 Fix for timeZone validation and strategy 2022-03-29 11:40:34 -05:00
Ross Peoples
98837de446 TimeZone support for CronJobs 2022-03-28 16:33:00 -05:00
Kubernetes Prow Robot
36e69a3303
Merge pull request #105980 from ahg-g/ahg-mutable
Make job pod template annotations and labels mutable for suspended jobs that never started
2021-10-29 13:15:23 -07:00
Abdullah Gharaibeh
f466ab0989 Make job pod template annotations and labels mutable for suspended jobs that never started 2021-10-28 14:53:15 -04:00
Aldo Culquicondor
1bff5eb44d Add ready field to Job status
to keep a count of the pods that have the ready condition.

Also:
- Add feature gate JobReadyPods.
- Add Ready to describe.

Change-Id: Ib934730a430a8e2a2f485671e345fe2330006939
2021-10-19 15:18:34 -04:00
Abdullah Gharaibeh
335817cbce Allow updating node affinity, selector and tolerations for suspended jobs that never started 2021-10-14 10:04:47 -04:00
Sahil Vazirani
3988405c8d
GA TTLAfterFinish 2021-10-07 16:58:50 -07:00
Aldo Culquicondor
bb56a0bd04 Add Job.status.uncountedPodUIDs
For tracking Job Pods that have finished but are not yet counted as failed or succeeded

And feature gate JobTrackingWithFinalizers

Change-Id: I3e080f3ec090922640384b692e88eaf9a544d3b5
2021-07-08 15:31:59 +00:00
Davanum Srinivas
4b36a5cbe9
Switch to github.com/robfig/cron/v3
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-06-14 19:03:03 -04:00