Commit Graph

60 Commits

Author SHA1 Message Date
Michal Wozniak
79fe37537c Adjust the validation to the current state 2024-03-08 17:43:24 +01:00
Yuki Iwai
e216742672 Job: Support for the JobSuccessPolicy (alpha)
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-03-08 05:49:09 +09:00
Michał Woźniak
e568a77a93
Support for the Job managedBy field (alpha) (#123273)
* support for the managed-by label in Job

* Use managedBy field instead of managed-by label

* Additional review remarks

* Review remarks 2

* review remarks 3

* Skip cleanup of finalizers for job with custom managedBy

* Drop the performance optimization

* imrpove logs
2024-03-05 09:25:15 -08:00
Kubernetes Prow Robot
9fa043e769
Merge pull request #123181 from tenzen-y/job-avoid-casts-due-to-old-sets
Job: Use generic sets to avoid unnecessary string casts in valiations
2024-02-22 13:03:10 -08:00
Yuki Iwai
1ef469343f Job: Use generic sets to avoid unnecessary string casts in valiations
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-02-08 08:02:00 +09:00
Yuki Iwai
71bf563034 Job: Stop unnecessary sting casts in validations
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2024-02-02 06:46:30 +09:00
Maciej Szulik
9a58f6c4fb
Forbid creating CronJob with TZ or CRON_TZ, but allow updates 2023-10-20 17:14:03 +02:00
kannon92
f73c253acc fix typos for pod replacement policy 2023-08-09 20:34:48 +00:00
kannon92
ce92952037 add podReplacementPolicy and terminating field to job api 2023-07-19 16:34:38 +00:00
Michal Wozniak
fcbfdc1710 Extend the Job API for BackoffLimitPerIndex 2023-07-18 11:28:15 +02:00
Yuki Iwai
2e2afc7fd2 Job: Use generic Set in validation
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2023-05-12 03:26:25 +09:00
Yuki Iwai
235c261196 Job: Fix a misspelling
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2023-05-09 00:25:45 +09:00
kannon92
6a4cf352b8 remove tracking annotation from validation and webhooks 2023-04-26 17:16:05 +00:00
kannon92
aef8cbab89 Add batch.kubernetes.io to labels created in the Job controller. 2023-03-11 12:27:38 +00:00
kannon92
2da3e839b0 remove ValidateJobSpec and add more test cases to batch validation 2023-03-01 20:39:47 +00:00
ahg-g
5bca182544 Allow mutating schedulingGates in the Pod template for suspended Jobs 2023-02-24 18:10:26 +00:00
Daniel Vega-Myhre
15077a0f28 plumb feature gate value through job validation opts and modify validateCompletions function to only check completions == parallelism after the update, not before 2023-02-23 18:09:47 +00:00
Daniel Vega-Myhre
c63f448451 change test names and address other comments 2023-02-23 03:25:17 +00:00
Daniel Vega-Myhre
d41302312e update validation logic so completions is mutable iff completions is modified in tandem with parallelsim so completions == parallelism 2023-02-23 03:25:16 +00:00
Jordan Liggitt
7e19850f31
Validate format of timeZone 2023-01-30 17:01:45 -05:00
Jordan Liggitt
fc69084bf1
Update workload selector validation 2022-11-07 20:52:02 -05:00
Manjusaka
0843c4dfca
Add extra value validation for matchExpression field in LabelSelector 2022-11-07 20:48:21 -05:00
SataQiu
8dba9f782d remove GA featuregates IndexedJob and SuspendJob 2022-09-20 11:00:43 +08:00
Michal Wozniak
bf9ce70de3 Support handling of pod failures with respect to the specified rules 2022-08-04 18:39:08 +02:00
Ross Peoples
dbb3906a09 Fix for timeZone validation and strategy 2022-03-29 11:40:34 -05:00
Ross Peoples
98837de446 TimeZone support for CronJobs 2022-03-28 16:33:00 -05:00
Kubernetes Prow Robot
36e69a3303
Merge pull request #105980 from ahg-g/ahg-mutable
Make job pod template annotations and labels mutable for suspended jobs that never started
2021-10-29 13:15:23 -07:00
Abdullah Gharaibeh
f466ab0989 Make job pod template annotations and labels mutable for suspended jobs that never started 2021-10-28 14:53:15 -04:00
Aldo Culquicondor
1bff5eb44d Add ready field to Job status
to keep a count of the pods that have the ready condition.

Also:
- Add feature gate JobReadyPods.
- Add Ready to describe.

Change-Id: Ib934730a430a8e2a2f485671e345fe2330006939
2021-10-19 15:18:34 -04:00
Abdullah Gharaibeh
335817cbce Allow updating node affinity, selector and tolerations for suspended jobs that never started 2021-10-14 10:04:47 -04:00
Aldo Culquicondor
bb56a0bd04 Add Job.status.uncountedPodUIDs
For tracking Job Pods that have finished but are not yet counted as failed or succeeded

And feature gate JobTrackingWithFinalizers

Change-Id: I3e080f3ec090922640384b692e88eaf9a544d3b5
2021-07-08 15:31:59 +00:00
Davanum Srinivas
4b36a5cbe9
Switch to github.com/robfig/cron/v3
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-06-14 19:03:03 -04:00
Mengxue Zhang
0c99f29f98 add restriction to indexed job name 2021-05-07 13:29:01 +00:00
Aldo Culquicondor
e6c3d7b34d Only default Job fields when feature gates are enabled
Also use pointer for completionMode enum
2021-03-12 20:46:52 +00:00
Aldo Culquicondor
a1a5868a5a Add Job.spec.completionMode and Job.status.completedIndexes
And IndexedJob feature gate, disabled by default.
Update JobDescriber
2021-03-03 15:10:18 +00:00
SataQiu
961d062e9a fix the validation logic for Job/CronJob RestartPolicy field 2020-11-11 14:16:36 +08:00
Derek Carr
45bd6cb186 Downward API hugepages 2020-11-10 16:09:13 -05:00
Zhou Peng
b33e202397 CronJob: cleanup legacy ScheduledJob vars,docs
Signed-off-by: Zhou Peng <p@ctriple.cn>
2020-05-10 00:45:21 +08:00
Roy Hvaara
896f84b652
Fix golint issues in pkg/apis/batch/validation 2019-11-11 04:03:34 +01:00
Jordan Liggitt
c5dfe6b612 Update feature-gate handling of TTLSecondsAfterFinished 2018-12-29 19:36:43 -05:00
Janet Kuo
47d06c446d Validate Job .spec.ttlSecondsAfterFinished; clear it when feature disabled
1. If TTLAfterFinished feature is enabled, the value should be non-negative.
2. If TTLAfterFinished feature is disabled, the field value should not
be kept.
2018-09-04 14:21:14 -07:00
Dr. Stefan Schimanski
012b085ac8 pkg/apis/core: mechanical import fixes in dependencies 2017-11-09 12:14:08 +01:00
Jordan Liggitt
b8155e107c
Limit 52-character cronjob name validation to create 2017-09-24 23:56:27 -04:00
Kubernetes Submit Queue
d85f4c26e0 Merge pull request #52733 from julia-stripe/validate-cronjob-name-length
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..

Validate that cronjob names are 52 characters or less

**What this PR does / why we need it**:

Right now when you create a cronjob with a name longer than 52 characters, creation will succeed but the cronjob controller will create Job objects with names longer than 63 characters. Jobs cannot have names longer than 63 characters, so the cronjob will never be able to run any jobs.

**Which issue this PR fixes** : Fixes #50850 

**Special notes for your reviewer**:

**Release note**:
```release-note
Validate that cronjob names are 52 characters or less
```
2017-09-22 19:22:20 -07:00
Julia Evans
e30237b869 Validate that cronjob names are less than 52 characters 2017-09-19 13:39:33 -07:00
cedric lamoriniere
3989b18586 update API v1 Job object
Add new fields in api v1.JobSpec object for backoff policy
- BackoffLimit
- FailedPodsLimit

fixes: https://github.com/kubernetes/community/pull/583
2017-09-01 21:01:29 +02:00
peay
2b33de0684 Modify CronJob API to add job history limits, cleanup jobs in controller 2017-02-25 06:51:54 -05:00
deads2k
dd7cd951ce move meta/v1/validation to apimachinery 2017-01-16 13:40:13 -05:00
deads2k
6a4d5cd7cc start the apimachinery repo 2017-01-11 09:09:48 -05:00
jianhuiz
0e5d7c3fc0 fix swapped new/old job obj for validating object meta update 2016-12-16 17:17:34 -08:00