Commit Graph

406 Commits

Author SHA1 Message Date
SataQiu
4bd3baece3 kube-controller-manager: remove the deprecated horizontal-pod-autoscaler-upscale-delay and horizontal-pod-autoscaler-downscale-delay flags 2024-05-19 17:49:23 +08:00
Alvaro Aleman
6d0ac8c561 Use the generic/typed workqueue throughout
This change makes us use the generic workqueue throughout the project in
order to improve type safety and readability of the code.
2024-05-04 14:33:12 -04:00
Claudiu Belu
2be8baeaef unittests: Skip failing Windows tests
Some of the unit tests are currently failing on Windows.

Skip them for now, and remove the skips later, once the underlying issues
have been resolved.
2024-04-25 14:24:16 +00:00
Kubernetes Prow Robot
2ec63e0d28
Merge pull request #123482 from sanposhiho/hpa-containerresource-graduation
graduate HPAContainerMetrics to stable
2024-03-06 17:37:36 -08:00
Mengjiao Liu
b584b87a94 kube-controller-manager: readjust log verbosity
- Increase the global level for broadcaster's logging to 3 so that users can ignore event messages by lowering the logging level. It reduces information noise.
- Making sure the context is properly injected into the broadcaster, this will allow the -v flag value to be used also in that broadcaster, rather than the above global value.
- test: use cancellation from ktesting
- golangci-hints: checked error return value
2024-02-26 14:51:56 +08:00
Kensei Nakada
07e0a80216 graduate HPAContainerMetrics to stable 2024-02-25 00:58:00 +00:00
Kubernetes Prow Robot
99bf6a674c
Merge pull request #121039 from josselin-c/master
hpa: always update status metrics when updating the replica count
2023-10-28 19:35:01 +02:00
Kubernetes Prow Robot
2b16f7b6bb
Merge pull request #120001 from qingwave/hpa-sidecar
HPA: calculate sidecar container resource in pod autoscaler
2023-10-23 18:39:31 +02:00
Josselin Costanzi
3c4512c6cc hpa: always update status metrics when updating the replica count
Have hpa always update both the metrics and replica count. This fix an
edge case behavior bug where the metrics would not be updated if a
custom metrics was unavailable.
2023-10-06 21:34:09 +00:00
Lukasz Stankiewicz
1b489963c8 Add nil checks for hpa object target type values 2023-10-05 17:15:51 -07:00
qingwave
7f805dc935 fix test name 2023-08-19 03:31:34 +00:00
qingwave
f07a3a3f26 calculate sidecar container resource in pod autoscaler
Signed-off-by: qingwave <isguory@gmail.com>
2023-08-17 07:47:59 +00:00
Kubernetes Prow Robot
0a82bdbfdb
Merge pull request #118173 from huiwq1990/feat-autoscale-variable
hpa: cleanup `currentReplicas` code
2023-07-02 23:00:50 -07:00
Kubernetes Prow Robot
52b1247b28
Merge pull request #118232 from luckymrwang/style
style: correct the sentence
2023-06-30 01:51:59 -07:00
Cookie Wang
e2ed8f8c3c style: correct the sentence 2023-05-24 20:24:36 +08:00
huiwq1990
048938f1d8 hpa: cleanup currentReplicas code
Signed-off-by: huiwq1990 <huiwq1990@163.com>
2023-05-22 20:37:49 +08:00
zach593
e3d5feb76c fix HPA plain metric calculate
fix inconsistency in plain metric replica calculator when usageRatio == 1.0, keep same with resource replicas
2023-05-10 11:14:29 +08:00
Guy Templeton
d102a6fea5
HPA Controller - Update Owners
Move josephburnett to emeritus status
2023-04-09 22:44:20 +01:00
Kensei Nakada
543f15d10c HPA: expose the metrics "metric_computation_duration_seconds" and "metric_computation_total" from HPA controller 2023-03-14 22:47:24 +00:00
Kensei Nakada
b49b34c03a
HPA: expose the metrics "reconciliations_total" and "reconciliation_duration_seconds" from HPA controller (#116010) 2023-03-14 09:39:42 -07:00
Kubernetes Prow Robot
c237ddb226
Merge pull request #116045 from sanposhiho/sanposhiho/message
fix(HPA): make a difference in SuccessfulRescale  events between the resource metric and the container resource metric
2023-03-13 13:24:47 -07:00
Kensei Nakada
fafbed3b1d
fix the error message 2023-03-12 14:48:48 +09:00
Kensei Nakada
f76258f0ff fix based on the suggestion 2023-03-05 15:01:34 +00:00
Kensei Nakada
33daba24fb fix(HPA): ignore the container resource metrics in HPA controller when the feature gate is disabled 2023-02-25 23:04:07 +00:00
Kensei Nakada
2ea50fc200 fix(HPA): make a difference in SuccessfulRescale events between the resource metric and the container resource metric 2023-02-24 14:47:38 +00:00
Freddie
dee494ece1 squashing without rebase 2023-02-17 01:47:52 +05:30
Kushagra
80384bbb55 spelling mistake rectified 2022-12-29 17:55:17 +00:00
Kushagra
f380ef8b61 Misleading message when there are no metrics. 2022-12-29 10:57:43 +00:00
ialidzhikov
aede3fbf40 pkg/controller: Replace deprecated func usage from the k8s.io/utils/pointer pkg 2022-11-23 17:40:23 +02:00
Kubernetes Prow Robot
c519bc02e8
Merge pull request #112011 from pbeschetnov/ambiguous-selectors
Add ambiguous selector check to HPA
2022-11-06 21:08:16 -08:00
Pavel Beschetnov
caddfdd040 Add pod ambiguous selector check 2022-11-04 12:49:20 +00:00
Kubernetes Prow Robot
f9f9f0107d
Merge pull request #112544 from abhijit-dev82/master
HPA : Enhance error message to capture POD details
2022-10-28 04:14:30 -07:00
Kubernetes Prow Robot
85643c0f93
Merge pull request #108501 from zroubalik/hpa
add `--concurrent-horizontal-pod-autoscaler-syncs` flag to kube-controller-manager
2022-10-17 14:13:18 -07:00
Zbynek Roubalik
1cefcdea2d add --concurrent-horizontal-pod-autoscaler-syncs flag to kube-controller-manager
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
2022-10-17 17:39:31 +02:00
Abhijit
ac56e6f34e HPA : Enhance error message to capture POD details
HPA : Enhance error message to capture POD details
2022-10-17 14:21:28 +05:30
Kubernetes Prow Robot
4245895261
Merge pull request #111463 from pbetkier/hpa-comment-fix
Fix comment in HPA's scale event replicaChange
2022-09-30 04:08:28 -07:00
Kubernetes Prow Robot
3a0dbe5749
Merge pull request #112335 from piotrnosek/fixcustomcrd
Fix HPA E2E CustomResourceDefinition test
2022-09-22 11:01:06 -07:00
Kushagra
dc321b4d2a requeted changes: fix variables in test cases 2022-09-22 09:17:15 +00:00
Kushagra
01b553145c requested changes: fix return type variables 2022-09-22 08:59:02 +00:00
Piotr Nosek
96ff1b1bcb Fix HPA E2E CRD test 2022-09-21 22:39:47 +00:00
Kushagra
cbea8d2248 requested changes 2022-09-19 08:15:06 +00:00
Kushagra
79f5c7da33 varibale name change for better understanding 2022-09-19 05:05:01 +00:00
Kushagra
de8245e952 added ut for the change 2022-09-05 14:56:24 +00:00
Kushagra
b75fbda0ed requested changes 2022-09-05 04:54:59 +00:00
Kushagra
bb735bf689 revert for non-utilization metrics 2022-09-05 04:54:59 +00:00
Kushagra
6bb73bae06 FIX: hpa scale down with target >= 100 2022-09-05 04:54:59 +00:00
Kubernetes Prow Robot
5ade6c833f
Merge pull request #110695 from lokichoggio/hpa
code optimization: deal with error first to prevent unnecessary computing
2022-09-01 17:52:04 -07:00
Kubernetes Prow Robot
4cb7524e5a
Merge pull request #110492 from j2gg0s/opt-var-name-in-hpa
hpa: rename rebalanceIgnored to scaleUpWithUnready for understanding
2022-08-30 23:43:00 -07:00
Kubernetes Prow Robot
239a19ecc1
Merge pull request #111170 from ping035627/k8s-220715
HandleError of updateStatusIfNeeded in func reconcileAutoscaler
2022-08-30 10:59:06 -07:00
Kubernetes Prow Robot
da6d8c997e
Merge pull request #109058 from oliviermichaelis/calculate-start-replicas
Fix replica calculation at start of HPA scaling policy period
2022-08-30 10:58:55 -07:00