github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
27,817 Commits 1 Branch 31 Tags
beebca1bb9db1d1892ef348288653bfa43fc3cb9
Commit Graph

707 Commits

Author SHA1 Message Date
goltermann
3fa6c6f6d9 Enable vet 2016-04-20 09:48:24 -07:00
Alex Robinson
23a8401c32 Merge pull request #24452 from a-robinson/dpv 
Fix gce.getDiskByNameUnknownZone logic.
 2016-04-19 11:58:04 -07:00
k8s-merge-robot
db28f73c3b Merge pull request #24282 from goltermann/spelling 
Automatic merge from submit-queue

Fix misspellings in comments
 2016-04-19 03:47:07 -07:00
Alex Robinson
d69ccd5c8c Fix gce.getDiskByNameUnknownZone logic. 2016-04-18 22:55:59 -07:00
k8s-merge-robot
1087162548 Merge pull request #23841 from dagnello/update-openstack-cloudprovider-volume-tests 
Automatic merge from submit-queue

Extend OpenStack Cloud Provider Volume Tests

Adding coverage for:
getVolume
AttachDisk
DetachDisk
 2016-04-16 17:44:09 -07:00
goltermann
c226c9435b Fix misspellings in comments. 
https://goreportcard.com/report/k8s.io/kubernetes#misspell
 2016-04-14 13:57:45 -07:00
k8s-merge-robot
62d65f3ce6 Merge pull request #23770 from dagnello/update-openstack-cloudprovider-instance-tests 
Automatic merge from submit-queue

Extend OpenStack Cloud Provider Instance Tests

Adding OpenStack cloud provider Instance coverage for:
ExternalID
InstanceID
 2016-04-14 04:26:42 -07:00
Jeff Lowdermilk
9be85fbaf0 Merge pull request #23541 from bprashanth/fw_default 
Default firewall port to TCP when unspecified.
 2016-04-08 09:32:00 -07:00
dagnello
cd7e99af1c Add OpenStack Cloud Provider Instance Tests 
Adding OpenStack cloud provider instance unit tests for externalID and
instanceID.
 2016-04-04 17:06:17 -07:00
dagnello
28590781c1 Extend OpenStack Cloud Provider Volume Tests 
Adding test coverage for:
getVolume
AttachDisk
DetachDisk
 2016-04-04 17:01:42 -07:00
zhouhaibing089
4758f9953b fix the gcfg typo 2016-03-29 23:32:11 +08:00
k8s-merge-robot
0c06f31cb8 Merge pull request #23340 from justinsb/fix_23339 
Auto commit by PR queue bot
 2016-03-29 05:04:27 -07:00
Prashanth Balasubramanian
7436fc6261 Default firewall port to TCP when unspecified. 2016-03-28 11:06:19 -07:00
k8s-merge-robot
e44ad7a083 Merge pull request #22735 from resouer/throttle-dev 
Auto commit by PR queue bot
 2016-03-26 06:44:48 -07:00
k8s-merge-robot
4e4ad61260 Merge pull request #23366 from goltermann/vet 
Auto commit by PR queue bot
 2016-03-24 21:50:56 -07:00
harry
8472cfa214 Refactor throttle into util pkg 
Fix missing throttle.go
 2016-03-25 08:32:23 +08:00
Chris Batey and James Ravn
be9ce30897 Change LoadBalancer methods to take api.Service 
This is a better abstraction than passing in specific pieces of the
Service that each of the cloudproviders may or may not need. For
instance, many of the providers don't need a region, yet this is passed
in. Similarly many of the providers want a string IP for the load
balancer, but it passes in a converted net ip. Affinity is unused by
AWS. A provider change may also require adding a new parameter which has
an effect on all other cloud provider implementations.

Further, this will simplify adding provider specific load balancer
options, such as with labels or some other metadata. For example, we
could add labels for configuring the details of an AWS elastic load
balancer, such as idle timeout on connections, whether it is
internal or external, cross-zone load balancing, and so on.

Authors: @chbatey, @jsravn
 2016-03-23 10:48:11 +00:00
goltermann
34d4eaea08 Fixing several (but not all) go vet errors. Most are around string formatting, or unreachable code. 2016-03-22 17:26:50 -07:00
Justin Santa Barbara
59013f5507 AWS: Fix problems with >2 security groups 
The previous logic was incorrect; if we saw two untagged security groups
before seeing the first tagged security, we would incorrectly return an
error.

Fix #23339
 2016-03-22 13:00:14 -04:00
k8s-merge-robot
8c02a46c4d Merge pull request #22486 from thockin/update-gcfg-dep 
Auto commit by PR queue bot
 2016-03-21 18:47:21 -07:00
k8s-merge-robot
0a28a38110 Merge pull request #22280 from justinsb/fix_error_message_formats 
Auto commit by PR queue bot
 2016-03-21 16:53:38 -07:00
k8s-merge-robot
0fe049f9ff Merge pull request #23019 from alex-mohr/oplimit 
Auto commit by PR queue bot
 2016-03-19 02:26:56 -07:00
k8s-merge-robot
ad7a0da5af Merge pull request #23089 from saad-ali/addZoneToErr 
Auto commit by PR queue bot
 2016-03-17 15:07:28 -07:00
saadali
26e3d7a27a Add zone to GCE "disk not found" error message 2016-03-16 17:31:12 -07:00
deads2k
ab03317d96 support CIDRs in NO_PROXY 2016-03-16 16:22:54 -04:00
Tim Hockin
a073c80e45 Use newer home for gcfg package 
Switch from obsolete "github.com/scalingdata/gcfg" to "gopkg.in/gcfg.v1".
 2016-03-16 08:42:08 -07:00
Alex Mohr
6dc63f805f Add a rate limiter to the GCE cloudprovider 
It will poll for operation completion with at most 10 qps to avoid
triggering GCE's rate limits.
 2016-03-15 15:47:32 -07:00
Jan Safranek
f270cb1b9b Allow 39 atached EBS devices. 
AWS has soft support limit for 40 attached EBS devices. Assuming there is just
one root device, use the rest for persistent volumes.

The devices will have name /dev/xvdba - /dev/xvdcm, leaving /dev/sda - /dev/sdz
to the system.

Also, add better error handling and propagate error
"Too many EBS volumes attached to node XYZ" to a pod.
 2016-03-15 17:28:59 +01:00
k8s-merge-robot
bf1bb5d309 Merge pull request #22899 from justinsb/aws_fix_e2e 
Auto commit by PR queue bot
 2016-03-14 17:37:13 -07:00
Justin Santa Barbara
3e12e8b7cc AWS e2e: don't try to build a full cloudprovider in e2e 
We have previously tried building a full cloudprovider in e2e for AWS;
this wasn't the best idea, because e2e runs on a different machine than
normal operations, and often doesn't even run in AWS.  In turn, this
meant that the cloudprovider had to do extra work and have extra code,
which we would like to get rid of.  Indeed, I got rid of some code which
tolerated not running in AWS, and this broke e2e.
 2016-03-12 06:14:45 -05:00
k8s-merge-robot
45064e19d1 Merge pull request #22793 from justinsb/fix_22792 
Auto commit by PR queue bot
 2016-03-11 20:37:25 -08:00
k8s-merge-robot
26e309c753 Merge pull request #22784 from justinsb/fix_17626 
Auto commit by PR queue bot
 2016-03-11 20:04:13 -08:00
k8s-merge-robot
de7193a095 Merge pull request #22788 from justinsb/fix_22786 
Auto commit by PR queue bot
 2016-03-11 15:13:06 -08:00
Justin Santa Barbara
e40595fa57 AWS volumes: Release disk from attaching map on error 
If AWS gives us an actual error (vs just timing out), we know the disk
did not attach, and so we can remove it immediately from the attaching
map.
 2016-03-11 11:40:39 -05:00
Justin Santa Barbara
16730aba96 AWS: Tag created EBS volumes with our cluster tag 
Fix #22792
 2016-03-10 08:13:50 -05:00
Justin Santa Barbara
79b2b7edef AWS EBS: Remove the attached volumes cache 
There are known issues with the attached-volume state cache that just aren't
possible to fix with the current interface.

Replace it with a map of the active attach jobs (that was the original
requirement, to avoid a nasty race condition).

This costs us an extra DescribeInstance call on attach/detach, but that
seems worth it if it ends this class of bugs.

Fix #15073
 2016-03-10 07:50:35 -05:00
Justin Santa Barbara
0921af4aca AWS: Don't pass empty filters to AWS requests 
It gives an error: `The filter 'null' is invalid`

Instead of a zero-length filter list, provide a nil value.

Fix #22786
 2016-03-10 07:22:31 -05:00
Justin Santa Barbara
7c82fe7389 AWS: Increase timeout deleting ELB; log remaining security groups 
Either ELB is slow to delete (in which case the bumped timeout will
help), or the security groups are otherwise blocked (in which case
logging them will help us track this down).

Fix #17626
 2016-03-10 06:57:13 -05:00
Justin Santa Barbara
cb818a01d0 AWS: Fix some error messages 
Some error messages had incorrect spacing.  Prefer Warningf to Warning,
and fix some of those problems.
 2016-03-08 06:29:29 -05:00
Justin Santa Barbara
02e79b9e52 AWS: If we have no subnets, bail out early 
We know the ELB call will fail, so we error out early rather than
hitting the API.  Preserves rate limit quota, and also allows us to give
a more self-evident message.

Fix #21993
 2016-03-06 09:41:29 -05:00
Justin Santa Barbara
5cf837452b AWS: Fix problems identifying subnets for internal ELBs 
We tacitly supported this before, but we broke this with the
public-subnet detection.

Fix #22527
 2016-03-06 09:41:29 -05:00
Justin Santa Barbara
43e6602c42 AWS: Fix test failure introduced by rebase 2016-03-05 08:11:30 -05:00
Justin Santa Barbara
cff564b1a6 AWS: Remove dead code and fix up comments 2016-03-05 08:09:40 -05:00
Justin Santa Barbara
f8e6098e4d AWS: Update tests for refactoring 2016-03-05 08:09:40 -05:00
Justin Santa Barbara
af9efa02b4 AWS: Remove getSelfAWSInstance, use field directly 
Now that we always populate the local instance, we don't need a getter.
 2016-03-05 08:09:40 -05:00
Justin Santa Barbara
8c492c7536 AWS: Don't store the AZ on the cloud 
Now we have Ubernetes-Lite, an AWSCloud can span multiple AZs.
 2016-03-05 08:09:40 -05:00
Justin Santa Barbara
ddb5072a54 AWS: Don't pretend getSelfAWSInstance can return an error 
It can't any more; this simplifies calling code.
 2016-03-05 08:09:40 -05:00
Justin Santa Barbara
40d0afbb1b AWS: Capture VPC ID into AWSCloud, avoiding requeries 
By storing the VPC ID on AWSCloud, we avoid the need to requery or to
pass it around.
 2016-03-05 08:09:40 -05:00
Justin Santa Barbara
00b666f853 AWS: Rename getInfo -> describeInstance/describeVolume 
Makes it clearer that we are making an AWS API call
 2016-03-05 08:09:40 -05:00
Justin Santa Barbara
efa68a3590 AWS: Build awsInstance as part of cloud provider creation 
We need getSelfAWSInstance to be working anyway; we might as well build
it early, and then we can use its methods to extract e.g. the VPC ID
 2016-03-05 08:09:40 -05:00