github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
109,852 Commits 1 Branch 31 Tags 1,019 MiB
bf9ce70de3
Commit Graph

5781 Commits

Author SHA1 Message Date
Jan Safranek
3b94ac228a Don't force detach volume from healthy nodes 
6 minute force-deatch timeout should be used only for nodes that are not
healthy. 

In case a CSI driver is being upgraded or it's simply slow, NodeUnstage
can take more than 6 minutes. In that case, Pod is already deleted from the
API server and thus A/D controller will force-detach a mounted volume,
possibly corrupting the volume and breaking CSI - a CSI driver expects
NodeUnstage to succeed before Kubernetes can call ControllerUnpublish.
 2022-06-24 12:51:41 +02:00
Kubernetes Prow Robot
ae3537120b
Merge pull request #110639 from aojea/slice_no_node 
EndpointSlice with Pods without an existing Node
 2022-06-22 10:43:42 -07:00
Kubernetes Prow Robot
b60978629d
Merge pull request #110700 from alculquicondor/increase_timeout 
Increase timeout for TestSyncPastDeadlineJobFinished
 2022-06-22 08:23:56 -07:00
Kubernetes Prow Robot
18b5efceda
Merge pull request #110410 from Jiawei0227/master 
CSIMigration feature gate to GA
 2022-06-22 04:05:48 -07:00
Antonio Ojea
b8ba6ab005 endpointslices: node missing on Pod scenario 
When a Pod is referencing a Node that doesn't exist on the local
informer cache, the current behavior was to return an error to
retry later and stop processing.
However, this can cause scenarios that a missing node leaves a
Slice stuck, it can no reflect other changes, or be created.
Also, this doesn't respect the publishNotReadyAddresses options
on Services, that considers ok to publish pod Addresses that are
known to not be ready.

The new behavior keeps retrying the problematic Service, but it
keeps processing the updates, reflacting current state on the
EndpointSlice. If the publishNotReadyAddresses is set, a missing
node on a Pod is not treated as an error.
 2022-06-22 09:45:16 +02:00
Antonio Ojea
baecb1981e fix metrics for placeholder slice 
There is always a placeholder slice.

The ServicePortCache logic was considering always one endpointSlice
per Endpoint, but if there are multiple empty Endpoints, we just
use one placeholder slice, not multiple placeholder slices.
 2022-06-22 09:45:02 +02:00
Antonio Ojea
0d9689a55d fix a bug on endpointslices tests comparing the wrong metrics 2022-06-22 09:40:18 +02:00
Aldo Culquicondor
817c8bbf59 Increase timeout for TestSyncPastDeadlineJobFinished 
To mitigate flakiness

Change-Id: I1d0286d16d2b7dd3a605690e9a2d4d2f954701ff
 2022-06-21 14:49:10 -04:00
Kubernetes Prow Robot
375fd32b9f
Merge pull request #109957 from adammw/adammw/disruption-implements-scale 
disruptioncontroller: check for scale subresource correctly
 2022-06-21 08:00:26 -07:00
Adam Malcontenti-Wilson
af3594dfa5 disruptioncontroller: check for scale subresource correctly 2022-06-15 08:52:47 +10:00
Kubernetes Prow Robot
10066243df
Merge pull request #110365 from spencerhance/epslice-recycle-bug 
Fix unnecessary recreation of placeholder EndpointSlice
 2022-06-14 13:15:34 -07:00
Spencer Hance
5f8dc48fbe Fix unnecessary recreation of placeholder EndpointSlice 
Fixes Issue 108231 by checking `slicesToDelete` in the EndpointSlice
reconciler for a pre-existing placeholder slice.

Also adds a helper function for comparing the slices.
 2022-06-14 09:24:38 -07:00
Kubernetes Prow Robot
5503bb0570
Merge pull request #110529 from wojtek-t/fix_leaking_goroutines_7 
Fix leaking goroutines in multiple integration tests
 2022-06-14 09:09:54 -07:00
Wojciech Tyczyński
8a87681a39 Clean shutdown of resourcequota integration tests 2022-06-14 13:55:31 +02:00
Harsha Narayana
eea7dca085
GIT-110239: fix activeDeadlineSeconds enforcement bug 
GIT-110239: add additional tests with preset Status.StartTime

GIT-110239: add additional tests with preset Status.StartTime
 2022-06-13 20:06:44 +05:30
Wojciech Tyczyński
32cbd77121 Clean shutdown of garbagecollector integration tests 2022-06-13 00:14:19 +02:00
Kubernetes Prow Robot
6cd258f9f5
Merge pull request #110292 from mimowo/109904-avoid-duplicate-conditions 
Avoid duplicate Failed conditions in job status
 2022-06-09 14:01:45 -07:00
Kubernetes Prow Robot
e8d6b76f8b
Merge pull request #109624 from aryan9600/fix-endpointslice-deletion 
Ignore EndpointSlices that are marked for deletion
 2022-06-09 00:11:42 -07:00
Kubernetes Prow Robot
39b6e6c6a0
Merge pull request #110362 from wojtek-t/fix_leaking_goroutines_5 
Fix leaking goroutines in multiple integration tests
 2022-06-07 08:44:55 -07:00
Jiawei Wang
760365d5c9 CSIMigration feature gate to GA 2022-06-06 21:19:19 +00:00
Wojciech Tyczyński
006ff4510b Clean shutdown of nodecontroller integration tests 2022-06-06 20:33:20 +02:00
Sanskar Jaiswal
4314e58ae5 move the ignore logic higher up to the reconciler 
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
 2022-06-06 09:49:57 +05:30
Wojciech Tyczyński
d9d46d5326 Clean shutdown of certificates integration tests 2022-06-02 21:02:04 +02:00
Wojciech Tyczyński
783da34f54 Clean shutdown of disruption integration tests 2022-06-02 21:02:04 +02:00
Kubernetes Prow Robot
9f82d81e55
Merge pull request #110286 from FillZpp/add-test-for-statefulset-maxunavailable 
A calculation function for StatefulSet maxUnavailable and some tests for it
 2022-06-02 10:46:07 -07:00
Kubernetes Prow Robot
03d0e2c338
Merge pull request #110264 from wojtek-t/fix_leaking_goroutines_4 
Fix leaking goroutines in multiple integration tests
 2022-06-02 03:59:47 -07:00
Kubernetes Prow Robot
22fda4e7ee
Merge pull request #108232 from qmloong/qmloong/chore 
fix: remove the redundant count variable
 2022-06-01 10:53:40 -07:00
Michal Wozniak
e298649b6c Avoid duplicate conditions by updating the pre-existing failed condition 
in case its status is False or Unknown.

In case the status of the pre-existing condition is true we ignore the new
condition. If there is no pre-existing failed condition, then append
the new failed condition as before.

Also, make the condition comparisons less hacky by ignoring timestamp fields
in tests.
 2022-06-01 19:32:53 +02:00
FillZpp
1818a9a36a A calculation function for StatefulSet maxUnavailable and some tests for it 
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
 2022-05-31 16:45:19 +08:00
Wojciech Tyczyński
c20f7cc4e1 Clean shutdown of endpoints/endpointslice integration tests 2022-05-30 20:17:35 +02:00
Kubernetes Prow Robot
8b6dd065d7
Merge pull request #110255 from robscott/fix-pod-eviction-ip 
Endpoints and EndpointSlices should not publish IPs for terminal pods
 2022-05-27 16:24:42 -07:00
Rob Scott
aa02b7a434
Updating e2e test to check EndpointSlices and Endpoints as well 2022-05-27 21:10:59 +00:00
Kubernetes Prow Robot
ad06854e5e
Merge pull request #110228 from mysunshine92/HPA-log-optimization 
Error message optimization for podautoscaler controller
 2022-05-27 05:13:18 -07:00
Antonio Ojea
aa35f6f160 endpoints controller: don't consider terminal endpoints 
Terminal pods, whose phase its Failed or Succeeded, are guaranteed
to never regress and to be stopped, so their IPs never should
be published on the Endpoints.
 2022-05-27 06:42:58 +02:00
Antonio Ojea
b905c2870b endpointslices: terminal pods doesn't receive enpoints 2022-05-27 06:42:52 +02:00
wangyamei
187dcb5a59 Error message optimization for podautoscaler controller 2022-05-26 23:40:34 +08:00
lokichoggio
57d1c2d5cd
complete doc 2022-05-24 11:26:15 +08:00
Kubernetes Prow Robot
fbb5717279
Merge pull request #110069 from FillZpp/fix-statefulset-maxunavailable-less-than-one 
Fix maxUnavailable of StatefulSet should not less than 1
 2022-05-20 16:50:12 -07:00
Wojciech Tyczyński
11b679c66a Fix event broadcaster shutdown in multiple controllers 2022-05-17 22:14:19 +02:00
FillZpp
85e3194cf6 Fix maxUnavailable of StatefulSet should not less than 1 
Signed-off-by: FillZpp <FillZpp.pub@gmail.com>
 2022-05-16 16:58:19 +08:00
Kubernetes Prow Robot
b91c5263f5
Merge pull request #109947 from alculquicondor/fix-job-orphan-pod-ut 
Wait for cache to sync in job's TestWatchOrphanPods
 2022-05-11 10:47:13 -07:00
Kubernetes Prow Robot
b74d023e70
Merge pull request #109694 from RyanAoh/fix-108837 
Be sure to update the status of StatefulSet even if the new replica creation fails
 2022-05-10 21:28:50 -07:00
Aldo Culquicondor
a5f5eab5fd Wait for cache to sync in job's TestWatchOrphanPods 
Otherwise the event handler might not be called.

Change-Id: I23c93c2251b411430a0f2469686db6355d84af2f
 2022-05-10 14:18:21 -04:00
Aohan Yang
774df1b0af Be sure to update the status of StatefulSet even if the new replica creation fails 2022-05-10 10:25:26 +08:00
Kubernetes Prow Robot
fcffb6de7e
Merge pull request #108089 from mysunshine92/nodeController-20220212 
fix typo for nodelifecycle controller
 2022-05-07 03:33:18 -07:00
Marcel Zięba
47257b7613 Reduce number of buckets in ttl controller for 2k+ nodes clusters 2022-05-05 12:26:36 +00:00
Kubernetes Prow Robot
7adb7c1d06
Merge pull request #109612 from pandaamanda/remove_DeprecatedControllerOptions 
refactor: remove deprecated `deleting-pods-qps` `deleting-pods-burst` `register-retry-count`  flags
 2022-05-04 02:34:54 -07:00
Kubernetes Prow Robot
63a618a815
Merge pull request #109486 from alculquicondor/job-backofflimit 
Fix job tracking leaving pods with finalizers
 2022-05-04 01:28:14 -07:00
Tom Kerkhove
77efbc411a
feat: Provide previous replica count for deployment/replica set scale up/down event (#101142) 
* feat: Provide previous replica count for deployment/replica set scale up/down event

Signed-off-by: GitHub <noreply@github.com>

* change format of event

Co-authored-by: Maciej Szulik <soltysh@gmail.com>

Co-authored-by: Maciej Szulik <soltysh@gmail.com>
 2022-05-03 17:16:59 -07:00
Sanskar Jaiswal
7d8048dd59 Ignore EndpointSlices that are already marked for deletion 
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
 2022-04-23 01:32:32 +05:30
熊中谅10171568
c4579165f1 refactor: remove deprecated flags 
refactor: remove deprecated deleting-pods-qps deleting-pods-burst register-retry-count flags
 2022-04-22 20:28:12 +08:00
Aldo Culquicondor
09caa36718 Fix removing finalizer from finished jobs 
In some rare race conditions, the job controller might create new pods after the job is declared finished.

Change-Id: I8a00429c8845463259cd7f82bb3c241d0011583c
 2022-04-20 16:39:10 -04:00
Aldo Culquicondor
53aa05df3a Don't mark job as failed until expectations are satisfied 
Change-Id: I99206f35f6f145054c005ab362c792e71b9b15f4
 2022-04-20 16:39:10 -04:00
Deepak Kinni
a7b1fcba40 Add or Remove PV deletion protection finalizer considering the recalimPolicy 
Signed-off-by: Deepak Kinni <dkinni@vmware.com>
 2022-04-07 00:48:35 +05:30
Jordan Liggitt
495b01ef6c Move cron job feature gate to correct file 2022-04-03 22:56:01 -04:00
d-honeybadger
7ae21b9849 cronjob_controllerv2: fix requeueing of cronjobs with every-style schedule 2022-04-01 20:14:23 -04:00
SataQiu
9ac1b4b68f remove unused option deployment-controller-sync-period for deployment controller 2022-03-30 20:00:53 +08:00
Kubernetes Prow Robot
1266744002
Merge pull request #108693 from gnufied/enable-rwx-call-all-nodes 
Enable node-expansion to be called on all nodes for RWX volumes
 2022-03-29 17:35:05 -07:00
Kubernetes Prow Robot
0f2300575c
Merge pull request #108032 from deejross/kep3140-cronjob-timezone 
KEP 3140: TimeZone support for CronJob
 2022-03-29 17:34:20 -07:00
Ross Peoples
dbb3906a09 Fix for timeZone validation and strategy 2022-03-29 11:40:34 -05:00
Aldo Culquicondor
8c00f510ef Graduate JobReadyPods to beta 
Set podUpdateBatchPeriod to 1s

Change-Id: I8a10fd8f8559adad9df179b664b8c82851607855
 2022-03-29 10:07:41 -04:00
Ross Peoples
f3b928a23d Import tzdata in apiserver, CronJob.timeZone fixes 2022-03-28 16:33:05 -05:00
Ross Peoples
98837de446 TimeZone support for CronJobs 2022-03-28 16:33:00 -05:00
Mayank Kumar
2733b66e80 add maxUnavailable implementation and UT 2022-03-28 11:01:05 -07:00
Hemant Kumar
a99466ca86 check existing size before querying new size from api-server 2022-03-28 11:32:49 -04:00
Hemant Kumar
ed217f4140 rename SetVolumeSize to InitializeVolumeSize 2022-03-28 11:32:49 -04:00
Hemant Kumar
7a43406138 Do not update PVC if it already has updated size 2022-03-28 11:32:49 -04:00
Hemant Kumar
e4f62d6c41 Modify code to use new interface functions 2022-03-28 11:32:49 -04:00
Kubernetes Prow Robot
25957117c2
Merge pull request #108443 from Monokaix/remove-redundant-SetNamespace-for-pvc 
Test: remove redundant SetNamespace() for pvc
 2022-03-26 11:45:40 -07:00
Kubernetes Prow Robot
c3e3f6cd4d
Merge pull request #107241 from houjun41544/20211228-ds 
pointer usage error
 2022-03-26 11:45:33 -07:00
Kubernetes Prow Robot
13ebb2e757
Merge pull request #99488 from chymy/rc-test-bug 
Fix pkg/controller/replicaset/replica_set_test.go variable reference error
 2022-03-26 11:45:21 -07:00
Kubernetes Prow Robot
83988399e8
Merge pull request #106109 from h4ghhh/sts_klog_InfoS 
Migrate statefulset files to structured logging
 2022-03-26 10:37:20 -07:00
Ashutosh Kumar
c00975370a
Handle Non-graceful Node Shutdown (#108486) 
Signed-off-by: Ashutosh Kumar <sonasingh46@gmail.com>

Co-authored-by: Ashutosh Kumar <sonasingh46@gmail.com>

Co-authored-by: xing-yang <xingyang105@gmail.com>
 2022-03-26 09:23:21 -07:00
Kubernetes Prow Robot
78889cd1bb
Merge pull request #109035 from deepakkinni/enable_def_v1 
Default enable flag for beta feature HonorPVReclaimPolicy
 2022-03-26 08:03:21 -07:00
Kubernetes Prow Robot
0b79a791ed
Merge pull request #107180 from ardaguclu/remove-deprecated-serverresource 
Remove deprecated discovery/ServerResources function
 2022-03-25 23:45:21 -07:00
Deepak Kinni
836ace46a0 Default enable flag for beta feature HonorPVReclaimPolicy 
Signed-off-by: Deepak Kinni <dkinni@vmware.com>
 2022-03-26 06:48:28 +05:30
Aldo Culquicondor
8776931abb Remove finalizer when orphaned 
Change-Id: Id88a28755660812a274dffab2693cb8a0ef4235c
 2022-03-24 11:57:51 -04:00
Aldo Culquicondor
211e33d93f Fix: Clean job tracking finalizer from orphan pods 
Change-Id: I04cd70725fd1830be8daf2dca53f67bc10a379b7
 2022-03-24 11:57:51 -04:00
Kubernetes Prow Robot
4e8b2ff023
Merge pull request #106844 from atiratree/gc_metrics 
add gc metrics and collect sync errors
 2022-03-24 04:40:42 -07:00
Kubernetes Prow Robot
f97825e1ce
Merge pull request #107395 from alculquicondor/indexed-job 
Graduate IndexedJob to stable
 2022-03-23 17:44:41 -07:00
Kubernetes Prow Robot
2d46f1bc30
Merge pull request #103062 from ikeeip/component_helper_storage 
Move volume helpers to "k8s.io/component-helpers/storage/volume".
 2022-03-23 13:21:20 -07:00
Kubernetes Prow Robot
14e8db067e
Merge pull request #108191 from ravisantoshgudimetla/wire-cert-contexts 
Wire cert contexts
 2022-03-23 11:20:17 -07:00
Ryan Richard
e29ac0f8be Promote CertificateSigningRequest's Spec.ExpirationSeconds field to GA 
Remove the comment "As of v1.22, this field is beta and is controlled
via the CSRDuration feature gate" from the expirationSeconds field's
godoc.

Mark the "CSRDuration" feature gate as GA in 1.24, lock its value to
"true", and remove the various logic which handled when the gate was
"false".

Update conformance test to check that the CertificateSigningRequest's
Spec.ExpirationSeconds field is stored, but do not check if the field
is honored since this functionality is optional.
 2022-03-18 14:41:43 -07:00
Kubernetes Prow Robot
f979b4094e
Merge pull request #99292 from yangjunmyfm192085/run-test23 
replace all occurrences of "node", nodeName to "node", klog.KRef("", nodeName)
 2022-03-17 12:22:42 -07:00
Konstantin Misyutin
438d224f0e Cleanup k8s.io/component-helpers/storage/volume package 
Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com>
 2022-03-16 15:43:09 +08:00
Konstantin Misyutin
4ba98a8610 cleanup: remove unnecessary import aliases 2022-03-16 15:43:09 +08:00
Konstantin Misyutin
1d7cefe9c4 Move volume helpers to "k8s.io/component-helpers/storage/volume". 
This patch aims to simplify decoupling "pkg/scheduler/framework/plugins"
from internal "k8s.io/kubernetes" packages. More described in
issue #89930 and PR #102953.

Some helpers from "k8s.io/kubernetes/pkg/controller/volume/persistentvolume"
package moved to "k8s.io/component-helpers/storage/volume" package:

- IsDelayBindingMode
- GetBindVolumeToClaim
- IsVolumeBoundToClaim
- FindMatchingVolume
- CheckVolumeModeMismatches
- CheckAccessModes
- GetVolumeNodeAffinity

Also "CheckNodeAffinity" from "k8s.io/kubernetes/pkg/volume/util"
package moved to "k8s.io/component-helpers/storage/volume" package
to prevent diamond dependency conflict.

Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com>
 2022-03-16 15:43:09 +08:00
Aldo Culquicondor
2c5d0a273c Graduate IndexedJob to stable 
- Lock feature gate to true and schedule for deletion in 1.26
- Remove checks on feature gate
- Graduate E2E test to Conformance

Change-Id: I6814819d318edaed5c86dae4055f4b050a4d39fd
 2022-03-15 13:41:06 -04:00
Kubernetes Prow Robot
02b1ec5b0b
Merge pull request #108485 from BigDarkClown/master 
Make daemon.NodeShouldRunDaemonPod function public
 2022-03-15 00:30:21 -07:00
Deepak Kinni
d37f14d0ae Support for in-tree PV Deletion protection finalizer 
Signed-off-by: Deepak Kinni <dkinni@vmware.com>
 2022-03-10 21:37:43 -08:00
Bartłomiej Wróblewski
b2e2fb8d89 Make daemon.NodeShouldRunDaemonPod function public 2022-03-08 11:32:17 +00:00
Kubernetes Prow Robot
34a6a7ca11
Merge pull request #108316 from hyschumi/fix_unnecessary_handlecrash 
endpointslice: remove unnecessary HandleCrash
 2022-03-07 18:20:34 -08:00
Ravi Gudimetla
72a62f47f7 Wire context for cert controllers 
All the controllers should use context for signalling termination of communication with API server. Once kcm cancels context all the cert controllers which are started via kcm should cancel the APIServer request in flight instead of hanging around.
 2022-03-07 10:19:45 -05:00
Kubernetes Prow Robot
da23196df6
Merge pull request #108450 from tnqn/stop-setting-rv-in-endpoints 
Stop publishing Pod ResourceVersion in Endpoints and EndpointSlice API
 2022-03-04 17:23:04 -08:00
Kubernetes Prow Robot
88f9728339
Merge pull request #108309 from zshihang/token 
no auto-generation of secret-based service account token
 2022-03-02 06:19:15 -08:00
Quan Tian
906e6d4670 Stop publishing Pod ResourceVersion in Endpoints and EndpointSlice API 
The field is not used anywhere and its value may be stale as Endpoints
and EndpointSlice won't be updated if there is only Pod ResourceVersion
change..
 2022-03-02 22:12:35 +08:00
Kubernetes Prow Robot
0dc83fe696
Merge pull request #108078 from tnqn/endpoints-resync 
Skip updating Endpoints if no relevant fields change
 2022-03-01 23:23:13 -08:00
XuzhengChang
d1ea5d07a9 Test: remove redundant SetNamespace() for pvc 2022-03-02 14:10:46 +08:00
Kubernetes Prow Robot
66daef4aa7
Merge pull request #108167 from jfremy/fix-107973 
Fix nodes volumesAttached status not being updated
 2022-03-01 12:49:54 -08:00
wangyamei
3808e193d9 fix typo for nodelifecycle controller 2022-02-28 14:30:28 +08:00