github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
77,144 Commits 1 Branch 31 Tags
c056a46ba9d45fb5aa98a285b2af2bee852f475f
Commit Graph

2595 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
f2659bcad8 Merge pull request #76572 from mkumatag/fix_flakey 
loop through next entry in stubDomainData if proxyIP == 0
 2019-04-15 05:14:05 -07:00
Kubernetes Prow Robot
c09cfb7178 Merge pull request #76566 from tedyu/adm-rollback-err 
Return aggregate error from rollbackOldManifests
 2019-04-15 03:54:23 -07:00
Kubernetes Prow Robot
18533fe84f Merge pull request #76545 from xichengliudui/update-DNSType-comments 
Update DNSType comments on compute.go
 2019-04-15 00:20:01 -07:00
Manjunath A Kumatagi
23153e3f04 loop through next entry in stubDomainData if proxyIP == 0 2019-04-14 20:14:01 -05:00
Kubernetes Prow Robot
299aa5d7a6 Merge pull request #76505 from rosti/fix-join-cri-detection 
kubeadm: Don't error out on join with --cri-socket override
 2019-04-14 14:30:00 -07:00
Ted Yu
3e0423926a Return aggregate error from rollbackOldManifests 2019-04-14 10:06:07 -07:00
SataQiu
8b7b2349c7 capitalize the first letter of the prompt for consistency 2019-04-14 19:10:51 +08:00
Kubernetes Prow Robot
0a59758c58 Merge pull request #76549 from xichengliudui/ends-with-newline 
Use fmt.printf() to end with a newline
 2019-04-13 15:26:00 -07:00
Rostislav M. Georgiev
2d4307db9f kubeadm: Don't error out on join with --cri-socket override 
In the case where newControlPlane is true we don't go through
getNodeRegistration() and initcfg.NodeRegistration.CRISocket is empty.
This forces DetectCRISocket() to be called later on, and if there is more than
one CRI installed on the system, it will error out, while asking for the user
to provide an override for the CRI socket. Even if the user provides an
override, the call to DetectCRISocket() can happen too early and thus ignore it
(while still erroring out).
However, if newControlPlane == true, initcfg.NodeRegistration is not used at
all and it's overwritten later on.
Thus it's necessary to supply some default value, that will avoid the call to
DetectCRISocket() and as initcfg.NodeRegistration is discarded, setting
whatever value here is harmless.

Signed-off-by: Rostislav M. Georgiev <rostislavg@vmware.com>
 2019-04-12 17:25:11 +03:00
Xin Wang
9870e0e7b5 Fix typo cgroupDriver -> cgroup-driver 
Signed-off-by: Xin Wang <wileywang@yunify.com>
 2019-04-12 06:38:53 +08:00
aaa
85901dd0e0 Update DNSType comments on compute.go 
update pull request

update pull request

update pull request

update pull request
 2019-04-10 11:43:18 -04:00
Dmitry Rozhkov
2d77d9a5a9 kubeadm: use correct expected key when checking test results 
Resulting key needs to be compared with the expected key which
was set for the test case, not just a key.
 2019-04-10 15:09:12 +03:00
aaa
980de9d38b Use fmt.printf() to end with a newline 
update pull request
 2019-04-10 03:27:25 -04:00
Manuel Rüger
912794b302 kubeadm: Quote values on envFile 
See documentation: https://github.com/kubernetes/website/blob/master/content/en/docs/setup/independent/kubelet-integration.md#workflow-when-using-kubeadm-init

Signed-off-by: Manuel Rüger <manuel@rueg.eu>
 2019-04-08 09:23:35 +02:00
Kubernetes Prow Robot
84b561033e Merge pull request #76175 from stealthybox/refactor-mediatype-loops 
Refactor loops over `SupportedMediaTypes()` where mediaType is used to match a single SerializerInfo{}
 2019-04-04 23:54:07 -07:00
Kubernetes Prow Robot
a4a4b4c1db Merge pull request #76119 from SataQiu/improve-kubeadm-20190404 
Code refactor: replace repeated values with a constant
 2019-04-04 22:31:43 -07:00
Kubernetes Prow Robot
990ee3c09c Merge pull request #76116 from xichengliudui/patch-5 
Fix comments and function names are different
 2019-04-04 21:08:07 -07:00
leigh capili
47e52d2981 Refactor loops over SupportedMediaTypes() where mediaType is used to match a single SerializerInfo{} 
We have an existing helper function for this:  runtime.SerializerInfoForMediaType()

This is common prep-work for encoding runtime.Objects into JSON/YAML for transmission over the wire or writing to ComponentConfigs.
 2019-04-04 19:01:01 -06:00
qingsenLi
ccac84c12b delete some unused consts in kubeadm/app/constants/constants.go 2019-04-04 19:54:51 +08:00
SataQiu
4a200a2222 replace repeated values with a constant 2019-04-04 12:42:26 +08:00
lIuDuI
6f89267125 Fix comments and function names are different 2019-04-04 10:57:20 +08:00
Kubernetes Prow Robot
2c675818ed Merge pull request #75866 from jmkeyes/kubeadm-config-image-repository-flag 
Provide imageRepository override for 'kubeadm config images' commands.
 2019-04-03 11:14:37 -07:00
Kubernetes Prow Robot
7cdd26e127 Merge pull request #76071 from qingsenLi/k8s190403 
fix some spelling error
 2019-04-03 05:31:53 -07:00
qingsenLi
1350446417 fix some spelling error 2019-04-04 00:07:19 +08:00
Kubernetes Prow Robot
628925672c Merge pull request #76029 from SataQiu/improve-kubeadm-20190403 
Code improve: use constants instead of hard coding
 2019-04-03 05:31:41 -07:00
Kubernetes Prow Robot
0ec8ce0077 Merge pull request #76038 from MengZn/patch-1 
patch-reset
 2019-04-03 03:24:06 -07:00
Kubernetes Prow Robot
0f3867a830 Merge pull request #75948 from xichengliudui/addconstants 
Replace variables 10251 and 10252 with constants
 2019-04-03 03:23:55 -07:00
MengZeLee
52d8f5e19b patch-reset 
When we reset cluster, the program does not automatically delete it ($HOME/.kube/config).
We should prompt the user how to checkt
 2019-04-03 14:18:49 +08:00
SataQiu
9e051bb327 code improve: use constants instead of hard coding 2019-04-03 05:58:01 +08:00
PingWang
38fe68658d Extract Method for kubeadm 
Signed-off-by: PingWang <wang.ping5@zte.com.cn>
 2019-04-02 18:45:30 +08:00
Kubernetes Prow Robot
c3cc31797a Merge pull request #75969 from rajansandeep/translationcheck 
Fix translation from kube-dns to CoreDNS Config to skip invalid values
 2019-04-01 22:44:35 -07:00
Kubernetes Prow Robot
dd96b15e5d Merge pull request #75931 from xichengliudui/Simplify-two-if 
Simplify two if (remove redundant code)
 2019-04-01 15:49:21 -07:00
Sandeep Rajan
deadefd385 Fix translation to skip invalid values 2019-04-01 15:15:39 -04:00
Kubernetes Prow Robot
255a73ffc6 Merge pull request #75939 from xichengliudui/conversion-constants 
Define common sentences as constants
 2019-04-01 10:03:25 -07:00
Kubernetes Prow Robot
13cde9e181 Merge pull request #75950 from qingsenLi/k8s190401-fix-Certifcate 
spelling error 'Certifcate'
 2019-04-01 06:38:58 -07:00
qingsenLi
703a397ee3 spelling error 'Certifcate' 2019-04-02 01:14:56 +08:00
SataQiu
694a5f1cdf use constant instead of hard coding 2019-04-01 13:29:47 +08:00
Kubernetes Prow Robot
8f304510c5 Merge pull request #75900 from neolit123/fix-upgrade-plan 
kubeadm: fix "upgrade plan" not defaulting to a "stable" version
 2019-03-30 12:47:08 -07:00
Kubernetes Prow Robot
214340256f Merge pull request #75874 from SataQiu/refactor-kubeadm-20190329 
Refactor code about setting KubernetesVersionFlag
 2019-03-29 23:53:33 -07:00
Kubernetes Prow Robot
c7a8596a39 Merge pull request #75867 from SataQiu/fix-kubeadm-golint-20190329 
Fix golint failures in cmd/kubeadm/app/util/system
 2019-03-29 17:33:57 -07:00
Lubomir I. Ivanov
d6328f1dbe kubeadm: fix "upgrade plan" not working without k8s version 
If the k8s version argument passed to "upgrade plan" is missing
the logic should perform the following actions:
- fetch a "stable" version from the internet.
- if that fails, fallback to the local client version.

Currentely the logic fails because the cfg.KubernetesVersion is
defaulted to the version of the existing cluster, which
then causes an early exit without any ugprade suggestions.

See app/cmd/upgrade/common.go::enforceRequirements():
  configutil.FetchInitConfigurationFromCluster(..)

Fix that by passing the explicit user value that can also be "".
This will then make the "offline getter" treat it as an explicit
desired upgrade target.

In the future it might be best to invert this logic:
- if no user k8s version argument is passed - default to the kubeadm
version.
- if labels are passed (e.g. "stable"), fetch a version from the
internet.
 2019-03-29 21:34:58 +02:00
Kubernetes Prow Robot
e6d274233c Merge pull request #75646 from bart0sh/PR0066-kubeadm-token-delete-multiple 
kubeadm: implement deletion of multiple tokens
 2019-03-29 11:48:24 -07:00
SataQiu
4f6003b61f refactor code about setting KubernetesVersionFlag 2019-03-29 15:51:16 +08:00
SataQiu
a41c85ea07 fix golint failures in cmd/kubeadm/app/util/system 2019-03-29 12:03:25 +08:00
Joshua M. Keyes
03725f78b4 Provide imageRepository override for 'kubeadm config images' commands. 2019-03-28 20:53:39 -07:00
Kubernetes Prow Robot
91f40aec8a Merge pull request #75847 from fabriziopandini/fix-external-etcd 
kubeadm: fix join control-plane with external-etcd
 2019-03-28 16:54:16 -07:00
fabriziopandini
f09d6388b2 fix-external-etcd 2019-03-28 23:25:18 +01:00
Kubernetes Prow Robot
c5114ee6c3 Merge pull request #75762 from SataQiu/fix-kubeadm-gates-20190327 
Fix none feature gates list
 2019-03-28 10:30:43 -07:00
SataQiu
c9cd3db627 fix none feature gates list 2019-03-28 20:11:47 +08:00
Kubernetes Prow Robot
6a277e0c4d Merge pull request #75784 from bart0sh/PR0069-kubeadm-use-t.Run-in-app-phases 
kubeadm: use t.Run in app/phases
 2019-03-28 02:34:43 -07:00