Commit Graph

3410 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
42436c877e Merge pull request #107462 from dims/next-step-in-csi-migration-for-openstack-take-2
Next step in CSI migration for openstack
2022-01-12 19:57:07 -08:00
Kubernetes Prow Robot
e22ec17057 Merge pull request #99441 from CKchen0726/csi-client
migrate volume/csi/csi-client.go logs to structured logging
2022-01-12 11:52:13 -08:00
Patrick Ohly
9eaa2dc554 avoid klog Info calls without verbosity
In the following code pattern, the log message will get logged with v=0 in JSON
output although conceptually it has a higher verbosity:

   if klog.V(5).Enabled() {
       klog.Info("hello world")
   }

Having the actual verbosity in the JSON output is relevant, for example for
filtering out only the important info messages. The solution is to use
klog.V(5).Info or something similar.

Whether the outer if is necessary at all depends on how complex the parameters
are. The return value of klog.V can be captured in a variable and be used
multiple times to avoid the overhead for that function call and to avoid
repeating the verbosity level.
2022-01-12 07:48:36 +01:00
Davanum Srinivas
7fd97433f0 Next step in CSI migration for openstack
delete/modify tests that use intree cinder as well.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2022-01-10 22:07:44 -05:00
Kubernetes Prow Robot
475644ccd8 Merge pull request #106073 from ping035627/k8s-21110202
Cleanup FindPluginByName() in VolumePluginMgr
2022-01-07 07:52:29 -08:00
Kubernetes Prow Robot
d1a5513cb0 Merge pull request #107006 from gnufied/add-total-mount-time-metrics
Add metric for reporting total end-to-end mount time
2022-01-07 06:19:31 -08:00
Hemant Kumar
c9177f3083 rename volume_mount to overall_volume_mount for total metric time 2022-01-06 12:51:05 -05:00
Kubernetes Prow Robot
31898fc504 Merge pull request #101856 from prateekpandey14/fix-staticcheck
fix static check of importing the same package multiple times
2022-01-05 14:55:47 -08:00
Kubernetes Prow Robot
4f35d80f4e Merge pull request #107302 from pacoxu/fix/empty-dir-quota-monitoring
assignQuota checks if the underlying medium supports quotas and if so setting it
2022-01-05 09:23:18 -08:00
Kubernetes Prow Robot
0f5e3d14bd Merge pull request #106421 from houjun41544/20211115-volume
Fix the wrong log
2022-01-04 23:03:05 -08:00
PingWang
075adb308d Cleanup FindPluginByName() in VolumePluginMgr
Signed-off-by: PingWang <wang.ping5@zte.com.cn>

update typo

Signed-off-by: PingWang <wang.ping5@zte.com.cn>

update import

Signed-off-by: PingWang <wang.ping5@zte.com.cn>
2022-01-05 11:42:26 +08:00
Paco Xu
3946e6c8c2 assignQuota checks if the underlying medium supports quotas and if so, sets 2022-01-05 09:33:07 +08:00
Kubernetes Prow Robot
f0dbc32ed9 Merge pull request #106853 from gnufied/disable-exp-backoff-volume-not-inuse
When volume is not marked in-use, do not backoff
2021-12-22 19:46:37 -08:00
Hemant Kumar
7989f27044 use node informer to check volumes attachment status before backoff
fix unit tests
2021-12-20 11:57:05 -05:00
Kubernetes Prow Robot
489fb9bee3 Merge pull request #107025 from jsafrane/remove-attach-match
Remove AttachID matching from Detach
2021-12-17 18:41:24 -08:00
Kubernetes Prow Robot
1426587e08 Merge pull request #106436 from dims/cleanup-owners-files-no-activity-in-a-year
Cleanup OWNERS files (No Activity in the last year)
2021-12-15 12:07:51 -08:00
Kubernetes Prow Robot
66931c9b8f Merge pull request #106703 from scottnice/patch-1
Fixed skipping valid volume plugins when another plugin has an error
2021-12-15 09:53:50 -08:00
Davanum Srinivas
497e9c1971 Cleanup OWNERS files (No Activity in the last year)
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-15 10:34:02 -05:00
Scott Nice
d9cbe5d314 Added unit test for flex volume probe and updated DynamicPluginProber Probe() interface description 2021-12-14 10:48:51 -05:00
Jan Safranek
516633d67f Remove AttachID matching from Detach
Detach() always gets CSI volume unique ID and never attachment ID. Related
code has been removed from Kubernetes in
129f15328b.
2021-12-14 15:37:17 +01:00
prateekpandey14
f9cf14f3f6 fix static check of importing the same package multiple times
Signed-off-by: prateekpandey14 <prateekpandey14@gmail.com>
2021-12-14 11:06:44 +05:30
Hemant Kumar
55b5e6dc33 Add metric for reporting total end-to-end mount time
This metric includes time spent in waiting for devices to be attached,
any RPC calls and performing recursive chown etc.
2021-12-13 16:23:01 -05:00
Davanum Srinivas
9405e9b55e Check in OWNERS modified by update-yamlfmt.sh
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-09 21:31:26 -05:00
Scott Nice
5183513661 Fix gofmt verify 2021-12-09 09:18:22 -05:00
Kubernetes Prow Robot
8174b0923c Merge pull request #105127 from astraw99/fix-dup-kubeClient
Fix duplicate CSI kube client
2021-12-07 17:25:30 -08:00
Hemant Kumar
5b7b2e2f6c When volume is not marked in-use, do not backoff 2021-12-07 11:50:15 -05:00
Scott Nice
1070eb7428 Fixed issue in plugin.go for bug #106696
Fixed issue in plugin.go where valid plugin events would be skipped if any plugin had an error. This meant that valid plugins would never be installed if another was in an error state as the events fired only once.
2021-11-27 15:07:19 -05:00
Hanna Lee
07a883d8e6 Remove //lint:ignore pragmas that aren't being used anymore 2021-11-17 08:56:54 +01:00
Hanna Lee
c8fde197f5 Add more //nolint:staticcheck for failures caught in PR tests 2021-11-17 08:56:02 +01:00
Kubernetes Prow Robot
8d9e424f73 Merge pull request #103447 from trierra/csi-translation-portworx
Csi translation portworx
2021-11-16 17:43:53 -08:00
houjun
7458399f77 Fix the wrong log 2021-11-17 09:07:07 +08:00
Oksana Naumov
3af11fc12d Add support for Portworx to csi-translation lib
Signed-off-by: Oksana Naumov <trierra.dev@gmail.com>
2021-11-16 13:26:09 -08:00
Kubernetes Prow Robot
f151a40d8d Merge pull request #106154 from gnufied/recover-expansion-failure-123
Recover expansion failure
2021-11-16 13:21:34 -08:00
Hemant Kumar
1ddd598d31 Implement controller and kubelet changes for recovery from resize
failures
2021-11-16 11:06:46 -05:00
Kubernetes Prow Robot
66c342ba63 Merge pull request #95361 from humblec/rbd-migration
RBD in-tree plugin migration to CSI driver using migration translation lib
2021-11-15 19:53:25 -08:00
Humble Chirammal
7c40eb9ae0 Add support for rbd plugin to csi-translation-lib
In support of csi-migration proposal here:
https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md

Will help with migration of in-tree RBD plugin ( kubernetes.io/rbd)
to RBD CSI driver ( rbd.csi.ceph.com ).

Fixes https://github.com/kubernetes/enhancements/issues/2923

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
2021-11-15 23:46:29 +05:30
Neha Lohia
fa1b6765d5 move pkg/util/node to component-helpers/node/util (#105347)
Signed-off-by: Neha Lohia <nehapithadiya444@gmail.com>
2021-11-12 07:52:27 -08:00
Kubernetes Prow Robot
7b9f4f18fe Merge pull request #105135 from astraw99/fix-nil-mergeMap
Fix nil check in map merge
2021-11-12 02:26:27 -08:00
Kubernetes Prow Robot
ba944971f6 Merge pull request #105512 from gnufied/add-subpath-mount-source-check
Fix check for subpath source
2021-11-11 04:43:51 -08:00
astraw99
9fe2c30609 fix nil merge map 2021-11-11 10:56:55 +08:00
Kubernetes Prow Robot
dcf0a031e9 Merge pull request #105885 from gnufied/move-configurable-fsgroup-ga
Move configurable fsgroup to GA
2021-11-10 13:53:27 -08:00
Hemant Kumar
27d1e9a4e2 Remove all references to ConfigurableFSGroupPolicy feature gate 2021-11-10 14:24:08 -05:00
Hemant Kumar
467bcd8b89 Add tests for checking bind mounts 2021-11-10 11:52:55 -05:00
Hemant Kumar
7a73168a59 Check subpath file 2021-11-09 16:05:04 -05:00
Hemant Kumar
06e040de40 Add check for subpaths 2021-11-09 16:05:03 -05:00
Kubernetes Prow Robot
6d9008b1b0 Merge pull request #105934 from jsafrane/dont-ignore-selinux
Don't guess SELinux support on error
2021-11-05 12:44:51 -07:00
Jonathan Dobson
082cb15648 Move CSIVolumeFSGroupPolicy feature to GA 2021-11-02 15:22:33 -06:00
Jan Safranek
bc0c1bf1c5 Fixed unit test SELinux support
Previously, an error from GetSELinuxSupport was treated as a filesystem did
not support SELinux. Now the error is treated separately.
2021-11-01 15:11:40 +01:00
Jan Safranek
7b07b1ef0e Add shortcut for SELinux detection
Skip parsing of /proc/mounts if SELinux is disabled on the machine.
2021-11-01 14:32:48 +01:00
Jan Safranek
186810eb47 Don't guess SELinux support on error
When GetSELinuxSupport() fails, don't assume a mounted filesystem does not
support SELinux at all. Try again instead in the next SetUp retry.

This may hurt performance a bit, since kubelet will call NodePublishVolume
again, but it's better than providing wrong information to the container
runtime that will then skip relabeling of the volume.
2021-10-27 12:00:07 +02:00