Commit Graph

3525 Commits

Author SHA1 Message Date
Kubernetes Submit Queue
9e2f868be0 Merge pull request #34360 from bprashanth/np_fix
Automatic merge from submit-queue

Remove onlyLocal NodePort e2e till pr #33957

We were basically testing this bug: https://github.com/kubernetes/kubernetes/issues/30809
We fixed the bug: https://github.com/kubernetes/kubernetes/pull/33587, but forgot to remove the "test". 
This pr adds a test for the new feature: https://github.com/kubernetes/kubernetes/pull/33957 (ensure that nodePort with onlyLocal works only on nodes with endpoints and fails otherwise)

fixes https://github.com/kubernetes/kubernetes/issues/34124
2016-10-10 14:49:01 -07:00
gmarek
8d3973c2f4 Small refactoring of scheduler predicates 2016-10-10 13:13:15 +02:00
Kubernetes Submit Queue
ef1ba5f2be Merge pull request #33160 from m1093782566/m109-petset-internal-int32
Automatic merge from submit-queue

[Pet Set] petset internal replicas type should be int32

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->

**What this PR does / why we need it**:

Fixes #32993 

Sometimes an int is 4 bytes and sometimes it's 8(depend on CPU architecture), but an int32 is always 32bits. So set petset internal replicas type to int32, avoid type casting in API version converting.
2016-10-09 16:08:11 -07:00
Kubernetes Submit Queue
853ee4c9f7 Merge pull request #34399 from brendandburns/e2efix
Automatic merge from submit-queue

Fix a formatting string.

Related to #33793
2016-10-08 19:04:06 -07:00
Kubernetes Submit Queue
c8668df048 Merge pull request #34357 from bowei/flake-fix-27023
Automatic merge from submit-queue

Add retry loop around check for /etc/hosts contents to work around issue #34256

See https://github.com/kubernetes/kubernetes/issues/34256

fixes #27023
2016-10-08 15:11:20 -07:00
Brendan Burns
8ddde326a0 Fix a formatting string. 2016-10-08 14:14:55 -07:00
m1093782566
fd47b6d4d1 change petset replicas type from int to int32
Change-Id: I0b8c30083e4a221421de46d9d4dcb21b1f5bb36f
2016-10-08 17:13:20 +08:00
Kubernetes Submit Queue
28a53453cf Merge pull request #34346 from aveshagarwal/master-kube-fix-messages
Automatic merge from submit-queue

Fix confusing log messages

While debugging https://github.com/kubernetes/kubernetes/issues/33876 , I noticed following confusing message:

``` 
The status of Pod kibana-logging-v1-j99la is Running, waiting for it to be either Running or Failed
```
2016-10-08 00:39:17 -07:00
Kubernetes Submit Queue
16da3824ec Merge pull request #34295 from macb/e2e/annotate_errors
Automatic merge from submit-queue

annotate some addtional errors in e2e tests

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->

**What this PR does / why we need it**:
Adds some additional context to e2e test failures.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: some work toward #34059

**Special notes for your reviewer**: I didn't want to go through all of the offending cases so I picked off a few files and addressed those.

**Release note**:
<!--  Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access) 
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. 
-->
```release-note
NONE
```
2016-10-08 00:39:07 -07:00
Kubernetes Submit Queue
f2016df2cc Merge pull request #34054 from deads2k/testapi-01-remove-default.groupversion
Automatic merge from submit-queue

remove testapi.Default.GroupVersion

I'm going to try to take this as a series of mechanicals.  This removes `testapi.Default.GroupVersion()` and replaces it with `registered.GroupOrDie(api.GroupName).GroupVersion`.

@caesarxuchao I'm trying to see how much of `pkg/api/testapi` I can remove.
2016-10-07 20:30:34 -07:00
Kubernetes Submit Queue
0c7b9b8f18 Merge pull request #33595 from freehan/fix-reboot-ifdownup
Automatic merge from submit-queue

try to use ifdown/ifup if available

Tried this on both ContainerVM and GCI image. 

`ip link set eth0 down` is too destructive for containerVM. It could not recover with correct network setup hence failing the test. Need to use ifdown/ifup on containerVM. 

reference:
http://serverfault.com/questions/603906/ip-link-set-not-assigning-ip-address-but-ifup-does
2016-10-07 15:22:05 -07:00
bprashanth
3d0fb31f26 Remove onlyLocal NodePort e2e till pr #33957 2016-10-07 14:47:55 -07:00
Bowei Du
c3f591a339 Add retry loop around check for /etc/hosts contents to work around issue #34256
See https://github.com/kubernetes/kubernetes/issues/34256
2016-10-07 13:13:16 -07:00
Avesh Agarwal
9fa12e3c99 Fix confusing log messages:
The status of Pod kibana-logging-v1-j99la is Running, waiting for it to be either Running or Failed
2016-10-07 13:54:36 -04:00
Kubernetes Submit Queue
2db9b3cddc Merge pull request #34323 from kargakis/bump-status-check-timeout
Automatic merge from submit-queue

test: bump deployment test timeout

Matches the timeout used in [WaitForDeploymentStatus](6d56d0337a/test/e2e/framework/util.go (L3610))

Fixes https://github.com/kubernetes/kubernetes/issues/31810
2016-10-07 07:34:20 -07:00
deads2k
518d5500c7 remove testapi.Default.GroupVersion 2016-10-07 10:10:54 -04:00
Kubernetes Submit Queue
59f929b636 Merge pull request #33451 from ivan4th/cleanup-scheduler-predicates-e2e-tests
Automatic merge from submit-queue

Clean up SchedulerPredicates e2e tests
2016-10-07 06:29:19 -07:00
Kubernetes Submit Queue
5d3321ef83 Merge pull request #31346 from wojtek-t/dont_set_timeout_in_tests
Automatic merge from submit-queue

Don't set timeouts in clients in tests

We are not setting timeouts in production - we shouldn't do it in tests then...

Addresses point 2. of #31345
2016-10-07 05:51:45 -07:00
Michail Kargakis
b90661af9b test: bump deployment test timeout
Matches the timeout used in WaitForDeploymentStatus
2016-10-07 14:18:29 +02:00
Kubernetes Submit Queue
3be8e3e44b Merge pull request #33981 from freehan/e2e-deletens-on-failure
Automatic merge from submit-queue

add delete-namespace-on-failure flag

I have been doing this for a while. 

Setting `--delete-namespace=false --clean-start=true` only works if you have only one e2e test running in a loop. 

This PR lets someone to set `delete-namespace-on-failure=false` and run multiple tests in parallel and preserve the crime scene. It makes it easier to reproduce failures. 

Let me know if this is worth it or there are some other tricks I am not aware.
2016-10-07 04:34:27 -07:00
Kubernetes Submit Queue
f352e6718e Merge pull request #33978 from rata/simplify-e2e-secret
Automatic merge from submit-queue

Remove duplicated code in secret e2e tests

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->

**What this PR does / why we need it**: This come up when writing another PR: https://github.com/kubernetes/kubernetes/pull/28936 as a comment from @thockin. 

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: 

**Special notes for your reviewer**:

**Release note**:
<!--  Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access) 
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. 
-->
```NONE
```

This patch just removes duplicated code in secret e2e tests.
2016-10-07 03:56:04 -07:00
Ivan Shvedunov
09b2d57da9 Clean up SchedulerPredicates e2e tests
Reduce repetition & don't use hardcoded pause image tags.
2016-10-07 13:17:47 +03:00
Kubernetes Submit Queue
813173466a Merge pull request #34135 from nikhiljindal/delFedNsTest
Automatic merge from submit-queue

Delete federation namespace after the test completes

The code was commented because of a bug in namespace deletion which is now fixed.
Note that this deletes the namespace in federation control plane. We still need to delete the namespace from each cluster (cascading deletion)

cc @kubernetes/sig-cluster-federation
2016-10-07 00:07:57 -07:00
Mac Browning
b9ca7384ec annotate errors in e2e tests 2016-10-06 23:11:29 -04:00
nikhiljindal
d96ad8d570 Delete federation namespace after the test completes 2016-10-06 17:38:34 -07:00
Rodrigo Campos
0ff2f089ff Remove duplicated code in secret e2e tests
This patch just removes duplicated code in secret e2e tests.
2016-10-06 10:04:51 -03:00
Kubernetes Submit Queue
392f6f4757 Merge pull request #33983 from janetkuo/check-petset-status
Automatic merge from submit-queue

Add status check in PetSet e2e tests

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->

**What this PR does / why we need it**:

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**: cc @erictune @foxish @kubernetes/sig-apps

**Release note**:
<!--  Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access) 
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. 
-->
```release-note
NONE
```
2016-10-06 02:51:26 -07:00
Kubernetes Submit Queue
a98850bf30 Merge pull request #34055 from freehan/revert-add-network-node-e2e
Automatic merge from submit-queue

Revert "Revert "move pod networking tests common""

Reverts #34011

And fix the problem causing `Granular Checks: Services [Slow] should update nodePort` tests to fail
2016-10-05 23:25:09 -07:00
Kubernetes Submit Queue
debac32d51 Merge pull request #33972 from bowei/flake-issue-27023
Automatic merge from submit-queue

Add a retry loop to KubeletManagerEtcHosts flake

Add a retry loop to KubeletManagerEtcHosts flake
    
    Note: this still makes the test fail if a retry occurs, but
    will give us more information regarding whether or not the
    test flake could be occuring due to delay in mounting of
    /etc/hosts.
2016-10-05 12:27:28 -07:00
Minhan Xia
1a9bafd679 fix bug in DialFromNode where it fail the test when encountered a command execution failure 2016-10-05 11:00:57 -07:00
Minhan Xia
df92825c33 Revert "Revert "move pod networking tests common"" 2016-10-05 10:53:22 -07:00
Bowei Du
d61d3e48ee Add a retry loop to KubeletManagerEtcHosts flake
Note: this still makes the test fail if a retry occurs, but
will give us more information regarding whether or not the
test flake could be occuring due to delay in mounting of
/etc/hosts.
2016-10-05 10:24:21 -07:00
MrHohn
c61911eedd Fix #31085, include output checking in retry loop 2016-10-05 09:13:19 -07:00
Wojciech Tyczynski
ce1925b829 Don't set timeouts in clients in tests 2016-10-05 14:33:26 +02:00
Kubernetes Submit Queue
0331b27f45 Merge pull request #34053 from bprashanth/trim_string
Automatic merge from submit-queue

Check for empty string post trimming

We curl in a retry loop and timeout,  trimming stdout to find endpoint names. When curl hits the timeout, stdout is empty, so we insert the empty string into the received set of endpoints. 

Fixes https://github.com/kubernetes/kubernetes/issues/32684
2016-10-05 02:32:41 -07:00
Kubernetes Submit Queue
6b82792880 Merge pull request #34030 from MrHohn/e2e_service_fix
Automatic merge from submit-queue

Improve source ip preservation test, fail the test instead of panic.

From #31085.

The source IP preserve test starts to be flake again. Sending out this PR to get rid of panicing and log the unexpected output for future investigation.

@freehan
2016-10-05 00:07:11 -07:00
Kubernetes Submit Queue
092b2cc081 Merge pull request #31994 from caesarxuchao/client-gen-versioned-options
Automatic merge from submit-queue

[Client-gen] Let versioned client use versioned options

i.e., use v1.ListOptions, v1.DeleteOptions when possible.

Remove the extension/v1beta1.ListOptions, because it's exactly the same as v1.ListOptions, and is not referred throughout the code base. After its removal, I register v1.ListOptions during extensions/v1beta1 scheme registration.

First three commits are manual changes.

Fix #27753

cc @lavalamp
2016-10-04 22:16:40 -07:00
Kubernetes Submit Queue
a9003a36ba Merge pull request #33976 from jingxu97/head-10-3
Automatic merge from submit-queue

Add a check for file size if the reading content returns empty

In order to debug the flaky tests for writing/reading files via
contains, this PR adds a check for file size if reading returns empty
content.
2016-10-04 21:03:00 -07:00
Chao Xu
75cc05de82 manual changes to let client-gen use versioned options 2016-10-04 20:39:29 -07:00
Kubernetes Submit Queue
11ba1aa5f3 Merge pull request #33854 from Random-Liu/fix-kubelet-perf-data
Automatic merge from submit-queue

Fix kubelet perf data to make it work again for perfdash.

Addresses https://github.com/kubernetes/kubernetes/pull/30333#issuecomment-248791257.

Add the "node" label back to fix kubelet perf dash. At least for now, we still need original perfdash to catch summary api performance regression.

/cc @coufon @yujuhong
2016-10-04 20:25:41 -07:00
bprashanth
1d7cdffebc Cleanup netexec image and usage. 2016-10-04 14:22:41 -07:00
bprashanth
fd9b152f28 Check for empty string post trimming 2016-10-04 14:11:59 -07:00
MrHohn
0d500921ea examine output format before return, fail the test instead of panic 2016-10-04 10:23:53 -07:00
Marek Grabowski
b7d76023c9 Revert "move pod networking tests common" 2016-10-04 14:22:55 +02:00
Kubernetes Submit Queue
ee77d4e6ca Merge pull request #33977 from quinton-hoole/2016-10-03-return-correct-ingress-in-e2e
Automatic merge from submit-queue

Heal the namespaceless ingresses in federation e2e.

For createIngressOrFail, it incorrectly returned the ingress passed in as an argument, which does not include the namespace, instead of the ingress returned from the create call (which does).

This in turn leads to errors in e2e tests like this:

INFO: Waiting for Ingress federated-ingress to acquire IP, error an empty namespace may not be set when a resource name is provided.

Self-applying LGTM label, as this is the same code that was LGTM'd by @nikhiljindal in #33502
2016-10-04 03:24:34 -07:00
Kubernetes Submit Queue
b74f0fc480 Merge pull request #33795 from freehan/add-network-node-e2e
Automatic merge from submit-queue

move pod networking tests common

This allows pod networking tests to run in both e2e and node e2e
2016-10-04 02:09:24 -07:00
Kubernetes Submit Queue
f79a53a734 Merge pull request #31777 from dshulyak/evict_pet
Automatic merge from submit-queue

Delete evicted pet

If pet was evicted by kubelet - it will stuck in this state forever.
By analogy to regular pod we need to re-create pet so that it will
be re-scheduled to another node, so in order to re-create pet
and preserve consitent naming we will delete it in petset controller
and create after that.

fixes: https://github.com/kubernetes/kubernetes/issues/31098
2016-10-04 01:32:02 -07:00
Kubernetes Submit Queue
4a0cd145e5 Merge pull request #33869 from madhusudancs/fed-e2e-cleanup-v4
Automatic merge from submit-queue

Deregister clusters during federated namespace e2e tear down.

This is causing other tests to leak resources.

cc @mwielgus @kubernetes/sig-cluster-federation
2016-10-03 17:36:16 -07:00
Janet Kuo
1c0e0e93b0 Add status check in PetSet e2e tests 2016-10-03 17:35:04 -07:00
Minhan Xia
47ccd15b1d add delete-namespace-on-failure flag 2016-10-03 17:14:51 -07:00