Commit Graph

164 Commits

Author SHA1 Message Date
Kubernetes Submit Queue
19d722671b Merge pull request #43297 from mvdan/kubectl-params
Automatic merge from submit-queue

kubectl/cmd: remove a bunch of unused parameters

Found with github.com/mvdan/unparam.

**Release note**: NONE
2017-04-13 04:07:21 -07:00
Brendan Burns
79f51923d3 Extract a bunch more strings from kubectl 2017-04-06 20:12:50 -07:00
Daniel Martí
810dbc5e98 kubectl/cmd: remove a bunch of unused parameters
Found with github.com/mvdan/unparam.
2017-04-04 10:36:30 +01:00
deads2k
8895f314b4 move category expansion out of restmapper 2017-03-27 13:54:05 -04:00
xilabao
131802a5cd add secret flag to options 2017-02-25 23:40:50 +08:00
Brendan Burns
f1de40b448 Extract some flag description strings to be translated. 2017-02-21 22:07:30 -08:00
Kubernetes Submit Queue
d404e07a72 Merge pull request #38183 from tianshapjq/remove-create-external-load-balancer
Automatic merge from submit-queue (batch tested with PRs 40345, 38183, 40236, 40861, 40900)

remove the create-external-load-balancer flag in cmd/expose.go

**What this PR does / why we need it**:
In cmd/expose.go there is a todo "remove create-external-load-balancer in code on or after Aug 25, 2016.", and now it's been a long time past. So I remove this flag and modify the test cases. 
Please check for this, thanks!

**Release note**:

```
remove the deprecated flag "create-external-load-balancer" and use --type="LoadBalancer" instead.
```
2017-02-07 11:33:41 -08:00
Brendan Burns
d9c4a289a6 Extract strings for translation. 2017-02-06 22:32:01 -08:00
deads2k
6a4d5cd7cc start the apimachinery repo 2017-01-11 09:09:48 -05:00
Kubernetes Submit Queue
fa5556b92b Merge pull request #32811 from fraenkel/headless_service
Automatic merge from submit-queue (batch tested with PRs 38260, 32811, 28458, 33570, 37096)

Allow no ports when exposing headless service

fixes #32795
2016-12-08 02:11:20 -08:00
tianshapjq
55521ee8be remove the create-external-load-balancer flag in cmd/expose.go 2016-12-06 16:48:32 +08:00
Fabiano Franz
f6d1ac72a0 Use our own normalizers for cmd examples and descriptions 2016-10-17 11:49:55 -02:00
AdoHe
b2280a646a update various commands to adapt the new Factory interface 2016-10-13 21:01:14 +08:00
Kubernetes Submit Queue
ea688f5e44 Merge pull request #31276 from juanvallejo/jvallejo_update-dry-run-create
Automatic merge from submit-queue

Update kubectl create message when using --dry-run

`kubectl create <resource> <name> --dry-run` provides a misleading success
message.

When commands such as `kubectl new-app node` are run with a
`--dry-run` flag, they make this clear by appending a "(DRY RUN)"
string to the final output. `kubectl create <resource>  <name> --dry-run`
does not do this, providing a potentially misleading output.

This patch appends a "(DRY RUN)" string to the end of a successful
message of `kubectl create` subcommands that support the `--dry-run` flag.

`kubectl create quota quota --dry-run`
```
resourcequota "quota" created
```

`kubectl create quota quota --dry-run`
```
resourcequota "quota" created (DRY RUN)
```

**Release note**:
```release-note
release-note-none
```
2016-09-26 16:01:17 -07:00
Kubernetes Submit Queue
2941069307 Merge pull request #32894 from deads2k/cli-01-remove-arg
Automatic merge from submit-queue

make --include-extended-apis deprecated and remove plumbing

Marks a dead CLI parameter as deprecated and removes the plumbing for it.
2016-09-19 21:11:04 -07:00
deads2k
862415aaa2 make --include-extended-apis deprecated and remove plumbing 2016-09-16 16:05:52 -04:00
Michael Fraenkel
a3537a02fe Allow no ports when exposing headless service 2016-09-15 14:56:49 -04:00
juanvallejo
52fc8efa55 update PrintSuccess message when using --dry-run 2016-09-15 10:11:21 -04:00
ymqytw
c67a62da49 Fixes #30562: Refactor kubectl command options to use common struct for common file params 2016-09-12 11:01:37 -07:00
juanvallejo
8faff9f949
update kubectl expose output to UsageError
This patch updates `kubectl expose` output (with no resources provided)
to a UsageError so that the `kubectl expose -h` suggestion is displayed.
2016-09-07 17:20:09 -04:00
lojies
513f24f857 add deploy for deployment 2016-08-31 09:50:22 +08:00
Kubernetes Submit Queue
207e8836c0 Merge pull request #29921 from andreykurilin/kubectl_typos
Automatic merge from submit-queue

Fix various typos in kubectl
2016-08-03 13:43:32 -07:00
k8s-merge-robot
7a62b9c8d1 Merge pull request #29523 from fraenkel/service_names_rfc1035
Automatic merge from submit-queue

Allow service names up to 63 characters (RFC 1035)

fixes #3752
2016-08-02 10:33:16 -07:00
Andrey Kurilin
91cace347d Fix various typos in kubectl 2016-08-02 19:51:51 +03:00
Michael Fraenkel
b1e7e6cf46 Service names conform to RFC 1035 2016-08-02 08:42:15 -06:00
k8s-merge-robot
44ea855713 Merge pull request #28239 from ApsOps/kubectl-expose-headless-svc
Automatic merge from submit-queue

Add a flag for `kubectl expose`to set ClusterIP and allow headless services

- Use `--cluster-ip=None` to create a headless service
- Fixes #10294
2016-08-02 01:18:19 -07:00
Aman
e9e06d6826
Add a kubectl expose flag to give ClusterIP
- Use `--cluster-ip=None` to create a headless service
- Fixes #10294
2016-07-05 00:59:53 +05:30
David McMahon
ef0c9f0c5b Remove "All rights reserved" from all the headers. 2016-06-29 17:47:36 -07:00
Michael Rubin
760b04e294 Use dedent for the kubectl commands
The one side effect is that for the "kubectl help" commands a newline
is prepended to output, which will alter the yaml output.

Here we use dedent to format the code to match the output.

hack/update-generated-docs.sh has been run and the affected files have
been added.

Note: for describe.go we added a period to the end of an output message.
2016-06-26 22:51:14 -07:00
Janet Kuo
4332472bde Add 'kubectl set image' 2016-05-18 21:23:17 -07:00
AdoHe
ad97cddb3e fix expose multi protocols issue 2016-05-12 00:07:07 -04:00
AdoHe
ba69f0f367 mark container-port flag as deprecated 2016-05-03 20:36:42 -04:00
Mike Metral
999c8e211e allow kubectl subcmds to process multiple resources
- use resource.Visit() to recursively process resources, as well as, aggregate
errors where possible
2016-05-01 20:27:37 -07:00
Kenjiro Nakayama
c9d34870ed Update bashcompletion codes for kubectl expose 2016-04-14 23:43:48 +09:00
Brendan Burns
be6c5b332b Add third party support to kubectl 2016-03-31 10:53:32 -07:00
k8s-merge-robot
9b6e4aa9b4 Merge pull request #23116 from metral/recursive-visit
Automatic merge from submit-queue

allow kubectl cmds to process files recursively, when given a dir

This PR accomplishes two things:

1. It creates a `--recursive` flag for use with certain `kubectl` commands that _currently_ do not process files beyond their first level of children, as seen in the issue https://github.com/kubernetes/kubernetes/issues/19767
2. It enables the ability to use the `--recursive` flag in the `kubectl` commands that currently _only_ support processing a directory up to its first level of children.
2016-03-30 05:07:47 -07:00
Phillip Wittrock
4d2f3c1c17 Update docs to reflect kubectl run creates deployments by default instead of replicatino controllers. 2016-03-28 16:25:02 -07:00
Mike Metral
7403878ac0 allow kubectl cmd to process dirs recursively
reqs:
    - the kubectl cmd must support the -f | --filename flag
    - the kubectl cmd must support visiting a dir one level deep,
    or using more than one resource
2016-03-28 12:44:21 -07:00
Janet Kuo
e93b855242 Update kubectl help for 1.2 resources 2016-03-22 14:14:35 -07:00
AdoHe
57534eaec9 update expose command description to add deployment 2016-03-19 13:51:21 -04:00
Madhusudan.C.S
67b70d7c89 Add a Deployment example for kubectl expose. 2016-03-18 17:05:49 -07:00
Jordan Liggitt
560b02b3ec Prefer fetched version when determining HPA group version kind 2016-03-11 00:03:38 -05:00
AdoHe
9cc668f7c6 update commented examples just remove $ 2016-02-29 09:41:09 -05:00
Madhusudan.C.S
293793cf0d Allow replica set to be exposed as a service and add kubectl command tests for replica sets. 2016-02-10 16:20:08 -08:00
Madhusudan.C.S
ed7ad6dcf3 Make deployments work. 2016-02-08 21:27:49 -08:00
Janet Kuo
5088d0e147 Record kubectl commands 2016-02-03 10:19:05 -08:00
Clayton Coleman
2fd38a7dc0 Break kubectl from assuming details of codecs
Most of the logic related to type and kind retrieval belongs in the
codec, not in the various classes. Make it explicit that the codec
should handle these details.

Factory now returns a universal Decoder and a JSONEncoder to assist code
in kubectl that needs to specifically deal with JSON serialization
(apply, merge, patch, edit, jsonpath). Add comments to indicate the
serialization is explicit in those places. These methods decode to
internal and encode to the preferred API version as previous, although
in the future they may be changed.

React to removing Codec from version interfaces and RESTMapping by
passing it in to all the places that it is needed.
2016-01-22 13:27:26 -05:00
Tim Hockin
5002b784f9 Clarify --external-ip in kubectl expose docs
Also fix a couple minor punctuation issues.
2016-01-10 23:29:57 -08:00
Michail Kargakis
71934b7643 kubectl: Validate flag usage against generators
This commit moves the generators into separate buckets and creates
separate calls for each one group. This helps in providing just the
necessary generators to each generator command.

Validation of flags against generators is also added so that flags
that are not meant to be used with a specific generator will result
in error.
2015-12-18 15:09:53 +01:00
deads2k
66eecb963a update more kubectl bits for groupversion 2015-12-07 09:01:44 -05:00
deads2k
303bcad398 use groupversion in RESTMapping 2015-11-16 09:22:11 -05:00
Janet Kuo
a6a64820d7 Make generation of the apply annotation optional 2015-11-06 15:08:50 -08:00
Jordan Liggitt
b58e62e7d4 Pass runtime.Object to Helper.Create/Replace 2015-10-28 12:43:21 -04:00
kargakis
7d0e691520 expose: Enable exposing multiport objects
The generated service will inherit all the ports from the exposed object.
2015-10-19 11:25:14 +02:00
kargakis
4b23bf602d expose: Minor cleanup 2015-10-10 16:16:41 +02:00
kargakis
083c5bebbd expose: --dry-run should dump the object
Also make some tests use --dry-run and compare generated objects
against expected
2015-10-10 16:15:17 +02:00
jackgr
ef3f64612e Add calls to set annotation for kubectl apply 2015-10-07 17:15:56 -07:00
kargakis
989806d9ec expose: Truncate service names
In case the generated service inherits the exposed object's name (the user didn't specify
a name via --name), truncate it up to the maximum length for a valid service name
2015-10-05 10:39:42 +02:00
feihujiang
98689a99ec Limit the type for kubectl expose command 2015-09-15 11:17:04 +08:00
Jeff Lowdermilk
0898ce852d Merge pull request #13756 from kargakis/make-external-svcs-exposable
expose: Avoid selector resolution if a selector is not needed
2015-09-14 16:01:55 -07:00
k8s-merge-robot
96df310729 Merge pull request #13783 from feihujiang/changeExposePortOperationToNoRequired
Auto commit by PR queue bot
2015-09-12 18:54:34 -07:00
Abhishek Shah
44ce4aa423 Create a LB for a K8S with the LB-IP provided by user. 2015-09-10 21:05:06 -07:00
feihujiang
714a042ce4 Change Expose Command's port operation to no required 2015-09-11 11:37:55 +08:00
kargakis
c9268e1faf expose: Avoid selector resolution if a selector is not needed 2015-09-09 21:30:23 +02:00
hurf
8efc62bcce Simplify default output of "expose" command
Use simple output string such as "rc nginx exposed" to show the
result. Users can still use options like "-o yaml" to view detailed
result.

IP will be printed with detailed result now.
2015-09-07 15:17:17 +08:00
feihujiang
0427711c42 Fixes upper case letters in kubectl examples 2015-09-03 12:00:21 +08:00
Abhi Shah
642ebb4994 Merge pull request #13099 from JanetKuo/kubectl-expose-deprecate-create-external-load-balancer
Deprecated kubectl flag "create-external-load-balancer"
2015-09-02 15:16:08 -07:00
Daniel Smith
10efd9806a Merge pull request #13227 from kargakis/fix-exposing-from-file
expose: Don't query the server for input objects
2015-09-01 12:23:01 -07:00
deads2k
f1b81ff678 bind filenames var instead of looking up 2015-09-01 08:35:57 -04:00
Janet Kuo
18e87724c5 Deprecated kubectl flag "create-external-load-balancer" 2015-08-28 00:54:33 -07:00
kargakis
e86bb1aeca expose: Don't query the server for input objects
Signed-off-by: kargakis <mkargaki@redhat.com>
2015-08-27 15:52:22 +03:00
Abhishek Shah
b6b8e99393 External IPs support. 2015-08-20 16:10:01 -07:00
Brendan Burns
586931fe16 Add optional arguments to kubectl run ... 2015-08-13 09:41:51 -07:00
Peeyush Agarwal
05e069d038 Use bash comments in kubectl examples
Comments in kubectl examples should use bash comments, not Go comments.
So, replaces // by # for example strings.
2015-08-12 19:56:23 +00:00
feihujiang
c0b2098844 Kubectl expose command accepts a filename param 2015-08-12 16:16:37 +08:00
Kris Rousey
565189f5b8 Correcting all go vet errors 2015-08-11 13:55:37 -07:00
Mike Danese
8e33cbfa28 rewrite go imports 2015-08-05 17:30:03 -07:00
hurf
33fb6170f9 Use TYPE instead of RESOURCE in help string
For commands in kubectl, use TYPE in help string.
2015-08-05 16:34:48 +08:00
Brendan Burns
c9bc1456ff Add session affinity flags to kubectl expose 2015-07-31 10:34:52 -07:00
nikhiljindal
c849730116 Fixing the error message 2015-07-16 23:33:16 -07:00
nikhiljindal
496f30a92f Introduce a new service generator that leaves service port unnamed 2015-07-16 20:40:40 -07:00
Brendan Burns
a8f02e5472 Automatically open a firewall when creating a GCE load balancer. 2015-07-10 14:35:29 -07:00
Kris Rousey
ffa764d60b Unify command line namespace resolution
This change allows the namespace in kubeconfig to be overridden by
specifying the namespace in the spec file. If namespace is explicitly
provided in the command line flags and the spec file has a different
namespace, this will cause an error.
2015-07-01 12:59:17 -07:00
Brendan Burns
380790a8e2 Add messages to indicate that opening an external firewall may be necessary. 2015-06-04 22:31:52 -07:00
kargakis
0fba4820f5 expose: Better error formatting and generic flag message
Re error formatting:
$ osc expose svc frontend --port=5432 --generator='service/v2' --name=test

Before:
error: generator %!!(MISSING)q(<nil>) not found.
see 'osc expose -h' for help.

Now:
error: generator "services/v2" not found.
see 'openshift cli expose -h' for help.
2015-06-02 13:06:21 +02:00
kargakis
6c85040cef expose: Use separate parameters for default and custom name 2015-05-28 11:03:16 +02:00
Justin Santa Barbara
973c2e4819 Add Type to ServiceSpec: ClusterIP or LoadBalancer 2015-05-22 19:14:21 -04:00
kargakis
30958f892d expose: Use resource builder
Plus:
* Rename flag --service-name to --name
* Some refactoring
2015-05-20 23:55:07 +02:00
kargakis
ac652d16e6 expose: Re-use labels in case none was specified 2015-05-15 11:54:41 +02:00
kargakis
93dc839b19 Load input object for increased safety 2015-05-08 03:17:54 +02:00
kargakis
c9e79a3c28 Setup generators in factory 2015-05-05 12:00:13 +02:00
kargakis
fa42901798 expose: Create objects in a generic way 2015-05-04 14:21:24 +02:00
Filip Grzadkowski
be2b2466f3 Merge pull request #7076 from eparis/bash-5-kubectl-required-flags
annotate required flags for bash_completions
2015-05-04 13:26:11 +02:00
Eric Paris
6b3a6e6b98 Make copyright ownership statement generic
Instead of saying "Google Inc." (which is not always correct) say "The
Kubernetes Authors", which is generic.
2015-05-01 17:49:56 -04:00
Rohit Jnagal
0a8b136ee6 Fix typo in 'kubectl expose' examples. 2015-04-30 06:02:16 +00:00
Eric Paris
0620940d26 annotate required flags for bash_completions
some commands require that certain flags be set in order to function.
Annotate those flags so the bash completions will suggest to the user
that they be set.
2015-04-20 18:33:00 -04:00
deads2k
6344cf3c3a refactor to move kubectl.cmd.Factory to kubect/cmd/util 2015-04-07 14:43:50 -04:00
Brendan Burns
674efe6de8 Make expose use introspection to grab the port value if possible.
Also improve service printing to include public IP addresses.
2015-04-02 13:08:47 -07:00
Tim Hockin
f928f52a4a Alias --container-port to --target-port in kubectl 2015-03-26 17:59:46 -07:00
Clayton Coleman
64f91f7dac Allow kubectl expose to be polymorphic to the source of the selector
Allows exposing new resource types to be exposed (OpenShift deployment
controllers, copying services, and other resources that will have
pod label selectors).

Also fixed a bug where the selector wasn't exposed because of parameter
defaulting.
2015-03-26 14:36:53 -04:00