Commit Graph

374 Commits

Author SHA1 Message Date
Michal Wozniak
926bc9bf8e Update podFailurePolicy comment from alpha-level to beta 2023-05-26 10:24:36 +02:00
Kubernetes Prow Robot
bc6cbdabbe
Merge pull request #117852 from tenzen-y/replace-deprecated-sets
Job: Use generic Set in validation
2023-05-24 14:47:00 -07:00
Yuki Iwai
2e2afc7fd2 Job: Use generic Set in validation
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2023-05-12 03:26:25 +09:00
Kubernetes Prow Robot
367180d781
Merge pull request #117933 from tenzen-y/replace-deprecated-Prt-utils
Job: Replace deprecated pointer utils with supported ones
2023-05-11 09:59:14 -07:00
Yuki Iwai
de882f5193 Job: Replace deprecated pointer utils with supported ones
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2023-05-11 19:29:14 +09:00
Tim Hockin
ec3379a717
Do hostNet Pod-ports -> hostPorts in Pod defaults
Rather than doing it in PodSpec defaulting, which triggers in
Deployments and DaemonSets, do it only when a Pod is actually in play.
2023-05-09 18:10:20 -07:00
Yuki Iwai
235c261196 Job: Fix a misspelling
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2023-05-09 00:25:45 +09:00
Kubernetes Prow Robot
7add692580
Merge pull request #117633 from kannon92/remove-job-tracking-finalizers
remove tracking annotation from validation and webhooks
2023-05-04 10:34:43 -07:00
Tim Hockin
d55b67b349
Clean up brace whitespace in **/validation_test.go
This was making my eyes bleed as I read over code.

I used the following in vim.  I made them up on the fly, but they seemed
to pass manual inspection.

:g/},\n\s*{$/s//}, {/
:w
:g/{$\n\s*{$/s//{{/
:w
:g/^\(\s*\)},\n\1},$/s//}},/
:w
:g/^\(\s*\)},$\n\1}$/s//}}/
:w
2023-05-02 00:48:42 -07:00
kannon92
6a4cf352b8 remove tracking annotation from validation and webhooks 2023-04-26 17:16:05 +00:00
kannon92
aef8cbab89 Add batch.kubernetes.io to labels created in the Job controller. 2023-03-11 12:27:38 +00:00
Kubernetes Prow Robot
48e4052fc0
Merge pull request #114902 from TommyStarK/pkg-apis/replace-deprecated-pointer-function
pkg/apis: Replace deprecated pointer function
2023-03-09 21:34:15 -08:00
Maciej Szulik
1b825c179b
Promote CronJob TZ to GA 2023-03-07 12:58:57 +01:00
kannon92
3489ace708 generated code 2023-03-01 21:43:25 +00:00
kannon92
cb9334ebb2 update batch apis 2023-03-01 20:39:47 +00:00
kannon92
2da3e839b0 remove ValidateJobSpec and add more test cases to batch validation 2023-03-01 20:39:47 +00:00
Kubernetes Prow Robot
e519921666
Merge pull request #115940 from ahg-g/ahg-mutable-ga
Allow mutating schedulingGates in the Pod template for suspended Jobs
2023-02-28 08:51:17 -08:00
Kubernetes Prow Robot
35f0507dca
Merge pull request #111856 from mengjiao-liu/improve-podSpec.restartPpolicy-description
Improve spec.template.spec.restartPolicy description
2023-02-27 22:53:27 -08:00
Mengjiao Liu
81aefe5fee Improve spec.template.spec.restartPolicy description 2023-02-27 14:25:48 +08:00
ahg-g
5bca182544 Allow mutating schedulingGates in the Pod template for suspended Jobs 2023-02-24 18:10:26 +00:00
Daniel Vega-Myhre
8d31da4599 add validation test case for immutable completions on indexed jobs when AllowElasticIndexedJobs is false 2023-02-23 21:05:03 +00:00
Daniel Vega-Myhre
15077a0f28 plumb feature gate value through job validation opts and modify validateCompletions function to only check completions == parallelism after the update, not before 2023-02-23 18:09:47 +00:00
Daniel Vega-Myhre
c63f448451 change test names and address other comments 2023-02-23 03:25:17 +00:00
Daniel Vega-Myhre
d41302312e update validation logic so completions is mutable iff completions is modified in tandem with parallelsim so completions == parallelism 2023-02-23 03:25:16 +00:00
Claudiu Belu
ec753fcb55 unittests: Fixes unit tests for Windows (part 6)
Currently, there are some unit tests that are failing on Windows due to
various reasons:

- On Windows, consecutive time.Now() calls may return the same timestamp, which would cause
  the TestFreeSpaceRemoveByLeastRecentlyUsed test to flake.
- tests in kuberuntime_container_windows_test.go fail on Nodes that have fewer than 3 CPUs,
  expecting the CPU max set to be more than 100% of available CPUs, which is not possible.
- calls in summary_windows_test.go are missing context.
- filterTerminatedContainerInfoAndAssembleByPodCgroupKey will filter and group container
  information by the Pod cgroup key, if it exists. However, we don't have cgroups on Windows,
  thus we can't make the same assertions.
2023-01-31 11:49:26 +00:00
Jordan Liggitt
7e19850f31
Validate format of timeZone 2023-01-30 17:01:45 -05:00
Jurj Andrei George
4df989d719 Skip failing Windows unit tests
As discussed during the SIG Testing meeting on January 10, 2023, failing
Windows unit tests are now skipped.
These changes should be reverted when the unit tests wil get fixed.
Mentioned SIG Testing meeting:
https://docs.google.com/document/d/1z8MQpr_jTwhmjLMUaqQyBk1EYG_Y_3D4y4YdMJ7V1Kk/edit#heading=h.qwblxf2uhgoo
2023-01-18 14:18:41 +02:00
TommyStarK
c242e647ae pkg/apis: Replace deprecated pointer function
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
2023-01-08 13:14:37 +01:00
ztzxt
70415b9562 Fix API refs for batch v1 and v1beta1
Add generatod docs for batch v1

Start types with uppercase letters

Fix batch API docs under pgs/apis

Create generated files for batch v1

Fix batch v1beta1 docs

Generate new files after merge conflict
2022-11-19 12:42:25 +03:00
Michal Wozniak
c803892bd8 Enable the feature into beta 2022-11-09 09:02:40 +01:00
Jordan Liggitt
fc69084bf1
Update workload selector validation 2022-11-07 20:52:02 -05:00
Manjusaka
0843c4dfca
Add extra value validation for matchExpression field in LabelSelector 2022-11-07 20:48:21 -05:00
Aldo Culquicondor
4948918155
Graduate JobTrackingWithFinalizers to stable
Change-Id: Ifc749a85b1270c0155ac511b91d4681d53236820
2022-11-04 17:05:53 -04:00
SataQiu
8dba9f782d remove GA featuregates IndexedJob and SuspendJob 2022-09-20 11:00:43 +08:00
Michal Wozniak
31740d1c37 Fix the TestRoundTripTypes by adding default to the fuzzer 2022-09-09 16:47:08 +02:00
Michal Wozniak
bf9ce70de3 Support handling of pod failures with respect to the specified rules 2022-08-04 18:39:08 +02:00
Maciej Szulik
130845c937
Change validation tests such that they accept valid values from a
provided TZ database and fail on any other values
2022-08-02 16:53:10 +02:00
Maciej Szulik
8fd81c6573
Promote CronJobTimeZone to beta 2022-08-02 16:53:04 +02:00
Abirdcfly
ceceb96f3d
cleanup: skip a test validate time_zone letter case in darwin
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
2022-04-04 16:50:45 +08:00
Kubernetes Prow Robot
0f2300575c
Merge pull request #108032 from deejross/kep3140-cronjob-timezone
KEP 3140: TimeZone support for CronJob
2022-03-29 17:34:20 -07:00
Ross Peoples
d26e6cca72 make update after timeZone support for CronJob 2022-03-29 11:40:46 -05:00
Ross Peoples
dbb3906a09 Fix for timeZone validation and strategy 2022-03-29 11:40:34 -05:00
Aldo Culquicondor
8c00f510ef Graduate JobReadyPods to beta
Set podUpdateBatchPeriod to 1s

Change-Id: I8a10fd8f8559adad9df179b664b8c82851607855
2022-03-29 10:07:41 -04:00
Ross Peoples
98837de446 TimeZone support for CronJobs 2022-03-28 16:33:00 -05:00
Aldo Culquicondor
2c5d0a273c Graduate IndexedJob to stable
- Lock feature gate to true and schedule for deletion in 1.26
- Remove checks on feature gate
- Graduate E2E test to Conformance

Change-Id: I6814819d318edaed5c86dae4055f4b050a4d39fd
2022-03-15 13:41:06 -04:00
Abdullah Gharaibeh
b2d2ec9e76 Graduate SuspendJob to GA 2022-02-15 10:46:13 -05:00
Davanum Srinivas
9405e9b55e
Check in OWNERS modified by update-yamlfmt.sh
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-09 21:31:26 -05:00
Sergey Kanzhelev
b7affcced1 implement :grpc probe action 2021-11-17 17:31:23 +00:00
Kubernetes Prow Robot
36e69a3303
Merge pull request #105980 from ahg-g/ahg-mutable
Make job pod template annotations and labels mutable for suspended jobs that never started
2021-10-29 13:15:23 -07:00
Tim Hockin
11a25bfeb6
De-share the Handler struct in core API (#105979)
* De-share the Handler struct in core API

An upcoming PR adds a handler that only applies on one of these paths.
Having fields that don't work seems bad.

This never should have been shared.  Lifecycle hooks are like a "write"
while probes are more like a "read". HTTPGet and TCPSocket don't really
make sense as lifecycle hooks (but I can't take that back). When we add
gRPC, it is EXPLICITLY a health check (defined by gRPC) not an arbitrary
RPC - so a probe makes sense but a hook does not.

In the future I can also see adding lifecycle hooks that don't make
sense as probes.  E.g. 'sleep' is a common lifecycle request. The only
option is `exec`, which requires having a sleep binary in your image.

* Run update scripts
2021-10-29 13:15:11 -07:00