Aohan Yang
e6863757f4
Add IP mode field
2023-07-17 15:51:40 +08:00
Mike Spreitzer
2069835094
Tolerate only the two allowed field changes
...
Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
2023-07-14 01:01:43 +00:00
Abu Kashem
3754d2da20
apf: allow admin to change the Exempt field only of the exempt pl
...
Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
2023-07-14 01:01:29 +00:00
Dr. Stefan Schimanski
f1f2fa9da8
kube-apiserver/corerest: split apart generic code
2023-07-12 14:13:10 +02:00
Dr. Stefan Schimanski
a34e06e74c
kube-apiserver/corerest: structure Config
2023-07-11 17:27:20 +02:00
Dr. Stefan Schimanski
75e3576523
kube-apiserver: rewire service controllers: kubernetesservice + IP repair
2023-07-11 17:27:20 +02:00
Dr. Stefan Schimanski
c733c57962
pkg/controlplane: wire core storage as RESTStorageProvider
2023-07-05 16:46:40 +02:00
Dr. Stefan Schimanski
68aee61d4f
SPLIT: kube-apiserver/corerest: split out service IP setup logic
2023-07-05 11:00:37 +02:00
Dr. Stefan Schimanski
dad3e4d211
SPLIT: kube-apiserver/corerest: split constructor
2023-07-05 09:45:20 +02:00
Dr. Stefan Schimanski
616c959988
FIXUP: pkg/controlplane: move bootstrap controller to controllers/kubernetesservice
2023-07-04 16:38:14 +02:00
Dr. Stefan Schimanski
19cb6d036a
kube-apiserver/corerest: remove redundant interface
2023-07-03 15:27:09 +02:00
Kubernetes Prow Robot
a8cc22f416
Merge pull request #118680 from danwinship/not-that-kind-of-proxying
...
move an apiserver helper function out of pkg/proxy
2023-07-03 02:28:51 -07:00
Dan Winship
bb0c3a0818
Remove proxyutil.IsProxyableIP / IsProxyableHostname
...
These don't belong in pkg/proxy/util; they involve a completely
unrelated definition of proxying.
Since each is only used from one place, just inline them at the
callers.
2023-07-01 08:49:38 -04:00
Patrick Ohly
a5df442be7
flowcontrol: copy object before passing it to client-go Create to avoid data race
...
This is similar to 5e1c6cd0d4
, except that here generics are involved:
because client-go Create under the hood mutates its input value temporarily,
callers must make a copy if the object is read from some other goroutine.
The race as reported by "go test -race" for
test/integration/examples.TestAggregatedAPIServerRejectRedirectResponse is:
WARNING: DATA RACE
Read at 0x00c000556010 by goroutine 16128:
reflect.Value.String()
/usr/local/go/src/reflect/value.go:2565 +0x216
encoding/json.stringEncoder()
/usr/local/go/src/encoding/json/encode.go:645 +0x223
encoding/json.structEncoder.encode()
/usr/local/go/src/encoding/json/encode.go:759 +0x2ba
encoding/json.structEncoder.encode-fm()
<autogenerated>:1 +0xdb
encoding/json.ptrEncoder.encode()
/usr/local/go/src/encoding/json/encode.go:943 +0x382
encoding/json.ptrEncoder.encode-fm()
<autogenerated>:1 +0x90
encoding/json.(*encodeState).reflectValue()
/usr/local/go/src/encoding/json/encode.go:358 +0x88
encoding/json.(*encodeState).marshal()
/usr/local/go/src/encoding/json/encode.go:330 +0x224
encoding/json.Marshal()
/usr/local/go/src/encoding/json/encode.go:161 +0xf9
k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/util/flowcontrol/format.ToJSON()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/util/flowcontrol/format/formatting.go:81 +0x44
k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/util/flowcontrol/format.Stringer.String()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/util/flowcontrol/format/formatting.go:68 +0x5a4
k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/util/flowcontrol/format.(*Stringer).String()
<autogenerated>:1 +0x4b
fmt.(*pp).handleMethods()
/usr/local/go/src/fmt/print.go:673 +0x4db
fmt.(*pp).printArg()
/usr/local/go/src/fmt/print.go:756 +0xce4
fmt.(*pp).doPrintf()
/usr/local/go/src/fmt/print.go:1077 +0x599
fmt.Fprintf()
/usr/local/go/src/fmt/print.go:224 +0x7e
k8s.io/kubernetes/vendor/k8s.io/klog/v2.(*loggingT).printfDepth()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/klog/v2/klog.go:733 +0x216
k8s.io/kubernetes/vendor/k8s.io/klog/v2.(*loggingT).printf()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/klog/v2/klog.go:718 +0xcc
k8s.io/kubernetes/vendor/k8s.io/klog/v2.Verbose.Infof()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/klog/v2/klog.go:1418 +0x64
k8s.io/kubernetes/vendor/k8s.io/apiserver/pkg/util/flowcontrol.(*cfgMeal).digestFlowSchemasLocked()
...
Previous write at 0x00c000556010 by goroutine 15271:
k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/apis/meta/v1.(*TypeMeta).SetGroupVersionKind()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/apis/meta/v1/meta.go:121 +0x193
k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/runtime.WithVersionEncoder.Encode()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/runtime/helper.go:239 +0x325
k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/runtime.(*WithVersionEncoder).Encode()
<autogenerated>:1 +0xfb
k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/runtime.Encode()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/runtime/codec.go:49 +0xb3
k8s.io/kubernetes/vendor/k8s.io/client-go/rest.(*Request).Body()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/client-go/rest/request.go:470 +0x884
k8s.io/kubernetes/vendor/k8s.io/client-go/kubernetes/typed/flowcontrol/v1beta3.(*flowSchemas).Create()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/client-go/kubernetes/typed/flowcontrol/v1beta3/flowschema.go:118 +0x23c
k8s.io/kubernetes/pkg/registry/flowcontrol/ensurer.(*objectOps[...]).Create()
<autogenerated>:1 +0x10f
k8s.io/kubernetes/pkg/registry/flowcontrol/ensurer.EnsureConfiguration[...]()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/registry/flowcontrol/ensurer/strategy.go:272 +0x1b5
k8s.io/kubernetes/pkg/registry/flowcontrol/ensurer.EnsureConfigurations[...]()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/registry/flowcontrol/ensurer/strategy.go:247 +0xf3
k8s.io/kubernetes/pkg/registry/flowcontrol/rest.ensureMandatoryConfiguration()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/registry/flowcontrol/rest/storage_flowcontrol.go:230 +0x59e
k8s.io/kubernetes/pkg/registry/flowcontrol/rest.ensure()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/registry/flowcontrol/rest/storage_flowcontrol.go:202 +0x1b2
k8s.io/kubernetes/pkg/registry/flowcontrol/rest.(*bootstrapConfigurationEnsurer).ensureAPFBootstrapConfiguration.func1.1()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/registry/flowcontrol/rest/storage_flowcontrol.go:159 +0xe4
k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait.runConditionWithCrashProtectionWithContext()
/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:154 +0x7b
2023-06-30 09:55:25 +02:00
Kubernetes Prow Robot
ba6d2674ca
Merge pull request #118722 from aojea/ip_leading_zeros
...
ipallocator bug if ips has leading zeros
2023-06-25 07:11:07 -07:00
Antonio Ojea
e4f93d8a82
ipallocator bug if ips has leading zeros
...
The ipallocator for the new IPAddress object use the golang big.Int
library for some math operations, like adding an offset to an IP
address.
We use the bytes array to convert between big.Int and IP addresses,
however, IP addresses are always represented as 4 or 16 bytes arrays.
Big int bytes representations just return the byte array until the
most representative number, this requires that we need to prepend
these extra bytes for IPs with leading zeros.
Change-Id: I9d539f582cae1f9f4e373b28c5b94d7a342f09c7
Signed-off-by: Antonio Ojea <aojea@google.com>
2023-06-25 13:14:46 +00:00
Mike Spreitzer
92a35f5bca
Usse generics to simplify pkg/registry/flowcontrol/ensurer
...
Signed-off-by: Mike Spreitzer <mspreitz@us.ibm.com>
2023-06-22 00:56:54 -04:00
Aldo Culquicondor
c27f9fdeb7
Add warnings for big number of completions and parallelism
...
Change-Id: I63e192b1ce9da7d8bb04f8be1a6e19ec6fbbfa5a
2023-06-14 10:38:42 -04:00
Kubernetes Prow Robot
e80e6b8e5a
Merge pull request #118597 from tkashem/apf-refactor
...
apf: refactor bootstrap ensure strategy
2023-06-13 04:59:58 -07:00
Kubernetes Prow Robot
3b44969134
Merge pull request #118460 from serathius/componentstatuses
...
Make etcd component status consistent with health probes
2023-06-13 02:17:58 -07:00
Marek Siarkowicz
a60314c47e
Make etcd component status consistent with health probes
...
Co-authored-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
2023-06-13 10:10:29 +02:00
Abu Kashem
672614b57e
apf: refactor bootstrap ensure strategy
2023-06-09 13:31:23 -04:00
Tim Hockin
151509fb74
Remove unreachable warning on volume name dup
...
Volume names are validated to be unique and always have been. The cited
issues are all about apply getting messed up, not the aspiserver
allowing dups.
```
$ k create -f /tmp/bad.yaml
The Deployment "bad-volumes-test" is invalid: spec.template.spec.volumes[1].name: Duplicate value: "config"
$ k apply --server-side -f /tmp/bad.yaml
Error from server: failed to create typed patch object (default/bad-volumes-test; apps/v1, Kind=Deployment): .spec.template.spec.volumes: duplicate entries for key [name="config"]
$ k apply -f /tmp/bad.yaml -o json | jq '.spec.template.spec.volumes'
The Deployment "bad-volumes-test" is invalid: spec.template.spec.volumes[1].name: Duplicate value: "config"
```
2023-06-07 17:14:49 -07:00
Tobias Klauser
0f5535ea25
registry/core/service: remove incorrect comments
...
These interface methods are not only used for testing. Remove the
incorrect comments.
2023-05-22 12:35:43 +02:00
Kubernetes Prow Robot
1d6158e11b
Merge pull request #117993 from liggitt/shortnames
...
Undo 1.28 shortname additions for now
2023-05-15 11:05:27 -07:00
Kubernetes Prow Robot
1487fc762f
Merge pull request #117982 from jpbetz/sig-roles-jpbetz
...
Add api-machinery TL owners permissions for jpbetz
2023-05-15 09:07:29 -07:00
Joe Betz
f0f92853ad
Add api-machinery TL owners permissions for jpbetz
2023-05-15 11:09:54 -04:00
Kubernetes Prow Robot
11218f10aa
Merge pull request #117061 from AxeZhan/duplicate_validation
...
remove duplicate validation for csi
2023-05-14 12:51:26 -07:00
Jordan Liggitt
815578295a
Revert "support short name for flowschema and prioritylevelconfiguration"
...
This reverts commit 3dd0c41663
.
2023-05-13 11:11:04 -04:00
Jordan Liggitt
72202f9a00
Revert "add shortnames for mutatingwebhookconfigurations and validatingwebhookconfigurations"
...
This reverts commit 7514d8b333
.
2023-05-13 11:10:55 -04:00
Daniel Smith
1ffe3f467e
lavalamp is taking a long break
2023-05-11 16:43:38 +00:00
Tim Hockin
4bbf611773
Retool validation for pod HostNetwork ports
...
This will ensure that HostPort == ContainerPort for pods and that
HostPort == 0 || HostPort == ContainerPort for embedded PodSpecs.
2023-05-09 18:10:44 -07:00
Kubernetes Prow Robot
a9b08f4cc2
Merge pull request #117642 from carlory/fix-001
...
remove ability to re-enable serving deprecated node.k8s.io/v1beta1 types
2023-05-09 09:35:56 -07:00
Kubernetes Prow Robot
51ffca216c
Merge pull request #117535 from hysyeah/feature/webhookconfiguration-shortnames
...
add shortnames for mutatingwebhookconfigurations and validatingwebhookconfigurations
2023-05-05 09:17:32 -07:00
Mike Spreitzer
008576da07
Improve and simplify maintenance of APF bootstrap objects
...
Prepare to make deletion of unwanted object conditional on ResourceVersion.
Remove unnecessary split between finding unwanted objects and removing
them.
Remove unnecessary layers of indirection to reach constant logic.
Use interfaces to remove need for type assertions.
Threaded context into APF object maintenance
Note and respect immutability of desired bootstrap objects
2023-05-05 09:36:48 -04:00
Kubernetes Prow Robot
f5e361e4e6
Merge pull request #117107 from pohly/test-integration-race-detection-flowcontrol
...
pkg/registry/flowcontrol: avoid race condition during Create
2023-05-05 00:09:24 -07:00
Kubernetes Prow Robot
3cd81876bd
Merge pull request #116208 from kkkkun/support-short-name-for-flowschema-and-prioritylevelconfigurations
...
support short name for flowschema and prioritylevelconfiguration
2023-05-05 00:09:12 -07:00
Jordan Liggitt
e807a6aec5
Disable NewVolumeManagerReconstruction feature gate
2023-05-04 16:41:20 -04:00
Kubernetes Prow Robot
7add692580
Merge pull request #117633 from kannon92/remove-job-tracking-finalizers
...
remove tracking annotation from validation and webhooks
2023-05-04 10:34:43 -07:00
Kubernetes Prow Robot
78833e1b33
Merge pull request #117713 from flant/ssr-ga
...
KEP-3325: Promote SelfSubjectReview to GA
2023-05-03 08:54:24 -07:00
carlory
e7396e3551
remove ability to re-enable serving deprecated versions of the runtimeclasses kind
2023-05-02 22:40:26 +08:00
m.nabokikh
40de26dcff
KEP-3325: Promote SelfSubjectReview to GA
...
Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>
2023-05-02 14:50:40 +02:00
Ricardo Katz
bff8a6cd9f
Remove withdrawn feature NetworkPolicyStatus
2023-05-01 15:19:25 -03:00
Stephen Kitt
026e7c7cb3
registry: replace intstr.FromInt with intstr.FromInt32
...
This touches cases where FromInt() is used on numeric constants, or
values which are already int32s, or int variables which are defined
close by and can be changed to int32s with little impact.
Signed-off-by: Stephen Kitt <skitt@redhat.com>
2023-05-01 09:17:45 +02:00
carlory
da922f0af6
Remove ability to re-enable serving deprecated discoveryv1beta1 APIs
2023-04-30 19:21:46 +08:00
carlory
944a4cd311
Remove ability to re-enable serving deprecated autoscalingapiv2beta APIs
2023-04-29 16:51:48 +08:00
Kubernetes Prow Robot
4ca7bcec24
Merge pull request #117665 from carlory/fix-007
...
Remove ability to re-enable serving deprecated eventv1beta1 APIs
2023-04-28 11:08:27 -07:00
carlory
f81b49d873
Remove ability to re-enable serving deprecated eventv1beta1 APIs
2023-04-28 14:58:59 +08:00
carlory
48d01d6d9b
Remove ability to re-enable serving deprecated batchapiv1beta1 APIs
2023-04-28 14:08:31 +08:00
kannon92
6a4cf352b8
remove tracking annotation from validation and webhooks
2023-04-26 17:16:05 +00:00