github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
82,500 Commits 1 Branch 31 Tags
c8c055b3163dd2661b3f9dd1b0ffb718a61aba24
Commit Graph

41 Commits

Author SHA1 Message Date
Tim Allclair
a2c51674cf Cleanup more static check issues (S1*,ST*) 2019-08-21 10:40:21 -07:00
Kevin Klues
4fdd52b058 Update GetTopologyHints() API to return a map 
At present, there is no way for a hint provider to return distinct hints
for different resource types via a call to GetTopologyHints(). This
means that hint providers that govern multiple resource types (e.g. the
devicemanager) must do some sort of "pre-merge" on the hints it
generates for each resource type before passing them back to the
TopologyManager.

This patch changes the GetTopologyHints() interface to allow a hint
provider to pass back raw hints for each resource type, and allow the
TopologyManager to merge them using a single unified strategy.

This change also allows the TopologyManager to recognize which
resource type a set of hints originated from, should this information
become useful in the future.
 2019-08-16 08:06:12 +02:00
Kubernetes Prow Robot
f2dd24820a Merge pull request #73920 from nolancon/topology-manager-cpu-manager 
Changes to make CPU Manager a Hint Provider for Topology Manager
 2019-08-15 05:44:33 -07:00
Kevin Klues
9a6788cb13 Add IterateSocketMasks() function to socketmask abstraction 2019-08-14 06:22:56 +02:00
Kubernetes Prow Robot
ac2295a24d Merge pull request #78587 from kad/socketmask-string 
Use go standard library for common bit operations
 2019-08-13 00:03:39 -07:00
Moshe Levi
3b83c5c7c6 TopologyManager: Fix rename best-effort policy files 
PR https://github.com/kubernetes/kubernetes/pull/80301 rename
the preferred policy to best-effort, but the files names are
still policy_preferred.go and policy_preferred_test.go. This
PR fix that.
 2019-07-28 19:35:16 +03:00
Kevin Klues
7eccc71c9e Rename 'preferred' TopologyManager policy to 'best-effort' 2019-07-25 10:44:36 +02:00
Kubernetes Prow Robot
5b496fe8f5 Merge pull request #80315 from klueska/upstream-cleanup-socketmask 
Cleanup the TopologyManager socketmask abstraction
 2019-07-23 11:40:28 -07:00
Kevin Klues
65b07312b0 Cleanup comments in TopologyManager socketmask abstraction 2019-07-18 18:52:19 -07:00
Kevin Klues
0edfd4be35 Add package level And/Or calls to TopologyManager socketmask abstraction 2019-07-18 09:06:51 -07:00
Kevin Klues
434fd34e0b Add NewEmtpySocketMask() call to TopologyManager socketmask abstraction 2019-07-18 09:05:55 -07:00
Kevin Klues
4ee5d5409e Update the topologymanager to error out if an invalid policy is given 
Previously, the topologymanager would simply fall back to the None() policy
if an invalid policy was specified. This patch updates this to return an
error when an invalid policy is passed, forcing the kubelet to fail
fast when this occurs.

These semantics should be preferable because an invalid policy likely
indicates operator error in setting the policy flag on the kubelet
correctly (e.g. misspelling 'strict' as 'striict'). In this case it is
better to fail fast so the operator can detect this and correct the
mistake, than to mask the error and essentially disable the
topologymanager unexpectedly.
 2019-07-18 13:24:09 +02:00
Kubernetes Prow Robot
1125054612 Merge pull request #80235 from moshe010/remove_string 
Remove unnecessary string() from policy_none
 2019-07-17 19:34:49 -07:00
Louise Daly
9d7e31e66e Topology Manager Implementation based on Interfaces 
Co-authored-by: Kevin Klues <kklues@nvidia.com>
Co-authored-by: Conor Nolan <conor.nolan@intel.com>
Co-authored-by: Sreemanti Ghosh <sreemanti.ghosh@intel.com>
 2019-07-17 02:30:21 +01:00
Moshe Levi
d52985d3a0 Remove unnecessary string() from policy_none 
Signed-off-by: Moshe Levi <moshele@mellanox.com>
 2019-07-17 01:58:43 +03:00
Kubernetes Prow Robot
4197adaf2d Merge pull request #79343 from nolancon/topology-manager-none 
Add Policy None for Topology Manager
 2019-07-16 13:22:47 -07:00
Kubernetes Prow Robot
d4d8daea73 Merge pull request #78558 from tedyu/policy-str 
Remove unnecessary string()
 2019-07-11 13:13:06 -07:00
nolancon
2d7ac702d6 Add Policy None for Topology Manager 
Update naming of test functions.
 2019-06-25 03:24:31 +01:00
Alexander Kanevskiy
89481f8c27 Use go standard library for common bit operations 
PR#72913 introduced own versions of the bit operations that are
less efficient than ones from standard library.
 2019-06-01 19:54:38 +03:00
Kubernetes Prow Robot
9ac58bae56 Merge pull request #78515 from klueska/upstream-socketmask-updates 
Updates to the SocketMask abstraction for the TopologyManager
 2019-06-01 09:50:16 -07:00
Kubernetes Prow Robot
46c74629cf Merge pull request #78516 from klueska/upstream-topology-manager-interface-updates 
Update the TopologyManager interfaces
 2019-06-01 08:00:19 -07:00
Ted Yu
1a755d13a6 Remove unnecessary string() 2019-05-30 19:48:26 -07:00
Kevin Klues
0a43d21c26 Add IsNarrowerThan() function to socketmask abstraction 2019-05-30 06:00:22 -07:00
Kevin Klues
617a1fa394 Update the TopologyManager interfaces 
These updates are based on discussions had about the preferred semantics
of the TopologyManager and will be reflected in changes to an upcoming
PR that adds the actual TopologyManager implementation.
 2019-05-30 05:52:11 -07:00
Kevin Klues
cdb59d3c7a Fix incorrect names for tests in socketmask 2019-05-30 04:16:53 -07:00
nolancon
0244c0e658 remove dependency on implementation from policy preferred and strict 
update build
 2019-05-30 05:57:39 +01:00
nolancon
ef9baf313d Update unit tests for TopologyHints - Topology Manager Policies 2019-05-30 05:44:01 +01:00
nolancon
e82fa41fb2 More Intuitive TopologyHints - topology manager policies 2019-05-30 05:44:01 +01:00
Sreemanti Ghosh
4e503597b8 Unit test for Topology Manager policy_strict and policy_preferred 2019-05-30 05:44:01 +01:00
nolancon
eff568e496 Add Policies Strict and Preferred for Topology Manager 2019-05-30 05:44:01 +01:00
lmdaly
c1a4457573 Update Bazel files to include SocketMask 2019-05-29 02:21:51 +01:00
Conor Nolan
d99bac12e6 Update Remove/AddPod to Container (#26) 
More intuitive TopologyHints
 2019-05-29 02:11:15 +01:00
lmdaly
e64c558a11 Added BUILD files and updates to Boilerplates 2019-05-29 02:11:15 +01:00
lmdaly
71bbc6d538 Add Topology Manager Interfaces 
*Topology Manager
*Policy
 2019-05-29 02:10:46 +01:00
nolancon
b7f6b8f8f1 Updated unit test for socketmask 2019-05-28 05:00:04 +01:00
nolancon
283dff9335 Update SocketMask based on feedback 
TODO: Unit tests to be updated
 2019-05-27 07:19:03 +01:00
nolancon
e8566caa3f Update to unit test and comment bug fixed 2019-05-13 06:41:44 +01:00
nolancon
7c525ffaa8 More intuitive TopologyHints - socketmask.go 2019-05-08 04:22:39 +01:00
Sreemanti-Ghosh
ce56956409 Socket mask unit test (#4) 2019-03-05 08:00:04 +00:00
nolancon
a273333f1f Add BUILD files and Boilerplates 
Updates based on comments
* Export comments added
* glog changed to klog
* Other small edits
 2019-03-05 07:59:51 +00:00
nolancon
f10e76962f Add Socket Mask for Topology Manager 2019-03-01 07:20:47 +00:00