Commit Graph

2392 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
cf535b0339 Merge pull request #104866 from zzchun/fix-typo-in-framework-interface
fix typo in framework interface
2021-09-10 06:46:01 -07:00
zzchun
3ad158d62c fix typo in framework interface
Signed-off-by: zzchun <zzchun@zju.edu.cn>
2021-09-10 10:14:21 +08:00
Kubernetes Prow Robot
c0c7039f3a Merge pull request #103751 from y-tag/approx-float64
fix AsApproximateFloat64() for BinarySI
2021-09-09 08:22:11 -07:00
Wei Huang
c2e9305173 Revert PR 103515 2021-09-08 13:23:30 -07:00
Kubernetes Prow Robot
5be7bb413d Merge pull request #104805 from chendave/typos
Fix couple of incorrect description
2021-09-08 07:43:21 -07:00
Kubernetes Prow Robot
3282d6cfdb Merge pull request #103515 from muma378/feature/verbose-node-scores
Add verbose logs for node/plugin scores even ranged in low levels
2021-09-07 21:21:22 -07:00
Dave Chen
6e1835b83b Fix couple of incorrect description
Signed-off-by: Dave Chen <dave.chen@arm.com>
2021-09-08 10:08:23 +08:00
Kubernetes Prow Robot
b12379ef1c Merge pull request #104605 from pohly/ephemeral-volume-events
scheduler: more informative generic ephemeral volume events
2021-09-03 17:51:19 -07:00
Clayton Coleman
2d7a9160a6 Additional resource quantity testing
Fractional binary SI quantities that cannot be represented as decimal
internally were incorrectly calculated.
2021-09-04 09:45:38 +09:00
Dave Chen
62b0579a40 Fix the key missing issue for structured log
Signed-off-by: Dave Chen <dave.chen@arm.com>
2021-09-01 10:43:10 +08:00
zc
b33897f36d modify non-uniform aliases 2021-08-31 09:07:51 +08:00
Kubernetes Prow Robot
7282c2002e Merge pull request #99273 from yangjunmyfm192085/run-test20
Structured Logging migration:modify Scheduler part logs.
2021-08-30 05:56:54 -07:00
Patrick Ohly
89cb4d0ee9 scheduler: better reason for delay with generic ephemeral volumes
These events are currently emitted for a pod using a generic ephemeral volume:

  Type     Reason            Age   From               Message
  ----     ------            ----  ----               -------
  Warning  FailedScheduling  3s    default-scheduler  0/1 nodes are available: 1 persistentvolumeclaim "my-csi-app-inline-volume-my-csi-volume" not found.
  Warning  FailedScheduling  2s    default-scheduler  0/1 nodes are available: 1 pod has unbound immediate PersistentVolumeClaims.

The one about "persistentvolumeclaim not found" is potentially confusing. It
occurs because the scheduler typically checks the pod before the ephemeral
volume controller had a chance to create the PVC.

This is a bit easier to understand:

  Type     Reason            Age   From               Message
  ----     ------            ----  ----               -------
  Warning  FailedScheduling  4s    default-scheduler  0/1 nodes are available: 1 waiting for ephemeral volume controller to create the persistentvolumeclaim "my-csi-app-inline-volume-my-csi-volume".
  Warning  FailedScheduling  2s    default-scheduler  0/1 nodes are available: 1 pod has unbound immediate PersistentVolumeClaims.
2021-08-30 10:06:59 +02:00
JunYang
93047824f7 Structured Logging migration:modify Scheduler part logs.
Signed-off-by: JunYang <yang.jun22@zte.com.cn>
2021-08-29 20:17:08 +08:00
Kubernetes Prow Robot
909c3db3ab Merge pull request #104559 from Huang-Wei/cleanup-json-tag
sched: remove unneeded json tags in unversioned API objs
2021-08-27 18:38:52 -07:00
Kubernetes Prow Robot
296991f697 Merge pull request #104518 from dntosas/scheduler-remove-deprecated-metric
[scheduler] Remove deprecated volumeSchedulingLatency metric
2021-08-25 03:08:39 -07:00
Wei Huang
2c3a196aa4 sched: remove unneeded json tags in unversioned API objs 2021-08-24 15:47:34 -07:00
Stephen Augustus
481cf6fbe7 generated: Run hack/update-gofmt.sh
Signed-off-by: Stephen Augustus <foo@auggie.dev>
2021-08-24 15:47:49 -04:00
sanposhiho
b7dd0a7660 Clean up: delete NumUnschedulablePods because it's no longer in use 2021-08-24 17:34:05 +09:00
dntosas
cd795fa2eb [scheduler] Remove deprecated volumeSchedulingLatency metric
As part of https://github.com/kubernetes/kubernetes/pull/100720 we
backported fix on existing releases and in this commit we completely
remove the deprecated metric from master branch.

Signed-off-by: dntosas <ntosas@gmail.com>
2021-08-23 15:18:16 +03:00
Antonio Ojea
0cd75e8fec run hack/update-netparse-cve.sh 2021-08-20 10:42:09 +02:00
Kubernetes Prow Robot
df51e4e63e Merge pull request #100720 from dntosas/scheduler-metrics-fix-buckets
[volumeScheduling/metrics] Fix buckets initialization
2021-08-19 18:47:24 -07:00
dntosas
7cbac6bde0 [volumeScheduling/metrics] Fix buckets initialization
This metrics is measured in seconds so it makes no sense starting from
1000 as init value. This breaks also the scheduler e2e metric thus make
users unable to compute, for example, their SLO for the scheduler.
Even if this metric is deprecated, it should behave correctly until it is
completely removed to avoid user confusion.

For example, for each volume created, the minimum value exposed
as a metric is 16.6min (1000sec/60) which is obviously wrong as logic.

In this commit, we migrate bucket creation to start from reasonable
numbers, copying the incrementation from the conventions that the
scheduler follows itself.

Signed-off-by: dntosas <ntosas@gmail.com>
2021-08-17 12:49:40 +03:00
Jordan Liggitt
87a4e082ac Change defaulter-gen input to package path 2021-08-14 11:00:18 -04:00
Konstantin Misyutin
29bd66d018 Remove "pkg/controller/volume/scheduling" dependency from "pkg/scheduler/framework/plugins"
All dependencies of VolumeBinding plugin from
"k8s.io/kubernetes/pkg/controller/volume/scheduling" package moved to
"k8s.io/kubernetes/pkg/scheduler/framework/plugins/volumebinding" package:

- whole file pkg/controller/volume/scheduling/scheduler_assume_cache.go
- whole file pkg/controller/volume/scheduling/scheduler_assume_cache_test.go
- whole file pkg/controller/volume/scheduling/scheduler_binder.go
- whole file pkg/controller/volume/scheduling/scheduler_binder_fake.go
- whole file pkg/controller/volume/scheduling/scheduler_binder_test.go

Package "k8s.io/kubernetes/pkg/controller/volume/scheduling/metrics" moved
to "k8s.io/kubernetes/pkg/scheduler/framework/plugins/volumebinding/metrics"
because it only used in VolumeBinding plugin and (e2e) tests.

More described in issue #89930 and PR #102953.

Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com>
2021-08-13 19:08:45 +08:00
Kubernetes Prow Robot
27b02a3e37 Merge pull request #104030 from chendave/refactoring_new
Refactor defaultpreemption for out-of-tree plugins
2021-08-11 18:38:00 -07:00
Dave Chen
3af26bae2c Refactor defaultpreemption for out-of-tree plugins
Signed-off-by: Dave Chen <dave.chen@arm.com>
2021-08-11 09:29:17 +08:00
Wei Huang
dc079acc2b sched: retry unschedule pods immediately after a waiting pod's deletion 2021-08-06 19:08:37 -07:00
Kubernetes Prow Robot
fcefb0bc2a Merge pull request #104158 from mamil/modify-func-notes
make notes more easily to understand
2021-08-06 01:21:19 -07:00
raymonder jin
b66d52f6a8 make notes more easily to understand 2021-08-06 09:03:23 +08:00
Kubernetes Prow Robot
18d9ea39af Merge pull request #103832 from yuanchen8911/patch-4
Fix a typo in comment
2021-08-05 06:09:22 -07:00
Kubernetes Prow Robot
2d08fd4f56 Merge pull request #103864 from yuanchen8911/master
Fix inaccurate comments in scheduler_queue.go
2021-08-05 01:45:15 -07:00
Kubernetes Prow Robot
6fb005d4d4 Merge pull request #103792 from lixiaobing1/activeQ5
fix typo scheduling queue to active queue
2021-08-05 01:43:50 -07:00
Kubernetes Prow Robot
3ee63b09b7 Merge pull request #103775 from jyz0309/optimze
Optimize the for range code in types.go
2021-08-04 22:12:53 -07:00
Kubernetes Prow Robot
33778cb2ba Merge pull request #103757 from sanposhiho/fix/scheduler/framework/add-doc-on-status-reason
Add: specify that reason is a field to record the reason why failed
2021-08-04 22:12:46 -07:00
Kubernetes Prow Robot
b16f7e841d Merge pull request #103686 from kerthcet/document/add_comment_for_enqueueExtensions
update comment with EnqueueExtensions
2021-08-04 22:11:48 -07:00
Kubernetes Prow Robot
9561e24413 Merge pull request #103653 from boenn/NominatedPodsForNode
add pods copy in NominatedPodsForNode and update test case
2021-08-04 22:11:15 -07:00
Xiao Yang
144f25afb5 Refactor the structure nodeScoreHeap 2021-07-28 14:48:12 +08:00
houjun
8dc091ef2e Fix wrong log 2021-07-26 11:38:02 +08:00
Yuan Chen
00e31ce565 Fix incorrect comments in scheduler_queue.go 2021-07-22 20:57:21 -07:00
Yuan Chen
971e0c4400 Fix a typo in comment 2021-07-21 16:19:22 -07:00
sanposhiho
6680368958 Add: specify that reason is a field to record the reason why failed 2021-07-20 20:33:40 +09:00
lixiaobing1
51e4694cd6 fix typo scheduling queue to active queue 2021-07-20 14:01:35 +08:00
jyz0309
d05b232afc optimize the code
Signed-off-by: jyz0309 <45495947@qq.com>
2021-07-20 09:16:14 +08:00
boenn
1980b18c45 Solved the test problem and added update comment 2021-07-16 10:57:23 +08:00
kerthcet
d1e9da9f8a update comment with EnqueueExtensions
Signed-off-by: kerthcet <kerthcet@gmail.com>

update comment with EnqueueExtensions

Signed-off-by: kerthcet <kerthcet@gmail.com>

update comment with EnqueueExtensions

Signed-off-by: kerthcet <kerthcet@gmail.com>

update comment with EnqueueExtensions

Signed-off-by: kerthcet <kerthcet@gmail.com>
2021-07-16 09:56:26 +08:00
Kubernetes Prow Robot
2423813207 Merge pull request #103573 from chendave/fix_index
Fix index out of range if multiple default plugins are overridden
2021-07-09 08:43:23 -07:00
Dave Chen
1727cea64c Fix index out of range if multiple default plugins are overridden
Signed-off-by: Dave Chen <dave.chen@arm.com>
2021-07-09 19:56:14 +08:00
boenn
369c4a2b98 Use cmp.Diff() replace reflect and diagnosis 2021-07-08 15:13:11 +08:00
Wei Huang
fb9cafc99b sched: provide an option for plugin developers to move pods to activeQ 2021-07-07 12:50:12 -07:00