github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
84,544 Commits 1 Branch 31 Tags
d410bd28c371fbb8c9b07feb8c4bc1fef018173f
Commit Graph

2736 Commits

Author SHA1 Message Date
Clayton Coleman
49250c6efc Make container create, start, and stop events consistent 
The messages for container lifecycle events are subtly inconsistent
and should be unified.

First, the field format for containers is hard to parse for a human,
so include the container name directly in the message for create
and start, and for kill remove the container runtime prefix.

Second, the pulling image event has inconsistent capitalization, fix
that to be sentence without punctuation.

Third, the kill container event was unnecessarily wordy and inconsistent
with the create and start events. Make the following changes:

* Use 'Stopping' instead of 'Killing' since kill is usually reserved for
  when we decide to hard stop a container
* Send the event before we dispatch the prestop hook, since this is an
  "in-progress" style event vs a "already completed" type event
* Remove the 'cri-o://' / 'docker://' prefix by printing the container
  name instead of id (we already do that replacement at the lower level
  to prevent high cardinality events)
* Use 'message' instead of 'reason' as the argument name since this is a
  string for humans field, not a string for machines field
* Remove the hash values on the container spec changed event because no
  human will ever be able to do anything with the hash value
* Use 'Stopping container %s(, explanation)?' form without periods to
  follow event conventions

The end result is a more pleasant message for humans:

```
35m         Normal    Created                       Pod    Created container
35m         Normal    Started                       Pod    Started container
10m         Normal    Killing                       Pod    Killing container cri-o://installer:Need to kill Pod
10m         Normal    Pulling                       Pod    pulling image "registry.svc.ci.openshift.org/openshift/origin-v4.0-2019-02-10-172026@sha256:3da5303d4384d24691721c1cf2333584ba60e8f82c9e782f593623ce8f83ddc5"
```

becomes

```
35m         Normal    Created                       Pod    Created container installer
35m         Normal    Started                       Pod    Started container installer
10m         Normal    Killing                       Pod    Stopping container installer
10m         Normal    Pulling                       Pod    Pulling image "registry.svc.ci.openshift.org/openshift/origin-v4.0-2019-02-10-172026@sha256:3da5303d4384d24691721c1cf2333584ba60e8f82c9e782f593623ce8f83ddc5"
```
 2019-02-10 16:39:42 -05:00
Andrew Kim
a62ee8b0a9 clean up volume rounding functions and move to k8s.io/cloud-provider/volume 2019-02-09 01:16:55 -05:00
Andrew Kim
ca6a051b00 remove cloud provider dependencies to pkg/volume 
Co-authored-by: Weibin Lin <linweibin1@huawei.com>
 2019-02-09 01:16:55 -05:00
Kubernetes Prow Robot
f0b72df47e Merge pull request #73789 from vladimirvivien/volume-plugin-can-attach 
AttachableVolumePlugin CanAttach() method for attachable check
 2019-02-08 09:06:17 -08:00
Kubernetes Prow Robot
b50c643be0 Merge pull request #73540 from rlenferink/patch-5 
Updated OWNERS files to include link to docs
 2019-02-08 09:05:56 -08:00
Vladimir Vivien
0a653b3b80 Adds method CanAttach() to check plugin attachability 2019-02-08 08:04:15 -05:00
Kubernetes Prow Robot
eac19a3ab9 Merge pull request #73616 from dims/move-part-of-kubelet-apis-well-known-lables 
move pkg/kubelet/apis/well_known_labels.go to staging/src/k8s.io/api/core/v1/
 2019-02-07 19:44:34 -08:00
Kubernetes Prow Robot
6fc9a72f58 Merge pull request #73533 from babiel/fix-fsgroup-directory-permissions 
Ensure directories are executable for fsGroup
 2019-02-06 20:03:01 -08:00
Kubernetes Prow Robot
4bbad05972 Merge pull request #73391 from qingsenLi/k8s190128 
fix some typos in /pkg/volume
 2019-02-06 13:23:51 -08:00
Kubernetes Prow Robot
2d956389dc Merge pull request #73313 from pivotal-k8s/csi-drivers-list 
Refactor csiDriversStore
 2019-02-06 09:31:06 -08:00
Kubernetes Prow Robot
f3a6dbceb2 Merge pull request #68925 from casusbelli/fix_65312 
Adding Quobyte Tenant to QuobyteVolumeSource to enable deletion of persistent volumes
 2019-02-05 12:08:37 -08:00
Davanum Srinivas
cf44bfa556 Move LabelMultiZoneDelimiter to pkg/volume/util 
Change-Id: I098b210e44ac3bb1901e029ff7cd33aa0afbdc74
 2019-02-05 13:39:07 -05:00
Davanum Srinivas
b975573385 move pkg/kubelet/apis/well_known_labels.go to staging/src/k8s.io/api/core/v1/ 
Co-Authored-By: Weibin Lin <linweibin1@huawei.com>

Change-Id: I163b2f2833e6b8767f72e2c815dcacd0f4e504ea
 2019-02-05 13:39:07 -05:00
Roy Lenferink
b43c04452f Updated OWNERS files to include link to docs 2019-02-04 22:33:12 +01:00
Kubernetes Prow Robot
c953daa3bc Merge pull request #73604 from andrewsykim/gce-features 
move GCERegionalPersistentDisk feature to k8s.io/cloud-provider/features
 2019-02-01 17:14:36 -08:00
Andrew Kim
8be7963797 move GCERegionalPersistentDisk feature to k8s.io/cloud-provider 2019-01-31 15:19:52 -05:00
Kubernetes Prow Robot
8f1082c6af Merge pull request #73455 from danielqsj/keymutex 
Migrate to k8s.io/utils/keymutex and k8s.io/utils/strings
 2019-01-31 09:56:19 -08:00
Kubernetes Prow Robot
9487d37666 Merge pull request #72873 from taragu/exponential-backoff-plugin-registration 
Add exponential backoff for plugin registration
 2019-01-31 08:07:12 -08:00
danielqsj
cf1fb8a1cd fix format issue 2019-01-31 22:01:13 +08:00
Daniel (Shijun) Qian
e72b32558c Merge branch 'master' into keymutex 2019-01-31 20:50:57 +08:00
Kubernetes Prow Robot
1f7e9fd9a2 Merge pull request #73488 from andrewsykim/replace-utils-file 
Replace pkg/util/file with k8s.io/utils/path
 2019-01-30 17:50:16 -08:00
Maximilian Gaß
7a9f21bbb8 Ensure directories are executable for fsGroup 2019-01-30 18:07:38 +01:00
danielqsj
657a1a1a34 change import alias of utils/strings 2019-01-30 10:44:09 +08:00
danielqsj
093328e57f migrate to k8s.io/utils/strings 2019-01-30 10:24:00 +08:00
danielqsj
1add6b0cfa migrate to k8s.io/utils/keymutex 2019-01-30 10:23:59 +08:00
Tara Gu
1f822030a4 Correct error message 2019-01-29 21:14:26 -05:00
Tara Gu
ad4bd8bdac Add exponential backoff for plugin registration 2019-01-29 21:13:02 -05:00
Kubernetes Prow Robot
53ee46f9a9 Merge pull request #72201 from nmiculinic/secret_key 
Print non-existent key reference in the secret
 2019-01-29 12:49:39 -08:00
Andrew Kim
84191eb99b replace pkg/util/file with k8s.io/utils/path 2019-01-29 15:20:13 -05:00
Kubernetes Prow Robot
cc1be28943 Merge pull request #72624 from danielqsj/clean_unmount 
Cleanup callers of deprecated functions in volume/util
 2019-01-28 23:06:20 -08:00
Sunny
835183ad50 Add AttachDevice() to attach the device to a host 
AttachDevice() ensures that the volume device is attached to the
host before they are used.
 2019-01-28 22:58:07 +05:30
Sunny
a4cc754fb4 StorageOS update api library 2019-01-28 22:57:58 +05:30
qingsenLi
4b25a4fd93 fix some typos in /pkg/volume 2019-01-28 23:17:48 +08:00
Hannes Hörl
84c46629c5 Refactor to use new csi.DriversList & csi.Driver 2019-01-25 12:23:28 +00:00
Hannes Hörl
96aa4fb5d2 Implement DriversStore as a struct 
This allows us to hide
- the mutex handling
- the initialization
as implementation details.

Signed-off-by: Maria Ntalla <mntalla@pivotal.io>
 2019-01-25 12:23:15 +00:00
Masaki Kimura
732eb69597 Fix AWS driver fails to provision specified fsType 2019-01-23 05:17:06 +00:00
Silvan Kaiser
cc71b0aebd Adding Tenant to QuobyteVolumeSource 
Adds the tenant id to the QuobyteVolumeSource type and
updates the quobyte api client to support looking up
volume ids.
 2019-01-22 14:42:12 +01:00
Kubernetes Prow Robot
54c4428eb4 Merge pull request #71276 from jingxu97/Oct/uncertain 
Handle failed attach operation leave uncertain volume attach state
 2019-01-17 22:52:57 -08:00
Kubernetes Prow Robot
7f0e04a089 Merge pull request #73043 from davidz627/feature/migrationCommon 
Add common functionality required for all in-tree to CSI Migration shim code pieces
 2019-01-17 18:55:10 -08:00
David Zhu
384fce6bb1 Common Migration shim functaionality and flags 2019-01-17 14:43:59 -08:00
David Zhu
d8c9dc5bb5 Add IsMigratableToCSI to volume plugin interface 2019-01-17 14:43:52 -08:00
Kubernetes Prow Robot
493d3565d8 Merge pull request #72874 from humblec/iscsi 
Update approver list.
 2019-01-17 13:51:35 -08:00
Kubernetes Prow Robot
d6b7409103 Merge pull request #72980 from gnufied/cinder-pod-volumes 
Add Cinder Max Volume Limit
 2019-01-16 13:32:32 -08:00
Hemant Kumar
727b3097f9 Do not make Cinder Max volume predicate a default 2019-01-16 15:17:05 -05:00
Mike McRill
a88d1d3dcc Add Cinder Max Volume Limit 
Also add place holder support for reporting limits from node.
 2019-01-16 13:46:28 -05:00
Kubernetes Prow Robot
ce19aad22b Merge pull request #70527 from qingsenLi/git181101 
remove repetitive word in annotation
 2019-01-15 20:19:09 -08:00
Humble Chirammal
a5c5502d23 Update approver list. 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
 2019-01-14 11:45:26 +05:30
hchiramm
86761e524a Update volume plugin reviewers. 
Signed-off-by: hchiramm <hchiramm@redhat.com>
 2019-01-12 09:47:17 +05:30
Justin SB
dd19b923b7 Remove executable file permission from OWNERS files 2019-01-11 16:42:59 -08:00
Jing Xu
7bac6ca73a Address comments 
This commit addressed the comment and also add a unit test.
 2019-01-11 10:57:37 -08:00