Commit Graph

8199 Commits

Author SHA1 Message Date
gkarthiks
a4abc1dd4d refactor(golint): lint fixes for iptables test file
Signed-off-by: gkarthiks <github.gkarthiks@gmail.com>
2019-11-22 19:58:56 -08:00
Kubernetes Prow Robot
1900edf44a
Merge pull request #85440 from gkarthiks/master
Fix lint in /pkg/util/iptables
2019-11-22 17:31:31 -08:00
Guinevere Saenger
81d0007716 Hi San Diego (#85424)
* removed -staging/src/k8s.io/apimachinery/pkg/util/clock for golint failures

* first few code comments are done

* add correct comments for all packages
2019-11-22 17:31:13 -08:00
Ruben
55c83e3397 Fix golint issues in pkg/kubelet/events/event.go
Change the single const statement in favor of multiple const event lists.
This way we don't need to put the name of the constant in the comment
and it's clearer that the comment refers to the whole list.
2019-11-19 13:15:08 +01:00
Karthikeyan Govindaraj
1f4cd65be5
chore(lint): removing the iptables pkg 2019-11-18 23:49:34 -08:00
Travis Rhoden
0c5c3d8bb9
Remove pkg/util/mount (moved out of tree)
This patch removes pkg/util/mount completely, and replaces it with the
mount package now located at k8s.io/utils/mount. The code found at
k8s.io/utils/mount was moved there from pkg/util/mount, so the code is
identical, just no longer in-tree to k/k.
2019-11-15 08:29:12 -07:00
tanjunchen
7420faab43 fix-staticcheck in /test/e2e/windows 2019-11-15 09:45:43 +08:00
Kubernetes Prow Robot
bfb99d809a
Merge pull request #85117 from hwdef/fix-staticcheck10
pkg/kubeapiserver: fix staticcheck warning
2019-11-14 13:31:15 -08:00
Kubernetes Prow Robot
5c772f5933
Merge pull request #84674 from hwdef/fix-staticcheck4
pkg/client: fix staticcheck warning
2019-11-14 13:30:45 -08:00
hwdef
b3377e61de pkg/kubeapiserver: fix staticcheck warning 2019-11-14 11:24:22 +08:00
hwdef
82b9cf1890 pkg/client: fix staticcheck warning 2019-11-14 10:08:16 +08:00
Kubernetes Prow Robot
64f4be5b32
Merge pull request #84390 from robscott/endpointslice-beta
Promoting EndpointSlices to beta
2019-11-13 17:27:50 -08:00
Kubernetes Prow Robot
8af6906d1f
Merge pull request #85220 from liggitt/revert-licenses
Revert #76586, restructure LICENSES file generation
2019-11-13 14:52:11 -08:00
Kubernetes Prow Robot
d85103b185
Merge pull request #85217 from kaoskater08/kaoskater08/fix-golint-pkg-apis-extensions
fixed golint errors in pkg/apis/extensions register.go and types.go
2019-11-13 14:51:46 -08:00
Rob Scott
a7e589a8c6
Promoting EndpointSlices to beta 2019-11-13 14:20:19 -08:00
Kubernetes Prow Robot
f501d8e59a
Merge pull request #85138 from liggitt/webhook-config-v1
Promote apiserver.config.k8s.io/v1, kind=WebhookAdmissionConfiguration
2019-11-13 13:03:54 -08:00
Kubernetes Prow Robot
195664db0e
Merge pull request #85099 from liggitt/quota-config-v1
Promote apiserver.config.k8s.io/v1, kind=ResourceQuotaConfiguration
2019-11-13 13:02:52 -08:00
Kubernetes Prow Robot
b49afbfa64
Merge pull request #85098 from liggitt/admission-config-v1
Promote apiserver.config.k8s.io/v1, kind=AdmissionConfiguration
2019-11-13 13:02:40 -08:00
Kubernetes Prow Robot
6eb2f25247
Merge pull request #85075 from hwdef/fix-staticcheck9
pkg/credentialprovider: fix staticcheck warning
2019-11-13 09:27:18 -08:00
Jordan Liggitt
cd4474ae4f Revert "76093 restructure LICENSES file generation"
This reverts commit d39ac98cc5.
2019-11-13 10:24:32 -05:00
Eddie Hale
566484366e fixed golint errors in pkg/apis/extensions register.go and types.go 2019-11-13 08:48:42 -06:00
Chin-Ya Huang
92c7e8e802 Fix golint failures
* Remove pkg/registry/apps/replicaset

Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
2019-11-13 11:00:12 +08:00
Ji Shan Xing
d39ac98cc5 76093 restructure LICENSES file generation 2019-11-12 20:38:57 -05:00
Kubernetes Prow Robot
36373b37fd
Merge pull request #84672 from hwdef/fix-staticcheck2
cmd:fix staticcheck warning
2019-11-12 09:06:06 -08:00
Jordan Liggitt
71fad812ca Promote WebhookAdmissionConfiguration to v1 2019-11-12 09:56:58 -05:00
Jordan Liggitt
1234290adf AdmissionConfiguration v1 2019-11-12 09:05:50 -05:00
Jordan Liggitt
7d3012f297 Promote resource quota admission configuration to v1 2019-11-12 09:03:55 -05:00
Kubernetes Prow Robot
897ce3073c
Merge pull request #84533 from davidz627/fix/deprecatedPath
Remove plugin watching of deprecated directory and CSI v0 support in accordance with deprecation policy
2019-11-12 04:48:20 -08:00
toyoda
e99a325d4e Fix shellcheck failure in log-dump/log-dump.sh 2019-11-12 16:51:09 +09:00
David Zhu
802fe12803 Remove plugin watching of deprecated directory {kubelet_root_dir}/plugins and support for CSI V0 in accordance with deprecation announcement in https://v1-13.docs.kubernetes.io/docs/setup/release/notes/ 2019-11-11 11:42:58 -08:00
Roy Hvaara
896f84b652
Fix golint issues in pkg/apis/batch/validation 2019-11-11 04:03:34 +01:00
Clayton Coleman
c416ee584c
Remove deprecated-dynamic client
It is now unused.
2019-11-10 21:30:30 -05:00
hwdef
170eadc3d2 pkg/credentialprovider: fix staticcheck warning 2019-11-11 09:46:52 +08:00
Kubernetes Prow Robot
35cfd327c8
Merge pull request #84243 from Dingshujie/fix-golint
Fix golint errors in pkg/apis/apps
2019-11-10 16:29:54 -08:00
Kubernetes Prow Robot
ebbe4baf13
Merge pull request #83914 from guineveresaenger/ato-demo
Removes pkg/registry/core/secret/storage from golint failures
2019-11-10 16:29:41 -08:00
Kubernetes Prow Robot
a18303dfa4
Merge pull request #85042 from hvaara/fix-golint-pkg-apis-policy
Fix golint issues in pkg/apis/policy
2019-11-09 15:29:58 -08:00
Kubernetes Prow Robot
80b25a766a
Merge pull request #85037 from hvaara/fix-golint-pkg-apis-authorization
Fix golint issues in pkg/apis/authorization
2019-11-09 15:29:48 -08:00
Roy Hvaara
cfc34712c2
Fix golint issues in pkg/registry/.../storage 2019-11-10 00:22:51 +01:00
Roy Hvaara
cfc596b302 Fix golint issues in pkg/apis/autoscaling/validation (#85041)
* Fix golint issues in pkg/apis/autoscaling/validation

* Fix spelling issue in field of Error
2019-11-09 14:03:48 -08:00
Kubernetes Prow Robot
a258243f4c
Merge pull request #85009 from oomichi/enable-verify-import-aliases
Enable verify-import-aliases check in CI
2019-11-09 12:23:39 -08:00
Roy Hvaara
10c8508acd
Fix golint issues in pkg/apis/policy 2019-11-09 21:15:35 +01:00
Roy Hvaara
8d3c74aebc
Fix golint issues in pkg/apis/authorization 2019-11-09 17:45:37 +01:00
Kubernetes Prow Robot
b15dfd778a
Merge pull request #84708 from yue9944882/feat/flowcontrol-storage
Feature: Flowcontrol rest storage implementation
2019-11-08 18:44:09 -08:00
Kubernetes Prow Robot
e4fdb82c01
Merge pull request #84302 from serathius/restrict-prometheus-import
Restrict visibility of prometheus packages
2019-11-08 13:48:26 -08:00
Kenichi Omichi
1b165fc440 Enable verify-import-aliases check in CI
To block violation of import-aliases rule, this enables
verify-import-aliases in CI system.
2019-11-08 19:17:39 +00:00
yue9944882
3d1b5d0e9a flowcontrol rest storage implementation 2019-11-08 14:27:14 +08:00
Kubernetes Prow Robot
e445d4d779
Merge pull request #84871 from liggitt/cmd-test
Make test-cmd effective again
2019-11-07 13:28:21 -08:00
Kubernetes Prow Robot
7a1eaa112e
Merge pull request #84696 from dims/BenTheElder-byebyehacke2e
Remove hack/e2e.go
2019-11-07 09:05:04 -08:00
Kubernetes Prow Robot
0a46e374dc
Merge pull request #84772 from hvaara/golint-failures-support-comments
Support comments in hack/.golint_failures
2019-11-07 04:36:17 -08:00
Kubernetes Prow Robot
41a70bcc0a
Merge pull request #84750 from hvaara/fix-golint-test-e2e_kubeadm
Fix golint issues in test/e2e_kubeadm
2019-11-07 04:36:07 -08:00
Kubernetes Prow Robot
1183771545
Merge pull request #84748 from hvaara/fix-golint-controller-volume-persistentvolume-options
Fix golint issues in pkg/controller/volume/persistentvolume/options
2019-11-07 04:35:53 -08:00
Marek Siarkowicz
e7d5659943 Restrict visibility of prometheus to enforce usage of k8s.io/component-base/metrics 2019-11-07 09:12:55 +01:00
Jordan Liggitt
1678f42970 Fix run_kubectl_sort_by_tests 2019-11-07 02:26:45 -05:00
Jordan Liggitt
59dfac587f Fix assert methods 2019-11-07 02:26:45 -05:00
Jordan Liggitt
9f30c783bc bump kazel, bazel, gazelle
hack/pin-dependency.sh k8s.io/repo-infra v0.0.1-alpha.1
To fix non-idempotent BUILD file generation

hack/pin-dependency.sh github.com/bazelbuild/bazel-gazelle v0.19.0
hack/pin-dependench.sh github.com/bazelbuild/buildtools 0.29.0
for go1.13.3 support

hack/lint-dependencies.sh

hack/pin-dependency.sh github.com/bazelbuild/buildtools v0.0.0-20190917191645-69366ca98f89
to pick up preferred version for repo-infra
2019-11-06 17:39:05 -05:00
Jordan Liggitt
e3ff39ffa0 Update build to go1.13.4 2019-11-06 17:39:05 -05:00
Jordan Liggitt
ee2b887c74 Fix hack/pin-dependency.sh for go1.13 2019-11-06 17:39:05 -05:00
Jordan Liggitt
8618c09369 opt out of module mode for builds 2019-11-06 17:39:05 -05:00
Roy Hvaara
e16ee0b68e
Support comments in hack/.golint_failures 2019-11-05 22:59:42 +01:00
Kubernetes Prow Robot
8245a24c37
Merge pull request #84761 from thockin/make-better-find-filter
Build: Use a better filter on find
2019-11-05 11:44:54 -08:00
feifei.zhang@huawei.com
fdce8ef960 fix golint failures of pkg/security/apparmor 2019-11-05 18:56:15 +08:00
Tim Hockin
a1ad4910dc Build: Use a better filter on find
In case the _workspace directory exists, filter it out.
2019-11-04 21:00:58 -08:00
Roy Hvaara
a9ed936792
Fix golint issues in test/e2e_kubeadm 2019-11-04 23:20:24 +01:00
Roy Hvaara
dffcf7c8cd
Fix golint issues in pkg/controller/volume/persistentvolume/options 2019-11-04 21:45:21 +01:00
Kubernetes Prow Robot
7b6369c803
Merge pull request #84249 from odinuge/bump-shellcheck
Bump shellcheck to v0.7.0
2019-11-04 06:19:40 -08:00
Benjamin Elder
83c56a0373
remove hack/e2e.go 2019-11-03 19:36:59 -05:00
hwdef
5c6ed21d34 cmd:fix staticcheck warning 2019-11-03 00:00:54 +08:00
Kubernetes Prow Robot
510fb38f27
Merge pull request #83671 from yue9944882/flow-control-api-model
Apiserver flowcontrol api models
2019-11-01 22:49:40 -07:00
Kubernetes Prow Robot
df8706e60b
Merge pull request #84408 from mikedanese/cleanup
delete unused cache
2019-11-01 18:07:56 -07:00
Kubernetes Prow Robot
7341803597
Merge pull request #84593 from mm4tt/benchmark_dockerized_gopath
Don't use hardcoded /go GOPATH in benchmark-dockerized.sh
2019-10-31 07:39:37 -07:00
Matt Matejczyk
68aebb4899 Don't use hardcoded /go GOPATH in benchmark-dockerized.sh 2019-10-31 13:57:04 +01:00
Kubernetes Prow Robot
ecec5cb2a4
Merge pull request #84540 from seans3/kubectl-get-staging
Moves kubectl get subcommand to staging
2019-10-30 21:56:37 -07:00
Kubernetes Prow Robot
5e468a49de
Merge pull request #84478 from hvaara/fix-golint-pkg/credentialprovider/gcp
Fix golint issues in pkg/credentialprovider/gcp
2019-10-30 06:38:54 -07:00
Kubernetes Prow Robot
e1d3cc74e5
Merge pull request #84329 from jingyih/update_etcd_server_to_3.4
Update default etcd server to 3.4.3
2019-10-30 02:30:52 -07:00
Sean Sullivan
907e3d61ab Fixes staticcheck failures and golint failures 2019-10-29 17:50:23 -07:00
Kubernetes Prow Robot
f8b45a12f4
Merge pull request #84464 from wojtek-t/remove_conversion_funcs_1
Migrate couple manual conversions to the new AddConversionFunc() way
2019-10-29 15:39:07 -07:00
Mike Danese
0e69316bb3 delete unused cache
We aren't using this anywhere and it's not named properly for what it
is. We should either rename it or delete it (both break the package
API).
2019-10-29 14:40:48 -07:00
Jingyi Hu
ccf4caf30f Update etcd.sh to use v3 endpoint 2019-10-29 13:10:29 -07:00
Kubernetes Prow Robot
a8e819746d
Merge pull request #83442 from serathius/remove-prometheus-addon
Remove prometheus addon
2019-10-29 01:34:43 -07:00
yue9944882
7c28a4b70e non-generated api models misc
rule list

rule

rule 2
2019-10-29 12:26:12 +08:00
Jingyi Hu
706cde51c5 Update default etcd server to 3.4.3 2019-10-28 18:29:37 -07:00
Roy Hvaara
e40c473334
Fix golint errors in pkg/credentialprovider/gcp 2019-10-28 21:54:45 +01:00
wojtekt
32759d33bf Cleanup conversions 2019-10-28 21:14:20 +01:00
Kubernetes Prow Robot
2896fb0be8
Merge pull request #83711 from tanjunchen/fix-staticcheck-test/e2e/network
fix staticcheck failures in test/e2e/common directory
2019-10-26 02:23:22 -07:00
Kubernetes Prow Robot
df8587f99f
Merge pull request #84062 from seans3/tableprinter-move
Removes kubectl get dependency on Kubernetes core
2019-10-24 16:55:52 -07:00
Kubernetes Prow Robot
98442617cc
Merge pull request #81708 from RainbowMango/pr_fix_static_failure_for_code-generator
Fix static failure for package: staging/src/k8s.io/code-generator
2019-10-23 23:25:07 -07:00
Odin Ugedal
d467b8ea14
Fix shellcheck failures SC2128 2019-10-23 22:47:46 +02:00
Odin Ugedal
cce1f32ea5
Fix shellcheck failures SC2034 2019-10-23 22:47:46 +02:00
Odin Ugedal
65a66b9d7f
Bump shellcheck to v0.7.0
Changelog:
https://github.com/koalaman/shellcheck/blob/master/CHANGELOG.md

We have some new erros due to the version bump.

- SC2034: VARIABLE_XYZ appears unused. Verify use (or export if used externally).
    - Applies to all scripts we source in other scripts
- SC2039: In POSIX sh, set option pipefail is undefined.
    - Applies to files using it with "sh" instead of "bash" in the shebang
- SC2054: Use spaces, not commas, to separate array elements.
    - Fixing Should make no difference in the code
- SC2128: Expanding an array without an index only gives the first element.
    - Fixing Should make no difference in the code
- SC2251: This ! is not on a condition and skips errexit. Use `&& exit 1` instead, or make sure $? is checked.
    - Not 100% sure if we can swap to `&& exit 1`. Applies to a lot of
    test code.

All changes should be straight forward to fix, but will be done in a
separate PR.
2019-10-23 21:32:19 +02:00
DingShujie
171b486c34 Fix golint errors in pkg/apis/apps 2019-10-23 23:32:08 +08:00
Sean Sullivan
1b40a8849d Ignore staticcheck again for tableprinter.go 2019-10-22 23:45:08 -07:00
Kubernetes Prow Robot
75cd65ae0e
Merge pull request #82145 from shivi28/fix-controller-nodeipam-ipam-cidrset
nodeipam-controller:fix static check failures
2019-10-22 23:18:26 -07:00
Cristian Dima
a18de39166 fix golint errors in pkg/controller/service 2019-10-23 01:52:19 +03:00
ianlang
3359577d42 set default value of KUBE_MASTER_URL to empty 2019-10-22 10:08:55 +08:00
Kubernetes Prow Robot
c634276498
Merge pull request #83497 from pivotal-k8s/allow-custom-tags
Allow users to use custom tags
2019-10-20 22:17:37 -07:00
Kubernetes Prow Robot
ff7a09928b
Merge pull request #84070 from neolit123/1.17-remove-test-owners-ref
remove usage of the test/test_owners.* files
2019-10-19 02:13:36 -07:00
Kubernetes Prow Robot
b574074981
Merge pull request #84055 from odinuge/cherry_pick_indent
Fix indent in cherry_pick_pull script
2019-10-18 02:15:58 -07:00
Lubomir I. Ivanov
2c54160021 remove usage of the test/test_owners.* files
- remove update_owners.py; seems responsible for generating
test_owners files
- remove the existing test/test_owners.* files
- remove verify-test-owners.sh and references to it
2019-10-18 03:01:21 +03:00
Kubernetes Prow Robot
7ed388caa6
Merge pull request #83744 from neolit123/1.17-move-test-owners-sig-cl-gcp
test/e2e: move some tests from cluster-lifecycle to cloud-provider-gcp
2019-10-17 16:33:58 -07:00
Odin Ugedal
b840398be8
Fix indent in cherry_pick_pull script 2019-10-17 17:43:29 +02:00