kubernetes

github/kubernetes

Fork 0

Commit Graph

Author	SHA1	Message	Date
Kenichi Omichi	d5bc1ae8aa	Make the check strict to use ExpectNoError() As https://github.com/kubernetes/kubernetes/pull/78478 we can use ExpectNoError() instead of Expect(err).ToNot(HaveOccurred()) also. This makes the test code check strict to cover the above case and replaces the remaining in test/e2e/common/expansion.go	2019-06-18 16:55:16 +00:00
Kenichi Omichi	63e0507fd9	Check e2e test code to use ExpectError() We can use framework.ExpectError() for checking the expected error happens. However Expect(err).To(HaveOccurred()) can be used instead and that makes the e2e test code unreadable. This adds the check to use framework.ExpectError() for readable code.	2019-05-29 17:04:58 +00:00
Kenichi Omichi	496a18febc	Add hack/verify-test-code.sh This script checks coding style for test code. It is useful to enforce developers to use framework methods for keeping readable test code for example.	2019-05-22 14:15:25 +00:00

Author

SHA1

Message

Date

Kenichi Omichi

d5bc1ae8aa

Make the check strict to use ExpectNoError()

As https://github.com/kubernetes/kubernetes/pull/78478 we can use
ExpectNoError() instead of Expect(err).ToNot(HaveOccurred()) also.
This makes the test code check strict to cover the above case and
replaces the remaining in test/e2e/common/expansion.go

2019-06-18 16:55:16 +00:00

Kenichi Omichi

63e0507fd9

Check e2e test code to use ExpectError()

We can use framework.ExpectError() for checking the expected error
happens. However Expect(err).To(HaveOccurred()) can be used instead
and that makes the e2e test code unreadable.
This adds the check to use framework.ExpectError() for readable code.

2019-05-29 17:04:58 +00:00

Kenichi Omichi

496a18febc

Add hack/verify-test-code.sh

This script checks coding style for test code.
It is useful to enforce developers to use framework methods for
keeping readable test code for example.

2019-05-22 14:15:25 +00:00

3 Commits