Commit Graph

35 Commits

Author SHA1 Message Date
Eric Chiang
a1b310e004 pkg/probe/http: don't compare error strings in tests
TestHTTPProbeChecker fails on the Go1.7 release candidates. The
package's history show that this was the case for Go1.5 and Go1.6
as well.

The test depend on errors holding specific string values, behavior
not guarenteed in the standard library API, and causing new test
failures every minor Go release. Just look for an error rather than
trying to inspect it using string comparison. If we feel this
impacts coverage we can add more test cases.
2016-07-19 11:13:36 -07:00
Davanum Srinivas
2b0ed014b7 Use Go canonical import paths
Add canonical imports only in existing doc.go files.
https://golang.org/doc/go1.4#canonicalimports

Fixes #29014
2016-07-16 13:48:21 -04:00
David McMahon
ef0c9f0c5b Remove "All rights reserved" from all the headers. 2016-06-29 17:47:36 -07:00
zhouhaibing089
5923fd352e followup to add http server close method 2016-05-05 12:04:41 +08:00
zhouhaibing089
bf1a3f99c0 Uncomment the code that cause by #19254 2016-04-25 23:21:31 +08:00
Ed Robinson
55b1ae857c Allow setting the Host header in a httpGet probe
Fixes #24288
2016-04-15 01:59:42 +01:00
Joe Finney
bc791cbd4e Fix pkg/probe/http unit test for go 1.6. 2016-03-21 15:27:02 -07:00
Joe Finney
03043e4114 Fix pkg/probe/tcp unit test for go 1.6. 2016-03-21 15:27:01 -07:00
deads2k
ab03317d96 support CIDRs in NO_PROXY 2016-03-16 16:22:54 -04:00
Prashanth Balasubramanian
fcc7e99b83 Log response body when http probe fails. 2016-02-25 13:29:06 -08:00
Tim Hockin
7cab7bd472 fix a few go-vet errors 2016-02-09 13:20:31 -08:00
Rudi Chiarito
a2d1bb7acf Add httpHeaders to httpGet liveness probe
Also update existing documentation and try to steer users away from 'host'.
Add validation.
2016-02-05 11:20:04 -05:00
David Oppenheimer
8ac484793d Comment out calls to httptest.Server.Close() to work around
https://github.com/golang/go/issues/12262 . See #19254 for
more details. This change should be reverted when we upgrade
to Go 1.6.
2016-01-11 23:02:11 -08:00
Brendan Burns
07b3ab720d Improve error reporting a little in ingress e2e.
Also add Output() to the util/exec Cmd interface.
2016-01-06 15:25:04 -08:00
jiangyaoguo
cbbb3f7af0 return response StatusCode when http probe fail 2015-11-24 13:59:44 +08:00
Hongchao Deng
10cd7f5b7c testing: refactor TestTcpHealthChecker
- use host, port explicitly instead of usePort flag
- check error explicitly
- testing failure output formatting
- test struct naming
2015-11-04 14:54:41 -08:00
Hongchao Deng
65ab91d41c testing: fix TCP health checker failure on Mac
On Mac, error output looks like "nodename nor servname provided, or not known".
2015-11-04 14:54:41 -08:00
Yu-Ju Hong
80287e3430 Disable keep-alive for liveness/readiness probes
Keep-alive is often not useful for probing because kubelet checks many pods
with different addresses and ports. Disable keep-alive so prober does not
have to handle closed connections.
2015-10-15 14:21:27 -07:00
Daniel Martí
7aca60f636 Fix probe/tcp test on some systems
Depending on your system, the error might be "Servname not supported for
ai_socktype" instead of "unknown port". Accept both.

For example:
http://www.ducea.com/2006/09/11/error-servname-not-supported-for-ai_socktype/
2015-09-10 11:44:14 -07:00
Daniel Martí
0b10c6cfae Fix failing test in probe/http
The error that Go 1.5 returns is different compared to 1.4. Support both.
2015-09-10 11:44:13 -07:00
Tamer Tas
be7c223043 Refactor probe.Result enumeration 2015-08-10 19:08:15 +03:00
Mike Danese
8e33cbfa28 rewrite go imports 2015-08-05 17:30:03 -07:00
Steve Kuznetsov
3008ff6150 Changed HTTPGetAction to allow user-defined schemes 2015-06-25 16:59:12 -04:00
Tim Hockin
75617e8760 Better kubelet logging for probes
Log when we actually run probes and event when they fail.  Print the output of
a probe, too.
2015-05-20 08:56:45 -07:00
Brendan Burns
c9324e6e38 Switch exec to look at exit code not output status. 2015-05-08 16:51:37 -07:00
Vishnu Kannan
ec01265643 Fix docker exec logic. Without this patch, kubelet was not receiving any output from docker exec
and was incorrectly handling the output.
2015-05-04 16:01:32 -07:00
Eric Paris
6b3a6e6b98 Make copyright ownership statement generic
Instead of saying "Google Inc." (which is not always correct) say "The
Kubernetes Authors", which is generic.
2015-05-01 17:49:56 -04:00
Mike Danese
3d0cd81feb refactor pkg/probe ProbeRunners to interfaces and move global probers into kubelet field for testability 2015-02-10 08:30:11 -08:00
Mike Danese
14bfec92f2 rename probe.Status to probe.Result. 2015-02-05 15:49:58 -08:00
George Kuan
e8c33b7916 Add timeouts to HealthChecks and retry checks
Fixes issue #3532. Added timeouts for HTTP and TCP checks
and enabled kubelet/probe to kubelet#maxRetries times
before declaring Failure.

Added Probe.TimeoutSecs to API

Probe variants now check container.LivenessProbe.TimeoutSeconds
Also added a test for timeouts in http_test.go.
2015-02-05 06:04:45 -08:00
Deyuan Deng
c793c4f0ab Sync node status from node controller to master. 2015-01-29 23:17:15 -05:00
Mike Danese
5dc6362f8a rename probe.Healthy to probe.Success and renam probe.Unhealthy to probe.Failure. 2015-01-27 11:20:30 -08:00
Mike Danese
6eb0b89cbd add Probers to Probe pkgs. 2015-01-27 11:20:30 -08:00
Mike Danese
5ee4071cf1 migrated tests 2015-01-27 11:20:29 -08:00
Mike Danese
ee56a1d3e3 create pkg/probe as successor to pkg/health. 2015-01-27 11:20:29 -08:00