Commit Graph

240 Commits

Author SHA1 Message Date
zhouya0
bbf41448f6 Fix kubectl create secret docker-registry 2020-05-15 12:14:03 +08:00
Julian V. Modesto
360c348d0e Set kubectl field manager names 2020-05-09 13:24:39 -04:00
Kubernetes Prow Robot
775feed217
Merge pull request #90018 from wojtek-t/deprecate_default_conversions
Deprecate default conversions
2020-04-23 10:23:10 -07:00
Maciej Szulik
a871738c86
Revert "stop defaulting kubeconfig to http://localhost:8080"
This reverts commit b19ad9e7a7.
2020-04-17 16:37:15 +02:00
Kubernetes Prow Robot
b0806d0c02
Merge pull request #90165 from ScrapCodes/fix_flake_run_apply
Fixed flaky test by changing get_object_assert -> wait_object_assert.
2020-04-16 08:38:59 -07:00
Prashant Sharma
5a765b1e15 Changed get_object_assert -> wait_object_assert, to fix the flaky test. 2020-04-16 10:01:18 +05:30
Kubernetes Prow Robot
4bba193bea
Merge pull request #89666 from julianvmodesto/kubectl-scale-dry-run
Support kubectl scale --dry-run=server|client
2020-04-11 10:45:47 -07:00
wojtekt
f624314f91 Fix multiple conversion tests 2020-04-10 17:03:35 +02:00
Kubernetes Prow Robot
897c10e7b2
Merge pull request #89551 from zlabjp/restore-kubectl-prune-multiple-namespaces
Restore the ability to `kubectl apply --prune` without -n flag
2020-04-09 07:49:43 -07:00
Tatsuhiro Tsujikawa
7af3b01f24 Restore the ability to kubectl apply --prune without -n flag
Before https://github.com/kubernetes/kubernetes/pull/83084, `kubectl
apply --prune` can prune resources in all namespaces specified in
config files.  After that PR got merged, only a single namespace is
considered for pruning.  It is OK if namespace is explicitly specified
by --namespace option, but what the PR does is use the default
namespace (or from kubeconfig) if not overridden by command line flag.
That breaks the existing usage of `kubectl apply --prune` without
--namespace option.  If --namespace is not used, there is no error,
and no one notices this issue unless they actually check that pruning
happens.  This issue also prevents resources in multiple namespaces in
config file from being pruned.

kubectl 1.16 does not have this bug.  Let's see the difference between
kubectl 1.16 and kubectl 1.17.  Suppose the following config file:

```yaml
apiVersion: v1
kind: ConfigMap
metadata:
  creationTimestamp: null
  name: foo
  namespace: a
  labels:
    pl: foo
data:
  foo: bar
---
apiVersion: v1
kind: ConfigMap
metadata:
  creationTimestamp: null
  name: bar
  namespace: a
  labels:
    pl: foo
data:
  foo: bar
```

Apply it with `kubectl apply -f file`.  Then comment out ConfigMap foo
in this file.  kubectl 1.16 prunes ConfigMap foo with the following
command:

$ kubectl-1.16 apply -f file -l pl=foo --prune
configmap/bar configured
configmap/foo pruned

But kubectl 1.17 does not prune ConfigMap foo with the same command:

$ kubectl-1.17 apply -f file -l pl=foo --prune
configmap/bar configured

With this patch, kubectl once again can prune the resource as before.
2020-04-09 02:54:10 +00:00
Lubomir I. Ivanov
9bbd321fec remove /cluster/kubeadm.sh and /test/cmd/kubeadm.sh
/cluster/kubeadm.sh is used to find the kubeadm binary.
This file is legacy and is removed.

Remove /test/cmd/kubeadm.sh. This file contains a function that is used
to build kubeadm and invoke "make test". Move the function contents
to hack/make-rules/test-cmd.cmd.

Stop sourcing /test/cmd/kubeadm.sh in /test/cmd/legacy-script.sh.

Also remove the --kubeadm-path invocation as this can be handled
with an env. variable directly.
2020-04-09 00:47:15 +03:00
Kubernetes Prow Robot
38f0a8bc74
Merge pull request #89652 from liggitt/relist-timeout
Fix client watch reestablishment handling of client-side timeouts
2020-04-07 01:15:44 -07:00
Sean R. Sullivan
748ad74245 Even with build error, kubectl apply should apply all valid resources 2020-04-04 15:48:31 -07:00
Prashant Sharma
3ff54eb10c
Fixes a flaky test, by adding kubectl wait for delete deployment in apply.sh (#89725)
* Add kubectl wait for delete deployment.

* Even better to wait for all pods deleted.

* get_object_assert -> wait_object_assert
2020-04-04 00:07:47 -07:00
Julian V. Modesto
9c0320f1bf Ensure diff doesn't persist patches 2020-04-02 19:23:32 -04:00
Julian V. Modesto
efed958779 Support kubectl scale --dry-run=server|client 2020-03-31 16:19:52 -04:00
Sean R. Sullivan
4ca2d5a9da Fixes kubectl apply tests to run; updates broken tests 2020-03-30 17:04:10 -07:00
Jordan Liggitt
343c1e7636 Fix client watch reestablishment handling of client-side timeouts 2020-03-30 17:48:00 -04:00
Sean R. Sullivan
1083c0fe05 Adds integration test for apply failures when applying multiple resources 2020-03-26 22:33:04 -07:00
Julian V. Modesto
bacc2c4960 Set field manager for kubectl diff --server-side.
Bonus: check diff only dry-runs without persisting.

Co-authored-by: Takahiro HATORI <tahatori@zlab.co.jp>
2020-03-04 20:20:07 -05:00
Kubernetes Prow Robot
b5b675491b
Merge pull request #86173 from soltysh/cli_defaults
stop defaulting kubeconfig to http://localhost:8080
2020-03-04 07:23:47 -08:00
Maciej Szulik
9dac1699bf
Wire --filename flag to exec 2020-03-03 12:16:52 +01:00
David Eads
b19ad9e7a7
stop defaulting kubeconfig to http://localhost:8080 2020-03-02 18:32:16 +01:00
Kubernetes Prow Robot
641616362d
Merge pull request #88133 from julianvmodesto/dry-run-tests
Cleanup --dry-run values in tests, docs, and scripts
2020-02-27 11:33:42 -08:00
Kubernetes Prow Robot
1591590030
Merge pull request #88292 from julianvmodesto/add-dry-run
Add --dry-run=server|client|none to more kubectl commands
2020-02-20 16:30:25 -08:00
Haowei Cai
aecce98a54 wait for pruned CR to be invisible from API 2020-02-19 17:41:13 -08:00
Julian V. Modesto
a9ec444d74 Add --dry-run to more kubectl commands.
- delete
- taint
- replace
2020-02-19 17:53:21 -05:00
Julian V. Modesto
d97169f59a Clean up --dry-run values.
- Clean up --dry-run values in tests, docs, and scripts
- Fix --dry-run for auth reconcile and add a test
2020-02-15 00:43:30 -05:00
Benjamin Elder
3fb7183215 bump pause to 3.2 in test/ 2020-02-14 14:03:19 -08:00
Julian V. Modesto
13b80b48cd Use --dry-run=client,server in kubectl.
- Support --dry-run=server for subcommands apply, run, create, annotate,
expose, patch, label, autoscale, apply set-last-applied, drain, rollout undo
- Support --dry-run=server for set subcommands
  - image
  - resources
  - serviceaccount
  - selector
  - env
  - subject
- Support --dry-run=server for create subcommands.
  - clusterrole
  - clusterrolebinding
  - configmap
  - cronjob
  - job
  - deployment
  - namespace
  - poddisruptionbudget
  - priorityclass
  - quota
  - role
  - rolebinding
  - service
  - secret
  - serviceaccount
- Remove GetClientSideDryRun
2020-02-12 20:46:54 -05:00
Kubernetes Prow Robot
19ca6d30d2
Merge pull request #87437 from apelisse/kubectl-diff-exit-code
kubectl-diff: Return non-1 errors on kubectl failures
2020-02-01 18:33:20 -08:00
Kubernetes Prow Robot
dba8d60f8c
Merge pull request #87077 from soltysh/remove_run_generators
Remove kubectl run generators
2020-01-29 12:16:14 -08:00
Maciej Szulik
6972d6f33a
Fix kubectl taint's Complete parsing 2020-01-27 13:31:22 +01:00
Maciej Szulik
82f97775b7
Remove kubectl run generators 2020-01-22 16:44:00 +01:00
Antoine Pelisse
38c5f318c9 kubectl-diff: Test return code on failure and changes 2020-01-21 15:34:22 -08:00
drfish
010b885236 Remove workaround for RS bug in cmd apps test 2020-01-10 09:39:54 +08:00
Jordan Liggitt
f50638f439 Isolate kubectl test-cmd plugin tests 2019-12-19 01:35:36 -05:00
Daniel Holbach
a252a617a5 drop KUBE_TIMEOUT in test/cmd/kubeadm.sh
As runyontr remarked in test/cmd/kubeadm.sh: when
	https://github.com/kubernetes/kubeadm/issues/1430 is closed,
	KUBE_TIMEOUT can be removed.
2019-11-28 10:49:41 +01:00
Rob Scott
7085d692b7
Reverting managed-by-setup annotation
This ended up causing far more problems than it was worth, especially
given that it just attempted to provide backwards compatibility with
the alpha release.
2019-11-15 11:50:58 -08:00
Kubernetes Prow Robot
141329fd21
Merge pull request #85285 from liggitt/kubectl-resource-version
Fix --resource-version handling in kubectl
2019-11-14 16:39:03 -08:00
Jordan Liggitt
0ac8345d3a Fix --resource-version handling in kubectl 2019-11-14 12:33:14 -05:00
Rob Scott
a7e589a8c6
Promoting EndpointSlices to beta 2019-11-13 14:20:19 -08:00
Jordan Liggitt
4c3bf1a660 Fix record_command suppression of test errors 2019-11-07 02:26:45 -05:00
Jordan Liggitt
cb17a2b6a6 Fix run_pod_tests 2019-11-07 02:26:45 -05:00
Jordan Liggitt
59dfac587f Fix assert methods 2019-11-07 02:26:45 -05:00
Odin Ugedal
4e44407fa9
Fix failing service test 2019-10-23 23:23:22 +02:00
Odin Ugedal
6a73c0899a
Fix shellcheck failures SC2251
https://github.com/koalaman/shellcheck/wiki/SC2251

This may be masking some test failures.

We have a bunch of test code like this:

set -o errexit
[...]
! kubectl get pod wrong-pod
[...]

This test will succeed no matter what the result (return code) of kubectl is.
2019-10-23 22:47:47 +02:00
Kubernetes Prow Robot
48b90db9c3
Merge pull request #83495 from tanjunchen/fix-typo
remove the repeat word in documents
2019-10-06 15:05:08 -07:00
tanjunchen
de3cf23414 remove the repeat word in documents 2019-10-06 23:32:01 +08:00
Kubernetes Prow Robot
791bfac90f
Merge pull request #83084 from yutedz/ns-prune
Prune should respect namespace option
2019-10-04 02:46:12 -07:00
Guangming Wang
c0a4c09040 fix wrong test in generic-resources.sh
Signed-off-by: Guangming Wang <guangming.wang@daocloud.io>
2019-10-01 20:45:17 +08:00
Ted Yu
88e2f8e04f Prune should respect namespace 2019-09-25 16:43:08 -07:00
ZP-AlwaysWin
d777b6aa94 replace with 2019-09-15 13:55:48 +08:00
calmkart
d558a89437 MOD:fix spelling errors 2019-09-11 15:59:15 +08:00
Antoine Pelisse
a3f4e6e933 Rename --experimental-* flags to --* for server-side apply 2019-08-28 15:03:41 -07:00
Xiangyang Chu
23ce08a7d0 Fix review comments, will squash later. 2019-07-25 14:42:23 +08:00
Xiangyang Chu
4ef227c682 Fix of review comments. Will squash later.
Including:
- Remove external usage of resource name vars
- Add commments about why we export field helpers
2019-07-18 09:12:28 +08:00
Xiangyang Chu
313044abd7 Fix shellcheck failures in test/cmd/l.*.sh 2019-07-17 17:07:22 +08:00
Xiangyang Chu
3a344c7168 Fix shellcheck failures in test/cmd/d.*.sh 2019-07-17 17:07:22 +08:00
Kubernetes Prow Robot
1c99825adf
Merge pull request #79566 from sukeesh/auditlog
Cleanup: Audit log and error capitalization
2019-07-11 14:33:59 -07:00
Kubernetes Prow Robot
b130ff4502
Merge pull request #79724 from deads2k/update-raw
make kubectl --raw consistent for create, update, get, delete
2019-07-09 08:26:17 -07:00
David Eads
09c55bd117 make kubectl --raw consistent for create, update, get, delete 2019-07-09 09:03:56 -04:00
Kubernetes Prow Robot
dd9ae9a1d2
Merge pull request #76227 from sawlanipradeep/window-plugin-fix
Replace syscall.Execve with exec.Command.
2019-07-08 13:00:36 -07:00
Pradeep Sawlani
13be373ce7 For windows, use exec.Command instead of syscall.Execve.
sycall.Execve is not supported on windows.
2019-07-08 10:09:51 -07:00
Sukeesh
346fdbccf0 Cleanup: Audit log and error capitalization 2019-07-08 20:20:12 +09:00
Jordan Liggitt
cf3e75de70 Remove internal object printing from kubectl 2019-06-28 10:54:50 -07:00
Sean Sullivan
e851af0aab Removes test-cmd inappropriate dependency on kubectl 2019-06-27 10:49:42 -07:00
Jordan Liggitt
6ca80760fd Switch test manifests to apps/v1, remove beta workloads calls 2019-06-22 13:58:07 -07:00
Kubernetes Prow Robot
0f2b01ab33
Merge pull request #78022 from xychu/fix-shellchecks-g
Fix shellcheck failures in test/cmd/g.*sh
2019-06-20 20:46:35 -07:00
Kubernetes Prow Robot
ab3b24ac0a
Merge pull request #77798 from xychu/fix-shellchecks-b
Fix shellchecks in test/cmd/{b,c}.*.sh
2019-06-20 10:00:52 -07:00
Xiangyang Chu
38a785b1ee Fix review comments to use ${} 2019-06-20 10:46:41 +08:00
Xiangyang Chu
99b2184993 Fix shellcheck faulures in test/cmd
Including files after test/cmd/n*
2019-06-17 14:04:34 +08:00
Kubernetes Prow Robot
0f5650d68b
Merge pull request #75859 from k-toyoda-pi/fix_shellcheck_failure_make-rules
fix shellcheck failures in /hack/make-rules/test.sh
2019-06-13 20:36:47 -07:00
Kubernetes Prow Robot
8305729d7a
Merge pull request #74635 from xychu/fix-with-assert
Fix shellchecks follow the `${var:?}` pattern
2019-06-13 19:12:45 -07:00
Kubernetes Prow Robot
a04017a468
Merge pull request #78530 from liggitt/deflake-core-integration
Wait for pods to be garbage collected in integration test
2019-06-04 05:03:08 -07:00
Xiangyang Chu
cfc7b0d9c3 Change quoting format 2019-06-04 14:42:01 +08:00
Xiangyang Chu
81eb22900b Fix shellchecks in test/cmd/{b,c}.*.sh 2019-06-04 14:42:01 +08:00
Kubernetes Prow Robot
d817a7e9a0
Merge pull request #78325 from caesarxuchao/storageVersionHash-beta
Graduate storageVersionHash field in the discovery doc to beta
2019-05-31 23:22:33 -07:00
Jordan Liggitt
d93ef9396b Wait for pods to be garbage collected 2019-05-30 11:46:09 -04:00
Kubernetes Prow Robot
38afd9815e
Merge pull request #78445 from soltysh/remove_job_scale
Remove kubectl scale job
2019-05-30 02:24:33 -07:00
Chao Xu
2f4c273398 Graduate storageVersionHash field in the discovery doc to beta 2019-05-29 17:38:28 -07:00
Kubernetes Prow Robot
afba9c0355
Merge pull request #77877 from liggitt/deflake-integration
Wait for integration precondition
2019-05-28 22:21:12 -07:00
Maciej Szulik
85d8b0ce3f
Remove kubectl scale job 2019-05-28 15:24:38 +02:00
Xiangyang Chu
eee32a6a88 Fix shellcheck failures in test/cmd/g.*sh 2019-05-17 15:40:14 +08:00
Kohei Toyoda
62d5eb524b
Merge branch 'master' into fix_shellcheck_failure_make-rules 2019-05-17 08:43:08 +09:00
Kubernetes Prow Robot
6dfc996156
Merge pull request #77423 from apelisse/rollout-restart-other-workloads
Implement rollout restart for statefulset and daemonset
2019-05-16 16:27:06 -07:00
Antoine Pelisse
145935d815 Implement rollout restart for statefulset and daemonset 2019-05-16 08:50:42 -07:00
Jordan Liggitt
e3b4937440 Wait for integration precondition 2019-05-14 14:11:35 -04:00
Kubernetes Prow Robot
07e3b7cdca
Merge pull request #74639 from xychu/fix-shellchecks-a
Make test/cmd/a*.sh pass shellcheck
2019-05-10 10:38:12 -07:00
toyoda
34a120fc42 fix shellcheck failures in /hack/make-rules/test.sh 2019-05-09 17:47:12 +09:00
Jordan Liggitt
e5778f05b9 Fix unstructured list interface compatibility, fix kubectl paging 2019-05-08 02:00:18 -04:00
Jordan Liggitt
37c9e6b444 Expect the correct object type to be removed 2019-05-03 14:10:02 -04:00
Xiangyang Chu
7a385bf2ea Fix wrong pipe in grep -q 2019-04-26 14:23:53 +08:00
Xiangyang Chu
906058bf7b Update grep -q usage to avoid closed pipe 2019-04-26 11:39:11 +08:00
Xiangyang Chu
2260cc29b9 Make test/cmd/a*.sh pass shellcheck 2019-04-26 11:39:11 +08:00
Ahmad Nurus S
0c39d7d380 Kubectl exec support resource/name format 2019-04-25 17:44:01 +07:00
WanLinghao
7fbd71835e 'kubectl auth can-i` command would not hint user when they try to access
some resource out of scope. For example, try get namespace inside defaut namespace.
It would be reject by api-server but `kubectl auth can-i get namespace --namespace=default`
would give a `yes`. After this patch, a warning info would be given.
For more detail, please refer issue #75950
2019-04-10 13:12:45 +08:00
Kubernetes Prow Robot
3409a5362a
Merge pull request #76062 from apelisse/rollout-restart
Create `kubectl rollout restart deployment/$deployment` to do a rolling restart
2019-04-08 14:40:44 -07:00
Antoine Pelisse
1bf99e2e4e Create kubectl rollout restart deployment/$deployment to do a rolling restart 2019-04-06 21:14:40 -07:00
Kubernetes Prow Robot
9c2df998af
Merge pull request #75820 from YoubingLi/bugfix
Fixes #75706 - Show warning message when namespace is specified for deleting a cluster-scoped resource
2019-04-06 11:00:27 -07:00