Commit Graph

7422 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
c3bec0bae4
Merge pull request #74601 from mrbobbytables/fix-test-image-shellcheck
Fix shellcheck lint errors in test/images/* scripts
2019-04-17 02:22:03 -07:00
Kenichi Omichi
08dc056480 Replace false with exit 1
Some scripts contained `false` for returning 1 to callers instead of
`exit 1` and that works like:

  $ false
  $ echo $?
  1
  $

But that made confusion in a PR review process.
So this replaces `false` with `exit 1` for long-term maintenance.
2019-04-16 23:13:00 +00:00
Kubernetes Prow Robot
1a0a75750c
Merge pull request #76613 from SataQiu/fix-golint-20190416
Fix golint failures of pkg/apis/core/helper
2019-04-16 10:27:31 -07:00
Kubernetes Prow Robot
123b9c9e10
Merge pull request #76313 from SataQiu/fix-hack-2019040902
Fix shellcheck failures of hack/update-openapi-spec.sh
2019-04-16 10:27:10 -07:00
Kubernetes Prow Robot
98b6f35999
Merge pull request #74610 from oomichi/issue/74038-2
Enable StorageObjectInUseProtection by default
2019-04-16 02:11:29 -07:00
Kubernetes Prow Robot
35669df1ab
Merge pull request #76066 from SataQiu/golint-test-20190403
Fix golint failures of e2e/apimachinery
2019-04-15 23:31:22 -07:00
SataQiu
91bd1ac1ea fix golint failures of test/e2e/apimachinery 2019-04-16 19:03:26 +08:00
Kubernetes Prow Robot
9f49dd2811
Merge pull request #76582 from danielqsj/gofmt
run update-gofmt when make update
2019-04-15 21:01:19 -07:00
Kubernetes Prow Robot
92562d5bc0
Merge pull request #76253 from YoubingLi/bugfix
Fixes # 76094 - Check the content of WHAT for Makefile's verify target
2019-04-15 18:05:05 -07:00
Bob Killen
5518defffc
Fix shellcheck lint errors in test/images/volume/nfs/run_nfs.sh 2019-04-15 20:02:03 -04:00
Bob Killen
f795e22932
Fix shellcheck lint errors in test/images/volume/iscsi/create_block.sh 2019-04-15 20:01:25 -04:00
Bob Killen
346bcdaa27
Fix shellcheck lint errors in test/images/volume/gluster/run_gluster.sh 2019-04-15 20:01:25 -04:00
SataQiu
556ff16b0d fix golint failures of pkg/apis/core/helper 2019-04-16 07:21:20 +08:00
Kubernetes Prow Robot
8d38f3f2cf
Merge pull request #75795 from mrbobbytables/shellcheck-ignore-third-party
Update hack/verify-shellcheck.sh to ignore ./third_party/*
2019-04-15 13:11:08 -07:00
SataQiu
142e458a97 fix shellcheck failures of hack/update-openapi-spec.sh 2019-04-16 03:40:56 +08:00
Kubernetes Prow Robot
4628133bda
Merge pull request #76558 from liggitt/lint-pin-improvements
propagate pinned versions to staging repos, output cleanup commands
2019-04-15 11:47:09 -07:00
Kubernetes Prow Robot
631bf8cbc8
Merge pull request #76497 from SataQiu/fix-golint-20190413
Fix golint failures of cmd/kube-proxy/app
2019-04-15 10:26:53 -07:00
Jordan Liggitt
77690137a9 propagate pinned versions to staging repos, output cleanup commands 2019-04-15 11:30:07 -04:00
Kubernetes Prow Robot
4a5151b2c4
Merge pull request #75524 from oomichi/issue/74432
Add check-conformance-test-requirements.go
2019-04-15 03:54:09 -07:00
danielqsj
187986cb65 run update-gofmt in make update 2019-04-15 15:01:54 +08:00
Kubernetes Prow Robot
76b877a93f
Merge pull request #76495 from h00130372/fix-unbound-variable
Fix older bash failing on unbound array variables
2019-04-14 20:56:01 -07:00
h00130372
de95a3344b Fix older bash failing on unbound array variables
Older bash versions fail when trying to expand array variables
when the array is empty.
2019-04-15 09:47:26 +08:00
Kubernetes Prow Robot
56817f2543
Merge pull request #76115 from SataQiu/fix-shell-20190404
Fix shellcheck failures of zookeeper-installer/install.sh, etc
2019-04-13 21:20:01 -07:00
Kubernetes Prow Robot
0e157cbc36
Merge pull request #75713 from SataQiu/fix-e2e_node-builder-20190326
Fix golint failures in test/e2e_node/builder
2019-04-13 19:18:00 -07:00
SataQiu
d735aaadd6 fix shellcheck failures of zookeeper-installer/install.sh zookeeper-installer/on-start.sh 2019-04-14 07:07:50 +08:00
Kubernetes Prow Robot
92918dc285
Merge pull request #76448 from xichengliudui/fixshellcheckfailures-20
update benchmark-dockerized.sh and verify-dockerized.sh
2019-04-13 14:02:01 -07:00
Bob Killen
db01d68d05
Update hack/verify-shellcheck.sh to ignore ./third_party/*
The ./third_party/* directory contains scripts, libraries and
other components from external sources. These should be omitted
from lints and checks with the exception of things that are
forked and modified (located in ./third_party/forked/*) for
project related reasons.
2019-04-13 16:58:20 -04:00
Kubernetes Prow Robot
df6ca6ab9f
Merge pull request #76156 from chardch/recreate-master-retry
Recreate nodes e2e test
2019-04-12 23:26:02 -07:00
Kubernetes Prow Robot
e68888384b
Merge pull request #76522 from liggitt/prune-replace
Prune replace directives
2019-04-12 20:00:04 -07:00
Kubernetes Prow Robot
ed5c7e6bfb
Merge pull request #76511 from liggitt/fixup-vendor-gopath
stop clearing GOPATH in vendor scripts
2019-04-12 18:08:47 -07:00
Kubernetes Prow Robot
ae11829495
Merge pull request #76499 from SataQiu/fix-bug-shellcheck
Follow up of #76314
2019-04-12 18:08:32 -07:00
Kubernetes Prow Robot
a08107fe99
Merge pull request #76482 from SataQiu/fix-shell-hack-2019041202
Fix shellcheck failures of hack/update-codegen.sh
2019-04-12 18:08:18 -07:00
Jiaying Zhang
8175579a0c add recreate node e2e test
Move recreate_node test to gce provider tests.
2019-04-12 16:00:19 -07:00
Kubernetes Prow Robot
90a939ec33
Merge pull request #76131 from SataQiu/fix-hack-20190404
Fix shellcheck failures of hack/lib/logging.sh hack/lib/protoc.sh
2019-04-12 15:56:45 -07:00
Kubernetes Prow Robot
969c1106f1
Merge pull request #76084 from SataQiu/fix-shell-20190403
Fix shellcheck failures of test/images/pets/redis-installer/on-start.sh
2019-04-12 15:56:32 -07:00
SataQiu
cc199c74fc fix golint failures of cmd/kube-proxy/app 2019-04-13 06:20:52 +08:00
Jordan Liggitt
aaa8802acb Prune unnecessary replace directives from staging go.mod files 2019-04-12 16:48:01 -04:00
SataQiu
84a0478d1b fix bug of hack/update-gofmt.sh 2019-04-13 03:29:51 +08:00
Jordan Liggitt
fb0cea22dc stop clearing GOPATH in vendor scripts
if unset, go defaults to $HOME/go, and fails if $GOROOT is also set to the same directory

we were only doing this to be doubly sure that only modules were being used.
just depend on export GO111MODULE=on for that.
2019-04-12 12:56:05 -04:00
Kubernetes Prow Robot
5b434eefc3
Merge pull request #74180 from mrbobbytables/fix-third-party-shellcheck
Fix shellcheck lint errors in third_party/* scripts
2019-04-12 06:14:46 -07:00
SataQiu
9863f26706 fix shellcheck failures of hack/update-codegen.sh 2019-04-12 19:15:56 +08:00
Kubernetes Prow Robot
b2db8c77ad
Merge pull request #76426 from SataQiu/join-hack-20190411
add @SataQiu as a reviewer of hack
2019-04-12 03:23:31 -07:00
Kubernetes Prow Robot
28d5023137
Merge pull request #76244 from cblecker/dep-script-fixups
Couple of dependency script cleanups
2019-04-12 03:23:17 -07:00
SataQiu
4231fa0980 fix shellcheck failures of hack/lib/logging.sh hack/lib/protoc.sh 2019-04-12 16:00:23 +08:00
Bob Killen
9e719d8d9c
Fix shellcheck lint errors in third_party/forked/shell2junit/sh2ju.sh 2019-04-11 10:25:41 -07:00
SataQiu
10b52bae28
Merge branch 'master' into fix-hack-2019040903 2019-04-11 23:29:10 +08:00
SataQiu
318af5f45a add @SataQiu as a reviewer of hack 2019-04-11 23:07:48 +08:00
Kubernetes Prow Robot
ef830e2bcf
Merge pull request #76311 from SataQiu/fix-hack-20190409
Fix shellcheck failures of hack/update-vendor-licenses.sh
2019-04-10 22:42:21 -07:00
yue9944882
cabe69faeb clean up unused vars in codegen scripts 2019-04-10 13:14:36 +08:00
Kubernetes Prow Robot
e2091b769a
Merge pull request #71136 from yue9944882/chore/prune-all-kk-internal-clientset
Prune literally all kube-apiserver internal client
2019-04-09 13:58:45 -07:00