Hanna Lee
07a883d8e6
Remove //lint:ignore pragmas that aren't being used anymore
2021-11-17 08:56:54 +01:00
Hanna Lee
0f3836dcc5
Ignore deprecation warnings with //nolint:staticcheck
2021-11-17 08:55:57 +01:00
Hemant Kumar
63fffd37b1
Implement API changes necessary for recovery from resize failure
2021-11-15 18:39:30 -05:00
Dan Williams
a04997e1a1
pod/storage: remove always-empty 'oldMachine' in setPodHostAndAnnotations()
...
There's only one caller of setPodHostAndAnnotations() and it always
passes an empty 'oldMachine'.
Signed-off-by: Dan Williams <dcbw@redhat.com>
2021-11-11 16:29:20 -06:00
Kubernetes Prow Robot
3128afa69a
Merge pull request #106296 from thockin/svc-logging-cleanup
...
Clean up some service logging
2021-11-10 11:51:38 -08:00
Tim Hockin
049e158a8f
Don't write fake logs to the real test log
...
This caused consternation as errors were logged but tests did not fail.
It was expected to log!
2021-11-09 22:56:34 -08:00
Tim Hockin
26db11f3dc
Clean up some service logging
...
This is a holdover from previous work. It is not complete, but it
should be incrementally better.
2021-11-09 22:46:22 -08:00
Kubernetes Prow Robot
23df2b97f7
Merge pull request #105302 from ml-/fix-typos
...
fix multiple typos in go files
2021-11-03 03:20:58 -07:00
Ruochen Xu
6cc9bedfab
add condition pre-check for pod uid and pod resource version in bind api
2021-11-02 09:51:15 +08:00
ml
a2441a256b
fix multiple typos
2021-10-29 21:43:52 +02:00
Patrick Ohly
a8c930ef46
generic ephemeral volume: graduation to GA
...
The feature gate gets locked to "true", with the goal to remove it in two
releases.
All code now can assume that the feature is enabled. Tests for "feature
disabled" are no longer needed and get removed.
Some code wasn't using the new helper functions yet. That gets changed while
touching those lines.
2021-10-11 20:54:20 +02:00
Tom Payne
21755f9ec0
Speed up counting of bits in allocator
...
Benchmark:
goos: linux
goarch: amd64
pkg: k8s.io/kubernetes/pkg/registry/core/service/allocator
cpu: Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz
Before:
BenchmarkCountBits-8 9459236 140.4 ns/op
After:
BenchmarkCountBits-8 140667842 9.541 ns/op
2021-10-01 17:09:56 +02:00
Tom Payne
125312a8cf
Add extra test and benchmark for count bits
2021-10-01 17:08:36 +02:00
Khaled Henidak (Kal)
a53e2eaeab
move IPv6DualStack feature to stable. ( #104691 )
...
* kube-proxy
* endpoints controller
* app: kube-controller-manager
* app: cloud-controller-manager
* kubelet
* app: api-server
* node utils + registry/strategy
* api: validation (comment removal)
* api:pod strategy (util pkg)
* api: docs
* core: integration testing
* kubeadm: change feature gate to GA
* service registry and rest stack
* move feature to GA
* generated
2021-09-24 16:30:22 -07:00
Tim Hockin
52f54ce90d
Svc REST: clean up defaultOnRead to be consistent
...
Headless+selectorless -> RequireDualStack
Headless+selector -> SingleStack
Add test cases to cover this and ExternalName and dual-stack init (which
I think can never trigger, but best to be safe).
2021-09-16 11:17:45 -07:00
Kubernetes Prow Robot
c10be982d1
Merge pull request #96345 from ingvagabund/disable-insecure-port-in-scheduler
...
refactor: disable insecure serving in kube-scheduler
2021-09-14 08:01:09 -07:00
Jan Chaloupka
07af6697e9
refactor: disable insecure serving in kube-scheduler
2021-09-14 07:52:16 +02:00
Tim Hockin
009aa36c89
Svc REST: Make transaction-accumulating funcs safe
...
Identified in review, these funcs are now more reslient to future
changes.
2021-09-11 11:30:02 -07:00
Tim Hockin
e594dd4281
Svc REST: Convert FIXME to TODO
2021-09-11 11:30:02 -07:00
Tim Hockin
03d11c53a8
Svc REST: Rename RESTAllocStuff
...
This was a dumb placeholder name.
2021-09-11 11:30:02 -07:00
Tim Hockin
5847426e5e
Svc REST: Use types for safer arg ordering
...
In all the places we pass (old, new) or (new, old), use wrapper-types to
make sure that we don't flip the order by accident.
2021-09-11 11:30:02 -07:00
Tim Hockin
d5143bca84
Svc REST: Rename GenericREST -> REST
...
This is consistent with every other registry. Service is no longer the
oddball.
2021-09-11 11:30:02 -07:00
Tim Hockin
fe6f278ea1
Svc REST: Move isValidAddress to storage.go
2021-09-11 11:30:02 -07:00
Tim Hockin
d7c8557281
Svc REST: Make update/releaseNodePorts methods
...
More consistent overall.
2021-09-11 11:30:02 -07:00
Tim Hockin
4c9bc5a53c
Svc REST: Move alloc code around
...
This is detrimental to future `blame` but makes it so much morereadable
I convinced myself it was worthwhile.
2021-09-11 11:30:02 -07:00
Tim Hockin
7ce34e311a
Svc REST: rename rest.go -> alloc.go
2021-09-11 11:30:02 -07:00
Tim Hockin
1ce9807de0
Svc REST: Make allocHCNP a method: more consistent
2021-09-11 11:30:02 -07:00
Tim Hockin
c94deffa48
Svc REST: rename allocateHealthCheckNodePort
2021-09-11 11:30:02 -07:00
Tim Hockin
6b06b9bfd3
Svc REST: rename healthCheckNodePortUpdate
2021-09-11 11:30:02 -07:00
Tim Hockin
5dfcb905d1
Svc REST: rename handleClusterIPsForUpdatedService
2021-09-11 11:30:02 -07:00
Tim Hockin
9c622230fc
Svc REST: rename releaseServiceClusterIPs
2021-09-11 11:30:02 -07:00
Tim Hockin
4fb338b279
Svc REST: rename releaseServiceClusterIP
2021-09-11 11:30:02 -07:00
Tim Hockin
2a98ec667e
Svc REST: rename allocServiceClusterIPs
2021-09-11 11:30:02 -07:00
Tim Hockin
b9f1f4712a
Svc REST: rename allocServiceClusterIP
2021-09-11 11:30:02 -07:00
Tim Hockin
1b79bbc9f4
Svc REST: rename releaseClusterIPs -> releaseIPs
2021-09-11 11:30:01 -07:00
Tim Hockin
8e330eb611
Svc REST: rename allocClusterIPs -> allocIPs
2021-09-11 11:30:01 -07:00
Tim Hockin
7d9357b181
Svc REST: rename allocUpdateServiceNodePortsNew
2021-09-11 11:30:01 -07:00
Tim Hockin
bb815e6687
Svc REST: rename allocUpdateServiceClusterIPsNew
2021-09-11 11:30:01 -07:00
Tim Hockin
3b971b137c
Svc REST: rename allocServiceNodePortsNew
2021-09-11 11:30:01 -07:00
Tim Hockin
f94782b4f5
Svc REST: rename allocServiceClusterIPsNew
2021-09-11 11:30:01 -07:00
Tim Hockin
8f5189a49f
Svc REST: Move tests and scaffolding around
...
No code edits. Just a little whitespace, adding comments, and
re-ordering functions.
2021-09-11 11:30:01 -07:00
Tim Hockin
017a430dcd
Svc REST: Move patchAllocatedValues to storage pkg
...
All the meaningful callers of it are in that pkg anyway. Removes 1
FIXME.
2021-09-11 11:30:01 -07:00
Tim Hockin
4ff4160e34
Svc REST: Move normalizeClusterIPs to storage pkg
...
All the meaningful callers of it are in that pkg anyway. Removes some
FIXMEs.
2021-09-11 11:30:01 -07:00
Tim Hockin
4718a0f214
DeepCopy() input objects in Service REST test
...
Since the PR to do this deeper in the stack was declined, we'll do it
ourselves. This ensures that we don't accidentally mutate the input and
then compare that mutated form to the result (which caused previous test
failures).
2021-09-11 11:30:01 -07:00
Tim Hockin
4ac7c73b2e
Svc REST: Remove old rest_test
...
All the tests have been ported to storage_test.go
2021-09-11 11:30:01 -07:00
Tim Hockin
b6da6c9c0f
Svc REST: Add InternalTrafficPolicy tests
...
Remove older form.
2021-09-11 11:30:01 -07:00
Tim Hockin
c71467def0
Svc REST: Remove overlapping rest_tests
...
Most are moved to storage_test
2021-09-11 11:30:01 -07:00
Tim Hockin
12ac38f661
Svc REST: Beef up ports test, remove old form
2021-09-11 11:30:01 -07:00
Tim Hockin
652dc8787c
Svc REST: Use "prove" helpers in other tests
2021-09-11 11:30:01 -07:00
Tim Hockin
245a654dec
Svc REST: Rename service NewGenericREST to NewREST
...
Just like all the other registries.
2021-09-11 11:30:01 -07:00