github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
10,496 Commits 1 Branch 31 Tags 1,019 MiB
e28625f7a6
Commit Graph

606 Commits

Author SHA1 Message Date
Yifan Gu
6c98b9daee kubelet/metrics: Move instrumented_docker.go to dockertools. 
This can solve the circular import problem when we move the
kubelet.pullImage to kubelet/metrics or kubelet/container package.
 2015-04-24 22:03:11 -07:00
Yu-Ju Hong
b0e6926f67 kubelet: filter out terminated pods in SyncPods 
Once a pod reaches a terminated state (whether failed or succeeded), it should
not transit out ever again. Currently, kubelet relies on examining the dead
containers to verify that the container has already been run. This is fine
in most cases, but if the dead containers were garbage collected, kubelet may
falsely concluded that the pod has never been run. It would then try to restart
all the containers.

This change eliminates most of such possibilities by pre-filtering out the pods
in the final states before sending updates to per-pod workers.
 2015-04-24 15:28:03 -07:00
Yifan Gu
b5a1b32aa4 kubelet/dockertools: Move RunContainer into container runtime. 
Also removed ContainerRunner interface.
 2015-04-23 16:40:37 -07:00
Yifan Gu
6ed27d06f7 kubelet: Move KillContainer to container runtime. 
Rename KillContainerID(string) with KillContainer(string).
Delete the old KillContainer(*kubecontainer.Container).
 2015-04-23 15:44:00 -07:00
David Oppenheimer
8667ebddff Merge pull request #7249 from yifan-gu/generator 
kubelet/container: Introduce RunContainerOptionsGenerator.
 2015-04-23 14:59:23 -07:00
Dawn Chen
6207c518b3 Merge pull request #7254 from yifan-gu/readiness 
kubelet/dockertools: Add readinessManage/containerRefManager to dockerManager.
 2015-04-23 14:34:43 -07:00
Yifan Gu
e8d485a3a1 kubelet/dockertools: Add readinessManage/containerRefManager to dockerManager. 
This can enable us to move KillContainer() to container runtime.
 2015-04-23 14:20:34 -07:00
Yifan Gu
bd7132bc07 kubelet/container: Introduce RunContainerOptionsGenerator. 
This interface wraps the kubelet to provide the options for
container runtime to run a container.
 2015-04-23 13:55:50 -07:00
Dawn Chen
f7831dcd93 Merge pull request #7229 from vmarmol/stats 
Kubelet: Add /stats/container endpoint for raw containers
 2015-04-23 13:43:23 -07:00
Victor Marmol
c29d328c55 Kubelet: Add /stats/container endpoint. 
This endpoint exposes container stats for all raw containers on the
machine. The addition is backwards compatible.
 2015-04-23 10:38:29 -07:00
Yifan Gu
af1e9f737f kubelet: Introduce volume manager. 
The volume manager book-keeps the information for the volume mounts
on the kubelet, so we can avoid passing the volumeMap around.
 2015-04-23 10:37:02 -07:00
Satnam Singh
2444c1f943 Propagate pod and container name for log files 2015-04-22 15:08:51 -07:00
Victor Marmol
45575d95b3 Merge pull request #7177 from yifan-gu/runner 
kubelet/dockertools: Remove dockerContainerCommandRunner.
 2015-04-22 13:24:50 -07:00
Yifan Gu
f59013410a kubelet/container: Move Prober/HandlerRunner interface to container/helpers.go 
This enables us to pass them to container runtime as parameters.
 2015-04-22 11:56:15 -07:00
Yifan Gu
c55c879ffe kubelet/dockertools: Remove dockerContainerCommandRunner. 
Replace with docker manager.
 2015-04-22 11:00:54 -07:00
Victor Marmol
914a6febfb Merge pull request #7010 from yifan-gu/compute 
kubelet: Refactor computePodContainerChanges().
 2015-04-22 08:05:18 -07:00
Brian Grant
8dbbf3da5c Merge pull request #7138 from pravisankar/unschedulable-event 
Record an event on node schedulable changes
 2015-04-22 07:11:14 -07:00
Yifan Gu
611fb25926 kubelet: Refactor GetDockerVersion(). 
Remove GetDockerServerVersion() from DockerContainerCommandRunner interface,
replaced with runtime.Version(). Also added Version type in runtime for version
comparision.
 2015-04-21 14:52:08 -07:00
Ravi Sankar Penta
f1d88f6d2f Record an event on node schedulable changes 2015-04-21 14:14:59 -07:00
Yifan Gu
5594981340 kubelet: Refactor computePodContainerChanges(). 
Pull generatePodStatus() and makePodDataDirs() out as they are the
common part for container runtimes.
 2015-04-21 13:53:20 -07:00
Victor Marmol
4b9a64bcd8 Merge pull request #7098 from yifan-gu/handler 
kubelet: Refactor runHandler().
 2015-04-21 08:14:42 -07:00
Yifan Gu
c23b83b0ca kubelet: Refactor runHandler(). 
Use new HandlerRunner type to replace runHandler()
 2015-04-20 21:31:11 -07:00
Daniel Smith
462534ca5d Merge pull request #7068 from krousey/api_pod_pointer 
Changing  a few more instances of api.Pod to *api.Pod
 2015-04-20 17:09:28 -07:00
Kris Rousey
594f514843 Changing a few remaining instances of passing pods around by value. I 
avoided changing api.PodList.Items to []*api.Pod.
 2015-04-20 15:26:45 -07:00
Victor Marmol
d44e9b4880 Merge pull request #7048 from yujuhong/para_cleanup 
Kubelet: parallelize cleaning up containers in unwanted pods
 2015-04-20 14:59:07 -07:00
Yu-Ju Hong
275002173e Kubelet: parallelize cleaning up containers in unwanted pods 
Kubelet kills unwanted pods in SyncPods, which directly impact the latency of a
sync iteration. This change parallelizes the cleanup to lessen the effect.

Eventually, we should leverage per-pod workers for cleanup, with the exception
of truly orphaned pods.
 2015-04-20 14:42:12 -07:00
Brendan Burns
01b891770f Merge pull request #7054 from ncdc/dockerclient-version 
Use go-dockerclient's APIVersion
 2015-04-20 14:20:57 -07:00
Andy Goldstein
a0a80ea76e Use go-dockerclient's APIVersion 
Use go-dockerclient's APIVersion to check the minimum required Docker
version, as it contains methods for parsing the ApiVersion response from
the Docker daemon and for comparing 2 APIVersion objects.
 2015-04-20 13:48:18 -04:00
Yu-Ju Hong
cd61aa9484 Merge pull request #7009 from yifan-gu/kube_dep 
kubelet: Refactor prober.
 2015-04-20 10:23:04 -07:00
Clayton Coleman
9e87924983 Tone down kubelet logs for already run containers 2015-04-19 22:55:38 -04:00
Yifan Gu
1d58992df7 kubelet: Refactor prober. 
Decompose the health check prober from the kubelet.
 2015-04-17 15:54:28 -07:00
Yu-Ju Hong
1f3e47f6f7 Merge pull request #7005 from yifan-gu/kube_dep 
kubelet: Refactor shouldContainerBeRestarted():
 2015-04-17 15:05:41 -07:00
Yifan Gu
29a5da231d kubelet: Refactor shouldContainerBeRestarted(): 
Remove the function's dependency on kubelet.
 2015-04-17 14:35:39 -07:00
Kris Rousey
81497f3ed2 Changing the scheduler package to use *api.Pod instead of api.Pod to 
avoid unnecessary shallow copies. The change rippled through a lot of
code.
 2015-04-17 13:34:31 -07:00
Yu-Ju Hong
13b29cd64b Merge pull request #6595 from guenter/kubelet-update-channel-closed 
kubelet syncloop should stop if/when updates chan closes
 2015-04-17 10:42:05 -07:00
Victor Marmol
abab9ea31f Merge pull request #6844 from yifan-gu/cleankube 
kubelet: Clean up computePodContainerChanges.
 2015-04-15 13:53:21 -07:00
Yifan Gu
3b28c6262b kubelet: Clean up computePodContainerChanges. 
More `continue`, less `else` to make it less indent and more readable.
 2015-04-15 10:13:57 -07:00
Victor Marmol
fb3c351fe1 Run Kubelet on "/kubelet" container. 2015-04-14 10:29:05 -07:00
Victor Marmol
ca9e209ccb Merge pull request #6795 from yifan-gu/cache 
kubelet/container: Replace DockerCache with RuntimeCache.
 2015-04-14 09:37:34 -07:00
Dawn Chen
8420abeea8 Merge pull request #6786 from yifan-gu/cleankube 
kubelet: Remove unused docker functions.
 2015-04-14 09:16:53 -07:00
Victor Marmol
e265f2c58d Merge pull request #6799 from xiang90/kerr 
pkg/kubelet: fix error msg in GetHostIP
 2015-04-14 08:40:34 -07:00
Xiang Li
4a152290f4 pkg/kubelet: fix error msg in GetHostIP 2015-04-13 22:44:23 -07:00
Yifan Gu
e1feed9a8b kubelet/container: Replace DockerCache with RuntimeCache. 2015-04-13 18:16:05 -07:00
Yifan Gu
7fedb14c27 kubelet: Remove unused docker functions. 
Remove kubelet.getPodInfraContainer().
Remove dockertools.RemoveContainerWithID().
Remove dockertools.FindContainersByPod().

Also replace the useless test with a test for GetPods().
 2015-04-13 16:32:18 -07:00
Yifan Gu
d14cb8f1dd kubelet: Introduce PodInfraContainerChanged(). 
This functions computes in ahead whether we need to restart the pod
infra container.
 2015-04-13 16:18:52 -07:00
Yifan Gu
dda600e45c kubelet/dockertools: Add puller interfaces in the containerManager. 2015-04-13 15:34:22 -07:00
Yifan Gu
a3675e08f2 kubelet/dockertool: Move Getpods() to DockerManager. 2015-04-13 14:05:22 -07:00
Xiang Li
cef744ecaa pkg/kubelet: move the capabilities related code to util.go 2015-04-11 12:09:11 -07:00
Tobi Knaup
3932dfd8bb Log an error when update channel is closed. 2015-04-10 17:30:04 -07:00
Dawn Chen
fff6cebb5f Merge pull request #6711 from yujuhong/container_status 
Kubelet: surface the container creation/start failure reason
 2015-04-10 17:19:32 -07:00
Yu-Ju Hong
bb417e82d7 Kubelet: surface the container creation/start failure reason 
Container creation/start failure cannot be reproduced by inspecting the
containers. This change caches such errors so that kubelet can retrieve it
later.

This change also extends FakeDockerClient to support setting error response
for a specific function.
 2015-04-10 16:02:27 -07:00
Daniel Smith
e2093798cb Merge pull request #6675 from wojtek-t/nodes_support_field_selector 
FieldSelector for node List()
 2015-04-10 10:30:55 -07:00
Victor Marmol
1563a7636a Merge pull request #6652 from dchen1107/podstatus 
Populate last terminated container information
 2015-04-10 09:21:58 -07:00
Wojciech Tyczynski
88eb0b0295 FieldSelector for node List() 2015-04-10 12:53:16 +02:00
Dawn Chen
563f2965ba Populate last terminated container information 2015-04-09 16:10:13 -07:00
Daniel Smith
629d94657e Merge pull request #6624 from gmarek/status_to_subresource 
Update NodeStatus use subresources.
 2015-04-09 16:00:15 -07:00
Victor Marmol
40acaef454 Merge pull request #6607 from yujuhong/mirror_update 
Kubelet: recreate mirror pod if the static pod changes
 2015-04-09 10:29:55 -07:00
Yifan Gu
b868f421e0 kubelet: Move pod infra container image setting to dockertools. 2015-04-09 09:53:07 -07:00
gmarek
ccc56d3c3c Update NodeStatus use subresources. 2015-04-09 14:07:40 +02:00
Yu-Ju Hong
d7cf294c99 Kubelet: recreate mirror pod if the static pod changes 
If a static pod changes, delete the corresponding mirror pod. When kubelet
could not see mirror pod from the API server update, it'd attemp to create a
new mirror pod with up-to-date specs.
 2015-04-08 18:06:21 -07:00
Vish Kannan
43949b41d4 Merge pull request #6586 from dchen1107/podstatus 
small cleanup by removing useless generatePodStatus
 2015-04-08 14:59:23 -07:00
Tobi Knaup
3efff6d4e8 kubelet syncloop should stop if/when updates chan closes 2015-04-08 14:45:16 -07:00
Dawn Chen
914616a195 Merge pull request #6592 from vishh/kubelet_logging 
Improve kubelet logging around startup.
 2015-04-08 14:35:53 -07:00
David Oppenheimer
4ffc2aad21 Merge pull request #6146 from kazegusuri/node_client_label 
List in NodesInterface takes label selector
 2015-04-08 14:22:53 -07:00
Vishnu Kannan
2b5cad6acf Improve kubelet logging around startup. This might help detect any lockup issues during startup. 2015-04-08 21:02:15 +00:00
Dawn Chen
b6d846aea5 small cleanup by removing useless generatePodStatus 2015-04-08 13:38:06 -07:00
Yifan Gu
4b945e7218 kubelet: Remove GetRecentDockerContainersWithNameAndUUID(). 
Add unit tests to test the restart behaviour under different
restart policy.
 2015-04-08 09:44:23 -07:00
Yifan Gu
ddf323ee00 kubelet: Remove GetRecentDockerContainersWithNameAndUUID(). 
Always call GetPodStatus().
 2015-04-08 09:44:23 -07:00
Yifan Gu
6103b144e0 kubelet: Remove GetRecentDockerContainersWithNameAndUUID(). 
Use the pod status to get the recent stopped containers in
shouldContainerBeRestarted().
 2015-04-08 09:44:23 -07:00
Masahiro Sano
d04cc5ced4 List in NodesInterface takes label selector 2015-04-08 23:41:27 +09:00
gmarek
72182735b9 Remove Node Controllers ability to pull status from Kubelet 2015-04-08 09:44:42 +02:00
Daniel Smith
c1390a0836 version field selector field names in the client 2015-04-07 16:59:57 -07:00
Quinton Hoole
c670071e87 Revert "kubelet: Remove GetRecentDockerContainersWithNameAndUUID." 2015-04-07 14:25:10 -07:00
David Oppenheimer
402bf60366 Merge pull request #6214 from gmarek/move_consts_to_flags 
Move NodeController constants to flags
 2015-04-07 11:31:11 -07:00
gmarek
321a81047c Move NodeController constants to flags 2015-04-07 12:33:03 +02:00
Yifan Gu
ba1ad9fad2 kubelet: Refactor RunInContainer/ExecInContainer/PortForward. 
Replace GetKubeletDockerContainers() with findContainer().
 2015-04-06 17:14:46 -07:00
Victor Marmol
7716804a0d Merge pull request #6470 from yifan-gu/get_recent 
kubelet: Remove GetRecentDockerContainersWithNameAndUUID.
 2015-04-06 14:25:59 -07:00
Yifan Gu
a8c02412b2 kubelet: Remove GetRecentDockerContainersWithNameAndUUID(). 
Use the pod status to get the recent stopped containers in
shouldContainerBeRestarted().
 2015-04-06 12:43:49 -07:00
James DeFelice
d194af6b4f allow for more easily customized kubelet creation and initialization 2015-04-06 18:51:42 +00:00
Yu-Ju Hong
0e1bd18b3e Fix the kubelet node watch 2015-04-04 09:59:39 -07:00
Dawn Chen
67c1678e7e Merge pull request #6378 from yujuhong/docker_manager 
RFC: Kubelet: a step towards to better encapsulation of docker functions
 2015-04-02 14:22:26 -07:00
Yu-Ju Hong
d01bc660b5 Kubelet: a step towards to better encapsulation of docker functions 
We want to stop leaking more docker details into kubelet, and we also want to
consolidate some of the existing docker interfaces/structs. This change creates
DockerManager as the new home of some functions in dockertools/docker.go. It
also absorbs containerRunner. In addition, GetDockerPodStatus is renamed to
GetPodStatus with the entire pod passed to it so that it is simialr to the what
is defined in the container Runtime interface.

Eventually, DockerManager should implement the container Runtime interface, and
integrate DockerCache with a flag to turn on/off caching. Code in kubelet.go
should not be using docker client directly.
 2015-04-02 13:26:39 -07:00
Brian Grant
414be101b6 Merge pull request #6352 from piosz/api 
Removed PodStatus.Host
 2015-04-02 13:16:24 -07:00
Wojciech Tyczynski
6b08958264 Kubelet watching only its own Node 2015-04-02 18:39:59 +02:00
Piotr Szczesniak
5c6439d449 Removed PodStatus.Host 
Fixes #6165
 2015-04-02 16:38:45 +02:00
Dawn Chen
db28ca67f6 Using gcr.io/google_containers/pause by default 2015-04-01 14:59:44 -07:00
Kris Rousey
6904c4d585 Fixing a lot of string formatting issues with regards to: 
* Improper format specifier (e.g. %s for bools or %s for ints)
  * More or less parameters than format specifiers
  * Not calling a formatting function when it should have (e.g. Error() instead of Errorf())
 2015-03-31 16:47:10 -07:00
Victor Marmol
9bbf0b1546 Merge pull request #6100 from pmorie/entrypoint 
Add control over container entrypoint
 2015-03-31 09:58:40 -07:00
Victor Marmol
d6d370d8ae Merge pull request #6211 from dchen1107/docker 
publish node components version information
 2015-03-31 09:47:08 -07:00
Dawn Chen
5b9a6d47e8 publish node components version information 2015-03-31 09:32:29 -07:00
Paul Morie
7628b37d78 Add control over container entrypoint 2015-03-31 12:32:03 -04:00
Victor Marmol
de35c8f2af Record event when image GC fails. 2015-03-30 10:32:51 -07:00
Federico Simoncelli
0e60374346 nodes: record an event on NodeReady changes 
Signed-off-by: Federico Simoncelli <fsimonce@redhat.com>
 2015-03-30 12:01:09 -04:00
Federico Simoncelli
fe2d1f6762 node: move the reboot detection logic to kubelet 
Signed-off-by: Federico Simoncelli <fsimonce@redhat.com>
 2015-03-30 09:33:07 -04:00
Federico Simoncelli
604e0ad328 kubelet: move getNodeReference logic into a function 
Signed-off-by: Federico Simoncelli <fsimonce@redhat.com>
 2015-03-30 09:33:00 -04:00
Yu-Ju Hong
372c5c9f3a Kubelet: set host field in the pending pod status 
Otherwise, the apiserver would reject the update.
 2015-03-27 17:26:47 -07:00
Victor Marmol
e4fc45c26f Merge pull request #6054 from fgrzadkowski/fix_pod_status 
Do not fail pod status update if failed to get host IP
 2015-03-27 09:10:44 -07:00
Victor Marmol
4ed3346587 Merge pull request #6039 from yifan-gu/readiness 
kubelet: Add container readiness manager.
 2015-03-27 09:04:00 -07:00
Filip Grzadkowski
fe2f7f25c6 Do not fail if failed to get host IP 2015-03-27 14:15:41 +01:00
Yifan Gu
6fecda710c kubelet: Add container readiness manager. 
Move the readiness managing logic into pkg/kubelet/container package
to facilitate the pluggable container runtime.
 2015-03-26 18:45:23 -07:00