Commit Graph

48529 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
6f4ad7a413 Merge pull request #121491 from dejanzele/pod-replacement-policy-e2e
Switch feature flag to beta for pod replacement policy and add e2e test
2023-10-27 14:49:16 +02:00
Kubernetes Prow Robot
fd5c406112 Merge pull request #120933 from mengjiao-liu/contextual-logging-scheduler-remaining-part
kube-scheduler: convert the remaining part to use contextual logging
2023-10-27 10:30:58 +02:00
Dejan Pejchev
e98c33bfaf switch feature flag to beta for pod replacement policy and add e2e test
update pod replacement policy feature flag comment and refactor the e2e test for pod replacement policy

minor fixes for pod replacement policy and e2e test

fix wrong assertions for pod replacement policy e2e test

more fixes to pod replacement policy e2e test

refactor PodReplacementPolicy e2e test to use finalizers

fix unit tests when pod replacement policy feature flag is promoted to beta

fix podgc controller unit tests when pod replacement feature is enabled

fix lint issue in pod replacement policy e2e test

assert no error in defer function for removing finalizer in pod replacement policy e2e test

implement test using a sh trap for pod replacement policy

reduce sleep after SIGTERM in pod replacement policy e2e test to 5s
2023-10-26 21:50:37 +02:00
Dan Winship
fcc55280b0 Use k8s.io/utils/ptr in pkg/proxy (#121154)
* Use k8s.io/utils/ptr in pkg/proxy

* Replace pointer.String(), pointer.StringPtr(), and pointer.Bool() with ptr.To()

* Replace pointer.Int32(constexpr) with ptr.To[int32](constexpr)

* Replace pointer.Int32(int32(var)) with ptr.To(int32(var))

* Replace remaining pointer.Int32() cases with ptr.To

* Replace 'tcpProtocol := v1.ProtocolTCP; ... &tcpProtocol', etc with ptr.To(v1.ProtocolTCP)

* Replace 'nodeName = testHostname; ... &nodeName' with ptr.To(testHostname)

* Use ptr.To for SessionAffinityConfig.ClientIP.TimeoutSeconds

* Use ptr.To for InternalTrafficPolicy

* Use ptr.To for LoadBalancer.Ingress.IPMode
2023-10-26 20:56:39 +02:00
Kubernetes Prow Robot
801d460296 Merge pull request #120678 from rothgar/system-log-query
Fix systemd unit string matches
2023-10-26 20:56:28 +02:00
Kubernetes Prow Robot
53e91942bf Merge pull request #117780 from sourcelliu/schedulinggates
Improve the performance of schedulinggates
2023-10-26 18:14:32 +02:00
Kubernetes Prow Robot
c73ab5162b Merge pull request #116507 from sourcelliu/podrequest
Improve performance of method PodRequests
2023-10-26 15:58:16 +02:00
Kubernetes Prow Robot
993c918311 Merge pull request #121255 from tukwila/OpenAPIV3-cleanup
Remove GAed feature gates OpenAPIV3
2023-10-26 14:09:17 +02:00
Kubernetes Prow Robot
4aea803f3f Merge pull request #121254 from bart0sh/PR124-graduate-DevicePluginCDIDevices-to-Beta
Graduate DevicePluginCDIDevices to Beta
2023-10-26 12:59:19 +02:00
Kubernetes Prow Robot
7658fe8dc4 Merge pull request #118456 from testwill/bool-constant
chore: omit comparison to bool constant
2023-10-26 12:59:05 +02:00
Kubernetes Prow Robot
191abe34b8 Merge pull request #120550 from adrianchiris/fix-dra-node-reboot
DRA: call plugins for claims even if exist in cache
2023-10-26 10:26:59 +02:00
Kubernetes Prow Robot
92c4b3254f Merge pull request #118432 from testwill/stats
chore: loop optimization
2023-10-26 06:25:25 +02:00
Kubernetes Prow Robot
266b3929e4 Merge pull request #117529 from sourcelliu/podstatus
Improve the performance of isPodStatusCacheTerminal
2023-10-26 06:25:16 +02:00
Kubernetes Prow Robot
f997e50425 Merge pull request #117516 from sourcelliu/intcast
Remove unnecessary type conversion
2023-10-26 06:25:02 +02:00
Kubernetes Prow Robot
338aee71c3 Merge pull request #119898 from saschagrunert/semconv
Use tracing semconv types instead of own defines
2023-10-26 04:22:38 +02:00
Kubernetes Prow Robot
b7e5cbf1cf Merge pull request #121301 from sttts/sttts-validate-cloud-provider-2
kubeapiserver/options: fix cloud provider validation
2023-10-26 01:08:14 +02:00
Kubernetes Prow Robot
0501933e56 Merge pull request #121291 from bzsuni/ga/CSIMigrationvSphere
Remove GA featuregate about CSIMigrationvSphere in 1.29
2023-10-26 01:08:06 +02:00
Kubernetes Prow Robot
5fbc278d94 Merge pull request #121097 from danwinship/BaseEndpointInfo-fixes
BaseEndpointInfo cleanup
2023-10-26 01:07:56 +02:00
ruiwen-zhao
1165609036 Add metric for e2e pod startup latency including image pull
Signed-off-by: ruiwen-zhao <ruiwen@google.com>
2023-10-25 20:34:17 +00:00
Kubernetes Prow Robot
12b01aff1b Merge pull request #121275 from haircommander/image-max-gc
KEP-4210: add support for ImageMaximumGCAge field
2023-10-25 21:29:10 +02:00
Kubernetes Prow Robot
06a7febe00 Merge pull request #120864 from uablrek/kube-proxy-init
kube-proxy: Optionally do privileged configs only
2023-10-25 21:28:47 +02:00
Kubernetes Prow Robot
2749509f35 Merge pull request #121469 from sanposhiho/renamerename
cleanup: rename failedPlugin to plugin in framework.Status
2023-10-25 20:16:43 +02:00
Kubernetes Prow Robot
f82670d8ec Merge pull request #120680 from ruiwen-zhao/pod-start-bucket
Use a wider-range of metric buckets for PodStartDuration
2023-10-25 20:16:34 +02:00
Dan Winship
f91228ee71 Unexport BaseEndpointInfo fields, fix getter names
BaseEndpointInfo's fields, unlike BaseServicePortInfo's, were all
exported, which then required adding "Get" before some of the function
names in Endpoint so they wouldn't conflict.

Fix that, now that the iptables and ipvs unit tests don't need to be
able to construct BaseEndpointInfos by hand.
2023-10-25 09:00:46 -04:00
Dan Winship
e3357d0c5f Clean up Endpoint / BaseEndpointInfo a bit
Remove NodeName, which was unused because we only care about IsLocal
which was tracked separately.

Remove Zone, which was unused because it's from the old topology
system?

Fix up some comments which still referred to Endpoints vs
EndpointSlice differences.

Also remove an unhelpful helper function in endpoints_test.go
2023-10-25 08:59:53 -04:00
Dan Winship
2879ec10d5 Rewrite ipvs/iptables tests that manually construct BaseEndpointInfo
The tests in pkg/proxy already test that EndpointSlice ->
BaseEndpointInfo conversion works correctly; all we need to test in
pkg/proxy/ipvs and pkg/proxy/iptables is that the correct set of
endpoints get picked out where we expect them to, which doesn't
require us to compare the complete BaseEndpointInfo objects.
2023-10-25 08:59:53 -04:00
Kensei Nakada
27bb66fd7b cleanup: rename failedPlugin to plugin in framework.Status 2023-10-25 12:03:56 +00:00
adrianc
3738111337 Add unit tests
adjust existing tests and add new test flows
to cover new DRA manager behaviour

Signed-off-by: adrianc <adrianc@nvidia.com>
2023-10-25 13:20:22 +03:00
adrianc
08b942028f DRA: call plugins for claims even if exist in cache
Today, DRA manager does not call plugin NodePrepareResource
for claims that it previously successfully handled, that is,
if claims are present in cache (checkpoint) even if node
rebooted.

After node reboots, it is required to call DRA plugin
for resource claims so that plugins may prepare them
again in case the resources dont persist reboot.

To achieve that, once kubelet is started, we call DRA
plugins for claims once if a pod sandbox is required
to be created during PodSync.

Signed-off-by: adrianc <adrianc@nvidia.com>
2023-10-25 13:20:16 +03:00
Jan Safranek
e511edf11f Fix SELinux unit tests
Use device mountable volume, to make it impossible to share the same global
mount with different SELinux contexts.

And fix pod2Name to actually refer to pod2.
2023-10-25 10:43:29 +02:00
Jan Safranek
2f5903b4cf Move SELinux warning metric to be counted once per pod
volume_manager_selinux_volume_context_mismatch_warnings_total should be
counted only once per volume + pod. The previous location is evaluated
periodically, so bump the metric only when a new pod is added to volume.
2023-10-25 10:43:29 +02:00
Kubernetes Prow Robot
8453eb0c24 Merge pull request #121069 from jsafrane/ocp-add-plugin-label
Add volume plugin label to SELinux metrics
2023-10-25 08:13:20 +02:00
Kubernetes Prow Robot
0b884c0e3a Merge pull request #121494 from aojea/fix/flake-unit-test
Fix/flake TestNewManagerImplStartProbeMode  unit test
2023-10-25 06:57:04 +02:00
Kubernetes Prow Robot
e279e02076 Merge pull request #121465 from kerthcet/cleanup/remove-get-indexer
Remove unnecessary GetIndexer
2023-10-25 06:56:55 +02:00
Kubernetes Prow Robot
925a8dd3d3 Merge pull request #119947 from saschagrunert/keyring-unit
Add unit tests for subdomain match in keyring
2023-10-25 03:32:05 +02:00
Kubernetes Prow Robot
8cdab8a5db Merge pull request #121481 from dejanzele/job-pod-creation-total-metrics
feat: add job_pods_creation_total metric
2023-10-24 23:43:20 +02:00
Antonio Ojea
8e0be64b8f remove data race on the devicemanager client plugin
Change-Id: I45b85440a792e5ed2f75a344ec1f0332854d8d6d
2023-10-24 21:35:13 +00:00
Kubernetes Prow Robot
413b15a8d9 Merge pull request #120914 from kannon92/kubelet-disk-api-cri-update
Kubelet disk api cri update
2023-10-24 21:00:40 +02:00
Kubernetes Prow Robot
722503e9e5 Merge pull request #121390 from wojtek-t/disable_paging
Remove ability to disable pagination at store level
2023-10-24 18:55:16 +02:00
Dejan Pejchev
88c0a8be1b feat: add job_pods_creation_total metric 2023-10-24 17:49:04 +02:00
Kubernetes Prow Robot
d2383ce467 Merge pull request #121457 from SteveProXNA/stevepro-topology-endpoint-logging
Add endpoint to skip topology aware log when missing zone hint
2023-10-24 17:10:45 +02:00
Kubernetes Prow Robot
87981480f3 Merge pull request #119186 from seans3/stream-translator-proxy
Stream Translator Proxy and FallbackExecutor for WebSockets
2023-10-24 17:10:34 +02:00
kerthcet
b1ce529b2a Remove unnecessary GetIndexer
Signed-off-by: kerthcet <kerthcet@gmail.com>
2023-10-24 23:03:34 +08:00
Dejan Zele Pejchev
f8a4e343a1 Fix tracking of terminating Pods when nothing else changes (#121342)
* cleanup: refactor pod replacement policy integration test into staged assertion

* cleanup: remove typo in job_test.go

* refactor PodReplacementPolicy test and remove test for defaulting the policy

* fix issue with missing update in job controller for terminating status and refactor pod replacement policy integration test

* use t.Cleanup instead of defer in PodReplacementPolicy integration tests

* revert t.Cleanup to defer for reseting feature flag in PodReplacementPolicy integration tests
2023-10-24 15:04:46 +02:00
Kubernetes Prow Robot
9aa04752e7 Merge pull request #118463 from testwill/replace_loop
chore: slice replace loop
2023-10-24 15:04:39 +02:00
Kubernetes Prow Robot
cdd20eebb7 Merge pull request #118381 from SataQiu/fix-controller-20230601
controller: fix the help information format of sorting_deletion_age_ratio metric
2023-10-24 15:04:25 +02:00
Kubernetes Prow Robot
015297a577 Merge pull request #121327 from soltysh/fix_nextScheduleTimeDuration
Fix next schedule time duration
2023-10-24 12:18:35 +02:00
Mengjiao Liu
bd8ac8c7fa kube-scheduler: checked err for golangci-lint 2023-10-24 17:56:59 +08:00
Mengjiao Liu
b0a73213d6 kube-scheduler: convert the remaining part to use contextual logging 2023-10-24 17:56:48 +08:00
Maciej Szulik
bf2f640ea2 Add more test cases ensuring nextScheduleTimeDuration is never < 0 2023-10-24 11:08:02 +02:00