github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
119,292 Commits 1 Branch 31 Tags
e511edf11f73d82c2d910e5bb5d11ae3916b31a8
Commit Graph

398 Commits

Author SHA1 Message Date
Patrick Ohly
7d064812bb kube-controller-manager: finish conversion to contextual logging 
This removes all exceptions and fixes the remaining unconverted log calls.
 2023-07-12 14:57:29 +02:00
Michal Wozniak
bf48165232 Remarks to syncJobCtx 2023-07-11 09:44:08 +02:00
Michal Wozniak
990339d4c3 Introduce syncJobContext to limit the number of function parameters 2023-07-11 09:27:21 +02:00
Daniel Vega-Myhre
98c6e25c37 update name of pod index label 2023-07-10 20:11:52 +00:00
Aldo Culquicondor
f7a1fb76f4 Only declare job as finished after removing all finalizers 
Change-Id: Id4b01b0e6fabe24134e57e687356e0fc613cead4
 2023-07-07 14:08:19 -04:00
Daniel Vega-Myhre
3a02ecb341 check test case param instead of feature flag in unit test code 2023-07-06 17:30:40 +00:00
kannon92
921b7e6e8f remove equalReady and replace with k8 util function 2023-07-05 20:11:48 +00:00
Daniel Vega-Myhre
a647f9febb default enabled pod index for test cases, add test case disabling it 2023-07-05 18:47:45 +00:00
Daniel Vega-Myhre
e0af0a5a45 add test case param for feature flag 2023-06-29 21:51:15 +00:00
Daniel Vega-Myhre
a9afaa1eee add feature gate 2023-06-27 18:07:17 +00:00
Daniel Vega-Myhre
2176053415 add completion index as pod label 2023-06-26 19:53:14 +00:00
Michal Wozniak
8ed23558b4 Do not set jm.syncJobBatchPeriod=0 if not needed 2023-06-22 11:10:53 +02:00
Michal Wozniak
784a309b91 Do not error in Job controller sync when there are pod failures 2023-06-20 11:31:24 +02:00
Michal Wozniak
74c5ff97f1 Lower the constants for the rate limiter in Job controller 2023-06-16 17:00:04 +02:00
Michal Wozniak
c51a422d78 Cleanup job controller handling of backoff 2023-06-16 14:53:27 +02:00
Ziqi Zhao
7bc449d7e0 add contextual logging to job-controller 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
 2023-06-14 13:40:02 +08:00
Michal Wozniak
2f6b1d3c0f Ensure Job sync invocations are batched by 1s periods 2023-06-07 17:32:46 +02:00
Michal Wozniak
71ab7dc791 Remarks 2023-06-05 10:48:32 +02:00
Michal Wozniak
70d3bb43e5 Adjust the algorithm for computing the pod finish time 
Change-Id: Ic282a57169cab8dc498574f08b081914218a1039
 2023-06-05 10:06:56 +02:00
Michal Wozniak
0fe27a06f9 Cleanup the Job controller handling of terminating pods 2023-05-19 09:52:08 +02:00
Yuki Iwai
e4340f0d9b Job: Use generic Set in controller 
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
 2023-05-08 15:02:23 +09:00
Sathyanarayanan Saravanamuthu
c84c8add70 Decouple batch/job back-off logic from workqueues (#114768) 
* batch/job: decouple backoff from workqueue

Signed-off-by: Sathyanarayanan Saravanamuthu <sathyanarays@vmware.com>

* Resolving review comments

* Resolving more review comments

* Resolving review comments

Signed-off-by: Sathyanarayanan Saravanamuthu <sathyanarays@vmware.com>

* Computing finish time to now when FinishedAt is unix epoch

* Addressing review comments

Signed-off-by: Sathyanarayanan Saravanamuthu <sathyanarays@vmware.com>

---------

Signed-off-by: Sathyanarayanan Saravanamuthu <sathyanarays@vmware.com>
 2023-03-16 10:15:21 -07:00
Kubernetes Prow Robot
ccba890df9 Merge pull request #114420 from bzsuni/bz/optimization 
Cleanup: fix variable names in comments
 2023-03-09 21:33:37 -08:00
Daniel Vega-Myhre
d41302312e update validation logic so completions is mutable iff completions is modified in tandem with parallelsim so completions == parallelism 2023-02-23 03:25:16 +00:00
kannon92
32ac4a9581 left over uncounted from tracking cleanup 2023-02-22 16:45:53 +00:00
Daniel Vega-Myhre
2a81337e7c update prev succeeded indexes for indexed jobs unconditionally 2023-01-31 19:15:53 +00:00
Kubernetes Prow Robot
5550064bc2 Merge pull request #115063 from kannon92/tracking-remove-comments 
tracking with finalizers is the default way for the job controller so comments are not needed that say we are tracking with finalizers
 2023-01-17 07:56:44 -08:00
Kubernetes Prow Robot
9af5ae0365 Merge pull request #115030 from kannon92/remove-pod-error-job-tracking 
Update SyncJob with PodControllerError updates in job unit tests
 2023-01-13 12:08:14 -08:00
Kubernetes Prow Robot
70217a4083 Merge pull request #114944 from mimowo/fix-active-deadline-test 
Fix the job controller unit test for enforcing ActiveDeadlineSeconds
 2023-01-13 10:46:26 -08:00
kannon92
4890928b78 tracking with finalizers is the default way for the job controller 2023-01-13 16:48:35 +00:00
kannon92
3a838033f8 Update SyncJob with PodControllerError updates in job unit tests 2023-01-13 16:39:18 +00:00
Michal Wozniak
7065b42bb2 Fix the job controller unit test for enforcing ActiveDeadlineSeconds 2023-01-13 16:48:15 +01:00
Nikhita Raghunath
fd8d92a29d pkg/controller/job: re-honor exponential backoff 
This commit makes the job controller re-honor exponential backoff for
failed pods. Before this commit, the controller created pods without any
backoff. This is a regression because the controller used to
create pods with an exponential backoff delay before (10s, 20s, 40s ...).

The issue occurs only when the JobTrackingWithFinalizers feature is
enabled (which is enabled by default right now). With this feature, we
get an extra pod update event when the finalizer of a failed pod is
removed.

Note that the pod failure detection and new pod creation happen in the
same reconcile loop so the 2nd pod is created immediately after the 1st
pod fails. The backoff is only applied on 2nd pod failure, which means
that the 3rd pod created 10s after the 2nd pod, 4th pod is created 20s
after the 3rd pod and so on.

This commit fixes a few bugs:

1. Right now, each time `uncounted != nil` and the job does not see a
_new_ failure, `forget` is set to true and the job is removed from the
queue. Which means that this condition is also triggered each time the
finalizer for a failed pod is removed and `NumRequeues` is reset, which
results in a backoff of 0s.

2. Updates `updatePod` to only apply backoff when we see a particular
pod failed for the first time. This is necessary to ensure that the
controller does not apply backoff when it sees a pod update event
for finalizer removal of a failed pod.

3. If `JobsReadyPods` feature is enabled and backoff is 0s, the job is
now enqueued after `podUpdateBatchPeriod` seconds, instead of 0s. The
unit test for this check also had a few bugs:
    - `DefaultJobBackOff` is overwritten to 0 in certain unit tests,
    which meant that `DefaultJobBackOff` was considered to be 0,
    effectively not running any meaningful checks.
    - `JobsReadyPods` was not enabled for test cases that ran tests
    which required the feature gate to be enabled.
    - The check for expected and actual backoff had incorrect
    calculations.
 2023-01-12 20:34:10 +05:30
kannon92
6dfaeff33c Remove Legacy Job Tracking 2023-01-10 14:52:54 +00:00
Kubernetes Prow Robot
e7549eae87 Merge pull request #114905 from kannon92/sync-job-test-fix 
Fix SyncPastDeadlineJobFinished for enabling finalizer path
 2023-01-09 12:47:28 -08:00
kannon92
0362c67859 Fix SyncPastDeadlineJobFinished for enabling finalizer path 2023-01-09 17:12:52 +00:00
Aldo Culquicondor
4c1b95ddfa Ensure job is up to date in informer cache in test 
The fake client doesn't guarantee that the informer cache is updated.
If it's not up-to-date, the controller always tries to set the
StartTime, leading to a broken test.

Change-Id: I71f26d46ea44beff88f0d03517985348654aec95
 2023-01-09 10:53:19 -05:00
Harsha Narayana
208c3868cf job controller: refactored job controller to be able to inject FakeClock for Unit Test 2022-12-20 21:29:24 +05:30
bzsuni
16fcb1c708 optimise some code 2022-12-13 09:56:36 +08:00
Kubernetes Prow Robot
0cd13e573c Merge pull request #113196 from mimowo/job-controller-reviewer 
Self-nominate mimowo as a reviewer for pkg/controller/job & test/integration/job packages
 2022-12-10 02:01:39 -08:00
ialidzhikov
aede3fbf40 pkg/controller: Replace deprecated func usage from the k8s.io/utils/pointer pkg 2022-11-23 17:40:23 +02:00
Aldo Culquicondor
7dc36bdf82 Wait for Pods to finish before considering Failed in Job (#113860) 
* Wait for Pods to finish before considering Failed

Limit behavior to feature gates PodDisruptionConditions and
JobPodFailurePolicy and jobs with a podFailurePolicy.

Change-Id: I926391cc2521b389c8e52962afb0d4a6a845ab8f

* Remove check for unsheduled terminating pod

Change-Id: I3dc05bb4ea3738604f01bf8cb5fc8cc0f6ea54ec
 2022-11-15 09:44:53 -08:00
Aldo Culquicondor
bc5afaf580 Fix match onExitCodes when Pod is not terminated 
Change-Id: Id1f9c46f8b6a12115577a1fadb12adc580c9ba6a
 2022-11-11 10:05:11 -05:00
Michal Wozniak
c803892bd8 Enable the feature into beta 2022-11-09 09:02:40 +01:00
Maciej Szulik
39d9981dc2 Promote job-related metrics to stable 2022-11-07 19:28:40 +01:00
Aldo Culquicondor
4948918155 Graduate JobTrackingWithFinalizers to stable 
Change-Id: Ifc749a85b1270c0155ac511b91d4681d53236820
 2022-11-04 17:05:53 -04:00
Aldo Culquicondor
5e03865f65 Add benchmark for large indexed job 
Change-Id: I556f0cce5842699c98654cfb5a66e7c8d63b2e2e
 2022-11-02 11:56:26 -04:00
Michał Woźniak
3628532311 Extend metrics with the new labels (#113324) 
* Extend job metrics

* Refactor TestMetrics to extract its checks into dedicated tests per feature
 2022-10-31 08:50:45 -07:00
Aldo Culquicondor
12d308f5c4 Add metric for terminated pods with tracking finalizer 
Change-Id: I26f3169588c30ed82250cb7baff8e277f8d13bb7
 2022-10-20 11:35:20 -04:00
Michal Wozniak
b1e575aaf7 Self-nominate mimowo as a reviewer for pkg/controller/job & test/integration/job 
I think I'm ready to start review and LGTM code changes within this
package, but not necessarily for the entire sig-apps.

My PRs to the packages:
https://github.com/kubernetes/kubernetes/pull/110292
https://github.com/kubernetes/kubernetes/pull/111113
https://github.com/kubernetes/kubernetes/pull/112948

PRs to the packages I contributed reviews to:
https://github.com/kubernetes/kubernetes/pull/113166
https://github.com/kubernetes/kubernetes/pull/110294
 2022-10-20 09:22:35 +02:00