Haosdent Huang
b09e35257a
Remove scheduler/algorithm/priorities
in import-restrictions
2020-01-22 11:54:28 +08:00
Kubernetes Prow Robot
8cd0c42845
Merge pull request #87407 from haosdent/remove-registry-args
...
Deprecate scheduler's framework.plugins.RegistryArgs
2020-01-21 16:26:57 -08:00
Wei Huang
170714e532
Remove folder pkg/scheduler/algorithm
2020-01-21 14:33:08 -08:00
Kubernetes Prow Robot
c9b4cf3d25
Merge pull request #87342 from Huang-Wei/move-predicates-to-kubelet
...
Move GeneralPredicates logic to kubelet.
2020-01-21 12:58:47 -08:00
Kubernetes Prow Robot
95fcc5f777
Merge pull request #87072 from fenggw-fnst/work
...
Fix typo in comments for func GetFullContainerName
2020-01-21 12:58:34 -08:00
Wei Huang
3f8b202266
Move GeneralPredicates logic to kubelet.
2020-01-21 09:27:00 -08:00
Kubernetes Prow Robot
37f98ac3b6
Merge pull request #87401 from zouyee/move
...
Move scheduler's SchedulerExtender interface to core/extenders.go
2020-01-21 09:21:50 -08:00
Haosdent Huang
50d511d4b8
Deprecate scheduler's framework.plugins.RegistryArgs
2020-01-21 23:50:58 +08:00
Kubernetes Prow Robot
29a4b39536
Merge pull request #87382 from yiyang5055/fix-staticcheck
...
fix static check failure in pkg/controller/disruption and pkg/control…
2020-01-21 06:35:37 -08:00
zouyee
d6b449b5c7
Move scheduler's SchedulerExtender interface to core/extenders.go
...
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
2020-01-21 20:20:20 +08:00
Kubernetes Prow Robot
48cb968825
Merge pull request #87297 from alculquicondor/cleanup/get_binder
...
Replace Scheduler.GetBinder with a method
2020-01-20 21:25:36 -08:00
Kubernetes Prow Robot
9822016bf8
Merge pull request #87397 from klueska/upstream-cpu-manager-set-initial-containers
...
Initialize CPUManager containerMap to set of initial containers
2020-01-20 17:39:50 -08:00
Kubernetes Prow Robot
e6b5194ec1
Merge pull request #84300 from klueska/upstream-cpu-manager-reconcile-on-container-state
...
Update logic in `CPUManager` `reconcileState()`
2020-01-20 12:27:37 -08:00
Kevin Klues
bd9d8fa42f
Initialize CPUManager containerMap to set of initial containers
...
A recent change made it so that the CPUManager receives a list of
initial containers that exist on the system at startup. This list can be
non-empty, for example, after a kubelet retart.
This commit ensures that the CPUManagers containerMap structure is
initialized with the containers from this list.
2020-01-20 20:42:29 +01:00
Aldo Culquicondor
eb265bc7db
Remove GetBinder member and replace it with a method.
...
Signed-off-by: Aldo Culquicondor <acondor@google.com>
2020-01-20 14:10:02 -05:00
Kubernetes Prow Robot
37ee6425ef
Merge pull request #87255 from klueska/upstream-remove-redundant-active-pods-check
...
Remove check for empty activePods list in CPUManager removeStaleState
2020-01-20 09:05:50 -08:00
Aldo Culquicondor
7a39e1396a
Remove unnecessary slow binding test
...
Signed-off-by: Aldo Culquicondor <acondor@google.com>
2020-01-20 11:49:45 -05:00
Kubernetes Prow Robot
23fa359d6c
Merge pull request #84705 from whypro/cpumanager-panic-master
...
Return error instead of panic when cpu manager fails on startup.
2020-01-20 07:25:37 -08:00
mattjmcnaughton
73b2d83125
Refactor docker specific oom const out of qos pkg
...
Previously, `pkg/kubelet/qos` contained two different docker-specific
OOM constants. One set the oom adj for sandbox docker containers and the
other set the oom adj for the docker daemon. Move both to be closer to
their actual usages in `dockershim`.
This change addresses a TODO and leads us towards the overall goal of
making `pkg/kubelet` runtime agnostic except for `dockershim`.
2020-01-20 10:22:31 -05:00
Kevin Klues
7be9b0fe55
Update comments and error messages in the CPUManager
2020-01-20 15:31:01 +01:00
Kevin Klues
f2acbf6607
Base CPUManager state reconciliation on container state, not pod state
2020-01-20 13:57:30 +00:00
Kevin Klues
f6cf9b8ce9
Move CPUManager Pod Status logic before container loop
2020-01-20 13:57:30 +00:00
Kubernetes Prow Robot
f680c261e6
Merge pull request #87074 from yuxiaobo96/k8s-staticcheck
...
fix staticcheck: pkg/volume/awsebs
2020-01-20 03:09:37 -08:00
yuxiaobo
221396ac35
cleanup: delete unused func
...
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2020-01-20 18:20:57 +08:00
yiyang5055
53aff819e0
fix static check failure in pkg/controller/disruption and pkg/controller/namespace/deletion
2020-01-20 09:10:46 +00:00
yuxiaobo
72f34b817e
staticcheck: pkg/volume/fc, pkg/volume/portworx and pkg/volume/vsphere_volume
...
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2020-01-20 16:47:54 +08:00
Mike Spreitzer
ce12105edc
Added server-side printers for the API object types for API priority and fairness
2020-01-20 01:49:05 -05:00
Kubernetes Prow Robot
3d8317ae91
Merge pull request #87139 from yuxiaobo96/k8s-staticcheck2
...
fix staticcheck:pkg/volume/cinder
2020-01-19 21:47:36 -08:00
drfish
f19f4e40f9
Fix static check errors in pkg/util/netsh
2020-01-20 13:25:34 +08:00
Kubernetes Prow Robot
073da1588a
Merge pull request #86801 from likakuli/fix_syncsts_orphanrevision
...
fix a bug that orphan revision cannot be adopted and statefulset cannot be synced
2020-01-19 00:07:35 -08:00
Kubernetes Prow Robot
f4b6b751cd
Merge pull request #87081 from dims/updating-protobuf-and-grpc
...
Updating protobuf (v1.3.1) and grpc (v1.26.0)
2020-01-18 13:01:36 -08:00
Kubernetes Prow Robot
37d9c22abe
Merge pull request #86377 from wojtek-t/immutable_secrets_api
...
API for immutable Secrets and ConfigMaps
2020-01-18 05:25:35 -08:00
Kubernetes Prow Robot
c1b696d672
Merge pull request #87313 from MikeSpreitzer/apf-validation
...
Update validation for API Priority and Fairness
2020-01-18 01:49:51 -08:00
Kubernetes Prow Robot
967b40f051
Merge pull request #86137 from robscott/endpointslice-proxy-feature
...
Creating new EndpointSliceProxying feature gate for kube-proxy, enabling EndpointSlice feature gate by default
2020-01-17 21:39:36 -08:00
Mike Spreitzer
47ad6db1dc
Fixup comments in internalbootstrap
2020-01-17 22:16:50 -05:00
Kubernetes Prow Robot
3538320d74
Merge pull request #87165 from alculquicondor/cleanup/mv_snapshot_2
...
Move Snapshot to internal/cache
2020-01-17 17:14:07 -08:00
Rob Scott
469de65c25
Enabling EndpointSlice feature gate by default
...
This enables the EndpointSlice controller by default, but does not make
kube-proxy a consumer of the EndpointSlice API.
2020-01-17 16:19:29 -08:00
Rob Scott
47b2593d59
Creating new EndpointSliceProxying feature gate for kube-proxy
...
This creates a new EndpointSliceProxying feature gate to cover EndpointSlice
consumption (kube-proxy) and allow the existing EndpointSlice feature gate to
focus on EndpointSlice production only. Along with that addition, this enables
the EndpointSlice feature gate by default, now only affecting the controller.
The rationale here is that it's really difficult to guarantee all EndpointSlices
are created in a cluster upgrade process before kube-proxy attempts to consume
them. Although masters are generally upgraded before nodes, and in most cases,
the controller would have enough time to create EndpointSlices before a new node
with kube-proxy spun up, there are plenty of edge cases where that might not be
the case. The primary limitation on EndpointSlice creation is the API rate limit
of 20QPS. In clusters with a lot of endpoints and/or with a lot of other API
requests, it could be difficult to create all the EndpointSlices before a new
node with kube-proxy targeting EndpointSlices spun up.
Separating this into 2 feature gates allows for a more gradual rollout with the
EndpointSlice controller being enabled by default in 1.18, and EndpointSlices
for kube-proxy being enabled by default in the next release.
2020-01-17 16:17:40 -08:00
Mike Spreitzer
4d88acee51
Made internalbootstrap gin up its own Scheme
...
doing our part to reduce usage of legacyscheme.Scheme
2020-01-17 16:47:40 -05:00
Mike Spreitzer
5330bd7440
dogged insistence on full verbosity
2020-01-17 15:46:36 -05:00
Kubernetes Prow Robot
f88f58cb79
Merge pull request #87245 from 928234269/fix_staticcheck
...
fix staticcheck errors in pkg/volume/hostpath.
2020-01-17 12:15:18 -08:00
Aldo Culquicondor
f53d7e55df
Move Snapshot from nodeinfo/snapshot to internal/cache
...
Signed-off-by: Aldo Culquicondor <acondor@google.com>
2020-01-17 13:29:41 -05:00
Kubernetes Prow Robot
0040920045
Merge pull request #87293 from pmorie/brad-childs-owners
...
Remove Brad Childs from OWNERS files
2020-01-17 09:00:56 -08:00
Aldo Culquicondor
6a14203658
Rename cache's Snapshot to Dump
...
Signed-off-by: Aldo Culquicondor <acondor@google.com>
2020-01-17 11:28:08 -05:00
Davanum Srinivas
b3853138a4
update generated files
2020-01-17 11:23:53 -05:00
Kubernetes Prow Robot
50f9ea7999
Merge pull request #85798 from nolancon/merge-policy-rebase
...
Updated - topologymanager: Add Merge method to Policy
2020-01-17 05:14:56 -08:00
Kubernetes Prow Robot
6278df2a97
Merge pull request #82223 from rikatz/issue77493
...
Check first if ipvs module is builtin
2020-01-17 03:52:56 -08:00
Sakura
fe8b32317f
delete unused field
...
Signed-off-by: Sakura <longfei.shang@daocloud.io>
2020-01-17 19:34:48 +08:00
Mike Spreitzer
ec5321c6a9
Update validation for API Priority and Fairness
...
This PR fixes oversights and adds validation that rejects writes
of wrong Spec values for the four mandatory objects.
2020-01-17 02:43:52 -05:00
Kobayashi Daisuke
ed1381e35f
Fix staticcheck in pkg/controller/podgc
2020-01-17 15:42:38 +09:00
Wei Huang
c712230ac1
Implement default queue sort logic as a scheduler plugin
2020-01-16 19:10:43 -08:00
Paul Morie
afaea605f4
Remove Brad Childs from OWNERS files
2020-01-16 15:21:34 -05:00
Kubernetes Prow Robot
9701baea0f
Merge pull request #87283 from klueska/update-printing-for-tm-bitmask
...
Update bitmask printing to print in groups of 2 instead of all 64 bits
2020-01-16 12:04:32 -08:00
Kevin Klues
708278098a
Update bitmask printing to print in groups of 2 instead of all 64 bits
2020-01-16 17:28:52 +01:00
Kubernetes Prow Robot
0c1d714627
Merge pull request #87128 from Aresforchina/fix-staticcheck-test12
...
fix-staticcheck:pkg/volume/emptydir
2020-01-16 07:48:50 -08:00
Kevin Klues
7069b1d6e8
Update TopologyManager single-numa-node logic to handle "don't cares"
...
The logic has been updated to match the logic of the best-effort policy
except in two places:
1) The hint filtering frunction has been updated to allow "don't care"
hints encoded with a `nil` affinity mask, to pass through the filter in
addition to hints that have just a single NUMA bit set.
2) After calculating the `bestHint` we transform "don't care" affinities
encoded as having all NUMA bits set in their affinity masks into "don't
care" affinities encoded as `nil`.
2020-01-16 08:50:35 +00:00
Kevin Klues
2905ffffa7
Rename TopologyManager test TestPolicyBestEffortMerge for consistency
2020-01-16 08:50:21 +00:00
Kevin Klues
94489c137c
Cleanup use of defaultAffinity in mergePermutation of TopologyManager
2020-01-16 08:50:12 +00:00
nolancon
5e23517ebf
Use reflect.DeepEqual check in policy_test.go
2020-01-16 08:13:07 +00:00
nolancon
92eb7cd601
Update "Single NUMA hint generation" expected affinity to nil
2020-01-16 08:13:07 +00:00
nolancon
8b3f6e61a2
Move test case "Two providers, 1 with 2 hints, 1 with single
...
non-preferred hint matching" into specific policy tests
2020-01-16 08:13:07 +00:00
nolancon
681c42bfc2
Move test case "Two providers, 1 hint each, same mask, 1 preferred, 1
...
not 2/2" into specific policy tests
2020-01-16 08:13:07 +00:00
nolancon
a38a2562b2
Move test case "Two providers, 1 hint each, same mask, 1 preferred, 1
...
not 1/2" into specific policy test.
2020-01-16 08:13:07 +00:00
nolancon
f639da7637
Move test case "Two providers, 1 hint each, no common mask" into
...
specific policy tests.
2020-01-16 08:13:07 +00:00
nolancon
401a2bb285
Move test case "Single TopologyHint with Preferred as false and
...
NUMANodeAffinity as nil" into specific policy tests.
2020-01-16 08:13:06 +00:00
nolancon
6460ef6392
Move test case "Single TopologyHint with Preferred as true and
...
NUMANodeAffinity as nil" into specific policy tests.
2020-01-16 08:13:06 +00:00
nolancon
baeff9ec5d
Move test case "HintProvider returns empty non-nil map[string][]TopologyHint from
...
provider" into specific policy tests.
2020-01-16 08:13:06 +00:00
nolancon
599217d482
Move test case "HintProvider returns -nil map[string][]TopologyHint from provider" into specific policy tests
2020-01-16 08:13:06 +00:00
nolancon
57661ee946
Move test case 'HintProvider returns empty non-nil map[string][]TopologyHint' into specific policy tests.
2020-01-16 08:13:06 +00:00
nolancon
51f1af0395
Move test case 'TopologyHint not set' into individual policy tests
2020-01-16 08:13:06 +00:00
nolancon
8466a5852a
Restore policy_test.go to upstream
...
Following commits will contain incremental changes to this file to ease
review process and ensure all tests are accounted for.
2020-01-16 08:13:06 +00:00
nolancon
59bb6c4d6f
Update checks in mergeProvidersHints:
...
- Initialize best Hint to TopologyHint{}
- Update checks.
- Move generic unit test case into policy specific tests and updated
expected outcome to reflect changes.
2020-01-16 08:13:06 +00:00
nolancon
6758f95117
Restore original policy none test cases:
...
Mistakenly overwritten in earlier commit
2020-01-16 08:13:06 +00:00
nolancon
2d1a535a35
Make mergePermutation generic:
...
- Remove policy parameters to make function generic
- Move function into top level policy.go
2020-01-16 08:13:06 +00:00
nolancon
5487941485
Refactor filterHints:
...
- Restructure function
- Remove bug fix for catching {nil true} - To be fixed in later commit
- Restore unit tests to original state for testing filterHints
2020-01-16 08:13:06 +00:00
nolancon
adfd11f38f
Make iterateAllProviderTopologyHints generic:
...
- Remove policy parameters to make this function generic.
- Move function out of individual policies and into policy.go
2020-01-16 08:13:06 +00:00
nolancon
e43f0a5293
Reinstate canAdmitPodResult in policy_none:
...
This is to keep consistency with the other policies.
This change may be made across all policies in a future PR, but removing it
from the scope of this PR for now.
2020-01-16 08:13:05 +00:00
nolancon
4cc5b9e46c
Edit hints returned from policies and unit tests:
...
- Best Effort Policy: Return hint with nil affinity as opposed to
defaultAffinity when provider has no preference for NUMA affinty or no
possible NUMA affinities.
- Single NUMA Node Policy: Remove defaultHint from mergeProvidersHints.
Instead return appropriate TopologyHint where required.
- Update unit tests to reflect changes. Some test cases moved into
individual policy test functions due to differing returned affinties
per policy.
2020-01-16 08:13:05 +00:00
nolancon
e3d0c9397f
Updates to single-numa-node policy:
...
- Remove getHintMatch method.
- Replace with simplified versions of mergePermutation and
iterateAllProviderTopologyHints methods - as used in best-effort.
- Remove getHintMatch unit tests.
2020-01-16 08:13:05 +00:00
nolancon
b5ca4989e3
Update unit tests:
...
- Update filterHints test to reflect changes in previous commit.
- Some common test cases achieve differing expected results based on
policy due to independent merge strategies. These cases are moved into
individual policy based test functions.
2020-01-16 08:13:05 +00:00
nolancon
17d615bca2
Update filterHints:
...
- Only append valid preferred-true hints to filtered
- Return true if allResourceHints only consist of
nil-affinity/preferred-true hints: {nil true}, update defaultHint
preference accordingly.
2020-01-16 08:13:05 +00:00
Adrian Chiris
9f21f49493
Additional unit tests for Topology Manager methods
2020-01-16 08:13:05 +00:00
Adrian Chiris
f886d2a832
Update single-numa-node policy unit tests
2020-01-16 08:13:05 +00:00
Adrian Chiris
2825a7be1a
Add new functionality for single-numa-node policy:
...
Explanation taken from original commit:
- Change the current method of finding the best hint.
Instead of going over all permutations, sort the hints and find
the narrowest hint common to all resources.
- Break out early when merging to a preferred hint is not possible
2020-01-16 08:13:05 +00:00
Adrian Chiris
5ce2ea2773
Return defaultAffinity from PolicyBestEffort:
...
Now that PolicySingleNUMANode is not considered here, return
defaultAffinity as was the original case before previous bug fix
2020-01-16 08:13:05 +00:00
Adrian Chiris
eda1521562
Make mergeProviderHints policy-specific:
...
- Remove need to pass policy and numaNodes as arguments
- Remove PolicySingleNUMANode special case check in policy_best_effort
- Add mergeProviderHints base to policy_single_numa_node for upcoming
commit
2020-01-16 08:13:05 +00:00
Adrian Chiris
dc36924c37
Update policy_none removing canAdmitPodResult
...
Update unit tests for none_policy
Add Name test for policy_restricted
2020-01-16 08:13:05 +00:00
Adrian Chiris
cf8b098dda
Refactor policy-best-effort
...
- Modularize code with mergePermutation method
2020-01-16 08:13:05 +00:00
Sascha Grunert
278717bc57
Fix ineffectual assignment to CPUSets
...
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
2020-01-16 08:57:42 +01:00
Guangwen Feng
e2e5bf5e0b
Fix golint warning for pkg/util/procfs/procfs_linux.go
...
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
2020-01-16 15:16:47 +08:00
Kubernetes Prow Robot
f437ff75d4
Merge pull request #87254 from egernst/lame-typo-fix
...
simple typo fix
2020-01-15 21:21:57 -08:00
Kubernetes Prow Robot
550034022f
Merge pull request #87238 from yuzhiquan/patch-scheduler
...
cleanup(scheduler): remove unused function, remove duplicate comment
2020-01-15 21:21:46 -08:00
yuzhiquan
0e81e39465
cleanup(scheduler): remove unused function, remove duplicate comment, implement interface
...
update bazel
2020-01-16 09:07:09 +08:00
Kevin Klues
34b942a41d
Remove check for empty activePods list in CPUManager removeStaleState
...
This check is redundant since we protect this call with a call to
`m.sourcesReady.AllReady()` earlier on. Moreover, having this check in
place means that we will leave some stale state around in cases where
there are actually no active pods in the system and this loop hasn't
cleaned them up yet. This can happen, for example, if a pod exits while
the kubelet is down for some reason. We see this exact case being
triggered in our e2e tests, where a test has been failing since October
when this change was first introduced.
2020-01-15 20:09:24 +01:00
Kevin Klues
5802f3a910
Add proper activePods list in TestGetTopologyHints for CPUManager
2020-01-15 20:08:41 +01:00
Eric Ernst
cdd92d39b7
preemption: typo cleanup
...
Signed-off-by: Eric Ernst <eric.ernst@intel.com>
2020-01-15 10:55:40 -08:00
Kubernetes Prow Robot
15aa065e86
Merge pull request #86569 from zouyee/btos
...
using string instead of byte
2020-01-15 08:25:49 -08:00
Kubernetes Prow Robot
97d68d014c
Merge pull request #86172 from liggitt/intstr
...
Clarify intstr.IntValue() behavior
2020-01-15 08:25:35 -08:00
Sakura
4143bc7a96
fix staticcheck errors in pkg/volume/hostpath.
...
Signed-off-by: Sakura <longfei.shang@daocloud.io>
2020-01-15 22:54:48 +08:00
ialidzhikov
a038a33dcf
Clean up commented assertions in tests
...
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
2020-01-15 11:34:27 +02:00
Kubernetes Prow Robot
208cc18c69
Merge pull request #86728 from mattjmcnaughton/mattjmcnaughton/add-test-coverage-oom-watcher
...
Add test coverage for oom watcher
2020-01-15 01:21:33 -08:00
Kubernetes Prow Robot
de34d2ce1e
Merge pull request #87193 from mattjmcnaughton/mattjmcnaughton/cleanup-rkt-code-in-pleg
...
Clean up rkt specific code in `pkg/kubelet/pleg`
2020-01-14 22:21:46 -08:00
Aresforchina
514bdbedac
fix-static:pkg/volume/scaleio/
2020-01-15 09:53:27 +08:00
Kubernetes Prow Robot
9173a5f93f
Merge pull request #87164 from liggitt/sar-approver-v1
...
Use v1 subjectaccessreview API in controller-manager CSR approver
2020-01-14 17:22:58 -08:00
Kubernetes Prow Robot
88cf4e5c25
Merge pull request #87091 from ahg-g/ahg-cleanup
...
Remove last scheduler dependencies on predicates package
2020-01-14 17:21:39 -08:00
Kubernetes Prow Robot
b046f742bd
Merge pull request #87038 from alculquicondor/cleanup/mv_snapshot
...
Remove direct use of Snapshot's data structures
2020-01-14 17:21:29 -08:00
mattjmcnaughton
9077603b97
Add richer unit tests for OomWatcher
...
Add unit tests for OomWatcher that actually test the logic defined in
the `Start` method. As a result of an earlier refactor, its now trivial
to mock the OOMInstance events which the `oom_watcher` is supposed to be
watching.
2020-01-14 07:57:06 -05:00
mattjmcnaughton
ab7e0f58d5
Clean up rkt specific code in pkg/kubelet/pleg
...
Clean up code in PLEG which was only necessary for the `rkt` runtime.
Rkt is no longer a built-in runtime and docker(shim) uses the CRI, so
its safe to remove this code entirely.
This diff removes the last mentions of `rkt` in the kubelet.
2020-01-14 07:42:30 -05:00
Kubernetes Prow Robot
be26fbc638
Merge pull request #86282 from RainbowMango/pr_refactor_resource_endpoint
...
Refactor kubelet resource metrics
2020-01-14 02:23:09 -08:00
Kubernetes Prow Robot
f4db8212be
Merge pull request #76496 from danielqsj/metrics-2
...
Clean deprecated metrics
2020-01-13 20:53:09 -08:00
Kubernetes Prow Robot
61d36e4a43
Merge pull request #85850 from danwinship/kubelet-ipv6-node-ip
...
Allow "kubelet --node-ip ::" to mean prefer IPv6
2020-01-13 17:41:08 -08:00
Kubernetes Prow Robot
e1cc36000f
Merge pull request #87002 from SataQiu/staticcheck-20200109
...
Fix staticcheck failures of pkg/util/ipconfig pkg/util/iptables pkg/util/ipvs/testing
2020-01-13 13:58:55 -08:00
Antonio Ojea
de15774e10
kube-proxy unit test FilterIncorrectIPVersion
...
Add an unit test to the kube-proxy FilterIncorrectIPVersion function
2020-01-13 22:44:22 +01:00
Jordan Liggitt
054e3846fc
Use v1 subjectaccessreview API in controller-manager CSR approver
2020-01-13 15:55:52 -05:00
Aldo Culquicondor
187d711225
Split findNodesThatFit into framework and extenders logic
...
Signed-off-by: Aldo Culquicondor <acondor@google.com>
2020-01-13 14:10:17 -05:00
Aldo Culquicondor
63c1c68d0c
Remove direct use of Snapshot's data structures
...
Signed-off-by: Aldo Culquicondor <acondor@google.com>
2020-01-13 14:10:17 -05:00
Abdullah Gharaibeh
fb66e807cd
Remove scheduler framework dependency on predicates package
2020-01-13 13:02:31 -05:00
yuxiaobo
da15570daa
fix staticcheck:pkg/volume/cinder
...
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2020-01-13 18:20:23 +08:00
Aresforchina
e62f9625cf
fix-static:pkg/volume/emptydir
2020-01-13 15:23:45 +08:00
wojtekt
9174905ae7
Autogenerated
2020-01-12 21:09:05 +01:00
wojtekt
e612ebfdff
Immutable field and validation
2020-01-12 20:51:31 +01:00
Kubernetes Prow Robot
c0e245fa0e
Merge pull request #85268 from yue9944882/feat/flow-control-defaulting
...
Bootstrap flow-control objects
2020-01-11 12:27:37 -08:00
Kubernetes Prow Robot
ace98e1382
Merge pull request #84433 from yamt/comment-typo
...
Fix a comment typo in legacyNodeRoleBehaviorFeature
2020-01-10 17:17:38 -08:00
Kubernetes Prow Robot
8467561f2c
Merge pull request #86783 from mattjmcnaughton/mattjmcnaughton/remove-unnecessary-modification-container-pid-namespace
...
Remove no longer needed `modifyContainerPIDNamespaceOverrides`
2020-01-10 15:43:50 -08:00
Kubernetes Prow Robot
befc371364
Merge pull request #86702 from mattjmcnaughton/mattjmcnaughton/refactor-oom-watcher-to-allow-greater-test-coverage
...
Refactor oom watcher to allow greater test coverage
2020-01-10 15:43:37 -08:00
Kubernetes Prow Robot
240782c7f7
Merge pull request #87043 from zjs/topic/propagate-providerid-errors
...
Ensure a provider ID is set on a node if expected
2020-01-10 14:33:50 -08:00
Kubernetes Prow Robot
dc2099ea11
Merge pull request #87055 from denkensk/clean-unused-predicate-error
...
Cleanup unused predicate error types.
2020-01-10 12:25:16 -08:00
Kubernetes Prow Robot
942b526e5c
Merge pull request #87051 from Huang-Wei/remove-prio-util-pkg
...
Remove scheduler/algorithm/priorities/util package
2020-01-10 12:25:01 -08:00
Kubernetes Prow Robot
6e2a2855ef
Merge pull request #87034 from ritazh/azure-owners
...
Update Azure owners
2020-01-10 12:24:49 -08:00
Zach Shepherd
2b554079af
Ensure a provider ID is set on a node if expected
...
A transient issue might occur that causes an error to be returned by
InstanceID(). When this is ignored, the external cloud provider taint
will be removed and neither AddCloudNode() nor UpdateCloudNode() will
try to set a provider ID in the future.
By returning the error we can ensure that the external cloud provider
taint is not removed prematurely, allowing the operation to be retried
(until the provider ID can be set).
Preserve support for external cloud providers that do not use IDs by
continuing if a NotImplemented error is returned, making a distinction
between lack of support for provider IDs and an actual error.
Introduce pair of unit tests that show a provider ID will eventually
be set if an error is returned, unless that error is a NotImplemented,
in which case the external cloud provider taint will be removed.
2020-01-10 11:00:54 -08:00
yue9944882
70dea6e4a8
review: several fixes and addressing comments
2020-01-11 01:46:31 +08:00
Kubernetes Prow Robot
a66adcb4f1
Merge pull request #87050 from KobayashiD27/fixgolint
...
fix golint error in pkg/apis/rbac
2020-01-10 08:58:48 -08:00
Kubernetes Prow Robot
a5a48d0bf3
Merge pull request #87037 from Huang-Wei/remove-util-pkg
...
Cleanup scheduler/algorithm/predicates package
2020-01-10 08:58:35 -08:00
Kubernetes Prow Robot
3341611480
Merge pull request #87001 from chendotjs/ipvs-typofix
...
fix typo in ipvs proxier README
2020-01-10 06:24:34 -08:00
yuxiaobo
c5764735e2
fix staticcheck:pkg/volume/awsebs
...
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
2020-01-10 18:36:39 +08:00
danielqsj
ab182552b4
clean SinceInMicroseconds, convert to SinceInSeconds
2020-01-10 17:05:38 +08:00
danielqsj
a8f2feaeb5
remove deprecated metrics of proxy
2020-01-10 17:05:38 +08:00
danielqsj
8ae3f80048
remove deprecated metrics of dockershim
2020-01-10 17:05:38 +08:00
danielqsj
85931af1ee
remove deprecated metrics of scheduler
2020-01-10 17:03:40 +08:00
danielqsj
1a9b121764
remove deprecated metrics of kubelet
2020-01-10 16:46:52 +08:00
Kubernetes Prow Robot
9269b5d430
Merge pull request #87014 from notpad/fix/comments
...
Fix comment
2020-01-09 21:58:55 -08:00
Alex Wang
0bab010b45
clean unused predicate error
2020-01-10 13:06:29 +08:00
Wei Huang
b2159b5d66
Remove scheduler/algorithm/priorities/util package
2020-01-09 20:16:05 -08:00
Kubernetes Prow Robot
7a50fdb2a6
Merge pull request #85993 from chendotjs/fix-cidr
...
kubenet: replace gateway with cni result
2020-01-09 20:13:04 -08:00
Wei Huang
6aaf0bb41b
Cleanup scheduler/algorithm/predicates package
2020-01-09 19:01:31 -08:00
Rita Zhang
b062fcb117
Update Azure owners
2020-01-09 18:35:18 -08:00
Kobayashi Daisuke
fee0d43d23
fix golint error in pkg/apis/rbac
2020-01-10 11:22:05 +09:00
draveness
2c3c6721ce
refactor(scheduling): remove priorities package
2020-01-10 09:05:39 +08:00
Kubernetes Prow Robot
adb8b08e91
Merge pull request #86905 from draveness/feature/disable-scheduling-plugin
...
feat(scheduling): address disabled plugins in scheduling framework
2020-01-09 16:10:47 -08:00
Kubernetes Prow Robot
e648e944e0
Merge pull request #86848 from haosdent/clean-filter-deps-nodeunschedulable
...
Break nodeunschedulable Filter plugins dependency on predicates package
2020-01-09 16:10:34 -08:00
Kubernetes Prow Robot
aef336d712
Merge pull request #86999 from draveness/feature/remove-ErrTopologySpreadConstraintsNotMatch
...
fix: remove ErrTopologySpreadConstraintsNotMatch
2020-01-09 13:29:42 -08:00
Kubernetes Prow Robot
95c9878b78
Merge pull request #86964 from alculquicondor/fix/snapshot_rm_node
...
Remove nodes from cache immediately on delete events
2020-01-09 13:29:32 -08:00
Kubernetes Prow Robot
f634ee6fe2
Merge pull request #86545 from xiaoanyunfei/cleanup/enhance_scheduler_metrics
...
Cleanup/Enhance scheduler metrics
2020-01-09 13:29:22 -08:00
Kubernetes Prow Robot
3ccdad175a
Merge pull request #86210 from draveness/feature/remove-ga-flags
...
feat: remove several feature gates in 1.18
2020-01-09 13:28:50 -08:00
Kubernetes Prow Robot
eedf1945b5
Merge pull request #86998 from denkensk/rm-errserviceaffinityviolated
...
Remove ErrServiceAffinityViolated scheduler predicate error
2020-01-09 11:33:42 -08:00
Kubernetes Prow Robot
407b29fa05
Merge pull request #86981 from alculquicondor/fix/node_info_list_2
...
Remove uses of NodeInfoMap outside of snapshot and cache
2020-01-09 11:33:31 -08:00
Aldo Culquicondor
afe3b907a1
Remove nodes from cache immediately on delete events
...
Signed-off-by: Aldo Culquicondor <acondor@google.com>
2020-01-09 12:58:12 -05:00
draveness
50deec25bc
feat(scheduling): address disabled plugins in scheduling framework
...
+ Custom plugins run after the default plugins.
+ Disable default plugins and re-enable them in the configuration could update
the execution order.
+ Use `*` to disable all the default plugins of specific extension points.
2020-01-09 23:59:59 +08:00
Aldo Culquicondor
bcab9b4c9e
Remove uses of NodeInfoMap outside of snapshot and cache
...
Signed-off-by: Aldo Culquicondor <acondor@google.com>
2020-01-09 10:04:11 -05:00
Kubernetes Prow Robot
32d8799ef1
Merge pull request #86979 from ahg-g/ahg-cleanup2
...
Move TaintToleration predicate to its plugin
2020-01-09 06:53:45 -08:00
Abdullah Gharaibeh
50b697bacb
move TaintToleration predicate to its plugin
2020-01-09 08:14:53 -05:00
notpad
228891de9c
Fix comment
2020-01-09 20:06:56 +08:00
Kubernetes Prow Robot
edad4bbfc8
Merge pull request #86940 from skilxn-go/master
...
Add VolumeBinder to FrameworkHandle interface
2020-01-09 03:01:45 -08:00
SataQiu
51c742c1dd
fix staticcheck failures of pkg/util/ipconfig pkg/util/iptables pkg/util/ipvs/testing
2020-01-09 16:05:11 +08:00
draveness
0278d793c8
fix: remove ErrTopologySpreadConstraintsNotMatch
2020-01-09 16:01:13 +08:00
chenyaqi01
f893486191
ipvs proxier README: fix typo
2020-01-09 15:12:05 +08:00
Alex Wang
80127fe10f
rm errserviceaffinityviolated
2020-01-09 15:08:59 +08:00
Haosdent Huang
864600f05f
Break nodeunschedulable Filter plugins dependency on predicates package
2020-01-09 14:54:28 +08:00
Kubernetes Prow Robot
2c800c5a70
Merge pull request #86985 from ahg-g/ahg-cleanup4
...
Remove test/integration dependency on predicates and algorithmprovider
2020-01-08 21:29:58 -08:00
Kubernetes Prow Robot
4d41f4809f
Merge pull request #86890 from damemi/move-selector-spread-to-plugin
...
Move selector spreading priority code to plugin
2020-01-08 21:29:45 -08:00
sunxiaofei03
6c58cc0ad0
change framework_extension_point_duration_seconds from sampling to always record
2020-01-09 12:23:05 +08:00
Kubernetes Prow Robot
b3c94d3fb9
Merge pull request #86966 from bharaththiruveedula/master
...
Fix interpodaffinity issue
2020-01-08 19:12:20 -08:00
Kubernetes Prow Robot
4426ccb2a6
Merge pull request #86963 from ahg-g/ahg-status
...
Update scheduler's RunFilterPlugins to return a plugin to status map
2020-01-08 19:12:12 -08:00
Kubernetes Prow Robot
4d95d40a41
Merge pull request #86836 from haosdent/clean-filter-deps-interpodaffinity
...
Break interpodaffinity Filter plugins dependency on predicates package
2020-01-08 19:11:53 -08:00
skilxn-go
5def91d778
Add VolumeBinder to FrameworkHandle interface
2020-01-09 10:29:35 +08:00
Abdullah Gharaibeh
c86f59610c
remove test/integration dependency on predicates and algorithmprovider
2020-01-08 19:51:22 -05:00
Kubernetes Prow Robot
720e6de6b9
Merge pull request #85168 from Jefftree/admission-wh-proxy
...
Use Network Proxy for Admission Webhooks
2020-01-08 16:07:40 -08:00
Jefftree
1289bdaba4
network proxy with admission wh
2020-01-08 15:01:38 -08:00
Kubernetes Prow Robot
b558cff8f5
Merge pull request #86950 from yuzhiquan/patch-pod
...
cleanup(api-machinery): remove unused struct and variable
2020-01-08 14:46:48 -08:00
Kubernetes Prow Robot
792fe793a1
Merge pull request #86946 from cchord/fix_typo
...
fix typo
2020-01-08 14:46:24 -08:00
Kubernetes Prow Robot
ca05f4c63b
Merge pull request #86930 from alculquicondor/fix/node_info_list
...
Use Snapshot.NodeInfoList for listing operations
2020-01-08 14:46:03 -08:00
Abdullah Gharaibeh
f3c7a4c823
Update scheduler's RunFilterPlugins to return a plugin to status map
2020-01-08 16:44:51 -05:00
Bharath Thiruveedula
8e3c1b54a7
Fix interpodaffinity issue
...
Signed-off-by: Bharath Thiruveedula <bharath_ves@hotmail.com>
2020-01-09 01:18:49 +05:30
Mike Dame
d227b7822f
Move selector spreading priority code to plugin
2020-01-08 13:37:37 -05:00
Kubernetes Prow Robot
b34c96b62c
Merge pull request #86764 from haosdent/migrate-servie-affinity
...
Break serviceaffinity Filter plugins dependency on predicates package
2020-01-08 08:47:39 -08:00
Aldo Culquicondor
5d916e20dd
Use Snapshot.NodeInfoList for listing operations
...
instead of iterating over NodeInfoMap.
Also remove redundant queries to NodeInfoMap.
Signed-off-by: Aldo Culquicondor <acondor@google.com>
2020-01-08 09:45:36 -05:00
Kubernetes Prow Robot
1e0bfae887
Merge pull request #86871 from gosoon/master
...
fix log message error in nodelifecycle
2020-01-08 02:58:33 -08:00
Kubernetes Prow Robot
1f50be5d04
Merge pull request #86775 from Aresforchina/fix-staticcheck-test03
...
fix staticcheck of pkg/util/ebtables
2020-01-08 02:58:07 -08:00
Kubernetes Prow Robot
b1e8bed5be
Merge pull request #86755 from mwmix/scheduler_server_unit_tests
...
Adding in missing Registry unit tests.
2020-01-08 02:57:54 -08:00
Kubernetes Prow Robot
fd0358fd21
Merge pull request #86689 from klueska/upstream-fix-cpumanager-v1-state-checksum
...
Lock checksum calculation for v1 CPUManager state to pre 1.18 logic
2020-01-08 02:57:40 -08:00
likakuli
10864d3366
fix a bug that orphan revision cannot be adopted and sts cannot be synced
2020-01-08 17:56:41 +08:00
yuzhiquan
8d7f383785
cleanup(api-machinery): remove unused struct and variable
2020-01-08 16:57:02 +08:00
Jiahao Zhu
680df17f39
fix typo
2020-01-08 15:48:58 +08:00
Haosdent Huang
a1053e4835
Break interpodaffinity Filter plugins dependency on predicates package
2020-01-08 14:37:51 +08:00
Kubernetes Prow Robot
8dca390262
Merge pull request #84927 from mattjmcnaughton/mattjmcnaughton/fix-kubelet-config-common
...
Fix golint failures for pkg/kubelet/config/...
2020-01-07 21:09:40 -08:00
mattjmcnaughton
8897c435ad
Refactor oom watcher to allow greater test coverage
...
This diff contains a strict refactor; there are no behavioral changes.
Address a long standing TODO in `oom_watcher_linux_test.go` around test
coverage. We refactor our `oom.Watcher` so it takes in a struct
fulfulling the `streamer` interface (i.e. defines `StreamOoms` method).
In production, we will continue to use the `oomparser` from `cadvisor`.
However, for testing purposes, we can now create our own `fakeStreamer`,
and control how it streams `oomparser.OomInstance`. With this fake, we
can implement richer unit testing for the `oom.Watcher` itself.
Actually adding the additional unit tests will come in a later commit.
2020-01-07 21:48:14 -05:00
Kubernetes Prow Robot
6099a739d8
Merge pull request #86919 from ahg-g/ahg-fix
...
Fix how we check for node info list consistency
2020-01-07 14:09:05 -08:00
Kubernetes Prow Robot
99600ae9a7
Merge pull request #86852 from haosdent/clean-filter-deps-volumezone
...
Break volumezone Filter plugins dependency on predicates package
2020-01-07 14:08:55 -08:00
Kubernetes Prow Robot
c867fdbc1c
Merge pull request #86847 from haosdent/clean-filter-deps-nodelabel
...
Break nodelabel Filter plugins dependency on predicates package
2020-01-07 14:08:46 -08:00
Kubernetes Prow Robot
c7af1da206
Merge pull request #86913 from ahg-g/ahg-nodelimit
...
fix a bug in scheduler's node resource limits score
2020-01-07 12:34:25 -08:00
Abdullah Gharaibeh
e26fbe6f08
fix a bug in scheduler's node resource limits score
2020-01-07 13:43:44 -05:00
Kubernetes Prow Robot
d4d3d4b55e
Merge pull request #86875 from ahg-g/ahg1-cleanup
...
Move RequestedToCapacityRatio argument processing to its plugin
2020-01-07 10:14:42 -08:00
Kubernetes Prow Robot
dc084fe131
Merge pull request #86849 from haosdent/clean-filter-deps-nodevolumelimits
...
Break nodevolumelimits Filter plugins dependency on predicates package
2020-01-07 10:14:33 -08:00
Haosdent Huang
320c9bfeed
Break volumezone Filter plugins dependency on predicates package
2020-01-08 01:03:01 +08:00
Abdullah Gharaibeh
591b870691
fix how we check for node info list consistency
2020-01-07 11:45:25 -05:00
Kubernetes Prow Robot
49e24adf3e
Merge pull request #86832 from mattjmcnaughton/mattjmcnaughton/remove-dead-code-in-fake-docker-client
...
Remove dead code in fake docker client
2020-01-07 07:36:18 -08:00
Matt Mix
42afa0a2cc
Adding in missing Registry unit tests.
2020-01-07 10:20:39 -05:00
Haosdent Huang
6a82609902
Break serviceaffinity Filter plugins dependency on predicates package
2020-01-07 22:43:37 +08:00
Dan Winship
ce68edf700
Allow "kubelet --node-ip ::" to mean prefer IPv6
2020-01-07 07:53:21 -05:00
Kubernetes Prow Robot
f3df7a2fdb
Merge pull request #86727 from mattjmcnaughton/mattjmcnaughton/remove-recorder-PastEventf
...
Remove `recorder.PastEventf` method
2020-01-07 04:38:49 -08:00
Kubernetes Prow Robot
5373fa3f59
Merge pull request #82462 from vllry/dualstack-iptables
...
Dualstack support for kube-proxy iptables mode
2020-01-07 04:38:20 -08:00
Kubernetes Prow Robot
dd5272b76f
Merge pull request #86575 from gongguan/nkubemark
...
kubemark use remote cri
2020-01-07 03:20:46 -08:00
Kubernetes Prow Robot
38173d586a
Merge pull request #86877 from ahg-g/ahg1-cleanup2
...
Remove unused scheduler types
2020-01-07 01:13:33 -08:00
Kubernetes Prow Robot
08ae3b490a
Merge pull request #86859 from silenceshell/ExtenderConfig-rename-Extender
...
rename ExtenderConfig to Extender in comments
2020-01-07 01:13:24 -08:00
Kubernetes Prow Robot
195e8e3ad9
Merge pull request #86844 from mattjmcnaughton/mattjmcnaughton/update-cadvisor-stats-provider-comment
...
Correct comment around which integrations require cadvisor_stats
2020-01-07 01:13:14 -08:00
Haosdent Huang
4ef31f81c7
Break nodelabel Filter plugins dependency on predicates package
2020-01-07 16:37:52 +08:00
Kubernetes Prow Robot
8b8f2aa4a5
Merge pull request #85431 from irbull/api-doc
...
Add public documentation for kubelet/apis/config
2020-01-06 23:12:18 -08:00
louisgong
8d54a84507
fix kubemark use fake CRI
2020-01-07 11:39:58 +08:00
louisgong
324e5ce7e3
hollow-node use remote CRI
2020-01-07 11:00:45 +08:00
Abdullah Gharaibeh
729c37373a
Remove unused scheduler types
2020-01-06 21:19:42 -05:00
Kubernetes Prow Robot
59b4933fb8
Merge pull request #86724 from gongguan/fix-fake-CRI
...
fix fake remote CRI
2020-01-06 18:06:57 -08:00
Kubernetes Prow Robot
e7c79050b4
Merge pull request #86718 from ahg-g/ahg1-err
...
Copy nodeaffinity predicate to its filter plugin
2020-01-06 18:06:46 -08:00
Kubernetes Prow Robot
49bc696614
Merge pull request #86251 from bboreham/pleg-last-seen-metric
...
Kubelet: add a metric to observe time since PLEG last seen
2020-01-06 18:06:18 -08:00
Kubernetes Prow Robot
d6412b856f
Merge pull request #84345 from danielqsj/withdialer
...
replace grpc.WithDialer which is deprecated
2020-01-06 15:56:17 -08:00
Kubernetes Prow Robot
19ecd690fa
Merge pull request #86646 from yutedz/client-protocol
...
Require client / server protocols
2020-01-06 13:34:18 -08:00
Kubernetes Prow Robot
b112ad4f0b
Merge pull request #86845 from mattjmcnaughton/mattjmcnaughton/remove-rkt-from-runtime-options
...
Remove `rkt` from container runtime options
2020-01-06 11:12:29 -08:00
Abdullah Gharaibeh
4e67476867
move nodeaffinity predicate to its filter plugin
2020-01-06 13:22:51 -05:00
Kubernetes Prow Robot
9acf7d11fe
Merge pull request #86344 from klueska/upstream-cm-approver
...
Add klueska as an approver in pkg/kubelet/cm/OWNERS
2020-01-06 09:54:16 -08:00
Abdullah Gharaibeh
b9e2389e0d
Move RequestedToCapacityRatio argument processing to its plugin
2020-01-06 11:54:09 -05:00
Ted Yu
906adbdfcd
Require client / server protocols
2020-01-06 08:50:04 -08:00
tianfeiyu
fddf50cf88
fix log message error in nodelifecycle
2020-01-06 21:02:08 +08:00
yue9944882
fe8ad90afa
bootstrap flow-control objects
...
typo
wrap bootstrap-creation-flow w/ wait.PollUtil
go wait
2020-01-06 20:35:03 +08:00
Kubernetes Prow Robot
0f61791bc7
Merge pull request #86850 from haosdent/clean-filter-deps-volumerestrictions
...
Break volumerestrictions Filter plugins dependency on predicates package
2020-01-05 20:57:41 -08:00
silenceshell
7254517c5c
rename ExtenderConfig to Extender
2020-01-06 11:18:51 +08:00
Kubernetes Prow Robot
10dc4a0c79
Merge pull request #86822 from ahg-g/ahg-cleanup
...
Cleanup deprecated scheduler functions/files
2020-01-05 12:37:41 -08:00
Haosdent Huang
9bcca31e52
Break volumerestrictions Filter plugins dependency on predicates package
2020-01-06 02:59:47 +08:00
Haosdent Huang
aae9a7f704
Break nodevolumelimits Filter plugins dependency on predicates package
2020-01-06 02:30:40 +08:00
mattjmcnaughton
794d0d9b4d
Remove rkt
from container runtime options
...
Part of efforts to clean up mentions of rkt in kubelet.
rkt was removed entirely in 1.11, in favor of using `rktlet` and CRI
instead. It should no longer be listed at all as a runtime.
2020-01-05 09:27:38 -05:00
Kubernetes Prow Robot
862c8bf818
Merge pull request #85561 from cwdsuzhou/Nov/return_when_failed
...
Return when removePod failed
2020-01-05 06:23:40 -08:00
mattjmcnaughton
06b44c76fd
Correct comment around which integrations require cadvisor_stats
...
This commit is part of a larger effort to clean up references to `rkt`
in the kubelet.
Previously, this comment hard-coded which integrations required
the cadvisor stats provider. The comment has grown stale
(i.e. referenced rkt and did not reference cri-o).
Update the comment to instead point to the code which determines which
integrations need the cadvisor stats provider.
2020-01-05 09:23:09 -05:00
mattjmcnaughton
f2cb1f35fe
Remove dead code in fake docker client
...
The `FakeDockerClient` had a number of methods defined on it which were
not being called anywhere. The majority were of the form `Assert...`.
In the spirit of removing dead code, remove the methods which aren't
being called.
2020-01-05 08:31:59 -05:00
Kubernetes Prow Robot
2d56d75061
Merge pull request #86730 from ahg-g/ahg1-ds
...
Break DS controller dependency on scheduler predicates and predicate errors
2020-01-04 14:39:40 -08:00
Kubernetes Prow Robot
fd98df37b5
Merge pull request #86742 from haosdent/clean-filter-deps
...
Break volumebinding Filter plugins dependency on predicates package
2020-01-04 12:21:40 -08:00
Haosdent Huang
d27dc6751e
Break volumebinding Filter plugins dependency on predicates package
2020-01-05 01:37:22 +08:00
Abdullah Gharaibeh
041e5b5560
addressed comments
2020-01-04 01:14:24 -05:00
Kubernetes Prow Robot
135ddf1ccc
Merge pull request #86820 from Huang-Wei/cleanup-SetPredicatesOrdering
...
Cleanup SetPredicatesOrderingDuringTest due to deprecation of predicates
2020-01-03 16:59:41 -08:00
louisgong
e8eb5c656b
fix fake remote CRI
2020-01-04 08:43:17 +08:00
Abdullah Gharaibeh
d31dcecd20
cleanup unused scheduler functions/files
2020-01-03 19:09:14 -05:00
Wei Huang
051be8fe80
Cleanup SetPredicatesOrderingDuringTest due to deprecation of predicates
2020-01-03 11:57:17 -08:00
Wei Huang
64d7b224d9
Cleanup unused parameter of NewGenericScheduler
2020-01-03 11:42:39 -08:00
Abdullah Gharaibeh
7d604c318c
Break DS controller on scheduler predicates and predicate errors
2020-01-03 13:05:07 -05:00
Kubernetes Prow Robot
180e1c9f51
Merge pull request #86584 from xiaoanyunfei/cleanup/deprecate_scheduler_metrics
...
deprecate scheduling_algorithm_predicate_evaluation_seconds and sched…
2020-01-03 03:41:40 -08:00
Bryan Boreham
cc0b3e82eb
Kubelet: add a metric to observe time since PLEG last seen
...
Expose the measurement that kubelet uses to judge that "PLEG is
unhealthy". If we can observe the measurement growing then we can
alert before the node goes unhealthy.
Note that the existing metrics PLEGRelistInterval and
PLEGRelistDuration are poor for this, because when relist() gets
stuck they are never updated.
Signed-off-by: Bryan Boreham <bryan@weave.works>
2020-01-03 10:01:27 +00:00
Kubernetes Prow Robot
47d5c3ef8d
Merge pull request #86785 from cwdsuzhou/Jan/update_comments
...
update comments of some funs in scheduling_queue
2020-01-02 22:26:02 -08:00
Kubernetes Prow Robot
b3c4c90a72
Merge pull request #86673 from ahg-g/ahg1-provider
...
Define algorithm providers in terms of plugins
2020-01-02 22:25:53 -08:00
Kubernetes Prow Robot
30090d0809
Merge pull request #86665 from SataQiu/clean-proxy-20191227
...
kube-proxy: add some interface type assertions
2020-01-02 22:25:40 -08:00
Kubernetes Prow Robot
fdfcb00ede
Merge pull request #86586 from xiaoanyunfei/cleanup/deprecate_scheduler_duration_seconds
...
Deprecate scheduling_duration_seconds Summary metric
2020-01-02 19:15:55 -08:00
Abdullah Gharaibeh
b535ed3b0c
Merge scheduler's ConfigProducerRegistry into LegacyRegistry
2020-01-02 16:40:33 -05:00
caiweidong
02e217759e
update comments of some funs in scheduling_queue
2020-01-02 23:35:12 +08:00
mattjmcnaughton
d09fe8e247
Remove no longer needed modifyContainerPIDNamespaceOverrides
...
As of https://github.com/kubernetes/kubernetes/pull/72831/ , the minimum
kubernetes version is now 1.13.1. As a result, this function becomes a
no-op. As the TODO indicates, we should delete it.
2020-01-02 09:09:02 -05:00
Aresforchina
bfc4a7a1c5
fix staticcheck of pkg/util/ebtables
2020-01-02 18:16:50 +08:00
Kubernetes Prow Robot
26b52e84a4
Merge pull request #86230 from hex108/skip_schedule
...
Scheduler handles pod annotation updates during scheduling more gracefully
2019-12-31 17:03:40 -08:00
Abdullah Gharaibeh
a6b7b0d95e
Define algorithm providers in terms of plugins.
2019-12-31 15:28:09 -05:00
notpad
7f79516705
Move resource-based priority functions to their Score plugins
2019-12-31 23:50:11 +08:00
Jun Gong
706e90a033
Skip scheduling the pod if it has been assumed and the pod updates could be skipped.
2019-12-31 14:21:41 +08:00
caiweidong
6410ac3173
Return when removePod failed
2019-12-31 10:11:12 +08:00
mattjmcnaughton
92940fa80d
Remove recorder.PastEventf
method
...
The `recorder.PastEventf` method wasn't actually working as advertised.
It was supposed to accept a timestamp, which would be used when
generating the event. However, as the
[source code](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/record/event.go#L316 )
shows, this `timestamp` was never actually used.
In other words, `PastEventf` is identical to `Eventf`.
We have two options: one would be to fix `PastEventf` so that it works
as advertised. The other would be to delete `PastEventf` and only
support `Eventf`.
Ultimately, I could only find one use of `PastEventf` in the code base,
so I propose we just delete `PastEventf` and convert all uses to
`Eventf`.
2019-12-30 12:00:23 -05:00
Kubernetes Prow Robot
a443014dfc
Merge pull request #86621 from yuzhiquan/patch-pod
...
refactor (pod log) container valiate
2019-12-30 02:41:39 -08:00
yuzhiquan
ca69051475
refactor(pod log):refactor for container valiate, little cleanup
...
bug(pod log):TestCheckLogLocation should point out pod name
modify container if statement
fix typo
2019-12-30 16:16:45 +08:00
Kubernetes Prow Robot
6d53021196
Merge pull request #86511 from aojea/v6example
...
Add ipv6 examples for network policy API
2019-12-29 19:39:39 -08:00
Wei Huang
78352240f6
Move podtopologyspread priority logic to its Score plugin
2019-12-28 19:29:37 -08:00
Kevin Klues
b373121a14
Make CPUManagerCheckpointV2 type an alias of CPUManagerCheckpoint
...
This change is to prevent problems when we remove the V1->V2 migration
code in the future. Without this, the checksums of all checkpoints would
be hashed with the name CPUManagerCheckpointV2 embedded inside of them,
which is undesirable. We want the checkpoints to be hashed with the name
CPUManagerCheckpoint instead.
2019-12-28 19:29:13 +01:00
Kubernetes Prow Robot
f796b750c6
Merge pull request #86681 from Huang-Wei/interpodaffinity-typo
...
Fix a typo in interpodaffinity score plugin
2019-12-28 08:23:38 -08:00
Kevin Klues
5faf8f4c52
Lock checksum calculation for v1 CPUManager state to pre 1.18 logic
...
The updated CPUManager from PR #84462 implements logic to migrate the
CPUManager checkpoint file from an old format to a new one. To do so, it
defines the following types:
```
type CPUManagerCheckpoint = CPUManagerCheckpointV2
type CPUManagerCheckpointV1 struct { ... }
type CPUManagerCheckpointV2 struct { ... }
```
This replaces the old definition of just:
```
type CPUManagerCheckpoint struct { ... }
```
Code was put in place to ensure proper migration from checkpoints in V1
format to checkpoints in V2 format. However (and this is a big however),
all of the unit tests were performed on V1 checkpoints that were
generated using the type name `CPUManagerCheckpointV1` and not the
original type name of `CPUManagerCheckpoint`. As such, the checksum in
the checkpoint file uses the `CPUManagerCheckpointV1` type to calculate
its checksum and not the original type name of `CPUManagerCheckpoint`.
This causes problems in the real world since all pre-1.18 checkpoint
files will have been generated with the original type name of
`CPUManagerCheckpoint`. When verifying the checksum of the checkpoint
file across an upgrade to 1.18, the checksum is calculated assuming
a type name of `CPUManagerCheckpointV1` (which is incorrect) and the
file is seen to be corrupt.
This patch ensures that all V1 checksums are verified against a type
name of `CPUManagerCheckpoint` instead of ``CPUManagerCheckpointV1`.
It also locks the algorithm used to calculate the checksum in place,
since it wil never change in the future (for pre-1.18 checkpoint
files at least).
2019-12-28 14:17:55 +01:00
Kubernetes Prow Robot
d605766c89
Merge pull request #86662 from draveness/feature/cloud-specific-predicates
...
feat(scheduling): implement azure, cinder, ebs and gce as filter plugin
2019-12-27 22:23:38 -08:00
Wei Huang
b3bebddb30
Fix a typo in interpodaffinity score plugin
2019-12-27 20:23:28 -08:00
Kubernetes Prow Robot
8bf6504661
Merge pull request #86583 from libnux/change_random_fully_log_level
...
Change log level to 3 when --random-fully is not supported
2019-12-27 19:47:39 -08:00
draveness
320ac4e277
feat(scheduling): implement azure, cinder, ebs and gce as filter plugin
2019-12-28 11:46:40 +08:00
Kubernetes Prow Robot
f1cbbda291
Merge pull request #86650 from RainbowMango/pr_testapi_cleanup
...
Cleanup testapi after it has been removed
2019-12-27 14:05:38 -08:00
Antonio Ojea
31e59fd5e3
Add ipv6 examples for network policy API
...
Add IPv6 examples to the network policy API
2019-12-27 22:47:20 +01:00
Kubernetes Prow Robot
0387ee4244
Merge pull request #86625 from zouyee/cnu
...
Move CheckNodeUnschedulable predicate to its filter plugin
2019-12-27 09:27:39 -08:00
Kubernetes Prow Robot
429ad7db4f
Merge pull request #86659 from Huang-Wei/eps-move-pred
...
Move pod topology spread predicate logic to its filter plugin
2019-12-27 07:53:38 -08:00
Kubernetes Prow Robot
b52cdca17d
Merge pull request #86638 from danielqsj/ServiceAntiAffinityPriority
...
Move ServiceAntiAffinityPriority to score plugin
2019-12-27 04:05:38 -08:00
SataQiu
134c545b96
proxy: add some interface type assertions
2019-12-27 18:30:25 +08:00
Wei Huang
8a4dce5431
Move pod topology spread predicate logic to its filter plugin
2019-12-26 23:56:03 -08:00
Kubernetes Prow Robot
9d31c9387c
Merge pull request #86635 from draveness/feature/move-volume-limits-predicates
...
feat(scheduling): move csi volume predicates to csi filter plugin
2019-12-26 22:27:51 -08:00
RainbowMango
eea91c018b
Cleanup testapi after it has been removed
2019-12-27 14:11:15 +08:00
danielqsj
f53c81f4a2
Move ServiceAntiAffinityPriority to score plugin
2019-12-27 10:02:13 +08:00
Kubernetes Prow Robot
d4ba10ec80
Merge pull request #85703 from robscott/endpointslice-controller-race-fix
...
Fixing Potential Race Condition in EndpointSlice Controller.
2019-12-26 17:59:52 -08:00
Kubernetes Prow Robot
4158e7c1de
Merge pull request #85123 from danielqsj/apierrs
...
Unify aliases for "k8s.io/apimachinery/pkg/api/errors"
2019-12-26 17:59:38 -08:00
draveness
291a7bb164
feat(scheduling): move csi volume predicates to csi filter plugin
2019-12-27 09:14:35 +08:00
Kubernetes Prow Robot
40320be679
Merge pull request #86612 from andyzhangx/azuredisk-excludepath
...
fix: azure disk could not mounted on Standard_DC4s/DC2s instances
2019-12-26 13:43:51 -08:00
Rob Scott
c75787bb77
Fixing Potential Race Condition in EndpointSlice Controller.
...
This adds a new EndpointSlice tracker to keep track of the expected resource versions of EndpointSlices associated with each Service managed by the EndpointSlice controller. This should prevent a potential race where a syncService call could happen with an incomplete view of EndpointSlices if additions or deletions hadn't fully propagated to the cache yet. Additionally, this ensures that external changes to EndpointSlices will be handled by the EndpointSlice controller.
2019-12-26 12:15:38 -08:00
zouyee
89867e1c21
Move CheckNodeUnschedulable predicate to its filter plugin
...
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
2019-12-26 21:38:27 +08:00
zouyee
c4331b0369
Move VolumeZone predicate to its Filter plugin
...
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
2019-12-26 21:36:11 +08:00
Kubernetes Prow Robot
04d71d8a7b
Merge pull request #86614 from ahg-g/ahg1-default2
...
Deprecate scheduler predicate and priority factory registration and associated types
2019-12-26 05:21:38 -08:00
danielqsj
19fe9f8d94
replace grpc.WithDialer which is deprecated
2019-12-26 17:46:59 +08:00
danielqsj
5bc0e26c19
unify alias of api errors under pkg and staging
2019-12-26 16:42:28 +08:00
Kubernetes Prow Robot
f13e2ed491
Merge pull request #86591 from ahg-g/ahg1-default
...
Added scheduler algorithm provider registrey.
2019-12-25 18:25:38 -08:00
Abdullah Gharaibeh
2b3df3587e
Deprecate scheduler predicate and priority factory registration
2019-12-25 20:33:08 -05:00
Kubernetes Prow Robot
c84b1a8a10
Merge pull request #86601 from angao/no-disk-conflict
...
move NoDiskConflict predicate to its filter plugin
2019-12-25 15:27:38 -08:00
Kubernetes Prow Robot
bd1195c28e
Merge pull request #86580 from zouyee/rlp
...
Move ResourceLimitsPriority to its Score plugin
2019-12-25 07:39:38 -08:00
andyzhangx
36393390f4
fix: azure disk could not mounted on Standard_DC4s/DC2s instances
2019-12-25 13:55:58 +00:00
Alex Wang
e5168cc7bb
move nodepreferavoidpods to score plugin
2019-12-25 17:26:58 +08:00
zouyee
bf2b709e82
Move ResourceLimitsPriority to its Score plugin
...
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
2019-12-25 16:41:40 +08:00
Kubernetes Prow Robot
26253903b5
Merge pull request #86595 from draveness/feature/move-node-affinity-to-score-plugin
...
feat: implement node affinity priority as score plugin
2019-12-25 00:01:43 -08:00
yue9944882
141909fa2e
tighten ceiling for matching-precedence to 10000
2019-12-25 15:47:11 +08:00
Wen Gao
e5d90c57f0
move NoDiskConflict predicate to its filter plugin
2019-12-25 15:44:59 +08:00
Abdullah Gharaibeh
8fc21710e7
Added scheduler algorithm provider registery.
2019-12-25 00:48:52 -05:00
notpad
c33c4fffd1
Move RequestedToCapacityRatio to plugins/noderesources
2019-12-25 12:18:32 +08:00
draveness
75872b8e79
feat: implement node affinity priority as score plugin
...
+ Add DefaultNormalizeScore function
+ Implement NodeAffinity as score plugin
2019-12-25 10:53:35 +08:00
Kubernetes Prow Robot
e94cf58f25
Merge pull request #86593 from ahg-g/ahg1-intree
...
Cleanup scheduler's in-tree plugins registry naming
2019-12-24 18:39:29 -08:00
Kubernetes Prow Robot
bb7bad49f5
Merge pull request #86588 from hase1128/clean-up-apiserver-document
...
Clean up kube-apiserver reference document
2019-12-24 15:17:29 -08:00
Abdullah Gharaibeh
fe7de96ebe
cleanup scheduler's in-tree plugins registry naming
2019-12-24 15:56:36 -05:00
Kubernetes Prow Robot
24469a3692
Merge pull request #86585 from SataQiu/scheduler-taint-toleration
...
"Move Taint and toleration priority to its Score plugin"
2019-12-24 11:43:29 -08:00
Kubernetes Prow Robot
0c54ec3e4c
Merge pull request #86577 from draveness/feature/remove-total-num-nodes-in-metdata
...
fix: remove totalNumNodes from priority metadata
2019-12-24 08:41:29 -08:00
Jin Hase
49b6e40461
Clean up kube-apiserver reference document
2019-12-24 21:21:06 +09:00
sunxiaofei03
97676963c3
deprecate scheduling_algorithm_predicate/priority_evaluation_seconds
2019-12-24 19:41:01 +08:00
Kubernetes Prow Robot
175ee0a111
Merge pull request #86542 from zouyee/nodeinfocheck
...
introduce checker for the result of nodeInfo.Node()
2019-12-24 03:23:29 -08:00
SataQiu
21c916c3d2
move Taint and toleration predicate to its Score plugin
2019-12-24 19:22:12 +08:00
sunxiaofei03
70b80ae28a
Deprecate scheduling_duration_seconds Summary metric
2019-12-24 19:17:29 +08:00
libnux
f0e01bcfde
Change log level to 3 when --random-fully is not supported
2019-12-24 17:47:27 +08:00
draveness
5fd6b8fae7
fix: remove totalNumNodes from priority metadata
2019-12-24 15:45:04 +08:00
Kubernetes Prow Robot
39d0710a4b
Merge pull request #86530 from zouyee/vbb
...
Move volumebinding predicate to its filter plugin
2019-12-23 22:05:29 -08:00
Kubernetes Prow Robot
d758fc3edb
Merge pull request #81886 from praseodym/fix-staticcheck-pkg/proxy
...
Fix staticcheck failures for pkg/proxy/...
2019-12-23 17:33:29 -08:00
zouyee
bae72ee8d2
using string instead of byte
...
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
2019-12-24 09:23:02 +08:00
zouyee
bf8a8a657c
introduce checker for the result of nodeInfo.Node()
...
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
2019-12-24 09:11:40 +08:00
Kubernetes Prow Robot
5e31799701
Merge pull request #86534 from liggitt/ipallocator-range
...
Restore IPAllocator ipv4 range handling
2019-12-23 13:25:29 -08:00
Kubernetes Prow Robot
06fb3eb582
Merge pull request #86496 from ahg-g/ahg1-check
...
Support AlwaysCheckAllPredicates in the scheduler framework.
2019-12-23 09:53:33 -08:00
Maciej Szulik
fcae27b9d2
If lastTimestamp is not set use firstTimestamp when printing event
2019-12-23 17:07:04 +01:00
draveness
3f591bb2dd
feat: implement image locality as score plugin
2019-12-23 23:05:23 +08:00
zouyee
83408acf75
Move volumebinding predicate to its filter plugin
...
Signed-off-by: Zou Nengren <zouyee1989@gmail.com>
2019-12-23 21:57:49 +08:00
Jordan Liggitt
6a1354252d
Add unit test for extended ipv4 service IP range
2019-12-22 22:32:42 -05:00
Jordan Liggitt
df4f5c1a30
Revert "remove ipallocator in favor of k/utils net package"
...
This reverts commit f984b4c7a2
.
2019-12-22 22:31:25 -05:00
Mark Janssen
a54e5cec54
Fix staticcheck failures for pkg/proxy/...
...
Errors from staticcheck:
pkg/proxy/healthcheck/proxier_health.go:55:2: field port is unused (U1000)
pkg/proxy/healthcheck/proxier_health.go:162:20: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
pkg/proxy/healthcheck/service_health.go:166:20: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
pkg/proxy/iptables/proxier.go:737:2: this value of args is never used (SA4006)
pkg/proxy/iptables/proxier.go:737:15: this result of append is never used, except maybe in other appends (SA4010)
pkg/proxy/iptables/proxier.go:1287:28: this result of append is never used, except maybe in other appends (SA4010)
pkg/proxy/userspace/proxysocket.go:293:3: this value of n is never used (SA4006)
pkg/proxy/winkernel/metrics.go:74:6: func sinceInMicroseconds is unused (U1000)
pkg/proxy/winkernel/metrics.go:79:6: func sinceInSeconds is unused (U1000)
pkg/proxy/winuserspace/proxier.go:94:2: field portMapMutex is unused (U1000)
pkg/proxy/winuserspace/proxier.go:118:2: field owner is unused (U1000)
pkg/proxy/winuserspace/proxier.go:119:2: field socket is unused (U1000)
pkg/proxy/winuserspace/proxysocket.go:620:4: this value of n is never used (SA4006)
2019-12-22 21:32:06 +01:00
Kubernetes Prow Robot
2d310b1321
Merge pull request #86346 from SataQiu/bump-utils-20191217
...
Bump k8s.io/utils version
2019-12-21 23:55:32 -08:00
Kubernetes Prow Robot
ff975e865d
Merge pull request #86498 from Huang-Wei/deprecate-failedPredicateMap
...
Cleanup failedPredicateMap from generic_scheduler.go
2019-12-21 08:41:33 -08:00
Abdullah Gharaibeh
eeb8a5b728
Added back the flag to trigger examining all Filters in the scheduler.
2019-12-21 05:17:23 -05:00
SataQiu
2497a1209b
bump k8s.io/utils version
2019-12-21 14:54:44 +08:00
Kubernetes Prow Robot
8737890681
Merge pull request #86459 from ahg-g/ahg1-affinity-pred
...
move inter pod affinity predicate logic to its Filter plugin
2019-12-20 18:28:08 -08:00
Wei Huang
3e65b3793f
Cleanup failedPredicateMap from generic_scheduler.go
2019-12-20 15:18:15 -08:00
Abdullah Gharaibeh
429448cb40
move inter pod affinity predicate logic to its Filter plugin
2019-12-20 16:58:36 -05:00
Wei Huang
1f78a936d4
Deprecate AlwaysCheckAllPredicates in scheduler Policy API
2019-12-20 11:41:33 -08:00
Kubernetes Prow Robot
9fa1e00be9
Merge pull request #83437 from matthyx/startupprobe-beta
...
Promote StartupProbe to beta for 1.18
2019-12-20 00:59:32 -08:00
Kubernetes Prow Robot
b632eaddba
Merge pull request #86446 from ahg-g/ahg1-nodelabel
...
Move NodeLabel priority logic to its Score and Filter plugin
2019-12-19 15:37:21 -08:00
Kubernetes Prow Robot
641d0290e4
Merge pull request #86399 from ahg-g/ahg1-prioritymeta
...
InterPodAffinity Priority as Score plugin
2019-12-19 13:39:56 -08:00
Kubernetes Prow Robot
03e90b80ce
Merge pull request #86167 from yiyang5055/change-CounterVec-to-Counter
...
change CounterVec to use Counter in the Kubelet's Pod Lifecycle Event…
2019-12-19 11:33:56 -08:00
Abdullah Gharaibeh
68f3802ba8
move NodeLabel predicate logic to its Filter plugin
2019-12-19 14:00:39 -05:00
Abdullah Gharaibeh
119a9a94d1
InterPodAffinity Priority as Score plugin
2019-12-19 13:42:49 -05:00
Abdullah Gharaibeh
22a0f55a68
move NodeLabel priority logic to its Score plugin
2019-12-19 13:35:43 -05:00