Commit Graph

566 Commits

Author SHA1 Message Date
Tim Allclair
19a588eeda Add a special-cased runtime handler for dockershim 2019-05-24 15:30:34 -07:00
Jean Rouge
b39d8f4777 Kubelet & implementation changes for Windows GMSA support
This patch comprises the kubelet changes outlined in the Windows GMSA KEP
(https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/20181221-windows-group-managed-service-accounts-for-container-identity.md)
to add GMSA support to Windows workloads.

Updated tests.

Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-05-16 22:07:03 -04:00
Kubernetes Prow Robot
37281a400d Merge pull request #76442 from viegasdom/fix-golint-utils-bandwith
Fix golint failures of util/bandwith/*.go
2019-05-15 22:56:08 -07:00
mattjmcnaughton
0547167ad0 Increase maxMsgSize for dockershim
Increase the grpc max message size to be the same as the value defined
in `pkg/kubelet/remote/utils.go`.

Increase the limit because, `ListPodSandbox` (and possibly other) calls
are hitting the limit. Long term, the best solution to this issue is to
use pagination, but that is not currently available.
2019-04-27 13:26:31 -04:00
Kubernetes Prow Robot
f4937619a2 Merge pull request #75442 from mars1024/bugfix/bandwidth_unit
change bandwidth units from Kb to b
2019-04-25 13:36:54 -07:00
SataQiu
423e8f0292 fix golint failures of pkg/kubelet/dockershim/cm 2019-04-23 12:59:13 +08:00
Davanum Srinivas
7b8c9acc09 remove unused code
Change-Id: If821920ec8872e326b7d85437ad8d2620807799d
2019-04-19 08:36:31 -04:00
Kubernetes Prow Robot
1192ca09f0 Merge pull request #76634 from xichengliudui/addConsts
Using const() defines constants together
2019-04-18 01:50:10 -07:00
Kubernetes Prow Robot
dffbae622a Merge pull request #76633 from xichengliudui/little-bug
Small bug: Comments and function names do not match
2019-04-16 17:48:34 -07:00
Yu-Ju Hong
903f635ab3 dockershim: Fix negotiating docker API version
API version negotiation needs to happen before any meaningful docker
calls, including simple commands such as "/version".
2019-04-15 15:25:06 -07:00
viegasdom
9d3d7a7b51 Changes another usage of the BandwidthShaper to Shaper 2019-04-12 17:24:57 +01:00
viegasdom
80578d5bf1 Changes code that still used BandWidthShaper instead of Shaper 2019-04-11 18:50:32 +01:00
Alok Kumar Singh
5b3a44fd56 Use docker api IsErrNotFound(). String handling is not required anymore
Why? https://github.com/kubernetes/kubernetes/pull/75843#discussion_r273785877
Moby support: https://github.com/moby/moby/pull/38689
Moby def: 053c6f097a/client/errors.go (L44-L49)
2019-04-11 20:52:57 +05:30
aaa
bad985dc3a Using const() defines constants together 2019-04-10 17:41:29 -04:00
aaa
49a2b1fd8f Small bug: Comments and function names do not match
add a function
2019-04-10 17:37:24 -04:00
Kubernetes Prow Robot
dabeb20a1a Merge pull request #75587 from tiffanyfay/cred-provider
Refactor AWS credential provider
2019-03-29 14:48:47 -07:00
tiffany jernigan
847cb24aa1 Credential provider Provide takes image (general) 2019-03-27 01:00:26 +00:00
Davanum Srinivas
33081c1f07 New staging repository for cri-api
Change-Id: I2160b0b0ec4b9870a2d4452b428e395bbe12afbb
2019-03-26 18:21:04 -04:00
Bruce Ma
183247ca5c change bandwidth units from Kb to b
Signed-off-by: Bruce Ma <brucema19901024@gmail.com>
2019-03-18 21:22:34 +08:00
Pengfei Ni
a304297c99 Fix panic when removing docker images 2019-03-14 18:53:02 +08:00
Kubernetes Prow Robot
a6d8dbcaef Merge pull request #74913 from yastij/explicit-restart-policy
explicit the restartPolicy on the dockershim
2019-03-07 16:12:39 -08:00
Kubernetes Prow Robot
752f5668cc Merge pull request #74737 from wk8/wk8/gmsa_bug_fix
Fixing a small bug with GMSA support
2019-03-06 11:20:49 -08:00
Yassine TIJANI
5f7c60859c explicit the restartPolicy on the dockershim
This change explicits the restart policy, as on some docker version
(e.g. 11.07-ce) the default for this field is "". which seems to be not
respected by dockerd
2019-03-04 23:11:20 +01:00
Kubernetes Prow Robot
9b8c58644a Merge pull request #74418 from danielqsj/duration
convert latency/latencies in metrics name to duration
2019-03-01 17:58:12 -08:00
Jean Rouge
5e3f3b35e0 Review comments
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-03-01 17:57:39 -08:00
Jean Rouge
1908a0ce04 Fixing a small bug with GMSA support
A previous PR (https://github.com/kubernetes/kubernetes/pull/73726)
added GMSA support to the dockershim. Unfortunately, there was a
bug in there: the registry keys used to pass the cred specs down
to Docker were being cleaned up too early, right after the containers'
creation - before Docker would ever try to read them, when trying to
actually start the container.

This patch fixes this.

An e2e test is also provided in a separate PR.

Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-02-28 10:26:54 -08:00
Kubernetes Prow Robot
cf24d24e66 Merge pull request #70647 from vshn/imagegc_multi_repo_image_removal
Always run untag when removing docker image
2019-02-26 11:04:58 -08:00
Kubernetes Prow Robot
44d13d3b77 Merge pull request #73726 from wk8/wk8/gmsa_alpha
Kubelet changes for Windows GMSA support
2019-02-25 21:48:21 -08:00
Kubernetes Prow Robot
272d78f1d9 Merge pull request #73966 from alculquicondor/fix/lint-kubelet-server
Fix lint on pkg/kubelet/server/...
2019-02-25 20:27:48 -08:00
Jean Rouge
0d392ffcef Udpated Bazel files
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-02-26 03:02:09 +00:00
Jean Rouge
f1bdfa93f9 Review comments
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-02-25 10:59:23 -08:00
danielqsj
f7b437cae0 convert latency in mertics name to duration 2019-02-22 21:40:13 +08:00
chenjun.cj
4fe13c2a99 sync CNI config in goroutine 2019-02-22 16:26:49 +08:00
Aldo Culquicondor
e61cd68bf3 Fix lint on pkg/kubelet/server/... 2019-02-21 10:31:41 -05:00
Kubernetes Prow Robot
78573805a7 Merge pull request #66228 from liucimin/fix_cniplugin_get_expose_hostip
fix_the_checkpoint_no_hostip_bug
2019-02-20 12:51:14 -08:00
Jean Rouge
a09031dbbd Typo in comment
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-02-19 13:10:23 -08:00
Jean Rouge
b1ea622359 Review from @yujuhong
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-02-16 07:55:43 -08:00
Jean Rouge
b435dbf718 Merge branch 'master' into wk8/gmsa_alpha
Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-02-14 15:38:25 -08:00
Kubernetes Prow Robot
0480214903 Merge pull request #73804 from Random-Liu/remove-unused-functions
Remove unused function from the legacy runtime interface.
2019-02-11 22:56:00 -08:00
Kubernetes Prow Robot
5b7a790d35 Merge pull request #72185 from dcbw/owners-label-sig-network
OWNERS: add label:sig/network to a bunch of places
2019-02-08 10:36:16 -08:00
Kubernetes Prow Robot
b50c643be0 Merge pull request #73540 from rlenferink/patch-5
Updated OWNERS files to include link to docs
2019-02-08 09:05:56 -08:00
Lantao Liu
1a92e218e0 Remove unused function from the legacy runtime interface.
Signed-off-by: Lantao Liu <lantaol@google.com>
2019-02-07 16:57:19 -08:00
Kubernetes Prow Robot
ae45068688 Merge pull request #72323 from danielqsj/dockershim
Change docker metrics to conform metrics guidelines
2019-02-06 09:30:54 -08:00
Jean Rouge
c4806186d4 Review comments
* value names are now purely random
* cleaning up leaked registry keys at Kubelet init
* fixing a small bug masking create errors

Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-02-05 16:53:17 -08:00
Jean Rouge
3f5675880d Kubelet changes for Windows GMSA support
This patch comprises the kubelet changes outlined in the GMSA KEP
(https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/20181221-windows-group-managed-service-accounts-for-container-identity.md)
to add GMSA support to Windows workloads.

More precisely, it includes the logic proposed in the KEP to resolve
which GMSA spec should be applied to which containers, and changes
`dockershim` to copy the relevant GMSA credential specs to Windows
registry values prior to creating the container, passing them down
to docker itself, and finally removing the values from the registry
afterwards; both these changes need to be activated with the `WindowsGMSA`
feature gate.

Includes unit tests.

Signed-off-by: Jean Rouge <rougej+github@gmail.com>
2019-02-05 09:17:46 -08:00
Roy Lenferink
b43c04452f Updated OWNERS files to include link to docs 2019-02-04 22:33:12 +01:00
Ashish Ranjan
7be223e798 Refactor to use k8s.io/utils/net/ package instead of kubernetes/pkg/util/net/sets
Signed-off-by: Ashish Ranjan <ashishranjan738@gmail.com>
2019-02-04 10:34:53 +05:30
Kubernetes Prow Robot
ce19aad22b Merge pull request #70527 from qingsenLi/git181101
remove repetitive word in annotation
2019-01-15 20:19:09 -08:00
Yu-Ju Hong
f62cc81934 Bump minimum docker version to 1.13.1 2019-01-11 10:21:38 -08:00
danielqsj
7aef2efe5b Mark deprecated in related dockershim metrics 2019-01-08 15:24:44 +08:00