Commit Graph

11 Commits

Author SHA1 Message Date
juanvallejo
0257a2bcee
allow re-usability of plugin handler, allow support for multiple valid plugin filename prefixes 2019-02-01 16:17:47 -05:00
Kubernetes Prow Robot
b8b0dbcb7d
Merge pull request #73599 from tedyu/master
Add ps1 to windows executable extensions
2019-02-01 06:32:01 -08:00
Kubernetes Prow Robot
ad58fb1ea0
Merge pull request #73542 from juanvallejo/jvallejo/log-missing-dir-errors
make missing-directory errors non fatal
2019-02-01 04:45:12 -08:00
Ted Yu
9e227af65c Add ps1 to windows executable extensions 2019-01-31 09:21:01 -08:00
juanvallejo
de015167a9
make missing-directory errors non fatal 2019-01-30 15:45:32 -05:00
Danny Shemesh
aae1944a07 Added windows executable extensions to Kubectl plugins
Currently, the kubectl plugins system - when running under Windows - will determine that a plugin is executable
by looking at its extension, comparing it to '.exe'.

I think we should allow plugins w/ a few more known extensions (.bat, .com, .cmd; for example) -
This would give more of a similar experience to plugins under *nix, where shell scripts are often used.

Moreover, there were two windows-specific behaviors that were redundant,
which I've removed:

1. In plugin.go - There's no need to differentiate between windows and
under OS-es when looking at the PATH variable; It can be refered as 'PATH'
in Windows as well

2. In cmd.go - There's no need to append a suffix when looking up
plugins on windows; One can safely use 'exec.LookPath' without a suffix
on Windows - and get automatic resolving for known executable types
2019-01-30 19:24:16 +02:00
juanvallejo
dbf9aa5009
add PATH de-duplication when searching for plugins 2019-01-21 13:00:42 -05:00
Yang Li
141d33a2a5 Fix some golint errors for packages in pkg/kubectl/cmd
Co-authored-by: Arijit Basu <sayanarijit@gmail.com>
2018-11-22 22:09:08 +08:00
juanvallejo
901c798681
prevent sorting of PATH dirs
This patch allows the `kubectl plugin list` command to display discovered
plugin paths in the same order as they appear in a user's PATH.
Prior to this patch, discovered plugin paths were sorted before being
displayed.

Additionally, any errors encountered while reading from any directory in a
user's PATH will now be printed to stderr at the end of the command's
output.
2018-10-30 14:13:13 -04:00
Maciej Szulik
21789b85a6
Move pkg/kubectl/cmd/templates -> pkg/kubectl/util/temlpates 2018-10-11 22:01:03 +02:00
Maciej Szulik
33adf367f9
Move each kubectl command to a separate directory 2018-10-06 18:44:05 +02:00