github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8,762 Commits 1 Branch 31 Tags 1,019 MiB
ecee4b16a1
Commit Graph

216 Commits

Author SHA1 Message Date
Brian Grant
98fedf6b2e Merge pull request #5407 from nikhiljindal/newSwagger 
Updating go-restful to the latest version
 2015-03-12 16:26:16 -07:00
nikhiljindal
b2276b5d4b Updating pkg/api/validation/ to consider swagger.items as object and not array 2015-03-12 16:04:11 -07:00
Nikhil Jindal
d9249a26e0 Merge pull request #5175 from thockin/plural_services_10 
Make testing service validation easier
 2015-03-12 15:48:37 -07:00
Ravi Sankar Penta
f6ecec5880 Allow admin user to explicitly unschedule the node 
Setting Unschedulable on the node will not touch any existing pods
on the node but will block scheduling of new pods on the node.
 2015-03-12 14:27:27 -07:00
Clayton Coleman
d016f478e0 Ignore changes to creation timestamp from clients on update 
CreationTimestamp is not an authoritative field (like UID) so mismatches
can be safely ignored.
 2015-03-09 12:04:35 -04:00
Tim Hockin
0b888e8673 Make testing service validation easier 
Part of multi-port services.

If people like this, we could start to apply this pattern elsewhere.

TL;DR: don't redefine objects over and over changing one thing each
time.  Instead provide a func that mutates a base object to test facets
of validation.  Much easier to read and to update.
 2015-03-08 21:41:37 -07:00
gmarek
bb8a4f5ed3 apply comments 2015-03-06 08:23:22 +01:00
gmarek
726a5af075 Loosen label and annotation validation and related tests 2015-03-06 08:23:22 +01:00
Deyuan Deng
9b0af8df63 Node addresses 2015-03-04 16:47:31 -05:00
Brendan Burns
fb90b56bf6 Embed VolumeSource in v1beta3 and internal. 2015-03-04 02:25:40 -08:00
Brian Grant
fca9fd68c7 Merge pull request #4779 from smarterclayton/status_endpoints 
Minimal status mutation change
 2015-03-03 11:00:02 -08:00
Clayton Coleman
0ac49d77a0 TCPSocket could not be used as it was not checked in validation 
Attempting to use it gave the error "must register one handler".
Added more tests for it.
 2015-03-02 15:27:11 -05:00
Zach Loafman
4937008ae0 Revert "TCPSocket could not be used as it was not checked in validation" 2015-03-02 11:14:27 -08:00
Brendan Burns
c7cbc5c991 Merge pull request #4883 from smarterclayton/fix_tcpsocket_validation 
TCPSocket could not be used as it was not checked in validation
 2015-03-02 10:53:48 -08:00
Brendan Burns
fe973461f5 Merge pull request #4916 from thockin/plural_21_endpoints 
Rename type Port to ContainerPort
 2015-03-02 10:53:32 -08:00
Tim Hockin
532c39c336 Add defaults for HTTGetAction.Path & test actions 
The comment says optional - this makes it optional.  Test handler actions.
 2015-03-01 21:23:18 -08:00
Clayton Coleman
3d290089ae Minimal status mutation change 
PUT /api/v1beta3/namespaces/default/pods/foo/status
    {
      "metadata": {...}, // allowed for valid values
      "spec": {}, // ignored
      "status": {...}, // allowed, except for Host
    }

Exposes the simplest possibly change. Needs a slight refactoring
to RESTUpdateStrategy to split merging which can be done in a
follow up.
 2015-03-01 22:35:17 -05:00
Clayton Coleman
d3a5a48d00 TCPSocket could not be used as it was not checked in validation 
Attempting to use it gave the error "must register one handler".
Added more tests for it.
 2015-03-01 22:31:57 -05:00
Tim Hockin
ea548b8260 Rename type Port to ContainerPort 
Sadly I had to do this by hand - I just could not get gorename to fix up
users of it.
 2015-02-27 21:05:59 -08:00
Daniel Smith
650f6cb826 Revert "Multi-port Endpoints" 2015-02-23 13:53:21 -08:00
Tim Hockin
eed36455a7 Merge pull request #4653 from thockin/secret_fixups 
Secrets fixups
 2015-02-23 13:49:19 -08:00
Tim Hockin
607b736a3f Rename volume source types to be consistent. 2015-02-23 12:39:57 -08:00
Tim Hockin
8bdfc352ce minor fixups as I review secrets 2015-02-23 12:39:47 -08:00
Tim Hockin
e0fd83096c Rename type Port to ContainerPort 
Sadly I had to do this by hand - I just could not get gorename to fix up
users of it.
 2015-02-21 22:26:38 -08:00
Paul Morie
a42ff94c8f Add secret volume plugin and e2e test 2015-02-18 16:27:44 -05:00
Paul Morie
fb001ada21 Secret API resource 2015-02-18 11:54:56 -05:00
Mike Danese
f7df9b9d37 add validation for api.Probe 2015-02-16 21:56:03 -08:00
Clayton Coleman
abe8adc2e2 Expose new REST strategy methods for Pods 2015-02-13 12:12:50 -05:00
derekwaynecarr
0bd0e12bbc Add support for Namespace as Kind 
Add example for using namespaces
 2015-02-10 09:50:50 -05:00
Vishnu Kannan
d0524d4778 Rename ResourceRequirementSpec to ResourceRequirements. 2015-02-09 23:19:38 +00:00
Marek Grabowski
72a066a992 Add more information to Validator error messages. 2015-02-09 18:07:09 +01:00
Brendan Burns
31ce2a9411 Adjust replication controller validation to be more flexible about 
read/write volumes.
Update docs to reflect reality as it is implemented.
 2015-02-06 14:58:21 -08:00
Brendan Burns
50e855953f Merge pull request #4131 from a-robinson/validate 
Add a few extra test cases for API validation of labels
 2015-02-05 15:37:45 -08:00
Yu-Ju Hong
283919e8b1 Fix tests in validation_test 
Some tests expect the error cases to fail for a specific reason, but they could
fail for other reasons and still pass. This caused some changes to break the
tests without noticing the breakage. Example are the recent defaulting PR

This change fixes such tests and also updates some obsolete tests.
 2015-02-04 15:44:46 -08:00
Alex Robinson
6bb374ca54 Add a few extra test cases for API validation of labels that would have 
caught a bug that was in past versions. Also, copy the label key format
requirements from the API types.go comments into the labels doc.
 2015-02-04 22:24:46 +00:00
Yu-Ju Hong
4a72addaeb Factor out API defaulting from validation logic 
Currently, the validation logic validates fields in an object and supply default
values wherever applies. This change factors out defaulting to a set of
defaulting callback functions for decoding (see #1502 for more discussion).

 * This change is based on pull request 2587.

 * Most defaulting has been migrated to defaults.go where the defaulting
   functions are added.

 * validation_test.go and converter_test.go have been adapted to not testing the
   default values.

 * Fixed all tests with that create invalid objects with the absence of
   defaulting logic.
 2015-02-03 00:55:42 -08:00
Clayton Coleman
5603714df8 Use name generation on pods via replication controllers 
The generated name is '<controllerName>-%s', unless controllerName-
would be long enough to cause a validation error.
 2015-02-02 14:44:53 -05:00
Clayton Coleman
a7c9a12286 Add name generation and normalize common create flows 
Adds `ObjectMeta.GenerateName`, an optional string field that defines
name generation behavior if a Name is not provided.

Adds `pkg/api/rest`, which defines the default Kubernetes API pattern
for creation (and will cover update as well). Will allow registries
and REST objects to be merged by moving logic on api out of those places.

Add `pkg/api/rest/resttest`, which will be the test suite that verifies
a RESTStorage object follows the Kubernetes API conventions and begin
reducing our duplicated tests.
 2015-02-02 14:44:53 -05:00
Brian Grant
6e415f760b Merge pull request #4017 from smarterclayton/relax_annotation_validations 
Slightly relax annotation validation
 2015-02-02 11:42:38 -08:00
Clayton Coleman
b30173658f Slightly relax annotation validation 
The more aggressive validation on annotations broke openshift (and
backwards compat for our data).  This change relaxes to allow mixed
case so we can continue working in the short term, try to see if we
can agree on relaxation, and if we can't, apply the stronger
validation here.
 2015-02-01 19:03:04 -05:00
Vishnu Kannan
5e36f63f8b Adding ResourceRequirementSpec to v1beta1, v1beta2, and v1beta3 APIs. The old resource 
quantities 'CPU' and 'Memory' will be preserved until support for v1beta1 and v1beta2 APIs are
dropped.
Improved resource validation in the process.
 2015-02-01 02:19:55 +00:00
Satnam Singh
3c3b016b8b Merge pull request #3917 from yujuhong/dedup 
Refactor API object fuzzer
 2015-01-30 08:07:25 -08:00
Deyuan Deng
c793c4f0ab Sync node status from node controller to master. 2015-01-29 23:17:15 -05:00
Yu-Ju Hong
4cb730dad5 Refactor API object fuzzer 
API object fuzzer is used to randomly populate API object for testing. Similar
code of the fuzzer was duplicated in multiple files. This change refactors the
tests and moves the fuzzer to a separate file.
 2015-01-29 18:14:09 -08:00
Tim Hockin
d01ea11a6e Merge pull request #3856 from smarterclayton/validation_logic_needs_cleanup 
Validation of ObjectMeta is inconsistently applied
 2015-01-29 14:12:44 -08:00
derekwaynecarr
829fa69527 Introduce a ResourceQuota object 2015-01-28 15:03:19 -05:00
Clayton Coleman
a0356bca96 Unify validation logic for create and update paths 
Ensure ObjectMeta is consistently validated on both create and update

Make PortalIP uncleareable
 2015-01-28 13:10:37 -05:00
Tim Hockin
a480794efc Tighten validation of Name and Namespace 2015-01-27 17:04:59 -05:00
derekwaynecarr
4faf27e63d Validate limit.Min and limit.Max resource names using ValidateResourceName 2015-01-27 16:41:28 -05:00
derekwaynecarr
74f368f50e Modified LimitRangeItem.Kind to LimitRangeItem.Type, added example files 2015-01-27 16:41:28 -05:00
derekwaynecarr
091cbe5fa2 Add a limit range resource 2015-01-27 16:41:27 -05:00
Brendan Burns
99583fc8c5 Fix a bug in validation that was leftover from the previous way of externalizing services. 2015-01-26 13:19:27 -08:00
markturansky
131ce993c4 Added validation for annotations 2015-01-26 09:32:09 -05:00
Vishnu Kannan
c32295a180 Adding a 'Typename' strongtype for representing all compute resource types. 2015-01-23 22:17:56 +00:00
Tim Hockin
30219f8dfa Merge pull request #3664 from thockin/pull-if 
Pull if
 2015-01-21 13:05:28 -08:00
Tim Hockin
c729f345f0 Merge pull request #3660 from dchen1107/image 
Using switch in validatePullPolicyWithDefault
 2015-01-21 12:54:12 -08:00
Tim Hockin
81343aac63 Change PullPolicy constants to match 2015-01-21 12:48:56 -08:00
Tim Hockin
819803b79f Make VolumeSource not be a pointer 
There's no reason for it to be a pointer.
 2015-01-20 17:54:04 -08:00
Dawn Chen
cf54dcb689 Using switch in validatePullPolicyWithDefault 2015-01-20 17:41:09 -08:00
Brian Grant
dd45246150 Merge pull request #3587 from dchen1107/image 
Clean up Kubernetes PullPolicy
 2015-01-20 17:18:26 -08:00
Tim Hockin
60ec08db93 Rename HostDir to HostPath in v1beta3 2015-01-20 15:56:44 -08:00
Dawn Chen
aec4594a8d Introduce validatePullPolicyWithDefault to validation. 2015-01-20 11:54:22 -08:00
Tim Hockin
6ff26d924c Merge pull request #3619 from smarterclayton/expose_validate_labels 
Expose ValidateLabels in validation.go for reuse by other components
 2015-01-20 09:11:08 -08:00
Clayton Coleman
48146e01cd Expose ValidateLabels in validation.go for reuse by other components 
Label validation is common to anyone building kube resources.
 2015-01-19 22:33:52 -05:00
Andrew Seidl
6dee1d7fa4 Fix typos in user-facing strings 2015-01-18 01:32:34 -06:00
Paul Morie
fd834ae84d Pods should see services only from their own ns 2015-01-14 17:06:36 -05:00
Sam Ghods
7845ab90f8 Upgrade from gopkg.in/v2/yaml to gopkg.in/yaml.v2 everywhere 2015-01-13 15:06:25 -08:00
Tim Hockin
2ea27c3df3 Fix wrong field check in validation 2015-01-12 14:27:34 -08:00
Tim Hockin
4fcd496d59 change everything to use new util/errors 2015-01-08 22:10:03 -08:00
Daniel Smith
2050131b9a ParseOrDie -> MustParse; stop returning pointer 2015-01-07 15:21:35 -08:00
Daniel Smith
0d628b3bff Make semantic deep equal public feature 
* Use semantic deep equal when validating
* More test cases for deep equal
 2015-01-07 15:21:34 -08:00
Daniel Smith
7f49ba0dcf Put quantity into packages 
kubelet, GCE, validation, client
 2015-01-07 15:21:34 -08:00
Tim Hockin
1ec3457fc9 Beef up validation tests 2015-01-06 13:02:42 -08:00
Tim Hockin
6e8f5fea8e Fix validation for BoundPods to allow defaults 
Thunking to Manifest makes a copy of the input, which is not useful for
defaulting.
 2015-01-06 13:02:41 -08:00
Tim Hockin
ca27fb259c Don't use pointers for session affinity 2014-12-29 14:43:17 -08:00
Tim Hockin
652479a3b1 Add kubelet DNS flags & api disable for DNS 
This adds --cluster_dns and --cluster_domain flags to kubelet.  If
non-empty, kubelet will set docker --dns and --dns-search flags based on
these.  It uses the cluster DNS and appends the hosts's DNS servers.
Likewise for DNS search domains.

This also adds API support to bypass cluster DNS entirely, needed to
bootstrap DNS.
 2014-12-29 09:18:12 -08:00
Brendan Burns
9884142061 Clear node status before the validation check. 2014-12-22 11:57:31 -08:00
Brendan Burns
5e8490d5fe Add a PodUnknown phase and make ListPods return even when there are errors 
obtaining info for some pods.
 2014-12-19 15:08:48 -08:00
Brendan Burns
36bc3604b9 Merge pull request #2893 from brendandburns/pd3 
Make it easier to update nodes, make it possible to update capacity.
 2014-12-18 10:18:54 -08:00
Brendan Burns
cf0b41535f Make it easier to update nodes, make it possible to update capacity. 2014-12-17 21:50:26 -08:00
Mike Foley
569ce87f0e Updated types API to include session affinity. … 
- changed CLIENT-IP and NONE to be ClientIP and None respectively
 - updated conversions to support translating between api versions.
 - updated validations to validate session affinity type if specified.
 2014-12-17 15:59:20 -05:00
Joe Beda
93ed9173e3 Merge pull request #2781 from commonlisp/master 
simplify util.ErrorList by eliminating errorListInternal
 2014-12-16 15:43:55 -08:00
Clayton Coleman
dadb8431c4 Remove internal PodState in favor of internal PodStatus object 2014-12-15 16:50:05 -05:00
George Kuan
5e1fc1f4e0 Fixes #1605: make ErrorList introspectable by replacing ErrorList and 
ErrorList#ToError with []error and util.SliceToError() respectively
 2014-12-12 10:56:31 -08:00
Daniel Smith
f81ec248d0 Merge pull request #2786 from smarterclayton/load_opaque_objects 
Allow runtime.Object to be encoded as runtime.RawExtension
 2014-12-10 16:24:05 -08:00
Clayton Coleman
19379b5a38 Internal rename api.Minion -> api.Node 2014-12-10 12:08:18 -05:00
bgrant0607
4a9afe61da Merge pull request #2621 from brendandburns/kubecfg 
Add validation back in
 2014-12-09 15:10:51 -08:00
Brendan Burns
18cfac0d31 Make validation optional, handle YAML 2014-12-09 12:37:49 -08:00
Brendan Burns
c29f5db81c Revert "Revert "Add optional validation to kubecfg/kubectl."" 
This reverts commit 6590c66dd4.
 2014-12-09 12:37:48 -08:00
Clayton Coleman
2c27f7d332 Allow an empty service 2014-12-09 12:48:53 -05:00
Tim Hockin
5ecce5d60c Add util to validate namespaced names 2014-12-08 15:31:43 -08:00
Clayton Coleman
714dbf4522 Shrink runtime.TypeMeta to be equivalent to api TypeMeta 
Remove unused fuzzing
 2014-12-07 20:49:07 -05:00
Jordan Liggitt
22eee15fe7 Remove uint64 bitshift workaround 2014-12-04 15:00:23 -08:00
Tim Hockin
89875ef09d Loosen DNS 952 for labels 2014-12-01 12:30:43 -08:00
Tim Hockin
c857dc1196 Add namespacing for label keys 2014-12-01 12:30:43 -08:00
Tim Hockin
d5a6a54391 clean up error message on labels validation errs 2014-12-01 12:30:43 -08:00
Tim Hockin
9afeaf36ef Fix head 2014-11-26 13:48:50 -08:00
Eric Tune
585afa1bae Merge pull request #2610 from ddysher/node-namespace 
Fix node namespace.
 2014-11-26 13:02:21 -08:00
Joe Beda
6590c66dd4 Revert "Add optional validation to kubecfg/kubectl." 
This reverts commit acf6d82800.
 2014-11-25 14:45:00 -08:00
Eric Tune
636ffed399 Merge pull request #2515 from thockin/why 
Add details on Invalid validation errors
 2014-11-25 14:04:27 -08:00