Commit Graph

3676 Commits

Author SHA1 Message Date
k8s-ci-robot
3bcbc5da79 Merge pull request #70887 from seans3/kubectl-get-fix
kubectl get: remove internal resource dependency
2018-11-12 13:20:08 -08:00
Davanum Srinivas
954996e231 Move from glog to klog
- Move from the old github.com/golang/glog to k8s.io/klog
- klog as explicit InitFlags() so we add them as necessary
- we update the other repositories that we vendor that made a similar
change from glog to klog
  * github.com/kubernetes/repo-infra
  * k8s.io/gengo/
  * k8s.io/kube-openapi/
  * github.com/google/cadvisor
- Entirely remove all references to glog
- Fix some tests by explicit InitFlags in their init() methods

Change-Id: I92db545ff36fcec83afe98f550c9e630098b3135
2018-11-10 07:50:31 -05:00
k8s-ci-robot
7872a1db2f Merge pull request #70856 from lojies/cleanuptaint
code cleanup for kubectl taint
2018-11-10 00:14:22 -08:00
k8s-ci-robot
2dcdad297e Merge pull request #70883 from seans3/printing-test-remove
kubectl: remove redundant test
2018-11-09 16:23:13 -08:00
Sean Sullivan
c814f61510 kubectl get: remove internal resource dependency 2018-11-09 11:33:11 -08:00
Sean Sullivan
6b0f66d864 kubectl: remove redundant test 2018-11-09 11:12:20 -08:00
lojies
e3d69d8c33 code cleanup for kubectl taint 2018-11-09 16:22:00 +08:00
Sean Sullivan
62ec499d6f kubectl convert: add deprecation warning for 1.13 2018-11-08 11:50:49 -08:00
Davanum Srinivas
43f523d405 Switch to sigs.k8s.io/yaml from ghodss/yaml
Change-Id: Ic72b5131bf441d159012d67a6a3d87088d0e6d31
2018-11-07 13:17:32 -05:00
k8s-ci-robot
1f56cd801e Merge pull request #70713 from deads2k/kubectl-15-wait
kubectl version should print just client information in the absence of kubeconfig
2018-11-07 09:06:18 -08:00
David Eads
4efb020860 kubectl version should print just client information in the absence of kubeconfig 2018-11-06 16:25:39 -05:00
Jordan Liggitt
9ae79f9653 authorizers subproject approvers/reviewers 2018-11-06 00:57:38 -05:00
k8s-ci-robot
5656ac754d Merge pull request #70577 from WanLinghao/kubectl_logs_fix
fix a bug that --tail option does not take effects in 'kubectl logs --selector xx=xx --tail 3'
2018-11-05 16:32:53 -08:00
k8s-ci-robot
8fe6eb3076 Merge pull request #70420 from idealhack/fix-golint-pkg-kubectl
Fix some golint errors for packages in `pkg/kubectl`
2018-11-05 06:53:55 -08:00
Sean Sullivan
68cea87cfd kubectl: remove unnecessary internal->external conversion before PrintObj 2018-11-02 10:03:52 -07:00
WanLinghao
ea7065d471 fix a bug that --tail option does not take effects in 'kubectl logs --selector xx=xx --tail 3' 2018-11-02 18:20:58 +08:00
Yang Li
3d0c961d57 Fix some golint errors for packages in pkg/kubectl
- Fix some golint errors for `pkg/kubectl`
- Fix a golint error for `pkg/kubectl/apps`
- Fix all golint errors for `pkg/kubectl/cmd`
- Fix some golint errors for `pkg/kubectl/generate/versioned`
- Fix a golint error for `pkg/kubectl/generate`
- Fix some golint errors for `pkg/kubectl/metricsutil`
- Fix all golint errors for `pkg/kubectl/util`
- Fix all golint errors for `pkg/kubectl/util/slice`
2018-11-02 11:55:40 +08:00
k8s-ci-robot
bce51cc574 Merge pull request #70412 from Pingan2017/kubectl-top
code cleanup for kubectl top
2018-11-01 15:17:55 -07:00
Sean Sullivan
1e161bb329 kubectl: change legacyscheme codecs to direct codecs (no conversion) 2018-10-31 15:24:22 -07:00
juanvallejo
901c798681 prevent sorting of PATH dirs
This patch allows the `kubectl plugin list` command to display discovered
plugin paths in the same order as they appear in a user's PATH.
Prior to this patch, discovered plugin paths were sorted before being
displayed.

Additionally, any errors encountered while reading from any directory in a
user's PATH will now be printed to stderr at the end of the command's
output.
2018-10-30 14:13:13 -04:00
Pingan2017
eea9994112 code cleanup for kubectl top 2018-10-30 15:01:24 +08:00
k8s-ci-robot
117c6177c4 Merge pull request #70278 from jhvhs/master
Documentation re-formatting
2018-10-26 13:32:00 -07:00
Maciej Szulik
fdcd6de9c0 Update deprecation warning for kubectl run 2018-10-26 16:22:33 +02:00
Konstantin Semenov
84ba7e8f69 Documentation re-formatting
The closing bracket in the link was automatically included in the link HREF.
Myself and @lurraca used standard markdown formatting to prevent that from happening.
2018-10-26 11:32:36 +01:00
k8s-ci-robot
b6fd5d93b2 Merge pull request #69389 from smarterclayton/wait_error
kubectl wait must handle errors returned by watch
2018-10-25 09:40:41 -07:00
k8s-ci-robot
1af393d58e Merge pull request #69866 from xichengliudui/fix181016
Remove duplicate words
2018-10-22 15:35:36 -07:00
k8s-ci-robot
d8f9b5b668 Merge pull request #69958 from Pingan2017/cleanup-kubectl-delete
remove unneed if block for kubectl delete command
2018-10-18 19:50:53 -07:00
k8s-ci-robot
85e460e362 Merge pull request #69809 from sc14aec/create-context-error-messages
Fix error messages suggesting invalid flag
2018-10-18 19:50:43 -07:00
k8s-ci-robot
007ad9179c Merge pull request #69760 from Pingan2017/validate-args
validate args for kubectl api-versions/api-resources command
2018-10-18 14:44:00 -07:00
k8s-ci-robot
00dd32b167 Merge pull request #69573 from bjhaid/master
Opt out of chowning and chmoding from kubectl cp.
2018-10-18 14:43:49 -07:00
bjhaid
44bed94f0e Opt out of chowning and chmoding from kubectl cp.
`kubectl cp` relies on tar to extract the copied file/directory in the
container, tar by default attempts to chown/chmod the extracted file
after extraction if the user is the "superuser"(root)

```
--same-owner
try extracting files with the same ownership as exists in the archive
(default for superuser)
-p, --preserve-permissions, --same-permissions
extract information about file permissions (default for superuser)
```

This fails in environment where the container runs as root but is not
granted the OWNER or CHOWN capability.

Before this patch below was the behavior of `kubectl cp`

```
kubectl cp README.md foo-67b6fcbd4c-qjlt6:/tmp
tar: README.md: Cannot change ownership to uid 1000, gid 1000: Operation
not permitted
tar: Exiting with failure status due to previous errors
command terminated with exit code 2
kubectl exec -it foo-67b6fcbd4c-qjlt6 -- ls -l /tmp/README.md
-rw------- 1 1000 1000 3179 Oct  7 22:00 /tmp/README.md
```

After this patch

```
kubectl cp -x a foo-67b6fcbd4c-qjlt6:/
kubectl exec -it foo-67b6fcbd4c-qjlt6 -- ls -l /tmp/README.md
-rw-r--r-- 1 root root 3179 Oct  7 22:00 /tmp/README.md
```
2018-10-18 14:16:06 +00:00
Pingan2017
797f0ac660 remove unneed if block for kubectl delete command 2018-10-18 11:33:45 +08:00
k8s-ci-robot
0d6f6a680b Merge pull request #68441 from smarterclayton/describe_dependency
Move versioned generators into their own package
2018-10-17 04:24:06 -07:00
Clayton Coleman
5a8afa073f Dynamic client watchers should be able to handle ERROR gracefully
Watch can return type "ERROR" and a metav1.Status object. We need to
handle that during wait, and make it easy to handle the status object.
2018-10-16 12:55:23 -04:00
Clayton Coleman
c21774e9de Remove defaulting from test that uses kubectl.Scheme
The dependency on printers/internalversion was causing kubectl/scheme
to have defaulters registered, which should not be the case. Remove
defaults from the test.
2018-10-16 12:54:41 -04:00
Clayton Coleman
5e905f1f5f Move versioned generators into their own package
pkg/kubectl has a lot of files. Move everything generator related
into pkg/kubectl/generate (generic) or pkg/kubectl/generate/versioned
(type specific).

Move the DescriberFn and GeneratorFn out of kubectl/cmd/util and into
the respective versioned packages, along with tests.
2018-10-16 12:54:40 -04:00
Clayton Coleman
c291d3d7ed Consistently print errors to stderr and add newlines to cordon 2018-10-16 11:16:15 -04:00
Pingan2017
2b2d8ba8c1 validte args for kubectl api-versions/api-resources 2018-10-16 19:22:17 +08:00
xichengliudui
e394482373 Remove duplicate words 2018-10-15 15:55:49 -04:00
Sean Sullivan
6a2ef97d46 kubectl: update to use correct printers package 2018-10-15 11:02:19 -07:00
Andy Crow
4400996c48 Fix error messages suggesting invalid flag 2018-10-15 16:39:53 +01:00
k8s-ci-robot
2129bc9f85 Merge pull request #69742 from apelisse/fix-diff-error
Rename KUBERNETES_EXTERNAL_DIFF to KUBECTL_EXTERNAL_DIFF
2018-10-13 09:54:52 -07:00
k8s-ci-robot
a5b489a3a3 Merge pull request #69751 from seans3/tabwriter-fix
kubectl: copy printer tabwriter into kubectl
2018-10-13 03:56:17 -07:00
k8s-ci-robot
d84c43120e Merge pull request #69745 from apelisse/check-dryrun-on-create
kubectl dry-run: Check for server didn't work on create
2018-10-12 22:31:28 -07:00
k8s-ci-robot
b66d58c1b6 Merge pull request #69446 from seans3/taint-fix
kubectl taint: copy core taintutil dependency into kubectl
2018-10-12 16:01:33 -07:00
Sean Sullivan
d076897be7 kubectl: copy printer tabwriter into kubectl 2018-10-12 15:10:46 -07:00
k8s-ci-robot
3348f9ae23 Merge pull request #69627 from dims/updating-ghodss-yaml-to-latest-version-2
Updating ghodss/yaml and gopkg.in/yaml.v2 to latest version 2
2018-10-12 14:48:26 -07:00
Antoine Pelisse
572a028148 kubectl diff: Print error when something goes wrong 2018-10-12 14:12:32 -07:00
Sean Sullivan
8c196137e8 kubectl taint: copy core taintutil dependency into kubectl 2018-10-12 12:39:15 -07:00
Antoine Pelisse
54889d581a kubectl dry-run: Check for server didn't work on create
We changed the code to verify that the type supports dry-run, but we've
only done it for patch, not for create, which means that people can
create objects they don't want to create. We can actually simplify the
code by moving the check much earlier in the method, which fixes all
possible bug like this.
2018-10-12 11:30:49 -07:00