Commit Graph

7469 Commits

Author SHA1 Message Date
yameiwang
f130e48deb fix golint errors in pkg/volume/host_path 2019-04-25 06:46:47 +08:00
Kubernetes Prow Robot
e6390ce3ff
Merge pull request #76835 from SataQiu/fix-shellcheck-hack-20190420
Fix shellcheck failures of hack/verify-boilerplate.sh verify-cli-conventions.sh verify-codegen.sh
2019-04-23 03:14:12 -07:00
Kubernetes Prow Robot
fd0a140673
Merge pull request #76890 from xichengliudui/fixshellcheckfailures-31
fix shellcheck failures on and verify-test-featuregates.sh
2019-04-23 00:46:26 -07:00
SataQiu
2704abf844 fix shellcheck failures of hack/verify-boilerplate.sh verify-cli-conventions.sh verify-codegen.sh 2019-04-23 13:39:00 +08:00
Kubernetes Prow Robot
4ec29a1a2b
Merge pull request #76889 from SataQiu/fix-golint-kubelet-util-20190422
Fix golint failures of pkg/kubelet/util
2019-04-22 20:44:25 -07:00
Kubernetes Prow Robot
b9606bef8d
Merge pull request #76860 from SataQiu/fix-golint-volume-20190420
Fix golint failures of pkg/volume/local
2019-04-22 20:44:07 -07:00
Kubernetes Prow Robot
588ea5d757
Merge pull request #76871 from cblecker/shellcheck-colour
Fix malformed JUNIT XML with shellcheck failures
2019-04-22 14:38:19 -07:00
Kubernetes Prow Robot
b57387b333
Merge pull request #76767 from SataQiu/fix-shellcheck-20190418
Fix shellcheck failures of hack/verify-openapi-spec.sh
2019-04-22 13:17:46 -07:00
Kubernetes Prow Robot
dc395391bc
Merge pull request #76834 from SataQiu/fix-hack-shell-2019041905
Fix bug and golint failures of hack/verify-api-groups.sh
2019-04-22 10:44:00 -07:00
Kubernetes Prow Robot
0ca27bfee2
Merge pull request #76139 from SataQiu/fix-golint-kubectl-20190404
Fix golint failures of pkg/kubectl/apps
2019-04-22 10:43:44 -07:00
Kubernetes Prow Robot
3488cd346a
Merge pull request #76804 from SataQiu/fix-apis-golint-20190419
Fix golint failures of pkg/apis/batch
2019-04-22 09:23:46 -07:00
SataQiu
741caa4475 fix bug and golint failures of hack/verify-api-groups.sh 2019-04-22 22:20:04 +08:00
SataQiu
cd6828bae0 fix golint failures of pkg/kubelet/util 2019-04-22 15:23:07 +08:00
SataQiu
b4bc5cb4fe
Merge branch 'master' into fix-shellcheck-20190418 2019-04-22 11:32:17 +08:00
Kubernetes Prow Robot
75d45bdfc9
Merge pull request #76856 from SataQiu/fix-hack-cherrypick-20190420
Fix shellcheck failures of hack/cherry_pick_pull.sh
2019-04-21 09:25:44 -07:00
Kubernetes Prow Robot
1377108c08
Merge pull request #76808 from SataQiu/fix-hack-shellcheck-20190419
Fix shellcheck failures of hack/verify-readonly-packages.sh
2019-04-21 00:47:44 -07:00
Christoph Blecker
5236850989
Fix malformed JUNIT XML with shellcheck failures 2019-04-20 18:22:28 -07:00
SataQiu
1f40880615 fix golint failures of pkg/volume/local 2019-04-20 18:18:25 +08:00
aaa
5c8ec1ce9c fix shellcheck failures
update pull request

update pull request
2019-04-20 05:08:00 -04:00
SataQiu
e7e517434b fix shellcheck failures of hack/cherry_pick_pull.sh 2019-04-20 15:49:34 +08:00
SataQiu
43095d9218 fix shellcheck failures of hack/verify-readonly-packages.sh 2019-04-20 14:10:58 +08:00
Kubernetes Prow Robot
f980370fc0
Merge pull request #76608 from suigh/b1_etcd.sh
update the output of install-etcd.sh, show how to export the environment of etcd
2019-04-19 20:29:42 -07:00
aaa
ad5bccc510 fix shellcheck in test-smoke.sh and test-network.sh
update pull request

update pull request

update pull request

update pull request
2019-04-19 16:15:10 -04:00
aaa
e05f85a611 Fix shellcheck failures on verify-readonly-packages.sh 2019-04-19 14:59:50 -04:00
Kubernetes Prow Robot
e4f9d8fe3f
Merge pull request #76331 from xichengliudui/fixshellcheckfailures-17
Fix shellcheck failures in stage-upload.sh
2019-04-19 09:47:55 -07:00
SataQiu
a20aec8d2d fix shellcheck failures of hack/verify-openapi-spec.sh 2019-04-19 23:28:34 +08:00
Kubernetes Prow Robot
3b12266c06
Merge pull request #76803 from cblecker/goldflags-fix
Fix shellcheck in hack/lib/golang.sh
2019-04-19 05:53:56 -07:00
SataQiu
61478c04d8 fix golint failures of pkg/apis/batch 2019-04-19 18:04:54 +08:00
suigh
c056a46ba9 update the output of install-etcd.sh, show how to export the environment of etcd. 2019-04-19 16:43:00 +08:00
Kubernetes Prow Robot
b54053924e
Merge pull request #76810 from SataQiu/fix-hack-shellcheck-2019041903
Fix shellcheck failures of hack/test-update-storage-objects.sh
2019-04-19 01:06:13 -07:00
SataQiu
4d6319b9b2 fix shellcheck failures of hack/test-update-storage-objects.sh 2019-04-19 20:00:58 +08:00
Kubernetes Prow Robot
3cbb20c694
Merge pull request #76809 from SataQiu/fix-hack-shellcheck-2019041902
Fix shellcheck failures of hack/verify-description.sh and hack/verify-import-boss.sh
2019-04-18 23:40:26 -07:00
SataQiu
04ab994cc3 fix shellcheck failures of hack/verify-description.sh and hack/verify-import-boss.sh 2019-04-19 18:59:24 +08:00
Kubernetes Prow Robot
f0022d87e5
Merge pull request #76744 from xichengliudui/fixshellcheckfailures-25
Fix shellcheck failures on test-e2e-node.sh and test-integration.sh
2019-04-18 23:40:10 -07:00
Christoph Blecker
4543e68ae5
Fix shellcheck in hack/lib/golang.sh 2019-04-18 18:53:13 -07:00
Kubernetes Prow Robot
d308368b2d
Merge pull request #76417 from SataQiu/fix-shell-update-generated-runtime-dockerized-20190411
Fix shellcheck failures of hack/update-generated-runtime-dockerized.sh
2019-04-18 14:27:54 -07:00
SataQiu
bd7f7fefae fix shellcheck failures of hack/update-generated-runtime-dockerized.sh 2019-04-18 22:36:22 +08:00
Davanum Srinivas
7e01702a88
Move "-s -w" flags to GOLDFLAGS as an overridable default.
If GOLDFLAGS is set, whether it is empty or not, we should honor it.
Only if the GOLDFLAGS is totally not set, then we use "-s -w"

See Parameter Expansion section in the urls below:

https://stackoverflow.com/questions/3601515/how-to-check-if-a-variable-is-set-in-bash/16753536
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02

Change-Id: I826c34efc63c77f0e3e9677fff30a3eb2219a377
2019-04-17 21:55:13 -04:00
Kubernetes Prow Robot
401cc19548
Merge pull request #76622 from oomichi/enable-conformance-check
Enable conformance requirement check
2019-04-17 12:16:53 -07:00
Kubernetes Prow Robot
f625bef870
Merge pull request #76478 from SataQiu/fix-shell-hack-20190412
Fix shellcheck failures of hack/update-generated-kms-dockerized.sh and hack/update-generated-protobuf-dockerized.sh
2019-04-17 12:16:36 -07:00
Kubernetes Prow Robot
23e6f80304
Merge pull request #76132 from SataQiu/fix-e2e-apps-golint-20190404
Fix golint failures of test/e2e/apps
2019-04-17 12:16:04 -07:00
SataQiu
4c713e94d9 fix golint failures of pkg/kubectl/apps 2019-04-17 19:37:35 +08:00
SataQiu
03180ec2b2 fix golint failures of test/e2e/apps 2019-04-17 19:04:51 +08:00
Kubernetes Prow Robot
c3bec0bae4
Merge pull request #74601 from mrbobbytables/fix-test-image-shellcheck
Fix shellcheck lint errors in test/images/* scripts
2019-04-17 02:22:03 -07:00
Kenichi Omichi
08dc056480 Replace false with exit 1
Some scripts contained `false` for returning 1 to callers instead of
`exit 1` and that works like:

  $ false
  $ echo $?
  1
  $

But that made confusion in a PR review process.
So this replaces `false` with `exit 1` for long-term maintenance.
2019-04-16 23:13:00 +00:00
Kenichi Omichi
c76bb08357 Enable conformance requirement check 2019-04-16 22:54:16 +00:00
Kubernetes Prow Robot
1a0a75750c
Merge pull request #76613 from SataQiu/fix-golint-20190416
Fix golint failures of pkg/apis/core/helper
2019-04-16 10:27:31 -07:00
Kubernetes Prow Robot
123b9c9e10
Merge pull request #76313 from SataQiu/fix-hack-2019040902
Fix shellcheck failures of hack/update-openapi-spec.sh
2019-04-16 10:27:10 -07:00
Kubernetes Prow Robot
98b6f35999
Merge pull request #74610 from oomichi/issue/74038-2
Enable StorageObjectInUseProtection by default
2019-04-16 02:11:29 -07:00
Kubernetes Prow Robot
35669df1ab
Merge pull request #76066 from SataQiu/golint-test-20190403
Fix golint failures of e2e/apimachinery
2019-04-15 23:31:22 -07:00