Commit Graph

3141 Commits

Author SHA1 Message Date
JieJhih Jhang
f1829a7744 fix golint in volume fs 2021-01-12 06:35:52 +08:00
Chris Henzie
736b7e15b7 Remove duplicate test CSI plugin constructor logic 2021-01-06 16:32:41 -08:00
Chris Henzie
359b9e3383 Ensure CSI test plugin informers are synced before returning
This way of syncing informers ensures all informers generated from these
factories are synced. Informers are lazy loaded, and only created once a
user calls .Informer() (which was why the .PollImmediate() worked).
Asserting the number of synced types to ensure everything is set up
correctly.
2021-01-06 16:11:50 -08:00
Chris Henzie
257704b30d Remove setupInformer argument from test CSI plugin constructor 2021-01-06 16:11:50 -08:00
Chris Henzie
70eddfefec Ensure goroutines exit in CSI attacher tests
The reason for adding an expectedVolumeHost field is to prevent a
channel read from hanging when a test fails prior to creating the
VolumeAttachment watch.
2021-01-06 16:11:50 -08:00
Chris Henzie
f098ada9d1 Extract watch reactor out of test CSI plugin constructor 2021-01-06 16:11:50 -08:00
Chris Henzie
195a5af23b Make volume attachment watch timeout configurable for csiAttacher 2021-01-06 16:11:39 -08:00
Chris Henzie
b4e3f272b9 Remove unused waitSleepTime field in csiAttacher 2021-01-06 15:45:56 -08:00
Kubernetes Prow Robot
39483aa095
Merge pull request #96889 from jsafrane/fix-kubelet-symlink
Fix loopback device lookup
2021-01-05 20:57:51 -08:00
Kubernetes Prow Robot
8b24d1f2f9
Merge pull request #96806 from CKchen0726/master
remove input parameter that is invalid before
2021-01-05 13:27:53 -08:00
Kubernetes Prow Robot
72ede75d9c
Merge pull request #97587 from heqg/typo-expected-01
Fix typo in pkg/volume/rbd/rbd_test.go
2021-01-05 11:46:54 -08:00
Kubernetes Prow Robot
07bd985724
Merge pull request #96561 from ialidzhikov/cleanup/csi-node-info
Remove CSINodeInfo feature gate
2021-01-05 11:46:00 -08:00
he.qingguo
3e4e50a3b9 Fix typo in pkg/volume/rbd/rbd_test.go
Signed-off-by: he.qingguo <he.qingguo@zte.com.cn>
2020-12-30 13:58:41 +08:00
Kubernetes Prow Robot
0f7c2dc314
Merge pull request #97082 from andyzhangx/azurefile-actimeo
fix: azure file latency issue for metadata-heavy workloads
2020-12-21 19:12:25 -08:00
andyzhangx
8d43976b74 fix azure file secret not found issue 2020-12-21 11:17:40 +00:00
Kubernetes Prow Robot
b538d23066
Merge pull request #96844 from gnufied/use-force-unmount
Use force umount for nfs volumes
2020-12-18 12:32:25 -08:00
Chris Henzie
9d8f994d4e Separate test Kubelet and AttachDetach VolumeHost types
fakeVolumeHost previously implemented both the KubeletVolumeHost and
AttachDetachVolumeHost interfaces. This design makes it difficult to test the
CSIAttacher since it behaves differently depending on what type of
VolumeHost is supplied.
2020-12-17 15:17:04 -08:00
Chris Henzie
53cae84aea Move fakeVolumeHost logic into a separate file 2020-12-17 15:17:04 -08:00
Jan Safranek
357a8c3f55 Fix loopback device lookup
In case /var/lib/kubelet is a symlink, "losetup -j <device in
/var/lib/kubelet>" will show the device paths with symlinks fully
evaluated.

Fix the parsing routine and expand symlinks in the path that we want to
find in "losetup -j" output.
2020-12-16 09:33:51 +01:00
Hemant Kumar
379daa6aff Use force umount for nfs volumes 2020-12-15 11:50:57 -05:00
ialidzhikov
bc432124a2 Remove CSINodeInfo feature gate
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
2020-12-10 09:58:22 +02:00
Chris Henzie
80bd46ce46 Prevent data race in volume plugin manager 2020-12-09 14:32:49 -08:00
Kubernetes Prow Robot
f8db0d91de
Merge pull request #97013 from jsafrane/fc-fixcorrupted-fs
Fix FibreChannel volume plugin corrupting filesystem on detach
2020-12-08 21:06:33 -08:00
Kubernetes Prow Robot
d5430313bf
Merge pull request #96751 from jsafrane/deprecation-log
Lower the frequency of volume plugin deprecation warning
2020-12-08 20:02:32 -08:00
Kubernetes Prow Robot
984bc043d5
Merge pull request #96593 from pandaamanda/typo_fix
fix typo and format for klog
2020-12-08 17:29:43 -08:00
Kubernetes Prow Robot
4a4bdb0169
Merge pull request #96581 from qingsenLi/201114-unmount
Fix typo unmount for klog
2020-12-08 17:29:27 -08:00
Kubernetes Prow Robot
ce7ac8442e
Merge pull request #94599 from verult/adc-op-asw-race
Fixes Attach Detach Controller reconciler race reading ActualStateOfWorld and operation pending states
2020-12-08 16:28:53 -08:00
andyzhangx
ff110654e9 fix: azure file latency issue for metadata-heavy workload 2020-12-05 12:42:56 +00:00
Jan Safranek
8f186f9172 Flush FibreChannel devices before deleting
If a FibreChannel device is used as a block volume, we should flush its I/O
before deleting its device. It is not strictly necessary when it's used as
a filesystem (mount), but it won't hurt either.
2020-12-03 09:54:22 +01:00
Jan Safranek
6f8bdb7cc1 Fix FibreChannel volume plugin corrupting filesystem on detach
FibreChannel volume plugin misses one important step when removing a
device: "multipath -f". It flushes all multipath buffers to its individual
paths. Without it, a filesystem on the device may get corrupted.
2020-12-02 14:39:00 +01:00
CKchen0726
a3fdab491a use input parameter that is invalid before 2020-11-26 17:04:55 +08:00
Jan Safranek
62ecc68183 Lower the frequency of volume plugin deprecation warning
The warning is always logged (klog.Warningf), so make sure it's logged only
once per process. We've seen clusters where the deprecation warning was
about 20% of total logs.
2020-11-20 14:22:28 +01:00
Kubernetes Prow Robot
160c33a6a1
Merge pull request #96533 from gnufied/reduce-vsphere-volume-name
Reduce volume name length for vsphere
2020-11-17 17:34:05 -08:00
Hemant Kumar
742436c431 Reduce volume name length for vsphere 2020-11-16 11:28:26 -05:00
xiongzhongliang
0d2b542dde fix typo and format for klog 2020-11-14 23:44:38 +08:00
10177505
7531e2a311 Fix typo unmount for klog 2020-11-14 11:32:39 +08:00
Christian Huffman
4d2d063635 Included e2e test for CSIDriver FSGroupPolicy 2020-11-12 16:30:38 -05:00
Christian Huffman
01f70d69b7 Move CSIVolumeFSGroupPolicy to beta 2020-11-12 16:28:54 -05:00
Shihang Zhang
d2859cd89b plumb service account token down to csi driver 2020-11-12 09:26:43 -08:00
Kubernetes Prow Robot
0923b9abce
Merge pull request #95206 from misterikkit/quobyte-update
storage: Use FilteredDialContext in quobyte client
2020-11-10 21:44:30 -08:00
Jonathan Basseri
dfe6ea6df6 Use FilteredDialContext with quobyte API
This injects the filtered DialContext behavior from VolumeHost into the
quobyte plugin, which allows us to configure a host deny list for the
plugin.

There should be no change in timeouts, because we are able to use the
same default transport settings as before.
2020-11-10 11:21:04 -08:00
Kubernetes Prow Robot
f458996af1
Merge pull request #95770 from jingxu97/oct/readyfile
Remove ready directory which created in empty volumeMounter setUp func
2020-11-10 10:54:40 -08:00
Jing Xu
a4aa494cc1 Remove ready directory which created in empty volumeMounter setUp func
Change-Id: I2384b07c7a044149e93e951a45f9f8a7bd9dba15
2020-11-09 23:12:21 -08:00
Kubernetes Prow Robot
734889ed82
Merge pull request #96224 from gnufied/add-dangling-error-vsphere
Add dangling volume check for vsphere
2020-11-09 16:09:09 -08:00
Kubernetes Prow Robot
2b4be7bb5f
Merge pull request #88759 from andyzhangx/csi-dir-fix
feat: ignore mount dir check in csi node stage/publish
2020-11-09 16:08:40 -08:00
Hemant Kumar
6c4c5ab691 Add dangling volume check for vsphere 2020-11-09 15:39:17 -05:00
Jan Safranek
6060c57ba3 Call MountDevice only once
Cann MountDevice only when the volume was not device-mounted before.
2020-11-09 19:22:29 +01:00
Jan Safranek
b3b53cbf63 Mark MountDevice as uncertain after failed resize
When NodeExpand fails between MountDevice and SetUp, make sure the next
NodeExpand attempt is called before SetUp.
2020-11-09 19:22:29 +01:00
Jan Safranek
9a765f8c2d Restore staging path creation
CSI says about NodeStage (=MountDevice):
// The CO SHALL ensure [...]
// that the path is directory and that the process serving the
// request has `read` and `write` permission to that directory. The
// CO SHALL be responsible for creating the directory if it does not
// exist.
2020-11-09 19:22:29 +01:00
Jan Safranek
55ffd9d5fc Add unit test for staging path creation 2020-11-09 19:22:25 +01:00