github/kubernetes
4
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
106,685 Commits 1 Branch 31 Tags 1,019 MiB
f4df7d0eb2
Commit Graph

5619 Commits

Author SHA1 Message Date
sunzhaochang
f0e74bfb7f Fix unexpected end of TestDependentsRace 2021-12-10 20:07:37 +08:00
Davanum Srinivas
9405e9b55e
Check in OWNERS modified by update-yamlfmt.sh 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
 2021-12-09 21:31:26 -05:00
Kubernetes Prow Robot
d16a5e5feb
Merge pull request #106673 from qmloong/qmloong/master 
refactor: use utilerrors instead of join error msg
 2021-12-07 18:27:22 -08:00
Kubernetes Prow Robot
12901b95c9
Merge pull request #106344 from ikeeip/fix_import_formatting 
Fix golang imports in k8s.io/pkg/controller/volume/persistentvolume package
 2021-12-07 17:26:40 -08:00
menglong.qi
ea31d7b813 refactor: use utilerrors instead of join error msg 2021-11-28 17:16:17 +08:00
Matthew Cary
0e2b901762 Clean up deep copy needed for UpdateStatefulSet 
Change-Id: Id732358183d682d1a945cfee56f83bcaac0d7c31
 2021-11-23 06:48:54 -08:00
Aohan Yang
ad4fe13528 fix the error when cleaning up jobs for cronjob 2021-11-22 17:06:22 +08:00
Kubernetes Prow Robot
084b28f6d5
Merge pull request #106510 from robscott/topology-ready-fix-controller 
Updating TopologyCache to disregard unready endpoints in calculations
 2021-11-19 17:07:11 -08:00
Rob Scott
9813ec7e8a
Updating TopologyCache to disregard unready endpoints in calculations 2021-11-18 13:54:09 -08:00
Matthew Cary
53b3a6c1d9 controller change for statefulset auto-delete (tests) 
Change-Id: I16b50e6853bba65fc89c793d2b9b335581c02407
 2021-11-17 16:48:50 -08:00
Matthew Cary
bce87a3e4f controller change for statefulset auto-delete (implementation) 2021-11-17 16:48:50 -08:00
Kubernetes Prow Robot
39c76ba2ed
Merge pull request #106455 from soltysh/cronjob_warning 
Add warning about using unsupported CRON_TZ
 2021-11-16 17:44:31 -08:00
Kubernetes Prow Robot
165b581759
Merge pull request #105623 from ash2k/ash2k/resettable-rest-mapper 
ResettableRESTMapper to make it possible to reset wrapped mappers
 2021-11-16 16:36:08 -08:00
Kubernetes Prow Robot
6805e6ee41
Merge pull request #104722 from leiyiz/migration 
turning on the CSIMigrationGCE feature flag
 2021-11-16 15:28:32 -08:00
Kubernetes Prow Robot
f151a40d8d
Merge pull request #106154 from gnufied/recover-expansion-failure-123 
Recover expansion failure
 2021-11-16 13:21:34 -08:00
Léiyì Zhang
275fdf0884 fixing unit test failures induced by turning on CSIMigrationGCE 
disable CSIMigrationGCE in some unit tests
 2021-11-16 19:26:30 +00:00
Maciej Szulik
d0518848b5
Add warning about using unsupported CRON_TZ 
CRON_TZ variable slipped in during upgrading github.com/robfig/cron
library.  It allows setting a time zone which is a long requested
feature but one that is not officially supported. This adds warning
event since users should not rely on unsupported features.
 2021-11-16 17:41:37 +01:00
Hemant Kumar
1ddd598d31 Implement controller and kubelet changes for recovery from resize 
failures
 2021-11-16 11:06:46 -05:00
Kubernetes Prow Robot
6d1d8c73ee
Merge pull request #106316 from josephburnett/controller-v2 
Watch HPA v2 instead of v1.
 2021-11-16 06:41:38 -08:00
Joseph Burnett
711f96e05e Watch HPA v2 instead of v1. 2021-11-16 11:13:21 +01:00
Kubernetes Prow Robot
ce98eda406
Merge pull request #106376 from jsafrane/stabilize-unit-test 
Fix deletion protection unit test
 2021-11-15 13:04:48 -08:00
shawnhanx
acc55500bc should omit comparison to bool constant in pkg/controller/controller_utils.go 2021-11-13 17:15:25 +08:00
Neha Lohia
fa1b6765d5
move pkg/util/node to component-helpers/node/util (#105347) 
Signed-off-by: Neha Lohia <nehapithadiya444@gmail.com>
 2021-11-12 07:52:27 -08:00
Jan Safranek
bb8157d780 Fix deletion protection unit test 
The test should not depend on current set of default feature gates, it
should always ensure the ones necessary for the tests are set.
 2021-11-12 10:47:15 +01:00
Kubernetes Prow Robot
2bd67845d4
Merge pull request #105550 from damemi/wire-contexts-rbac 
Wire contexts to RBAC controllers
 2021-11-11 15:15:25 -08:00
Konstantin Misyutin
7434fdf1d4 fix import formatting in k8s.io/pkg/controller/volume/persistentvolume package 
Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com>
 2021-11-11 16:31:38 +08:00
Mike Dame
80c01707e0
Wire contexts to Batch controllers (#105491) 
* Wire contexts to Batch controllers

* (hold) feedback + updates that overlap with Apps controllers

* fixup errors
 2021-11-10 14:56:46 -08:00
Kubernetes Prow Robot
91ff1f9840
Merge pull request #101250 from evertrain/master 
Bugfix: prevent daemon controller to adopt controller revisions of ot…
 2021-11-10 09:19:26 -08:00
Kubernetes Prow Robot
9b083c4226
Merge pull request #105773 from deepakkinni/2680_fgate_v1 
PV controller changes to support PV Deletion protection finalizer
 2021-11-10 05:33:26 -08:00
Kubernetes Prow Robot
8e02b78873
Merge pull request #102534 from wangyysde/create-hpav2stable 
Create HPA v2 Stable API
 2021-11-09 10:27:48 -08:00
Kubernetes Prow Robot
376b2150d5
Merge pull request #105874 from cyclinder/Add_func_name_to_comment 
fix some lint error
 2021-11-09 08:29:47 -08:00
evertrain
a67f22c849 add ut for cluster-scoped controller case 2021-11-09 23:50:24 +08:00
wangyysde
d2abddd909 rename v2beta2 to v2 
Signed-off-by: wangyysde <net_use@bzhy.com>

Generation swagger.json.

Use v2 path for hpa_cpu_field.

run update-codegen.sh

Signed-off-by: wangyysde <net_use@bzhy.com>
 2021-11-09 10:34:54 +08:00
Deepak Kinni
bfd5f23a0b PV controller changes to support PV Deletion protection finalizer 
Signed-off-by: Deepak Kinni <dkinni@vmware.com>
 2021-11-08 10:35:58 -08:00
Mikhail Mazurskiy
de4598d0db
ResettableRESTMapper to make it possible to reset wrapped mappers 2021-11-06 10:44:02 +11:00
Manu Gupta
79a51090f9
fix: 81134: fix unsafe json for ReleaseControllerRevision (#104049) 
* fix: 81134: fix unsafe json for ReleaseControllerRevision

1. Ensures that ReleaseControllerRevision returns a proper json by
marshalling an object into bytes. Otherwise, it returns an error.

2. Also, refactors the code to commonize the merge type
   GenerateDeleteOwnerRefStrategicMergeBytes that returns a byte and is
   used across ReleasePod, ReleaseControllerRevison
   ReleaseReplicaSet.

* Move GeneratePatchBytesForDelete to controller_ref_manager
 2021-11-05 06:33:52 -07:00
Kubernetes Prow Robot
ed42bbd722
Merge pull request #106126 from soltysh/remove_old_cronjob 
Remove old cronjob controller
 2021-11-04 20:35:53 -07:00
Maciej Szulik
5254493044
Remove old cronjob controller 2021-11-04 13:24:28 +01:00
Carl
b3e4fed844
only apply this check if the controller is actually namespaced 
Co-authored-by: Jordan Liggitt <jordan@liggitt.net>
 2021-11-04 13:08:47 +08:00
Kubernetes Prow Robot
4dfd739403
Merge pull request #105997 from robscott/mirroring-selector 
Fixing how EndpointSlice Mirroring handles Service selector transitions
 2021-11-03 12:48:32 -07:00
Kubernetes Prow Robot
aa0ea62489
Merge pull request #104903 from ikeeip/storageobjectinuseprotection_feature_ga_cleanup 
Remove StorageObjectInUseProtection feature gate logic
 2021-11-02 20:22:57 -07:00
Shihao Xia
afb0023ab3 fix potential deadlock 2021-11-02 20:46:06 -04:00
Kubernetes Prow Robot
3fdeb490e0
Merge pull request #105510 from damemi/wire-contexts-bootstrap 
Wire contexts to Bootstrap controllers
 2021-11-02 14:27:42 -07:00
Konstantin Misyutin
808c8f42d5 Remove StorageObjectInUseProtection feature gate logic 
This feature has graduated to GA in v1.11 and will always be
enabled. So no longe need to check if enabled.

Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com>
 2021-11-03 00:13:50 +03:00
Kubernetes Prow Robot
9be67806cd
Merge pull request #102945 from chenchun/fake 
Pass DeleteOptions down to the Reactor
 2021-11-02 07:14:58 -07:00
Chun Chen
621970476f Pass DeleteOptions down to the Reactor 
Co-authored-by: Mo Khan <theenjeru@gmail.com>
 2021-11-02 10:04:48 +08:00
evertrain
9ceb226c06 Bugfix prevent daemon controller to adopt controller revisions of other namespaces 2021-11-02 00:14:26 +08:00
Mike Dame
4960d0976a Wire contexts to Core controllers 2021-11-01 10:29:00 -04:00
Rob Scott
794f0cb7f1
Fixing how EndpointSlice Mirroring handles Service selector transitions 2021-10-29 11:03:28 -07:00
Kubernetes Prow Robot
c592bd40f2
Merge pull request #105609 from pohly/generic-ephemeral-volume-ga 
generic ephemeral volume GA
 2021-10-28 17:36:50 -07:00
Kubernetes Prow Robot
8e37a3b324
Merge pull request #103868 from qingsenLi/210723-forget 
Merge conditional assignment into variable declaration
 2021-10-28 16:32:50 -07:00
Kubernetes Prow Robot
6edcb60d9f
Merge pull request #104915 from alculquicondor/job-ready 
Track ready pods in Job status
 2021-10-28 09:20:26 -07:00
Shuanglu
9bcfa71e31
Fix Daemonset controller role missing 'update pod' permission (#104758) 
* fix_dsc_rbac_pod_update

* add test for DaemonSet Controller updates label of the pod after "DedupCurHistories"

* rebase

* update parameter of dsc.Run
 2021-10-28 05:24:26 -07:00
cyclinder
ab47b8b94b fix some lint error 
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
 2021-10-26 13:56:29 +08:00
Aldo Culquicondor
60fc90967b Count ready pods in job controller 
When the feature gate JobReadyPods is enabled.

Change-Id: I86f93914568de6a7029f9ae92ee7b749686fbf97
 2021-10-19 15:18:37 -04:00
Konstantin Misyutin
dbc9d7b71a Remove tests when StorageObjectInUseProtection feature is disabled 
As well as feature gate are locked, the tests when this feature is
disabled will crash. So we should remove them together with locking
the feature.

Signed-off-by: Konstantin Misyutin <konstantin.misyutin@huawei.com>
 2021-10-15 19:39:37 +08:00
Kubernetes Prow Robot
0bfa37dfcc
Merge pull request #105676 from alculquicondor/job-name 
Fix name for Pods of NonIndexed Jobs
 2021-10-14 10:50:12 -07:00
Aldo Culquicondor
4ef9d18abe Fix name for Pods of NonIndexed Jobs 
Change-Id: I0ea4685a82f4cdec0caab362d52144476652f95a
 2021-10-14 10:55:46 -04:00
Kubernetes Prow Robot
3aafe75698
Merge pull request #105461 from damemi/wire-contexts-autoscaling 
Wire contexts to Autoscaling controllers
 2021-10-14 06:59:33 -07:00
Kubernetes Prow Robot
f27e4714ba
Merge pull request #105377 from damemi/wire-contexts-apps 
Wire contexts to Apps controllers
 2021-10-14 06:59:19 -07:00
Kubernetes Prow Robot
baaa53db64
Merge pull request #105211 from xiaopingrubyist/fix-pv-controller-claim-cache-issue 
fix:claim cached in pvcontroller is not the newest may cause unexpected issue
 2021-10-14 05:47:18 -07:00
Mike Dame
41fcb95f2f Wire contexts to Apps controllers 2021-10-13 16:32:13 -04:00
torubylist
f28a8d7f2b fix:cached claim is not the newest will cause unexpected issue 2021-10-13 20:03:00 +08:00
Mike Dame
7780024916 Wire contexts to Autoscaling controllers 2021-10-12 14:34:05 -04:00
Maciej Szulik
8322121434
Move test-related utils to test/utils 2021-10-12 14:52:19 +02:00
Maciej Szulik
1fb6bf8a14
Wire context instead of TODO 2021-10-12 13:21:45 +02:00
Patrick Ohly
a8c930ef46 generic ephemeral volume: graduation to GA 
The feature gate gets locked to "true", with the goal to remove it in two
releases.

All code now can assume that the feature is enabled. Tests for "feature
disabled" are no longer needed and get removed.

Some code wasn't using the new helper functions yet. That gets changed while
touching those lines.
 2021-10-11 20:54:20 +02:00
Mike Dame
3f0b6d390c Wire contexts to RBAC controllers 2021-10-07 15:04:49 -04:00
Kubernetes Prow Robot
b0eac84937
Merge pull request #105345 from pohly/generic-ephemeral-volume-util 
generic ephemeral volume util, base code and controller
 2021-10-07 08:19:47 -07:00
Jordan Liggitt
81fa9855c1 Fix quota controller hotloop in integration tests 2021-10-06 11:34:32 -04:00
Mike Dame
6ce2924818 Wire contexts to Bootstrap controllers 2021-10-06 10:27:32 -04:00
Patrick Ohly
4ae0eecb34 controller: use generic ephemeral volume helper functions 
The name concatenation and ownership check were originally considered small
enough to not warrant dedicated functions, but the intent of the code is more
readable with them.

There also was a missing owner check in the attach controller.
 2021-10-06 14:01:44 +02:00
Kubernetes Prow Robot
debd6c1e9e
Merge pull request #104526 from jingxu97/aug/volumeattach 
Fix issue in node status updating VolumeAttached list
 2021-10-05 17:30:32 -07:00
Jing Xu
69b9f9b1f0 Fix issue in node status updating VolumeAttached list 
During volume detach, the following might happen in reconciler

1. Pod is deleting
2. remove volume from reportedAsAttached, so node status updater will
update volumeAttached list
3. detach failed due to some issue
4. volume is added back in reportedAsAttached
5. reconciler loops again the volume, remove volume from
reportedAsAttached
6. detach will not be trigged because exponential back off, detach call
will fail with exponential backoff error
7. another pod is added which using the same volume on the same node
8. reconciler loops and it will NOT try to tigger detach anymore

At this point, volume is still attached and in actual state, but
volumeAttached list in node status does not has this volume anymore, and
will block volume mount from kubelet.

The fix in first round is to add volume back into the volume list that
need to reported as attached at step 6 when detach call failed with
error (exponentical backoff). However this might has some performance
issue if detach fail for a while. During this time, volume will be keep
removing/adding back to node status which will cause a surge of API
calls.

So we changed to logic to check first whether operation is safe to retry which
means no pending operation or it is not in exponentical backoff time
period before calling detach. This way we can avoid keep removing/adding
volume from node status.

Change-Id: I5d4e760c880d72937d34b9d3e904ecad125f802e
 2021-10-05 09:44:35 -07:00
Kubernetes Prow Robot
519b164db1
Merge pull request #105222 from cyclinder/remove_node_lease_GA 
remove nodeLease feature GA
 2021-10-05 05:41:21 -07:00
Author cyclinder
e61b901628 remove nodeLease feature GA 
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
 2021-10-05 12:23:27 +08:00
Kubernetes Prow Robot
0a29e2a73a
Merge pull request #105197 from alculquicondor/job-tracking 
Roll-forward: Beta requirements for JobTrackingWithFinalizers
 2021-10-04 18:57:49 -07:00
Aldo Culquicondor
5929ccd391 Track expected removals of Pod finalizers 
Add the UIDs of Pods for which we are removing finalizers to an in-memory cache.

The controller removes UIDs from the cache as Pod updates or deletes come in.

This avoids double counting finished Pods when Pod updates arrive after Job status updates.

https://github.com/kubernetes/kubernetes/issues/105200
 2021-10-04 16:09:58 -04:00
Kubernetes Prow Robot
c724abae81
Merge pull request #105375 from jonyhy96/fix-clock-util 
node: test file use k8s.io/utils/clock instead
 2021-10-04 04:19:31 -07:00
Rob Scott
d7a640d831
Excluding Control Plane Nodes from Topology Hints calculations 2021-10-01 15:12:38 -07:00
haoyun
8d9fa1decc fix: use k8s.io/utils/clock instead 
Signed-off-by: haoyun <yun.hao@daocloud.io>
 2021-10-02 00:08:53 +08:00
Aldo Culquicondor
95c2a8024c Parallelize pod updates in job test 
To potentially reduce the number of job controller syncs.

Also reduce the maximum number of pods to sync in tests.
 2021-10-01 09:55:53 -04:00
Kubernetes Prow Robot
598a8829c1
Merge pull request #105267 from llhuii/fix-topology-hint-bug 
TopologyAwareHints: fix getHintsByZone bug
 2021-09-28 20:54:48 -07:00
llhuii
e7350d126e TopologyAwareHints: add getHintsByZone unit test 2021-09-29 10:39:03 +08:00
llhuii
528cd30145 TopologyAwareHints: fix getHintsByZone bug 
The bug could result in the EndpointSlice controller unnecessarily updating
EndpointSlices associated with a Service that had Topology Aware Hints enabled.
 2021-09-28 09:02:24 +08:00
Kubernetes Prow Robot
aec9acda68
Merge pull request #105214 from alculquicondor/job-update 
Remove GET job and retries for status updates
 2021-09-27 09:05:47 -07:00
devincd
e62aef4fc9 fix the log description 
Signed-off-by: devincd <505259926@qq.com>
 2021-09-27 14:20:33 +08:00
Khaled Henidak (Kal)
a53e2eaeab
move IPv6DualStack feature to stable. (#104691) 
* kube-proxy

* endpoints controller

* app: kube-controller-manager

* app: cloud-controller-manager

* kubelet

* app: api-server

* node utils + registry/strategy

* api: validation (comment removal)

* api:pod strategy (util pkg)

* api: docs

* core: integration testing

* kubeadm: change feature gate to GA

* service registry and rest stack

* move feature to GA

* generated
 2021-09-24 16:30:22 -07:00
Kubernetes Prow Robot
b6924839ca
Merge pull request #101987 from sky-philipalmeida/patch-1 
Log if PV is still in use trying to delete it
 2021-09-23 14:30:54 -07:00
Aldo Culquicondor
a438f16741 Revert "Revert "Add metric job_pod_finished"" 
This reverts commit 7868fbbe64.
 2021-09-23 12:56:29 -04:00
Aldo Culquicondor
47a957d163 Revert "Revert "Limit number of Pods counted in a single Job sync"" 
This reverts commit 8bcb780808.
 2021-09-23 12:56:29 -04:00
Aldo Culquicondor
01f27cd93e Fix log line for target number of running pods 2021-09-23 12:56:29 -04:00
Aldo Culquicondor
eebd678cda Remove GET job and retries for status updates. 
Doing a GET right before retrying has 2 problems:
- It can masquerade conflicts
- It adds an additional delay

As for retries, we are better of going through the sync backoff.

In the case of conflict, we know that there was a Job update that would trigger another sync, so there is no need to do a rate limited requeue.
 2021-09-23 11:48:34 -04:00
Kubernetes Prow Robot
372103f4b8
Merge pull request #100672 from wangyx1992/structured-log 
Structured Logging migration: modify logs of controller-manager
 2021-09-22 20:27:10 -07:00
Kubernetes Prow Robot
76c0573ff4
Merge pull request #105181 from alculquicondor/revert 
Revert #104739
 2021-09-21 16:54:00 -07:00
Aldo Culquicondor
7868fbbe64 Revert "Add metric job_pod_finished" 
This reverts commit a0e7a567c5.
 2021-09-21 15:16:54 -04:00
Aldo Culquicondor
8bcb780808 Revert "Limit number of Pods counted in a single Job sync" 
This reverts commit 7d9cb88fed.
 2021-09-21 15:16:50 -04:00
Phil
f1a9402082 Log if PV is still in use trying to delete it 
Similar to what we have in:
https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/volume/pvcprotection/pvc_protection_controller.go#L181
The objective is to have a easy way to monitor if a PV will enter in Terminating state due to a failed removal when still in use.
This way we can capture the PV log and alert according.
The code is not tested.

Update pv_protection_controller.go

Change call to Infof
 2021-09-21 18:05:16 +01:00
Kubernetes Prow Robot
b34a735bbe
Merge pull request #102523 from stlaz/rootca_metrics_cleanup 
rootcacertpublisher: drop the namespace label from metrics to reduce its cardinality
 2021-09-20 13:54:24 -07:00
Kubernetes Prow Robot
353f0a5eab
Merge pull request #105095 from wojtek-t/migrate_clock_3 
Unify towards k8s.io/utils/clock - part 3
 2021-09-20 12:46:45 -07:00