Commit Graph

76 Commits

Author SHA1 Message Date
ahrtr
fe95aa614c io/ioutil has already been deprecated in golang 1.16, so replace all ioutil with io and os 2022-02-03 05:32:12 +08:00
Kubernetes Prow Robot
a18b0272e6 Merge pull request #103967 from pacoxu/probe-warning
add probe warning message body for terminated redirect
2022-01-06 08:57:01 -08:00
Ciprian Hacman
a0abe5aa33 Clean up dockershim in tests
Signed-off-by: Ciprian Hacman <ciprian@hakman.dev>
2021-12-22 13:05:34 +02:00
Paco Xu
65529fe6e9 add probe warning event body like 'Probe terminated redirects' 2021-12-16 13:04:51 +08:00
Davanum Srinivas
9405e9b55e Check in OWNERS modified by update-yamlfmt.sh
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-12-09 21:31:26 -05:00
Sergey Kanzhelev
f390d49e24 fix the grpc probes 2021-11-20 00:23:53 +00:00
Sergey Kanzhelev
b7affcced1 implement :grpc probe action 2021-11-17 17:31:23 +00:00
Lee Verberne
28bd71c291 De-flake ephemeral containers e2e test
The test waits for the container to be running, but the test command
sleeps for 2 seconds before writing output, creating a race.
2021-11-15 12:14:47 -05:00
Lee Verberne
d31d0cc29a Remove kubectl from ephemeral container e2e
It's not available in the node e2e environment.
2021-11-11 08:04:43 -05:00
Lee Verberne
e1e97a0e47 Add NodeFeature tag to ephemeral containers e2e 2021-11-11 05:54:01 -05:00
Sergey Kanzhelev
fc42da8eb8 PodReadinessGate is stable feature and test runs all green 2021-11-10 07:34:14 +00:00
Tim Hockin
11a25bfeb6 De-share the Handler struct in core API (#105979)
* De-share the Handler struct in core API

An upcoming PR adds a handler that only applies on one of these paths.
Having fields that don't work seems bad.

This never should have been shared.  Lifecycle hooks are like a "write"
while probes are more like a "read". HTTPGet and TCPSocket don't really
make sense as lifecycle hooks (but I can't take that back). When we add
gRPC, it is EXPLICITLY a health check (defined by gRPC) not an arbitrary
RPC - so a probe makes sense but a hook does not.

In the future I can also see adding lifecycle hooks that don't make
sense as probes.  E.g. 'sleep' is a common lifecycle request. The only
option is `exec`, which requires having a sleep binary in your image.

* Run update scripts
2021-10-29 13:15:11 -07:00
Kubernetes Prow Robot
f08ad3e0ed Merge pull request #105273 from claudiubelu/tests/fixes-pod-collection-flake
tests: Wait for pod collection to enter a Running state
2021-10-25 07:34:23 -07:00
Kubernetes Prow Robot
18104ecf1f Merge pull request #105405 from verb/1.23-ec-beta
Promote EphemeralContainers to beta
2021-10-20 09:24:10 -07:00
Martin Schimandl
c9edee165a Cleanup FeatureGate skippers (#105428)
* Cleanup FeatureGate skippers

* Perform changes requested by review

* some more review related changes

* Rename skipper functions to make code more readable

* add utilfeature back in
2021-10-20 01:47:57 -07:00
Lee Verberne
40e7689f0e Move ephemeral container e2e to common 2021-10-19 23:02:09 -04:00
Kubernetes Prow Robot
c20ff9839e Merge pull request #97045 from claudiubelu/tests-windows-containerd-enabled
tests: Enable some [LinuxOnly] tests for Windows Containerd
2021-10-06 19:53:45 -07:00
Kubernetes Prow Robot
519b164db1 Merge pull request #105222 from cyclinder/remove_node_lease_GA
remove nodeLease feature GA
2021-10-05 05:41:21 -07:00
Author cyclinder
e61b901628 remove nodeLease feature GA
Signed-off-by: cyclinder <qifeng.guo@daocloud.io>
2021-10-05 12:23:27 +08:00
Claudiu Belu
f7cf747e48 tests: Wait for pod collection to enter a Running state
While running tests in parallel, especially those with higher loads
than others, it might take some time for Pods to be Running, even more
so if the image has to be pulled as well.

The test [sig-node] Pods should delete a collection of pods [Conformance]
only waits for the for the pods to be scheduled before deleting them, and
expects them to be gone in 1 minute, which can flake because of the above
reasons. Note that the operations are in order, and kubelet runs them in
order, which means that the pod first has to enter the Running state
before attempting to delete it.

This commit waits for the Pods to enter the Running state first before
deleting the entire collection.

Co-Authored-By: Antonio Ojea <aojea@redhat.com>
2021-10-04 20:42:16 -07:00
Kubernetes Prow Robot
7c1e37ef27 Merge pull request #104803 from bobbypage/runtimeclass-skip
Skip runtimeclass test unless provider GCE
2021-09-27 12:49:45 -07:00
David Porter
4b056a615a Skip runtimeclass test unless provider GCE
This test case requires special test-handler setup which is only done
for gce clusters created by kube-up scripts. Let's skip the test when
run under other providers.
2021-09-14 13:23:09 -07:00
pacoxu
ddaa3466eb correct unsafe sysctls e2e test case & use status reason check instead of events watch
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
2021-08-18 15:11:09 +08:00
Claudiu Belu
91c095a11f tests: Enable some [LinuxOnly] tests for Windows Containerd
Windows Containerd has more features than Windows Docker. One of them is single file
mappings, allowing us to also map individual files into containers, not just folders.

This will set the tag [Excluded:WindowsDocker] for those tests instead of [LinuxOnly].

Co-authored-by: Mark Rossetti <marosset@microsoft.com>
2021-08-16 07:43:24 -07:00
Kubernetes Prow Robot
e6c7837afe Merge pull request #101063 from claudiubelu/tests/lifecycle-hooks
tests: Spawn poststart / prestop pods on the same node as the http pod
2021-08-12 10:19:49 -07:00
Kubernetes Prow Robot
20d5526575 Merge pull request #103593 from matthyx/container_probe
Flake #99979 increase delay for ready state propagation
2021-08-05 14:09:19 -07:00
Mike Miranda
0cce9a4a6c Remove conformance status from a sysctl test and relabel 2021-07-22 20:12:26 +00:00
Matthias Bertschy
5f0925a294 Flake #99979 increase delay for ready state propagation 2021-07-15 11:42:33 +02:00
Kubernetes Prow Robot
02355e22b3 Merge pull request #103650 from dims/get-golangci-lint-back-on-its-feet
Get golangci lint back on its feet
2021-07-15 02:06:48 -07:00
Kubernetes Prow Robot
f6c2068623 Merge pull request #102921 from fromanirh/pod-readiness-gate-timeout
e2e: increase readiness gate timeout
2021-07-14 23:34:48 -07:00
Davanum Srinivas
75748c185e enable verify-golangci-lint.sh
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-07-14 08:53:33 -04:00
Davanum Srinivas
07332ad398 fix ineffassign and varcheck
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-07-14 08:41:22 -04:00
Kubernetes Prow Robot
82398d1c0a Merge pull request #103427 from matthyx/99437
Fix test "Pods should run through the lifecycle of Pods and PodStatus"
2021-07-09 06:00:54 -07:00
Matthias Bertschy
b1f34ea205 add RetryOnConflict to pod status updates 2021-07-02 12:38:53 +02:00
Kubernetes Prow Robot
62503f254e Merge pull request #103413 from mgutierrez98/refactor-whitelist-blacklist
Refactored files containing whitelist/blacklist to allowlist/denylist…
2021-07-01 18:12:25 -07:00
mgutierrez98
1cfbb0aa25 remove webhook.go to revert changes to conformance test 2021-07-01 20:24:46 +00:00
Francesco Romani
c69ad8c57a e2e: increase readiness gate timeout
We're trying to fix https://github.com/kubernetes/kubernetes/issues/75355
sicne long time, and we believe the current timeout could
actually be too low (despite being "forever", which is 30s).

To validate this theory, we set the timeout to one full minute.

Also, make the logging more verbose to make the troubleshooting easier.

Signed-off-by: Francesco Romani <fromani@redhat.com>
2021-06-29 09:01:31 +02:00
tanjing2020
f80f9eeb6d Destroy the created runtimeclass resources at the end of the test case. 2021-06-29 09:20:40 +08:00
Kubernetes Prow Robot
7eae33cb0e Merge pull request #101464 from Nick-Triller/deflake_assert_events
e2e: deflake test by not relying on events
2021-06-24 17:44:45 -07:00
Claudiu Belu
f9e4a015e2 tests: Spawn poststart / prestop pods on the same node as the http pod
In the case of multinode clusters, the http server pod and the test cluster can
spawn on different nodes, which can be problematic for  poststart / prestop hooks,
as they are executed by the kubelet itself, and the cross-node lifecycle hook might
fail (according to the Kubernetes network model, it is not mandatory for kubelet to
be able to access pods on a different node).

This commit ensures that the test pod spawns on the same node as the http server pod.
2021-06-19 23:13:39 -07:00
Sergey Kanzhelev
ff0f83b4b2 skipping more tests in case when ExecProbeTimeout set to false 2021-06-15 00:24:09 +00:00
Kubernetes Prow Robot
9f7c9c322f Merge pull request #101738 from matthyx/deflake-startupprobe
fix manual trigger of readinessProbe on startupProbe success
2021-06-03 14:34:42 -07:00
Kubernetes Prow Robot
916ed1d3ad Merge pull request #100543 from chaitanyabandi/variable-expansion
Don't replace pod annotations in variable expansion test
2021-05-21 17:43:37 -07:00
Chaitanya Bandi
0681a44672 Don't replace pod annotations in variable expansion test
This change fixes the "Variable Expansion should verify that a failing subpath
expansion can be modified during the lifecycle of a container" conformance test
where the annotations are replaced with those used by the test, instead of
appending them.

This may cause undesirable side-effects with other controllers that may be
using pod annotations.
2021-05-21 13:38:04 -07:00
Stephen Heywood
4e3d006001 Increase TerminationGracePeriodSeconds to 1 2021-05-12 11:09:34 +12:00
Nick Triller
5ea0162906 e2e: deflake test by not relying on events 2021-05-06 10:49:21 +02:00
Matthias Bertschy
3916c00955 fix manual trigger of readinessProbe on startupProbe success 2021-05-05 11:21:40 +02:00
Antonio Ojea
3511357c0a Revert "Deflake startupProbe e2e test"
This reverts commit bcd582030f.
2021-05-01 10:29:03 +02:00
Kubernetes Prow Robot
6e29545168 Merge pull request #99998 from matthyx/deflake-startupprobe
Deflake startupProbe e2e test
2021-04-29 01:16:50 -07:00
Matthias Bertschy
bcd582030f Deflake startupProbe e2e test
Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
2021-04-28 07:07:01 +02:00