Lubomir I. Ivanov
f8da9ab287
kubeadm: return stored FakedServerVersion when dry-running
...
If we are dry-running, do not attempt to fetch the /version
resource and just return the stored FakeServerVersion,
which is done when constructing the dry-run client in
upgrade/common.go#getClient().
The problem here is that during upgrade
dry-run client reactors are backed by a dynamic client
via NewClientBackedDryRunGetterFromKubeconfig() and
for GetActions there seems to be no analog to
Discovery().Serverversion() resource for a dynamic client(?).
2022-12-22 19:53:35 +02:00
Lubomir I. Ivanov
54b73deaca
kubeadm: handle dry run GET actions from fake discovery
...
The kubeadm dry run client reactor code is flawed as it assumes
all invoked "get" verb actions can be casted to GetAction.
Apparently that is not the case when Discovery().ServerVersion()
and other discovery calls are made. In such cases the action
type is the bare ActionImpl.
Catch if an action can be casted to ActionImpl and construct a
GetAction from it. GetActionImpl only suppersets ActionImpl with
a Name field (empty string in this case).
Add unit test for Discovery().ServerVersion().
2022-12-21 11:49:59 +02:00
Kubernetes Prow Robot
03bfbdd8aa
Merge pull request #114455 from SataQiu/fix-kubeadm-2022121302
...
kubeadm: fix the bug that kubeadm always do CRI detection even if it is not required by phase subcommand
2022-12-19 00:51:44 -08:00
Jordan Liggitt
78cb3862f1
Fix indentation/spacing in comments to render correctly in godoc
2022-12-17 23:27:38 -05:00
Kubernetes Prow Robot
fdafd50085
Merge pull request #113318 from pacoxu/learner-mode
...
kubeadm: enable etcd's learner mode when joining etcd members
2022-12-16 21:55:41 -08:00
Paco Xu
37f5da904b
kubeadm: remove nested loops for member promotion
2022-12-17 12:40:15 +08:00
Shihang Zhang
4fd09a06d6
lock LegacyServiceAccountTokenNoAutoGeneration
2022-12-16 10:45:35 -08:00
Paco Xu
b3deecfb17
add etcd as learner mode and promote when fg EtcdLearnerMode is enabled
...
- use etcd backoff to wait; still has many warning messages
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
2022-12-16 21:09:59 +08:00
Paco Xu
0d2952202e
kubeadm upgrade: fix dry run of backing up kubelet config file
...
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
2022-12-16 17:02:28 +08:00
Kubernetes Prow Robot
c1c0e4fe0b
Merge pull request #114489 from aimuz/replace2tag
...
kubeadm: replace Runtime.GOOS with go:build tag
2022-12-15 07:27:47 -08:00
Kubernetes Prow Robot
930271fbd8
Merge pull request #114330 from chendave/backup_kubelet
...
kubeadm: backup the kubelet config file before writting the new one
2022-12-15 07:27:36 -08:00
aimuz
4860b67b48
kubeadm: replace Runtime.GOOS with go:build tag
...
Signed-off-by: aimuz <mr.imuz@gmail.com>
2022-12-15 17:57:45 +08:00
Dave Chen
cd1f082179
kubeadm: backup the kubelet config file before writting the new one
...
This addresses the TODO item so that the old kubelet config file could
be recovered if something goes wrong.
Signed-off-by: Dave Chen <dave.chen@arm.com>
2022-12-15 10:16:36 +08:00
Kubernetes Prow Robot
69fe066adc
Merge pull request #114477 from chendave/kubeadm_reviewer
...
kubeadm: add chendave as kubeadm reviewer
2022-12-14 13:01:36 -08:00
Kubernetes Prow Robot
bf49c7c0b5
Merge pull request #114080 from chendave/fix_testcases
...
kubeadm: fix invalid testcase for `enforceRequirements`
2022-12-14 11:55:56 -08:00
Kubernetes Prow Robot
08160f7975
Merge pull request #113465 from chendave/golang_generic
...
kubeadm: bump to use golang generic
2022-12-14 11:55:34 -08:00
SataQiu
2501a46b80
kubeadm: avoid CRI detection for phase subcommand when it's --cri-socket flag is not set
2022-12-14 12:00:49 +08:00
Paco Xu
861db2348e
kubeadm: add feature gate EtcdLearnerMode alpha
2022-12-14 11:07:46 +08:00
Dave Chen
8995346259
kubeadm: add chendave as kubeadm reviewer
...
Signed-off-by: Dave Chen <dave.chen@arm.com>
2022-12-14 10:54:03 +08:00
Dave Chen
8c7609fbe2
kubeadm: bump to use golang generic
...
Signed-off-by: Dave Chen <dave.chen@arm.com>
2022-12-14 10:31:18 +08:00
Andy Goldstein
0bdcb93b06
Create new conversion Factory interface
...
Create a new conversion Factory interface for CRDs, and split out
NewDelegatingConverter as a standalone package-level function, instead
of being part of CRConverterFactory.
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
2022-12-13 14:38:21 -05:00
Kubernetes Prow Robot
6b9035513b
Merge pull request #113981 from TommyStarK/unit-tests/cmd-kube-controller-manager-app-options
...
cmd/kube-controller-manager/app/options: Improving test coverage
2022-12-13 06:25:34 -08:00
TommyStarK
454290c583
cmd/kube-controller-manager/app/options: Improving test coverage
...
Add a snippet of the expected error string related to the aspect being tested
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
2022-12-13 14:05:48 +01:00
SataQiu
c51ce945a5
kubeadm: add missing --cri-socket flag for upload-certs phase
2022-12-13 16:59:17 +08:00
Kubernetes Prow Robot
014e3be258
Merge pull request #114409 from SataQiu/kubeadm-20221211
...
kubeadm: cleanup the temporary workaround about kubelet --container-runtime flag
2022-12-11 03:11:14 -08:00
SataQiu
76bb3364d2
kubeadm: cleanup the temporary workaround about kubelet --container-runtime flag
2022-12-11 15:52:12 +08:00
Kubernetes Prow Robot
d2ed6d355e
Merge pull request #114279 from pacoxu/coredns-v1.10.0
...
update coredns to v1.10.0
2022-12-10 12:21:52 -08:00
Kubernetes Prow Robot
b7684889be
Merge pull request #114379 from SergeyKanzhelev/RotateCertificateIsGA
...
rotate-certificates is a GA feature now
2022-12-10 09:06:24 -08:00
Kubernetes Prow Robot
f380944261
Merge pull request #114338 from champtar/kubeadm-priority
...
kubeadm: set priority for "system-node-critical" Pods
2022-12-10 09:05:48 -08:00
Kubernetes Prow Robot
9e3e47f56a
Merge pull request #114176 from QuantumEnergyE/kubeadm_retry_patch_node
...
Retry patch when then service is unavailable or timeout.
2022-12-10 06:05:26 -08:00
Kubernetes Prow Robot
7754f007d6
Merge pull request #114169 from jpbetz/improve-kubelet-flag-errors
...
Improve error messages of flags that parse quantities and percentages
2022-12-10 06:05:11 -08:00
TommyStarK
270141aa0b
cmd/kube-controller-manager/app/options: Improving test coverage
...
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
2022-12-10 13:36:12 +01:00
Kubernetes Prow Robot
2e6d3393f7
Merge pull request #113998 from SataQiu/fix-kubeadm-20221117
...
kubeadm: respect user provided kubeconfig during discovery process
2022-12-10 03:17:39 -08:00
Kubernetes Prow Robot
da588a31d4
Merge pull request #112627 from hj-johannes-lee/fix-typo-3
...
Kubemark: fix typos to be HollowKubeletOptions
2022-12-09 15:43:14 -08:00
Kubernetes Prow Robot
ee8e76c6ea
Merge pull request #113943 from Octopusjust/k8s-pr10
...
Add test for cmd/kubeadm/app/constants/constants.go
2022-12-09 14:35:31 -08:00
Kubernetes Prow Robot
15f47da1c9
Merge pull request #113874 from SataQiu/clean-20221113
...
kubeadm: remove unused command flag constants
2022-12-09 14:34:48 -08:00
Kubernetes Prow Robot
6d823a3815
Merge pull request #113823 from TommyStarK/unit-tests/cmd-kube-apiserver-app-options
...
cmd/kube-apiserver/app/options: Improving test coverage
2022-12-09 14:34:33 -08:00
Kubernetes Prow Robot
6c0f680be9
Merge pull request #113672 from falser101/fix/kubelet_cleanup
...
fix: Remove dependency on github.com/pkg/errors
2022-12-09 14:34:19 -08:00
Sergey Kanzhelev
3067259782
rotate-certificates is a GA feature now
2022-12-09 09:02:51 +00:00
Etienne Champetier
64eef3e9fa
kubeadm: set priority for "system-node-critical" Pods
...
Priority is normally set by the admission controller when missing.
For static pods there seems to be some corner cases, as, if priority
is not explicitly set, Graceful Node Shutdown will shutdown
static pods with the other pods that have priority 0 or unset.
Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
2022-12-07 14:19:28 -05:00
Paco Xu
34d845502f
kubeadm: use coredns v1.10.0
2022-12-05 11:42:43 +08:00
Paco Xu
f0d1a39e8f
add etcd 3.5.6-0 to kuebadm supported etcd version
2022-12-01 18:41:32 +08:00
QuantumEnergyE
847a39afc0
Retry patch when then service is unavailable or timeout.
2022-11-29 23:09:31 +08:00
Joe Betz
ab3c353227
Improve error messages for parse errors of --kube-reserved, --system-reserved and --qos-reserved
2022-11-28 16:35:26 -05:00
Dave Chen
2121ce17da
kubeadm: fix invalid testcase for enforceRequirements
...
These testcases are too vague, they are not test against the scenario
they want, but instead all of them are failed due to client cannot
be created.
`kubeconfig` file is created and mocked the function of `loadConfig` in
order to make those testcases valid.
Signed-off-by: Dave Chen <dave.chen@arm.com>
2022-11-24 16:52:44 +08:00
SataQiu
21cd660a1f
kubeadm: respect user provided kubeconfig during discovery process
2022-11-24 12:29:10 +08:00
Paco Xu
75f89875f8
use etcd 3.5.6-0 after promotion
2022-11-24 09:45:56 +08:00
TommyStarK
44c94f98b6
fix typo in cmd/kube-apiserver/app/options/validation_test.go
...
Put back test case that was dropped by mistake.
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
2022-11-16 19:25:31 +01:00
ZhangYu
44285a16ec
Add test for cmd/kubeadm/app/constants/constants.go
...
Add test for cmd/kubeadm/app/constants/constants.go
2022-11-16 14:50:32 +08:00
Mark Rossetti
534f052a8d
Updating pause image refernces to 3.9
...
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
2022-11-14 10:24:54 -08:00