Commit Graph

977 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
611dbaa055
Merge pull request #122790 from carlory/fix-121696
Fix flaky test: Test_Run_OneVolumeDetachFailNodeWithReadWriteOnce
2024-03-10 19:23:40 -07:00
Mengjiao Liu
b584b87a94 kube-controller-manager: readjust log verbosity
- Increase the global level for broadcaster's logging to 3 so that users can ignore event messages by lowering the logging level. It reduces information noise.
- Making sure the context is properly injected into the broadcaster, this will allow the -v flag value to be used also in that broadcaster, rather than the above global value.
- test: use cancellation from ktesting
- golangci-hints: checked error return value
2024-02-26 14:51:56 +08:00
Kubernetes Prow Robot
31a482a149
Merge pull request #120344 from rohitssingh/disable_force_detach
Add a flag to disable force detach behavior in kube-controller-manager
2024-02-22 13:02:38 -08:00
Rohit Singh
13dddca6a2 Add "disable-force-detach-on-timeout" flag to kube-controller-manager 2024-02-22 18:31:52 +00:00
carlory
0cd9d40a65 Test_Run_OneVolumeDetachFailNodeWithReadWriteOnce use
waitForAttachStateToNode instead of time.Sleep
2024-02-04 16:57:55 +08:00
Kubernetes Prow Robot
0209c546fd
Merge pull request #121824 from carlory/clean-112
adc remove stale comments
2024-01-29 14:13:17 -08:00
Kubernetes Prow Robot
9e34bac02a
Merge pull request #119395 from carlory/patch-expand-001
getPersistentVolume remove reduant deep copy
2024-01-29 05:40:40 -08:00
Kubernetes Prow Robot
eb1ae05cf0
Merge pull request #122030 from carlory/121799
fix issue with using feature HonorPVReclaimPolicy in csi-provisioner
2024-01-19 04:35:48 +01:00
carlory
5ff42b2368 fix issue with using feature HonorPVReclaimPolicy in csi-provisioner 2024-01-17 10:57:30 +08:00
carlory
8af9a177b2 If a pvc has an empty storageclass name, don't try to assign a default StorageClass to it. 2024-01-13 21:25:43 +08:00
Kubernetes Prow Robot
5cf72fbfae
Merge pull request #121713 from carlory/adc
adc remove redundant check
2023-12-28 21:47:19 +01:00
Kubernetes Prow Robot
755b4e2bc4
Merge pull request #121576 from huww98/opti-aswp
ad controller: optimize populateActualStateOfWorld
2023-12-19 17:43:45 +01:00
Kubernetes Prow Robot
c24e8ee403
Merge pull request #121697 from carlory/clean-111
add comments for switch case of syncUnboundClaim
2023-12-13 22:35:00 +01:00
huweiwen
a3e27aa1ad ad controller: optimize populateActualStateOfWorld
Reduce overall complexity from O(n^2) to O(n)
Run time of the new benchmark is reduced from hours to 13s
2023-11-17 16:48:30 +08:00
huweiwen
854347ac81 ad controller populator: check for inUse sync in test 2023-11-17 16:48:30 +08:00
carlory
4a4940694f remove stale comments 2023-11-09 11:58:50 +08:00
carlory
ae24846c48 add comments for switch of syncUnboundClaim 2023-11-08 17:15:27 +08:00
carlory
957e9a7f1a adc remove redundant check 2023-11-03 16:17:39 +08:00
carlory
58236aa3eb remove EventRecorder from ControllerParameters of pv base controller 2023-11-01 17:54:00 +08:00
carlory
5a20ff1617 fix wrong controller name for ephemeralController 2023-10-30 18:45:13 +08:00
huweiwen
63b3085f2a fix ad controller populators test
The informer is not initialized, so no assertion performed before. Fixed this now.

Then fixed the test failure by using NewAttachDetachController to initialize adc.
2023-10-27 23:35:45 +08:00
Kubernetes Prow Robot
07029999f9
Merge pull request #120666 from b8kings0ga/feature/fix-comment-correction
AttachDetachControllerConfiguration.ReconcilerSyncLoopPeriod default value comment fix
2023-10-11 22:51:49 +02:00
Kubernetes Prow Robot
d3559bf77f
Merge pull request #120595 from jsafrane/fix-detach-uncertain
Mark a volume as uncertain-attached after detach error
2023-10-08 05:54:01 +02:00
b8kings0ga
9345da51ac fix comment mistake, run "make update" 2023-09-22 16:37:55 +08:00
Jan Safranek
7fc11f47ff Mark a volume as uncertain-attached after detach error
Volume that failed Detach() should not be marked as attached, CSI
external-attacher is probably still trying to detach it.

Mark it uncertain instead and wait for Detach() to succeed.
2023-09-13 10:03:28 +02:00
kerthcet
6fbb8ec7e4 Move scheduler testing utils to /scheduler/testing
Signed-off-by: kerthcet <kerthcet@gmail.com>
2023-09-12 13:42:38 +08:00
Patrick Ohly
2472291790 api: introduce separate VolumeResourceRequirements struct
PVC and containers shared the same ResourceRequirements struct to define their
API. When resource claims were added, that struct got extended, which
accidentally also changed the PVC API. To avoid such a mistake from happening
again, PVC now uses its own VolumeResourceRequirements struct.

The `Claims` field gets removed because risk of breaking someone is low:
theoretically, YAML files which have a claims field for volumes now
get rejected when validating against the OpenAPI. Such files
have never made sense and should be fixed.

Code that uses the struct definitions needs to be updated.
2023-08-21 15:31:28 +02:00
carlory
ad0b671b56 getPersistentVolume remove reduant deep copy 2023-07-18 18:55:42 +08:00
Kubernetes Prow Robot
be2cfc9697
Merge pull request #118228 from carlory/move-non-graceful-node-shutdown-to-GA
move non-graceful node shutdown to GA
2023-07-13 15:47:37 -07:00
Patrick Ohly
7d064812bb kube-controller-manager: finish conversion to contextual logging
This removes all exceptions and fixes the remaining unconverted log calls.
2023-07-12 14:57:29 +02:00
carlory
f443c458af move non-graceful node shutdown to GA 2023-07-11 13:51:51 +08:00
xing-yang
cca6601106 Add reason to force detach metric 2023-07-10 06:30:05 +00:00
Ziqi Zhao
dfc1838379 Migrated pkg/controller/volume|util|replicaset|nodeipam to contextual logging
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
2023-07-06 07:39:52 +08:00
Kubernetes Prow Robot
960830bc66
Merge pull request #118102 from RomanBednar/retro-sc-assignment-ga
graduate RetroactiveDefaultStorageClass feature to GA in 1.28
2023-06-27 20:46:32 -07:00
Kubernetes Prow Robot
a48bcc06fe
Merge pull request #117064 from RomanBednar/multiple-defaults
storage class assignment should not ignore errors
2023-06-23 03:09:23 -07:00
Roman Bednar
1bd3f072fa stop ignoring storage class selection errors
The GetDefaultClass() was fixed in scope of this issue:
https://github.com/kubernetes/kubernetes/issues/110514

Before this change assignDefaultStorageClass() was ignoring errors from
this function since it could mean there are multiple defaults - assign
could safely continue and do nothing.

This is no longer true because we always choose one from multiple
defaults - any errors returned from GetDefaultClass() are real errors
and should not be ignored.
2023-06-21 13:09:05 +02:00
carlory
5e048041e4 remove helper function for unused storage feature in pkg/proxy/util 2023-06-13 09:22:59 +08:00
Kubernetes Prow Robot
8a0b1bbf24
Merge pull request #118095 from carlory/patch-002
remove unused pv informer from expand_controller
2023-06-12 11:43:58 -07:00
Roman Bednar
ac15d69757 remove RetroactiveDefaultStorageClass feature gate checks 2023-06-07 14:31:16 +02:00
Roman Bednar
6afb363ca1 test: remove RetroactiveDefaultStorageClass feature gate
Since the feature is GA and locked to true, tests can no longer set it
to false. Cleaning up by removing all references to this feature gate
from tests.

Feature gate will be removed in v1.29.
2023-06-07 14:31:16 +02:00
torredil
5d18f47149
Improve clarity and guidance in provisioner waiting message
Signed-off-by: torredil <torredil@amazon.com>
2023-05-25 17:26:06 +00:00
guangli.bao
931cc96b8d remote windows condition when #116693 is merged
Signed-off-by: guangli.bao <guangli.bao@daocloud.io>
2023-05-24 14:54:22 +08:00
Kubernetes Prow Robot
484645e817
Merge pull request #116659 from claudiubelu/skip-flaky-tests-2
unit tests: Skip flaky tests on Windows (part 2)
2023-05-23 20:04:48 -07:00
carlory
bea71a3e4e remove unused pv informer from expand_controller 2023-05-18 15:58:38 +08:00
SataQiu
3fa55d469c fix a bug where the AttachedVolume is not printed correctly in the log 2023-05-11 22:04:30 +08:00
Hao Ruan
c4e1b01416 replace spew methods with dump methods 2023-04-14 08:05:53 +08:00
Claudiu Belu
0979d55443 unit tests: Skip flaky tests on Windows (part 2)
Some of the unit tests are currently flaky on Windows. This commit
skips them until they are resolved.
2023-04-13 12:07:18 +00:00
Tim Hockin
29c0b73d64
Replace uses of diff.ObjectDiff with cmp.Diff
ObjectDiff is already a shim over cmp.Diff, so no actual output or
behavior changes
2023-04-12 08:46:12 -07:00
Kubernetes Prow Robot
8cdc7fa542
Merge pull request #116675 from pacoxu/volume-flake
deflake: Add retry with timeout to wait for final conditions
2023-04-11 18:19:09 -07:00
Kubernetes Prow Robot
4e6da50c56
Merge pull request #113800 from pacoxu/patch-4
add sig/storage label for pkg/controller/volume package PR
2023-04-11 15:34:31 -07:00