Commit Graph

678 Commits

Author SHA1 Message Date
Kubernetes Submit Queue
e4af9dccb0 Merge pull request #46923 from dims/nuke-wrapper-go-flags
Automatic merge from submit-queue (batch tested with PRs 47921, 45984, 46829, 46896, 46923)

Remove unnecessary wrapper flags

**What this PR does / why we need it**:

Drop KUBE_GOFLAGS, KUBE_GOGCFLAGS, KUBE_GOLDFLAGS references
from the build infrastructure

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #47296

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2017-06-22 20:26:29 -07:00
Kubernetes Submit Queue
d58b238b62 Merge pull request #46896 from dims/add-git-branch-to-short-hash
Automatic merge from submit-queue (batch tested with PRs 47921, 45984, 46829, 46896, 46923)

Add git branch to make build short hash unique

**What this PR does / why we need it**:

KUBE_ROOT_HASH depends just on the host name and
directory path. So when working with branches, it could lead
to some confusion since the hash is the same even when
you switch from branch to branch. Let us use the git branch
information when we compute the short hash

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

Fixes #1801

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2017-06-22 20:26:26 -07:00
Kubernetes Submit Queue
dafe578377 Merge pull request #45984 from cblecker/hack-vet
Automatic merge from submit-queue (batch tested with PRs 47921, 45984, 46829, 46896, 46923)

Move govet verify into rest of verify*-.sh scripts

**What this PR does / why we need it**:
Instead of having two govet scripts, consolidate them to into one and have both the Makefile and verify.sh scripts target the same script. This also will allow proper syntax highlighting and timing when the vet script is run as part of `make verify`.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes https://github.com/kubernetes/test-infra/issues/2725

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

/cc @fejta @rmmh
2017-06-22 20:26:21 -07:00
Chao Xu
bad65b4c95 Don't revert, necessary change to make helpers to include k8s.io/api
Don't revert, change boundingdirs in Makefile for deepcopy-gen

manually fix pkg/client/clientset_generated/clientset/typed/core/v1/pod_expansion.go because external policy types are moved now
2017-06-22 11:30:43 -07:00
Jeff Grafton
51a8f3c60a Update debian-iptables-amd64 for bazel build 2017-06-21 14:08:13 -07:00
Christoph Blecker
97783f9093
Run hack/verify-govet.sh as part of verify make target
This commit ensures that:
- go vet will be run as part of the make verify target
- the vet make-rule script won't be run directly, as generated_files won't be run in that case
- that go vet errors show up in the build log with a start time, finish time, and SUCCESS/FAILED message as part of the verify make rule script
2017-06-21 11:10:25 -07:00
Jeff Grafton
2098cb8463 debian-base: don't remove libcap2 2017-06-15 14:11:43 -07:00
Kubernetes Submit Queue
54f628ad79 Merge pull request #47375 from ixdy/debian-iptables-v8
Automatic merge from submit-queue (batch tested with PRs 46678, 45545, 47375)

bazel: update debian-iptables-amd64 digest

**What this PR does / why we need it**: upstream debian has fixed several CVEs recently, so we should apply those fixes:
* CVE-2017-2616
* CVE-2017-6512

x-ref #47386

**Special notes for your reviewer**: nothing has been pushed yet, so this will likely fail many of the tests.

Do you think these version numbers make sense? We also need to fix debian-iptables v5, and I don't know what to do there. (v5.1?)

**Release note**:

```release-note
NONE
```
/assign @timstclair
2017-06-12 20:32:43 -07:00
Jeff Grafton
901fba45e0 Bazel: use new debian-iptables-amd64 image 2017-06-12 16:42:56 -07:00
Jeff Grafton
0ac28c4b4c Add make rule to push debian-base image 2017-06-12 16:42:35 -07:00
Jeff Grafton
6b20f50142 Don't delete docker image if building a release 2017-06-12 12:06:22 -07:00
Jeff Grafton
5aa25f8309 Bump bazelbuild/rules_go and kubernetes/repo-infra dependencies 2017-06-08 14:59:55 -07:00
Kubernetes Submit Queue
502be9f906 Merge pull request #46401 from mikedanese/deprecate
Automatic merge from submit-queue

DO TODO: remove this alias after 2017-05-22
2017-06-08 13:50:49 -07:00
Davanum Srinivas
823e26ddbf Remove unnecessary wrapper flags
Drop KUBE_GOFLAGS, KUBE_GOGCFLAGS, KUBE_GOLDFLAGS references
from the build infrastructure. There are some usages still
for KUBE_GOFLAGS, so we should print a deprecation message
until all those are fixed. If both KUBE_GOFLAGS and GOFLAGS
are just then we just bail out.
2017-06-07 12:31:01 -04:00
Davanum Srinivas
733bb2c31d Add git branch to make build short hash unique
KUBE_ROOT_HASH depends just on the host name and
directory path. So when working with branches, it could lead
to some confusion since the hash is the same even when
you switch from branch to branch. Let us use the git branch
information when we compute the short hash

Fixes #1801
2017-06-02 21:18:00 -04:00
Jeff Grafton
052e4848f9 bazel: base kube-proxy image on debian-iptables instead of busybox 2017-06-01 19:27:15 -07:00
Kubernetes Submit Queue
47ba1a6c76 Merge pull request #46419 from bruceauyeung/k8s-branch-fix-make-release-doesnt-respect-go-build-flags
Automatic merge from submit-queue (batch tested with PRs 44061, 46614, 46419, 46628, 46134)

fix make release/quick-release doesn't respect go build flags

**What this PR does / why we need it**:
k8s build process run `make cross` in a docker container, so we have to pass make command line variables to docker container, then  each environment variable in docker container will be transformed into a makefile variable with the same name and value.
with this PR, `make release GOFLAGS=xx GOLDFLAGS=xx GOGCFLAGS=xx`, `make quick-release GOFLAGS=xx GOLDFLAGS=xx GOGCFLAGS=xx` will work as expected

**Which issue this PR fixes**: 
fixes #46274
2017-05-30 18:34:59 -07:00
Christoph Blecker
f3d3b0b092
Bump CNI base image to go1.7.6 2017-05-29 09:38:16 -07:00
Jeff Grafton
122499621b Bazel: mount tmpfs on /tmp 2017-05-26 17:02:18 -07:00
Kubernetes Submit Queue
99eee154f6 Merge pull request #46269 from xiangpengzhao/fix-make-helpinfo
Automatic merge from submit-queue

Update examples in Makefile with WHAT arguments changed.

**What this PR does / why we need it**:
The examples `make check WHAT` and `make vet WHAT` in Makefile don't work anymore. This PR updates them.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
xref: https://github.com/kubernetes/community/issues/327, https://github.com/kubernetes/community/pull/296, https://github.com/kubernetes/kubernetes/pull/39433

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
2017-05-26 01:33:30 -07:00
Wojciech Tyczynski
97b6701ea1 Get rid of patched version of Go 1.8.1 2017-05-25 20:05:34 +02:00
Wojciech Tyczynski
3e8c27af34 Bump Go version to 1.8.3 2017-05-25 20:05:34 +02:00
bruceauyeung
396695af15 fix make release/quick-release doesn't respect go build flags 2017-05-25 17:05:09 +08:00
Mike Danese
6f92f51d60 DO TODO: remove this alias after 2017-05-22 2017-05-24 20:03:14 -07:00
xiangpengzhao
a320c94cc3
Update examples in Makefile with WHAT arguments changed. 2017-05-23 12:36:45 +08:00
Jeffrey Regan
5a9b06b717 **What this PR does / why we need it**:
Remove kubectl's dependence on pkg/api/helper, as part of
broader effort to isolate kubectl from the rest of k8s.
In this case, the code becomes private to kubectl; nobody else uses it.

**Which issue this PR fixes**

Part of a series of PRs to address kubernetes/community#598

**Special notes for your reviewer**:

**Release note**:
```release-note
NONE
```
2017-05-21 20:44:21 -07:00
Kubernetes Submit Queue
249551461e Merge pull request #45855 from mikedanese/out-of-root
Automatic merge from submit-queue (batch tested with PRs 45582, 45855)

move build related files out of the root directory

Turn the files in root to symlinks into build/root/

alternative to OWNERS changes. what do you guys think of this?
2017-05-18 00:56:47 -07:00
Kubernetes Submit Queue
e7b1814863 Merge pull request #43578 from vsiddharth/pause-container
Automatic merge from submit-queue

Improve pause-container warning message

Signed-off-by: Vinothkumar Siddharth <sidvin@amazon.com>



**What this PR does / why we need it**:
This just improves the warning message currently emitted by pause

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
```
2017-05-17 22:56:20 -07:00
Vinothkumar Siddharth
9fa5e857e5 Fix file semantics
Signed-off-by: Vinothkumar Siddharth <sidvin@amazon.com>
2017-05-17 10:34:20 -07:00
Kubernetes Submit Queue
b059116a69 Merge pull request #45879 from wojtek-t/workaround_go_performance_regression
Automatic merge from submit-queue (batch tested with PRs 45884, 45879, 45912, 45444, 45874)

Use patched version of Go 1.8.1 to eliminate performance regression

Ref https://github.com/kubernetes/kubernetes/issues/45216

Until this is solved in Go (it's still unclear whether there will be patch release with the fix or not), this is solving the problem on our side.
2017-05-16 22:18:52 -07:00
Wojciech Tyczynski
3a1bb09ea9 Patch golang 2017-05-16 21:29:22 +02:00
Mike Danese
c67e4d1df0 plumb through version 2017-05-16 09:17:30 -07:00
Mike Danese
fd9c017d2d bazel: build rpms to match the debs that we output 2017-05-16 09:17:30 -07:00
Mike Danese
4bf2ef646f move build related files out of the root directory 2017-05-15 15:53:54 -07:00
Jeffrey Regan
7abff879d7 Introduce visibility rules to kubernetes code.
**What this PR does / why we need it**:

Visibility rules allow dependency control.  The rules currently in
place make all targets public, to override the default state of
private.  This PR removes public visibility from kubectl code.  It
uses specially named pacakge groups to identify "bad" dependencies on
kubectl code for later refactoring or removal.

**Which issue this PR fixes**

First in a series of PRs to address kubernetes/community#598

**Release note**:
```release-note
NONE
```
2017-05-15 12:50:56 -07:00
David McMahon
b82b3c0632 Only tag release containers if the name is different. 2017-05-04 18:43:23 -07:00
Jeff Grafton
e231d4280b Replace git_repository with http_archive and use ixdy's fork of bazel tools for pkg_tar 2017-05-03 10:13:06 -07:00
Jeff Grafton
45a6455ac7 Use new docker_bundle rule instead of ixdy's custom docker_build rule 2017-05-02 16:30:24 -07:00
Kubernetes Submit Queue
46971d6d21 Merge pull request #45120 from ixdy/bazel-push-build
Automatic merge from submit-queue

Also upload debs to bin/$OS/$ARCH

**What this PR does / why we need it**: the bazel-built debs are used by the kubeadm e2e tests, so upload them too.

https://github.com/kubernetes/kubernetes/pull/44591#issuecomment-298084453

/assign @pipejakob 
/cc @mikedanese @spxtr 

**Release note**:

```release-note
NONE
```
2017-05-02 15:40:35 -07:00
Jeff Grafton
37eb292bc0 Update bazel build to dockerize cloud-controller-manager 2017-05-02 12:07:13 -07:00
Kubernetes Submit Queue
3791abd628 Merge pull request #44981 from ixdy/version-docker-tag
Automatic merge from submit-queue

Use munged semantic version for side-loaded docker tag

**What this PR does / why we need it**: rather than using the md5sum of the dockerized binary for each side-loaded docker image, use the semantic version (with `+`s replaced with `_`s) for the side-loaded docker images.

The use of the md5sum for the docker tag dates to #6326 2 years ago. I'm not sure why that was chosen, short of it being fairly unique.

My main motivation for changing this is that it makes building the docker images using Bazel's docker rules easier, since the semantic version doesn't depend on the build output.

An added benefit is that the list of images on a running kubernetes cluster is also more straightfoward; rather than a list of opaque, meaningless hexadecimal strings, you get something that indicates the provenance of the image. It'd also be clearer that all of the images came from the same build.

I was able to start a cluster with this change on GCE using both `make quick-release` and `make bazel-release`.

Note that this change has no effect on the tag that's pushed to gcr.io during releases; that's still controlled via `KUBE_IMAGE_DOCKER_TAG`, though we may want to merge this functionality at some point.

@kubernetes/sig-node-pr-reviews is there any reason to stick with using the md5sum strategy? @dchen1107 do you remember why we went with md5sums originally?
cc @spxtr @mikedanese 

**Release note**:

```release-note
```
2017-05-01 19:48:18 -07:00
Kubernetes Submit Queue
03c9c48c81 Merge pull request #44062 from ixdy/semver-regexes
Automatic merge from submit-queue

Support arbitrary alphanumeric strings as prerelease identifiers

**What this PR does / why we need it**: this is basically an extension of #43642, but supports more general prerelease identifiers, per the spec at http://semver.org/#spec-item-9.

These regular expressions are still a bit more restrictive than the SemVer spec allows (we disallow hyphens, and we require the format `-foo.N` instead of arbitrary `-foo.X.bar.Y.bazZ`), but this should support our needs without changing too much more logic or breaking other assumptions.

**Release note**:

```release-note
NONE
```
2017-05-01 12:54:44 -07:00
Lucas Käldström
4ee9d047fd
Create a docker image for the cloud controller manager 2017-04-30 10:28:56 +03:00
Jeff Grafton
f0e0a27f3e Also upload debs to bin/$OS/$ARCH 2017-04-28 13:25:12 -07:00
Timothy St. Clair
01366851ea Prune k8petstore from examples and e2es per discussion on sig-testing 2017-04-28 11:49:23 -05:00
Jeff Grafton
f73e3cbb30 Use munged semantic version for side-loaded docker tag 2017-04-27 15:05:40 -07:00
Kubernetes Submit Queue
14a557b1a2 Merge pull request #44346 from mikedanese/build-static
Automatic merge from submit-queue (batch tested with PRs 41106, 44346, 44929, 44979, 45027)

bazel: statically link dockerized components
2017-04-27 12:11:00 -07:00
Kubernetes Submit Queue
549bd4b7d5 Merge pull request #44591 from ixdy/bazel-push-build
Automatic merge from submit-queue (batch tested with PRs 44591, 44549)

Update repo-infra bazel dependency and use new gcs_upload rule

This PR provides similar functionality to push-build.sh entirely within Bazel rules (though it relies on gsutil).

It's an alternative to #44306.

Depends on https://github.com/kubernetes/repo-infra/pull/13.

**Release note**:

```release-note
NONE
```
2017-04-27 10:54:56 -07:00
Lucas Käldström
6b5d5371d9
Bump to go1.8.1 and remove the edge GOROOT 2017-04-25 23:45:47 +03:00
Jeff Grafton
a9bfae8ec3 Update repo-infra bazel dependency and use new gcs_upload rule 2017-04-25 13:45:28 -07:00