This allows the execution of the Makefiles from distributions which do
have `bash` in a different path.
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
verify-publishing-bot is experiencing errors importing pyyaml since
python3 was added to kubekins-e2e image. This changes make verify to run
verify-publishing-bot with python3.
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
verify-no-vendor-cycles currently routinely takes 3-4 minutes to run due
to the way that it checks for cyclical imports in vendored packages.
Moving to using the new dependencycheck tool makes this test much faster.
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
The go version for all master branches is defined in `default-go-version`
locally.
Note that this validation isn't added to publishing-bot directly because
we still want to give users of the publishing-bot the ability to specify
specific go versions for the master branch if they need, but we want to
explicitly disallow this for kubernetes repos.
If a bearer token is present in a request, the exec credential plugin should accept that as the chosen method of authentication. Judging by an [earlier comment in exec.go](c18bc7e9f7/staging/src/k8s.io/client-go/plugin/pkg/client/auth/exec/exec.go (L217)), this was already intended. This would however not work since UpdateTransportConfig would set the GetCert callback which would then get called by the transport, triggering the exec plugin action even with a token present in the request. See linked issue for further details.
See #87369 for further details.
Signed-off-by: Anders Eknert <anders.eknert@bisnode.com>
This runs much faster than before. This change removes all of the
async status output because all of the compute time is spent inside
go/packages, with no opportunity to update the status.
Adds testdata code to prove it fails when expected.
Added comments and switched to _output for bentheelder.
Added error checking for logicalhan.
Fixed egrep error.
Added dedupe logic.
Added staging only option.
Fixed ls -> find.
Errors from staticcheck:
pkg/registry/autoscaling/horizontalpodautoscaler/storage/storage_test.go:207:7: this value of err is never used (SA4006)
pkg/registry/core/namespace/storage/storage.go:256:5: options.OrphanDependents is deprecated: please use the PropagationPolicy, this field will be deprecated in 1.7. Should the dependent objects be orphaned. If true/false, the "orphan" finalizer will be added to/removed from the object's finalizers list. Either this field or PropagationPolicy may be set, but not both. +optional (SA1019)
pkg/registry/core/namespace/storage/storage.go:257:11: options.OrphanDependents is deprecated: please use the PropagationPolicy, this field will be deprecated in 1.7. Should the dependent objects be orphaned. If true/false, the "orphan" finalizer will be added to/removed from the object's finalizers list. Either this field or PropagationPolicy may be set, but not both. +optional (SA1019)
pkg/registry/core/namespace/storage/storage.go:266:5: options.OrphanDependents is deprecated: please use the PropagationPolicy, this field will be deprecated in 1.7. Should the dependent objects be orphaned. If true/false, the "orphan" finalizer will be added to/removed from the object's finalizers list. Either this field or PropagationPolicy may be set, but not both. +optional (SA1019)
pkg/registry/core/namespace/storage/storage.go:267:11: options.OrphanDependents is deprecated: please use the PropagationPolicy, this field will be deprecated in 1.7. Should the dependent objects be orphaned. If true/false, the "orphan" finalizer will be added to/removed from the object's finalizers list. Either this field or PropagationPolicy may be set, but not both. +optional (SA1019)
pkg/registry/core/persistentvolumeclaim/storage/storage_test.go:165:2: this value of err is never used (SA4006)
pkg/registry/core/resourcequota/storage/storage_test.go:202:7: this value of err is never used (SA4006)
pkg/registry/core/service/ipallocator/allocator_test.go:338:2: this value of other is never used (SA4006)
pkg/registry/core/service/portallocator/allocator_test.go:199:2: this value of other is never used (SA4006)
pkg/registry/core/service/storage/rest_test.go:1843:2: this value of location is never used (SA4006)
pkg/registry/core/service/storage/rest_test.go:1849:2: this value of location is never used (SA4006)
pkg/registry/core/service/storage/rest_test.go:3174:20: use net.IP.Equal to compare net.IPs, not bytes.Equal (SA1021)
pkg/registry/core/service/storage/rest_test.go:3178:20: use net.IP.Equal to compare net.IPs, not bytes.Equal (SA1021)
pkg/registry/core/service/storage/rest_test.go:3185:20: use net.IP.Equal to compare net.IPs, not bytes.Equal (SA1021)
pkg/registry/core/service/storage/rest_test.go:3189:20: use net.IP.Equal to compare net.IPs, not bytes.Equal (SA1021)
This script quiently depended on being under a GOPATH, and failed
completely when it was not. This change sorts the input (to make
comparing results easier) and operates on files, rather than packages
until the last moment when we add back the package prefix.
Verified by instrumenting the code and comparing runs inside and outside
of GOPATH.
e2e test framework provides useful functions for implementing e2e tests,
but the framework itself should not contain e2e tests theirself.
This adds hacking check for blocking implementing e2e tests in the
framework.
verify-bazel seems to create read only files under its tmp dir.
When it then goes to clean up the tmp dir it fails.
Adding a command prior to delete to make sure we have perms.
This cluster add-on is required for snapshotting of CSI volumes and
must be installed when bringing up a cluster because CSI driver
installations depend on that.
It is unclear how many users of the script need CSI snapshotting,
therefore it is disabled by default (= the previous behavior).
While the umask was previously set for builds (and in fact `docker run`
sets it to 0022 by default), the release pipeline `cp`'s files (with
`-a`) which respect the user's umask, and is outside of the build path.
This sets the umask in a common function called by all build tools,
which Stephen agreed was the simplest and most complete fix. The
`verify-prereqs` function is already poorly named for what it does, and
this only makes it epsilon worse.
This moves licenses of vendored code from one monolith file into a tree
of individual files for easier reviews. This fixes both the bash and
bazel paths.
Some binaries now run as non-root (kube-scheduler). When umask is 0027,
for example, the container image we build has the binary 0750, which is
not executable by the non-root UID.
This is merely bringing PR #82059 back to life in a contemporary
context, so all cred should go to k-toyoda-pi (and BenTheElder).
Change-Id: I7cf33e50adabbd23d18348448c21c6255502c1ba
Signed-off-by: Joakim Roubert <joakimr@axis.com>
- add ./hack/tools/go.mod, this makes ./hack/tools a distinct module
- hack/tools/tools.go undescore imports bazel related tools, over time we
can add others.
- hack/*.sh scripts will cd to hack/tools and go install tools from there
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
pkg/util/rlimit/rlimit_linux.go:25:1: exported function RlimitNumFiles should have comment or be unexported
pkg/util/rlimit/rlimit_linux.go:25:6: func name will be used as rlimit.RlimitNumFiles by other packages, and that stutters; consider calling this NumFiles
pkg/util/rlimit/rlimit_unsupported.go:25:1: exported function RlimitNumFiles should have comment or be unexported
pkg/util/rlimit/rlimit_unsupported.go:25:6: func name will be used as rlimit.RlimitNumFiles by other packages, and that stutters; consider calling this NumFiles
Ref: https://github.com/kubernetes/kubernetes/issues/68026
Errors from staticcheck:
pkg/volume/azure_dd/azure_common.go:68:2: var winDiskNumFormat is unused (U1000)
pkg/volume/csi/csi_block.go:97:2: field volumeInfo is unused (U1000)
pkg/volume/csi/csi_block_test.go:56:6: func prepareBlockUnmapperTest is unused (U1000)
pkg/volume/csi/csi_client.go:108:2: const initialDuration is unused (U1000)
pkg/volume/csi/csi_client.go:109:2: const factor is unused (U1000)
pkg/volume/csi/csi_client.go:110:2: const steps is unused (U1000)
pkg/volume/csi/csi_client_test.go:83:8: this value of err is never used (SA4006)
pkg/volume/csi/csi_mounter.go:76:2: field options is unused (U1000)
pkg/volume/csi/csi_mounter_test.go:454:13: this value of err is never used (SA4006)
pkg/volume/csi/csi_plugin_test.go:766:16: this value of err is never used (SA4006)
pkg/volume/csi/csi_plugin_test.go:861:13: this value of err is never used (SA4006)
pkg/volume/csi/csi_plugin_test.go:1186:13: this value of err is never used (SA4006)
pkg/volume/csi/csi_plugin_test.go:1249:13: this value of err is never used (SA4006)
pkg/volume/csi/csi_test.go:305:5: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (SA2002)
pkg/volume/flexvolume/probe_test.go:67:10: this value of err is never used (SA4006)
pkg/volume/iscsi/iscsi_test.go:95:2: field attachCalled is unused (U1000)
pkg/volume/iscsi/iscsi_test.go:96:2: field detachCalled is unused (U1000)
pkg/volume/iscsi/iscsi_test.go:501:24: this value of err is never used (SA4006)
pkg/volume/iscsi/iscsi_util_test.go:159:2: this value of exist is never used (SA4006)
pkg/volume/local/local.go:351:57: argument devicePath is overwritten before first use (SA4009)
pkg/volume/plugins_test.go:119:2: this value of plug is never used (SA4006)
pkg/volume/plugins_test.go:125:2: this value of plug is never used (SA4006)
pkg/volume/quobyte/quobyte.go:474:23: this result of append is never used, except maybe in other appends (SA4010)
pkg/volume/quobyte/quobyte.go:477:23: this result of append is never used, except maybe in other appends (SA4010)
pkg/volume/quobyte/quobyte.go:480:23: this result of append is never used, except maybe in other appends (SA4010)
pkg/volume/rbd/rbd.go:886:2: field adminSecret is unused (U1000)
pkg/volume/rbd/rbd.go:887:2: field adminID is unused (U1000)
pkg/volume/rbd/rbd.go:888:2: field imageFormat is unused (U1000)
pkg/volume/rbd/rbd.go:889:2: field imageFeatures is unused (U1000)
pkg/volume/storageos/storageos.go:302:2: field secretName is unused (U1000)
pkg/volume/storageos/storageos_util_test.go:43:2: field apiAddr is unused (U1000)
pkg/volume/storageos/storageos_util_test.go:44:2: field apiUser is unused (U1000)
pkg/volume/storageos/storageos_util_test.go:45:2: field apiPass is unused (U1000)
pkg/volume/storageos/storageos_util_test.go:46:2: field apiVersion is unused (U1000)
pkg/volume/util/atomic_writer_test.go:756:49: argument err is overwritten before first use (SA4009)
pkg/volume/util/fsquota/common/quota_linux_common.go:37:2: const acct is unused (U1000)
pkg/volume/util/fsquota/common/quota_linux_common.go:38:2: const enforcing is unused (U1000)
pkg/volume/util/fsquota/project.go:168:31: identical expressions on the left and right side of the '==' operator (SA4000)
pkg/volume/util/fsquota/quota_linux.go:306:50: argument poduid is overwritten before first use (SA4009)
pkg/volume/util/fsquota/quota_linux_test.go:558:16: this value of err is never used (SA4006)
pkg/volume/util/subpath/subpath_linux.go:232:81: argument err is overwritten before first use (SA4009)
pkg/volume/util/subpath/subpath_linux_test.go:579:73: argument err is overwritten before first use (SA4009)
/cluster/kubeadm.sh is used to find the kubeadm binary.
This file is legacy and is removed.
Remove /test/cmd/kubeadm.sh. This file contains a function that is used
to build kubeadm and invoke "make test". Move the function contents
to hack/make-rules/test-cmd.cmd.
Stop sourcing /test/cmd/kubeadm.sh in /test/cmd/legacy-script.sh.
Also remove the --kubeadm-path invocation as this can be handled
with an env. variable directly.
Integration tests imported e2e test code and the dependency made two drawbacks:
- Hard to move test/e2e/framework into staging (#74352)
- Need to run integration tests always even if PRs are just changing e2e test code
This enables import-boss check for blocking such dependency.
We have been having issues with making builds reproducible, especially
with the `.note.go.buildid` ELF section. One tip from a golang issue was
to set `-ldflags=-buildid=` which seems to work well. You can confirm
that the buildid is set to empty by inspecting the binaries with the go
command example `go tool buildid _output/local/go/bin/kubectl`
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
This first version of `kubectl alpha debug` is an import of the existing
kubectl-debug plugin, which supports adding ephemeral containers to
running pods. This attempts to follow patterns used by other kubectl
commands such as run, exec and scale.
- On unstable arch like ARM, etcd needs the "ETCD_UNSUPPORTED_ARCH" to be set
`# etcd --version
etcd on unsupported platform without ETCD_UNSUPPORTED_ARCH=arm64 set`
- `tail -n +1 | head -n 1` is unnecessary, `head -n 1` is enough.
The new benchmark requires the benchtime to be set to a very small number
so each test is run at most once. Some machines can have too powerfull resources
and decrease running time of some tests under the default 1s. Also, the old suite
expects the benchtime to be set to 1s. Allow to override the benchtime for the
new test suite will allow to run the same script from both suites.
The image "gcr.io/authenticated-image-pulling/windows-nanoserver:v1" is not a
manifest list, and it is only useful for Windows Server 1809, which means that the
test "should be able to pull from private registry with secret" will fail for
environments with Windows Server 1903, 1909, or any other future version we might
want to test.
This commit adds the the ability to have an alternative private image to pull by
using a configurable docker config file which contains the necessary credentials
needed to pull the image.
The image used by the Image Promoter (gcr.io/k8s-testimages/gcb-docker-gcloud:v20190906-745fed4)
is based on busybox, and thus, the sed binary is actually busybox. image-util.sh calls
kube::util::ensure-gnu-sed several times, which ensures that a GNU sed binary exists
(it checks by greping GNU in its --help output). Obviously, it won't match the busybox sed
binary. But the sed usage in image-util.sh is fairly simple, and the busybox sed is sufficient.
This was previously fixed in: #87188, but it was reverted by #87653 as it was failing
on Mac (sed does not exist). This commit fixes that issue as well.
make test-integration ran within jenkins job does not collect json file with generated metrics
from kube-scheduler. The artifacts dir needs to be set explicitly through new -data-items-dir
test flag. The metrics are required to provide more comphrehensive information about
kube-scheduler internals.
This patch all the testing infra and utilities needed
to run e2e topology manager tests. This include setup
a guaranteed pod which needs some devices.
The simplest real device available for the purpose
are the SRIOV devices, hence we use them.
This patch pulls the SRIOV device plugin from
the official, yet external, repository.
We do it as close as possible for the nvidia GPU plugin.
This patch also performs minor refactoring for some
test framework utilities, needed to support the new
e2e tests.
Finally, we add an empty e2e topology manager test,
to be completed by the next patch.
Signed-off-by: Francesco Romani <fromani@redhat.com>
I have 140 commits in this directory and I get a lot of cleanup reviews
and want to be able to approve changes to hack/.golint_failures.
0e69316b delete unused cache
b9c7007c enable token review when openapi is generated
d5bbc35d make deps-approvers the approvers of sample-cli-plugin/Godeps
4186abf7 bzl: fix update-bazel.sh
7b472296 remove deprecated /proxy paths
b9738404 gke-certificates-controller: rm -rf
49610655 cluster: remove unused functions
1e2b6442 cluster: move logging library to hack/
bef68f7d cluster: build gci mounter like other go binaries
fe7ba9e7 kubeadm: use kubelet bootstrap instead of reimplementing
3c39173e fixit: break sig-cluster-lifecycle tests into subpackage
64f77ebf enable race detection on integration tests
cdcfa35c promote tls-bootstrap to beta
ff4a814c migrate set generation to go genrule
3600d495 delete benchmark integration tests that don't work at all
21617a60 don't use build tags to mark integration tests
59fc948a bump rules_go and go version for bazel builds
ba5c2855 bazel: implement git build stamping
ad42b429 move kubeadm api group testing to kubeadm package
c8ce55fe Revert "Merge pull request #41132 from kubernetes/revert-40893-kubelet-auth"
cbe5bd97 bump gazel to v14
86d94937 remove second CA used for kubelet auth in favor of webhook auth
04a7880b update repo local config to allow redirects from gopkg.in
44b72465 autogenerated
96c146c8 promote certificates.k8s.io to beta
087016dd update gazel to v8
837eee43 pin gazel to v3
e225625a add a configuration for kubelet to register as a node with taints
584689f1 implement kubectl procelain csr commands
93f737ea fix verify-bazel.sh on mac and windows
5dc7554a bazel: implement set-gen as a bazel genrule
61bd6aa6 remove docs/user-guide from bindata search path
224e32bc make godep licenses/copyright check case insensitive
1cd29689 godep: vendor go-bindata
d380cb1d fix realpath issue on mac
ea632fa8 Revert "disable bazel build"
27116c68 rename build/ to build-tools/
ee15c80d disable bazel build
999c9677 ignore BUILD in the flags-underscore.py validation
b250a880 don't check BUILD file when verifying godeps
a2eec91a add bazel presubmits to verify BUILD files are up to date
c17a8a77 kubectl: apply prune should fallback to basic delete when a resource has no reaper
25e4dcce kubeadm: fix conversion macros and add kubeadm to round trip testing
6d17a878 kubectl: add two more test of kubectl apply --prune
62960aac add a test for kubectl apply --prune
6339d915 add a test to test-cmd.sh for apply -f with label selector
b421bf43 build kube-discovery and kubeadm with release
0c76cf5c fix hack/verify-codegen.sh
9f379df7 add an option to controller-manager to auto approve all CSRs
95e2e299 move kube-dns to the cluster/addons/ directory
f3de21bd move integration tests into individual pacakges
af0177ef cleanup hack/verify-govet.sh to throttle process creation
2c93ea5d Merge pull request #27289 from mikedanese/split-verify
ee34c769 split verify out of unit/integration suite
d046275a now that go test runs iteration loops, use that instead of custom executor
1ef19062 Merge pull request #26197 from wonderfly/update_default_master_image
fbf6bbc4 Merge pull request #25596 from derekparker/inotify
3e1c0b59 run kube-addon-manager in a pod
c5cc0c34 Merge pull request #24277 from ihmccreery/upgrade-timeout
132c4271 add linux fastbuild option to ./build/release.sh
2857baa7 use defaults in test-dockerized for etcd prefix and api versions
695211e2 Merge pull request #21105 from caesarxuchao/watchCacheForIntegration
2172e0de Merge pull request #21108 from mml/slow-flake
1478cf34 Merge pull request #21090 from ihmccreery/feature-reboot
b3172a4c kubelet: add a pidfile
b1743a68 this is a manual reversion of #207025b270551 Merge pull request #19378 from ihmccreery/remove-update-jobs
b7438274 Merge pull request #19659 from ihmccreery/timeout-reboot
a6589f7d hack: ignore cluster/env.sh in boilerplate check
f71657d9 retrofit the scheduler with the leader election client.
bf763bba Merge pull request #19498 from pwittrock/nodelabels
22cfa5ea build: move some of hack/lib/ into a new cluster/lib/
b174fc9c Merge pull request #18994 from bprashanth/flannel_suite
a09d85bd expose master count configuration in a cli option on apiserver
c2753d75 bump ci go version to 1.5.2
0655e65b fall back to old behavior when deciding mem availablity during build
1d9d11c8 run kube-proxy in a static pod
91de3a12 cleanup some nits in hack/get-build.sh
cd79c6c0 fix unbound variable error in hace/get-build.sh
5e64590f renable enable var to correct name and only use it when needed
9bdb860e add apigroup installer and tests
e6d3b47e add componentconfig api group to autogen stuff
88008de9 Merge pull request #16459 from mikedanese/enable-exp
d28d1344 Merge pull request #16533 from ihmccreery/upgrade-test-fixes
33435225 enable deployment and daemonset in gce upgrade tests
7cbf249b Merge pull request #15836 from wojtek-t/codecgen_from_godeps
92404e7c add upgrade test between 1.0 and 1.1 for gce
95b8394a Merge pull request #15861 from mikedanese/upgrade-num-minion
ece5779f increase NUM_MINIONS for jenkins gce upgrade test
b8b35afa actually promote daemonset simple test out of flaky and skip all daemonset tests in gke
d379a360 copy directory not contents of directory
402e68e0 add slow test for terminated pod garbage collection
c0943f11 add intermediate e2e runs to gce upgrade
10d56ff1 promote simple daemonset test out of flaky
b635fc53 Merge pull request #15228 from mesosphere/sttts-conformance-tags
392f33e4 Merge pull request #14054 from mikedanese/register-master
fa60bbe8 add flag to kubelet to ignore the cidr passed down by the apiserver on the master
53e14c7a diff all of pkg/ when verifying swagerspec instead of just pkg/api/
05ef8ed2 Merge pull request #15104 from mikedanese/ds-e2e
fe820fc4 break up daemonset test into two tests
833be48d enable all experimental flags with one controller
905e9716 be explicit about minion group size in upgrade test
ae7d3d5a add gce-upgrade to jenkins/e2e.sh
376faea1 add pod garbage collection
b0457bee Merge pull request #13058 from mvdan/go1.5
a48f2182 Merge pull request #13754 from tummychow/labels-deps
1fec1993 Merge pull request #13824 from kubernetes/revert-13547-hpa-kubeup
fa40ced8 move contrib/for-tests to test/images
f0618758 updating all references in .sh scripts
83266970 rewrite all links to prs to k8s links
fb02b33e fix build
8e48431c Revert "demote to flaky tests from parallel e2e"
b56edd13 Merge pull request #11727 from ZJU-SEL/build-nonstatic-hyperkube
cf4cb1a6 Merge pull request #10474 from kargakis/scale-multiple-controllers
e376a094 demote to flaky service tests from parallel e2e
7c47d6bd Merge pull request #12009 from smarterclayton/fix_cmd_config
0269e2ba Merge pull request #11941 from GoogleCloudPlatform/enact_version_md
94a387d5 Revert "Improve conversion to support multiple packages"
1a613c43 Merge pull request #9971 from smarterclayton/make_conversion_more_flexible
0ae48c44 Merge pull request #11927 from wojtek-t/remove_shell_services
59a1dd42 Merge pull request #11789 from mbforbes/nodesNetwork
6294070c Merge pull request #11803 from wojtek-t/move_back_from_flaky
daa6d4dd Merge pull request #11285 from liggitt/ca
9f16fd90 Merge pull request #11860 from ingvagabund/delimiter-for-X-option-eparis
c0acfbcd Merge pull request #11421 from nikhiljindal/exposeServcPort
ae1c8e55 Merge pull request #11737 from thockin/cleanup-remove-v1beta3
01ee1b86 Merge pull request #10840 from jbeda/master
d4d99deb make mungedoc exit 1 if manual changes are needed and wire up erro message.
337772a9 fix all tests
055115a1 fake realpath, and standardize treatment of trailing / of dirs in gendoc
b4514ee1 fix run-gendocs to point to new repo location
c053b9a5 add documentation and script on how to get recent and "nightly" builds
719870fd add publishing of latest-green.txt to jenkins e2e tests on success
1e130e07 remove --machines from code and docs
dbb47fe2 remove e2e run before cluster upgrade
de55e17f e2e test cluster stability during upgrade
c9fcf45f fix bad cmd-test for patch.
9f915325 fix error where we can't use patch and add cmd-test for patch and file update
With these changes, /build/lib/release.sh can be removed from
hack/.shellcheck_failures and included in the scripts that are checked
by hack/verify-shellcheck.sh.
Signed-off-by: Joakim Roubert <joakimr@axis.com>
If "NewServer" returns an error, it will result in a nil pointer
dereference segfault.
A simple way to test the behavior is to prefix the server url with a
colon, ":".
In 24d105995d, a fix was made in bazel
based builds to ensure that we add `selinux` tag when we build all
binaries especially the `kubelet`. We need to do the same for in our
hack scripts so things like `make release` will work properly as well.
Some scripts use `GOFLAGS=-tags=providerless` for example, So we should
support the tags to be specified in GOFLAGS as well. We parse out the
tags from there and ensure selinux is added to the list of tags we used
for building the binaries. Note that we add our own `-tags` with the
full set of tags and since we specify our parameter at the end, ours
full list takes precendence
Prior to the Image Centralization part 4 (https://github.com/kubernetes/kubernetes/pull/81170),
a PR merged that enables the Image Promoter to run on the k/k test images.
The Image Promoter currently only builds the Conformance-related images, but the
Image Centralization part 4 centralized some of those images into agnhost, so they
need to be removed from the conformance_images list.
Additionally, https://github.com/kubernetes/kubernetes/pull/81226 proposes mounttest-user
image to be removed, and RunAsUser to be used in tests instead.
The image used by the Image Promoter (gcr.io/k8s-testimages/gcb-docker-gcloud:v20190906-745fed4)
is based on busybox, and thus, the sed binary is actually busybox. image-util.sh calls
kube::util::ensure-gnu-sed several times, which ensures that a GNU sed binary exists
(it checks by greping GNU in its --help output). Obviously, it won't match the busybox sed
binary. But the sed usage in image-util.sh is fairly simple, and the busybox sed is sufficient.
Bumps image versions for: jessie-dnsutils, nonewprivs, resource-consumer, sample-apiserver. These
images are included in the conformance_images that are being built by the Image Promoter, so
we're bumping them just to make sure we're not breaking anything and cause all the CIs to fall.
We're going to bump the image versions used in tests in a subsequent PR. The image version was not
bumped for: agnhost, kitten, nautilus, as they were already bumped by the Image Centralization part 4
PR.
handle local variable in cluster/common.sh
add comment for shellcheck disable line, and fix error change
fix error: "read" parameters -r position
update function comment
refactor function find-release-tars
rm lines in .shellcheck_failures
Continue to cleanup common.sh
Errors from staticcheck:
pkg/proxy/healthcheck/proxier_health.go:55:2: field port is unused (U1000)
pkg/proxy/healthcheck/proxier_health.go:162:20: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
pkg/proxy/healthcheck/service_health.go:166:20: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
pkg/proxy/iptables/proxier.go:737:2: this value of args is never used (SA4006)
pkg/proxy/iptables/proxier.go:737:15: this result of append is never used, except maybe in other appends (SA4010)
pkg/proxy/iptables/proxier.go:1287:28: this result of append is never used, except maybe in other appends (SA4010)
pkg/proxy/userspace/proxysocket.go:293:3: this value of n is never used (SA4006)
pkg/proxy/winkernel/metrics.go:74:6: func sinceInMicroseconds is unused (U1000)
pkg/proxy/winkernel/metrics.go:79:6: func sinceInSeconds is unused (U1000)
pkg/proxy/winuserspace/proxier.go:94:2: field portMapMutex is unused (U1000)
pkg/proxy/winuserspace/proxier.go:118:2: field owner is unused (U1000)
pkg/proxy/winuserspace/proxier.go:119:2: field socket is unused (U1000)
pkg/proxy/winuserspace/proxysocket.go:620:4: this value of n is never used (SA4006)
Few days ago I watched this kubectl code base tour on Youtube
(https://www.youtube.com/watch?v=uz8TS3V9qqY). It talks about a design
pattern that almost every command follows. But I found out that
`kubectl proxy` command does not follow this pattern. So, I'm
refactoring this command to use similar design pattern as other kubectl
commands.
Errors from staticcheck:
test/images/agnhost/dns/common.go:79:6: func runCommand is unused (U1000)
test/images/agnhost/inclusterclient/main.go:75:16: using time.Tick leaks the underlying ticker, consider using it only in endless functions, tests and the main package, and use time.NewTicker here (SA1015)
test/images/agnhost/net/nat/closewait.go:41:5: var leakedConnection is unused (U1000)
test/images/agnhost/netexec/netexec.go:157:17: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:250:18: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:317:18: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:331:19: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:345:19: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:357:19: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:370:19: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:380:9: this value of err is never used (SA4006)
test/images/agnhost/netexec/netexec.go:381:17: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/netexec/netexec.go:386:17: printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)
test/images/agnhost/pause/pause.go:43:23: syscall.SIGKILL cannot be trapped (did you mean syscall.SIGTERM?) (SA1016)
test/images/agnhost/serve-hostname/serve_hostname.go:125:15: the channel used with signal.Notify should be buffered (SA1017)
test/images/agnhost/webhook/patch_test.go:131:13: this value of err is never used (SA4006)
test/images/pets/peer-finder/peer-finder.go:155:6: this value of newPeers is never used (SA4006)
Right now, hack/jenkins/dockerized.sh is solely utilized by scheduler perf jenkins job.
There's an effort to extend the scheduler performance suite. In order to run
individual subsuites separately, we need a way to select a subset of benchmark tests
to be run. Golang exposes -bench option which allows to specify a prefix
of benchmark tests to be run.
clean remaining static check errors in legacy-cloud-providers/azure
logging unhandled error in azure_backoff.go
delete unused var and func in azure_vmss_cache.go
run gofmt
* Added a extractor to extract raw logs from json format and then pipe
it into benchmark parser.
* Also added -alsologtostderr=false -logtostderr=false to reduce noisy logs.
"etcd -version" command output an additional line on ARM platform:
"running etcd on unsupported architecture "arm64" since
ETCD_UNSUPPORTED_ARCH is set"
Currently etcd version filtering code can not get correct version
number.
Signed-off-by: Howard Zhang <howard.zhang@arm.com>
* apimachinery: fix dropped test error in pkg/util/net
* apimachinery: fix dropped test error in pkg/runtime/serializer
* apimachinery: fix dropped test error in pkg/conversion
* apimachinery: fix staticcheck warning
* removed -staging/src/k8s.io/apimachinery/pkg/util/clock for golint failures
* first few code comments are done
* add correct comments for all packages
The `kubelet/apis/config` package had golint failures. This change-set
removes the `kubelet/apis/config` package from the `.golint_failures`
and fixes the golint errors. In particular, this change-set adds
documentation to the public types in the package.
This change-set works towards issue#68026
Change the single const statement in favor of multiple const event lists.
This way we don't need to put the name of the constant in the comment
and it's clearer that the comment refers to the whole list.
This patch removes pkg/util/mount completely, and replaces it with the
mount package now located at k8s.io/utils/mount. The code found at
k8s.io/utils/mount was moved there from pkg/util/mount, so the code is
identical, just no longer in-tree to k/k.
hack/pin-dependency.sh k8s.io/repo-infra v0.0.1-alpha.1
To fix non-idempotent BUILD file generation
hack/pin-dependency.sh github.com/bazelbuild/bazel-gazelle v0.19.0
hack/pin-dependench.sh github.com/bazelbuild/buildtools 0.29.0
for go1.13.3 support
hack/lint-dependencies.sh
hack/pin-dependency.sh github.com/bazelbuild/buildtools v0.0.0-20190917191645-69366ca98f89
to pick up preferred version for repo-infra
Changelog:
https://github.com/koalaman/shellcheck/blob/master/CHANGELOG.md
We have some new erros due to the version bump.
- SC2034: VARIABLE_XYZ appears unused. Verify use (or export if used externally).
- Applies to all scripts we source in other scripts
- SC2039: In POSIX sh, set option pipefail is undefined.
- Applies to files using it with "sh" instead of "bash" in the shebang
- SC2054: Use spaces, not commas, to separate array elements.
- Fixing Should make no difference in the code
- SC2128: Expanding an array without an index only gives the first element.
- Fixing Should make no difference in the code
- SC2251: This ! is not on a condition and skips errexit. Use `&& exit 1` instead, or make sure $? is checked.
- Not 100% sure if we can swap to `&& exit 1`. Applies to a lot of
test code.
All changes should be straight forward to fix, but will be done in a
separate PR.
- remove update_owners.py; seems responsible for generating
test_owners files
- remove the existing test/test_owners.* files
- remove verify-test-owners.sh and references to it
Fix the `staticcheck` failures for `test/e2e/node`. All of the
staticcheck errors were for variables which were never used. When these
values were `err`, we added processing for the errors. When they were
values that were just never used, we stopped giving them a name.
`test/integration/kubelet` was failing staticcheck because it was
calling `t.Fatal` from the non-main Go routine. Address this by sending
errors causing t.Fatal back to a channel. The main thread can then
iterate through this channel, and call t.Fatal if there are any errors
in the channel.
When discovering the kube version we only consider tags that match the
glob 'v*'. By doing so users can create/use their custom tags as long as
they don't look like a version (starting with a 'v').
We already do a similar thing when building the pause container, see how
the `REV` is set in git.k8s.io/kubernetes/build/pause/Makefile.
The `err` return value was being overwritten in an unintended way, which
means the function may not return the proper error value. This diff
ensures it does.
This will now filter the hosts in gcloud by project, instance name and
zone, to make sure we only reuse the correct hosts. Previously it would
try to reuse images outside the selected zone, resulting in a crash.
The resulting command will look like this:
$ gcloud compute instances list --project="my-project-123" --filter="name:'test-cos-beta-78-12499-16-0' AND zone:'europe-west6-b'"
* Fix lint errors related to receiver name
Ref #68026
* Fix lint errors related to comments
Ref #68026
* Fix package name in comments
Ref #68026
* Rename Cpu to CPU
Ref #68026
* Fix lint errors related to naming convention
Ref #68026
* Remove deprecated field
DoNotUse_ExternalID has been deprecated and is not in use anymore.
It has been removed to fix lint errors related to underscores in field
names.
Ref #68026, #61966
* Include pkg/apis/core in golint check
Ref #68026
* Rename var to fix lint errors
Ref #68026
* Revert "Remove deprecated field"
This reverts commit 75e9bfc168077fcb9346e334b59d60a2c997735b.
Ref #82919
* Remove math from godoc
Ref #82919, #68026
* Remove underscore from var name
Ref #68026
* Rename var in staging core api type
Ref #68026
Dealing with unused functions/variables/types. (staticcheck U1000)
Dealing with value never used issue. (staticcheck SA4006)
Dealing with concurrency issue. (staticcheck SA2002 SA4010)
Remove packages from staticcheck failure files: apiextensions-apiserver
Errors from staticcheck:
cmd/kube-scheduler/app/server.go:297:27: prometheus.Handler is deprecated: Please note the issues described in the doc comment of InstrumentHandler. You might want to consider using promhttp.Handler instead. (SA1019)
pkg/apis/scheduling/v1alpha1/defaults.go:27:6: func addDefaultingFuncs is unused (U1000)
pkg/apis/scheduling/v1beta1/defaults.go:27:6: func addDefaultingFuncs is unused (U1000)
test/e2e/scheduling/predicates.go:757:6: func verifyReplicasResult is unused (U1000)
test/e2e/scheduling/predicates.go:765:6: func getPodsByLabels is unused (U1000)
test/e2e/scheduling/predicates.go:772:6: func runAndKeepPodWithLabelAndGetNodeName is unused (U1000)
test/e2e/scheduling/limit_range.go:172:3: this value of pod is never used (SA4006)
test/e2e/scheduling/limit_range.go:177:3: this value of pod is never used (SA4006)
test/e2e/scheduling/limit_range.go:196:3: this value of pod is never used (SA4006)
test/e2e/scheduling/limit_range.go:201:3: this value of pod is never used (SA4006)
test/e2e/scheduling/limit_range.go:240:3: this value of pod is never used (SA4006)
test/e2e/scheduling/taints.go:428:13: this value of err is never used (SA4006)
test/e2e/scheduling/ubernetes_lite.go:219:2: this value of pods is never used (SA4006)
test/integration/scheduler/extender_test.go:78:4: this value of resp is never used (SA4006)
test/integration/volumescheduling/volume_binding_test.go:529:15: this result of append is never used, except maybe in other appends (SA4010)
test/integration/volumescheduling/volume_binding_test.go:538:15: this result of append is never used, except maybe in other appends (SA4010)
The documentation on the cherry pick process has seen improvements
lately, but that isn't highly discoverable. This commit attempts to
make that information more visible.
Signed-off-by: Tim Pepper <tpepper@vmware.com>
When using hack/local-up-cluster.sh deploy local cluster, it
failed with following message "kube-proxy terminated unexpectedly"
and "Failed to retrieve node info: nodes "127.0.0.1" not found" in
kube-proxy.log.
The root reason for this error is miss boot order of kubernetes
services in local-up-cluster.sh, kube-proxy and kubectl daemon.
When starting kube-proxy, it would check node information. And
these information are collected by kubelet daemon. However, in
the shell script, kube-proxy service start before kubelet daemon.
This patch changed the boot order of kubelet daemon and kube-proxy
and check if node stats ready for kube-proxy start.
Signed-off-by: Howard Zhang <howard.zhang@arm.com>
Removed hack/lib/test.sh from /hack/shellcheck_failures
Removed and }s to satisfy shellcheck SC2004
Added double quotes to satisfy shellcheck SC2086
Converted array reference to access all elements to satisfy shellcheck SC2128
Updates to satisfy shellcheck SC2143
Updates to satisfy shellcheck SC2178 & SC2124
Updates to satisfy shellcheck SC2128
Updates to satisfy shellcheck SC2207
Remove double quotes to allow expansion. Fixed piping to grep -q
Removed quotes to allow for expansion on flags
