Davanum Srinivas
26cc8e40a8
fix deadcode issues
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-07-14 08:41:21 -04:00
Kubernetes Prow Robot
756203fda0
Merge pull request #102576 from dobsonj/101911
...
kubelet: do not call RemoveAll on volumes directory for orphaned pods
2021-06-29 06:54:40 -07:00
Kubernetes Prow Robot
fc26906546
Merge pull request #103049 from gdsoumya/feat/errors
...
Updating github.com/pkg/errors with native go errors pkg
2021-06-25 23:43:23 -07:00
Kubernetes Prow Robot
06dfe683ce
Merge pull request #103123 from dims/remove-fakefs-to-drop-spf13/afero-dependency
...
Remove fakefs to drop spf13/afero dependency
2021-06-24 07:57:41 -07:00
Davanum Srinivas
5feff280e1
remove fakefs to drop spf13/afero dependency
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2021-06-24 09:51:34 -04:00
Kubernetes Prow Robot
41c3f5b58d
Merge pull request #100287 from pacoxu/structure-log/clean
...
structure log related: use %v for error as it is already quoted
2021-06-23 17:19:40 -07:00
Soumya Ghosh Dastidar
1e949fa928
updating github.com/pkg/errors with native errors pkg
...
Signed-off-by: Soumya Ghosh Dastidar <gdsoumya@gmail.com>
2021-06-21 22:23:33 +05:30
Jonathan Dobson
01bb0f86b0
update comments and owners file for pkg/util/removeall
2021-06-15 10:41:02 -06:00
Jonathan Dobson
484eb01822
kubelet: do not call RemoveAll on volumes directory for orphaned pods
2021-06-08 13:57:35 -06:00
hantmac
127f14198d
comment words correct
...
Signed-off-by: hantmac <hantmac@outlook.com>
comment words correct
Signed-off-by: 韩山杰 <shanjie.han@zhangmen.com>
2021-05-13 20:51:36 +08:00
Masashi Honma
39538463de
test: Use bytes.Buffer.String
...
Fix some warnings from go-staticcheck.
"should use buffer.String() instead of string(buffer.Bytes()) (S1030)"
This warning is explained at this link.
https://staticcheck.io/docs/checks#S1030
2021-03-22 17:48:21 +09:00
pacoxu
bc3e7b5dca
nit: use %v for error as it is already quoted
2021-03-16 17:42:43 +08:00
Kubernetes Prow Robot
9067b5691d
Merge pull request #97818 from damemi/remove-util-node-dep
...
Scheduler: remove direct dependency for k8s.io/kubernetes/pkg/util/node
2021-03-05 04:06:32 -08:00
Mike Dame
af045087d9
Move GetZoneKey function to component-helpers
2021-03-04 10:32:38 -05:00
Supriya Premkumar
e52e5e486c
Adds ineffassign to GO linter script.
...
Changes:
- Enables ineffassign check in the verify scripts.
- Fixes lint errs.
2021-03-03 08:28:10 -08:00
Benjamin Elder
56e092e382
hack/update-bazel.sh
2021-02-28 15:17:29 -08:00
jialaijun
142e5b05cc
migrate logs.
2021-02-27 17:47:32 +08:00
Benjamin Elder
122966522e
drop obsolete verify-util-pkg.sh
...
https://github.com/kubernetes/test-infra/pull/21037 obsoletes this
2021-02-26 00:03:23 -08:00
Kubernetes Prow Robot
ccf8a2ef4f
Merge pull request #99088 from gavinfish/storage-resize
...
Storage: move filesystem resize code to kubernetes/mount-utils
2021-02-22 17:24:02 -08:00
Kubernetes Prow Robot
03b0ec955a
Merge pull request #98960 from BenTheElder/oom-test-v2
...
fix TestPidListerFailure on cgroupsv2
2021-02-19 22:17:41 -08:00
Dan Winship
95c6a488d8
Make kube-proxy check if IPv6 is really supported before assuming dual-stack
2021-02-17 09:11:15 -05:00
drfish
a04ab9debf
Move filesystem resize code to kubernetes/mount-utils
2021-02-15 16:07:07 +08:00
Antonio Ojea
7223f12f39
don´t leak files on iptables tests
...
the iptables restore function, if it considers that the --wait flag
is not supported, creates a lock file to mimic the iptables behaviour.
The test should take this into account and remove the file.
2021-02-11 00:20:38 +01:00
Benjamin Elder
0156eb179e
fix TestPidListerFailure on cgroupsv2
2021-02-10 00:15:12 -08:00
Artyom Lukianov
7561a0f96e
memory manager: provide new flag var to parse reserved-memory parameter
...
The new flag will parse the `--reserved-memory` flag straight forward
to the []kubeletconfig.MemoryReservation variable instead of parsing
it to the middle map representation.
It gives us possibility to get rid of a lot of unneeded code and use the single
presentation for the reserved-memory.
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
2021-02-09 01:10:01 +02:00
Hanlin Shi
4cd1eacbc1
Add rule to allow healthcheck nodeport traffic in filter table
...
1. For iptables mode, add KUBE-NODEPORTS chain in filter table. Add
rules to allow healthcheck node port traffic.
2. For ipvs mode, add KUBE-NODE-PORT chain in filter table. Add
KUBE-HEALTH-CHECK-NODE-PORT ipset to allow traffic to healthcheck
node port.
2021-02-03 15:20:10 +00:00
Kubernetes Prow Robot
10744811f5
Merge pull request #95701 from masap/ipset2
...
ipset: Address a TODO, add test for netmask
2020-12-08 23:34:50 -08:00
Kubernetes Prow Robot
f8c589e745
Merge pull request #96975 from wangkai1994/master
...
Fix typo in conntrack.go
2020-12-08 21:05:34 -08:00
Kai
03cc04e108
Update conntrack.go
2020-12-01 14:21:47 +08:00
Tim Hockin
f63ca48a1f
Clean up comments around old topology labels
2020-11-12 11:21:38 -08:00
Kubernetes Prow Robot
38f5dc8e7b
Merge pull request #96248 from qingsenLi/201105-IPVSProxyMode
...
Remove Const IPVSProxyMode
2020-11-10 13:41:28 -08:00
Tim Hockin
819ff9b087
Use topology labels instead of old beta names ( #96033 )
...
* Rename const for topology.../zone
* Rename const for topology.../region
* Rename const for failure-domain.../zone
* Rename const for failure-domain.../region
* Restore old names for compat
2020-11-05 20:26:50 -08:00
10177505
2cc888d474
Remove Const IPVSProxyMode
2020-11-05 16:17:18 +08:00
Kubernetes Prow Robot
f3fbd17bc8
Merge pull request #95697 from masap/ipset1
...
ipset: Address a TODO, add test for TestEntry() with IPv6 address
2020-11-04 20:47:05 -08:00
Masashi Honma
c6d2808ad6
ipset: Address a TODO, add test for TestEntry() with IPv6 address
...
This TODO was introduced by
commit 45ad69765e
"wrapper ipset util".
Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
2020-10-22 08:20:24 +09:00
Masashi Honma
4d30435f24
ipset: Address a TODO, add test for netmask
...
This PR removes a TODO comment by adding some netmask tests. The TODO comment
introduced by commit e768924a62
"validate entry in ipset".
// TODO: CIDR /32 may not be valid
The comment says that 32 is invalid netmask, but in reality values from 0 to
32 are valid because the result of the Linux ipset command says so.
$ sudo ipset create foo hash:ip,port,net
$ sudo ipset add foo 10.20.30.40,53,192.168.3.1/33
ipset v7.5: Syntax error: '33' is out of range 0-32
$ sudo ipset --version
ipset v7.5, protocol version: 7
Signed-off-by: Masashi Honma <masashi.honma@gmail.com>
2020-10-19 20:22:02 +09:00
Antonio Ojea
e3c1777f7d
conntrack log delete operations
2020-10-19 10:01:58 +02:00
Dan Winship
971477d9b5
kubelet: Set dual-stack hostNetwork pod IPs on dual-stack nodes
...
Add nodeutil.GetNodeHostIPs to return dual-stack node IPs (in
dual-stack clusters), and make kubelet use it.
2020-10-07 17:26:04 -04:00
Dan Winship
0b43753be7
utilnode: fix incorrect documentation about node name vs hostname
...
(The behavior is unchanged; the function always took a node name
rather than a hostname. Now it just documents that correctly.)
2020-10-07 17:25:56 -04:00
Srini Brahmaroutu
fbe5daed73
Change code to use staging/k8s.io/mount-utils
2020-09-16 21:51:24 -07:00
knight42
ce0a423ef7
test(iptables): deflake TestRestoreAllWaitOldIptablesRestore
...
Signed-off-by: knight42 <anonymousknight96@gmail.com>
2020-09-12 22:43:44 +08:00
knight42
b25af8e3c9
feat(iptables): be able to override iptables-1.4-compatible lock path
2020-09-12 22:43:43 +08:00
knight42
f6f0f7922a
test(iptables): deflake TestRestoreAllGrabOldLock
...
Signed-off-by: knight42 <anonymousknight96@gmail.com>
2020-09-05 01:07:46 +08:00
Luigi Bitonti
19793bd3fa
Update k8s.io/utils dependency and use ebtables from there
2020-07-30 08:58:21 +01:00
Jordan Liggitt
f33dc28094
generated: hack/update-hack-tools.sh && hack/update-vendor.sh
2020-07-25 16:45:02 -04:00
Antonio Ojea
924553b7ee
iptables don't do reverse DNS lookups
...
the iptables monitor was using iptables -L to list the chains,
without the -n option, so it was trying to do reverse DNS lookups.
A side effect is that it was holding the lock, so other components
could not use it.
We can use -S instead of -L -n to avoid this, since we only want
to check the chain exists.
2020-07-08 18:39:22 +02:00
Kubernetes Prow Robot
94e1c54735
Merge pull request #92655 from BenTheElder/cleanup-some-owners
...
Cleanup some owners
2020-07-01 23:14:08 -07:00
Benjamin Elder
2abc8afece
eparis to emeritus
2020-06-30 09:50:44 -07:00
Kubernetes Prow Robot
a5b0e44196
Merge pull request #92440 from luigibk/ebtables-broutetable-and-deleterule
...
Add ebtables rule delete function + broute table + brouting chain
2020-06-29 18:34:26 -07:00
Benjamin Elder
d1ec9b3f9c
fix pkg/util/coverage staticcheck
2020-06-23 18:30:32 -07:00
Luigi Bitonti
51f788c6dc
Add ebtables rule delete function + broute table + brouting chain
2020-06-22 09:07:29 +01:00
Kubernetes Prow Robot
ef198ec7ca
Merge pull request #90316 from tangcong/fix-ipvs-staticheck-err
...
fix ipvs staticcheck error
2020-05-19 20:34:32 -07:00
Kubernetes Prow Robot
b170451caa
Merge pull request #90183 from dims/update-kubernetes-to-klog-v2
...
Update kubernetes to klog v2
2020-05-16 18:59:51 -07:00
Kubernetes Prow Robot
9769e0f5da
Merge pull request #90008 from gavinfish/scheduler-utilparsers
...
Scheduler: remove direct import to /pkg/util/parsers
2020-05-16 07:35:49 -07:00
Davanum Srinivas
07d88617e5
Run hack/update-vendor.sh
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-16 07:54:33 -04:00
Davanum Srinivas
442a69c3bd
switch over k/k to use klog v2
...
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
2020-05-16 07:54:27 -04:00
cici37
7f4d19167e
Move pkg/util/configz to k8s.io/component-base
2020-04-29 12:17:25 -07:00
drfish
0b715ea690
Scheduler: remove direct import to /pkg/util/parsers
2020-04-26 23:41:52 +08:00
Kubernetes Prow Robot
15ed3b36d1
Merge pull request #90235 from cici37/addflag
...
Remove CCM dependency pkg/util/flag
2020-04-22 19:22:14 -07:00
Kubernetes Prow Robot
d2dcd6c399
Merge pull request #89896 from carlosedp/fix-89597
...
Add error messages to IPVS module
2020-04-22 17:02:41 -07:00
Carlos de Paula
b3d84fac52
Add error messages to IPVS module
...
Signed-off-by: Carlos de Paula <me@carlosedp.com>
2020-04-22 15:21:15 -03:00
cici37
15c844031f
Remove CCM dependency pkg/util/flag
2020-04-22 10:06:11 -07:00
Jie Shen
363bb39142
Use utils.net to parse ports instead of atoi ( #89120 )
2020-04-21 20:55:52 -07:00
tangcong
764b902d72
fix ipvs staticcheck error
2020-04-21 07:25:28 +08:00
Steve Azzopardi
4936cd476b
Fix golint issues for pkg/util/rlimit
...
pkg/util/rlimit/rlimit_linux.go:25:1: exported function RlimitNumFiles should have comment or be unexported
pkg/util/rlimit/rlimit_linux.go:25:6: func name will be used as rlimit.RlimitNumFiles by other packages, and that stutters; consider calling this NumFiles
pkg/util/rlimit/rlimit_unsupported.go:25:1: exported function RlimitNumFiles should have comment or be unexported
pkg/util/rlimit/rlimit_unsupported.go:25:6: func name will be used as rlimit.RlimitNumFiles by other packages, and that stutters; consider calling this NumFiles
Ref: https://github.com/kubernetes/kubernetes/issues/68026
2020-04-14 21:00:41 +02:00
Tim Hockin
9551ecb7c3
Cleanup: Change "Ip" to "IP" in func and var names
2020-04-10 15:29:50 -07:00
Tim Hockin
efb24d44c6
Rename iptables IsIpv6 to IsIPv6
2020-04-10 15:29:50 -07:00
Tim Hockin
ef934a2c5e
Add Protocol() method to iptables
...
Enables simpler printing of which IP family the iptables interface is
managing.
2020-04-10 15:29:49 -07:00
Kubernetes Prow Robot
ad4bd386eb
Merge pull request #86752 from SataQiu/fix-kubelet-20191231
...
Add error handler for rlimit.RlimitNumFiles
2020-04-01 22:14:38 -07:00
Kubernetes Prow Robot
c2ae0bd763
Merge pull request #74073 from Nordix/issue-70020
...
Issue #70020 ; Flush Conntrack entities for SCTP
2020-04-01 22:14:24 -07:00
Ricardo Pchevuzinske Katz
5c48f209a5
Update ipvs library to the new repo and upgrade library version
2020-03-26 11:20:01 -03:00
Lars Ekman
aa8521df66
Issue #70020 ; Flush Conntrack entities for SCTP
...
Signed-off-by: Lars Ekman <lars.g.ekman@est.tech>
2020-03-11 09:56:54 +01:00
Kubernetes Prow Robot
e4e3d72f1c
Merge pull request #83572 from chendotjs/tc-fix
...
bandwidth: use regexp to handle tc output and add IPv6 support
2020-03-04 13:18:38 -08:00
chenyaqi01
ef5c920325
bandwidth: use regexp to handle tc output
...
fix newly-added 'chain N' output from 'tc filter show dev XXX'
2020-03-03 20:07:11 +08:00
Clayton Coleman
b252865479
kubelet: Avoid sending no-op patches
...
In an e2e run, out of 1857 pod status updates executed by the
Kubelet 453 (25%) were no-ops - they only contained the UID of
the pod and no status changes. If the patch is a no-op we can
avoid invoking the server and continue.
2020-02-26 23:06:38 -05:00
Satyadeep Musuvathy
8c6956e5bb
Refactor handling of local traffic detection.
2020-02-21 17:57:34 -08:00
Mike Danese
25651408ae
generated: run refactor
2020-02-08 12:30:21 -05:00
Mike Danese
2637772298
some manual fixes
2020-02-07 18:17:40 -08:00
Mike Danese
3aa59f7f30
generated: run refactor
2020-02-07 18:16:47 -08:00
Kubernetes Prow Robot
1735f7a2b6
Merge pull request #87377 from gavinfish/pkg-util-netsh
...
Fix static check errors in pkg/util/netsh
2020-01-21 22:02:35 -08:00
drfish
f19f4e40f9
Fix static check errors in pkg/util/netsh
2020-01-20 13:25:34 +08:00
Guangwen Feng
e2e5bf5e0b
Fix golint warning for pkg/util/procfs/procfs_linux.go
...
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
2020-01-16 15:16:47 +08:00
SataQiu
51c742c1dd
fix staticcheck failures of pkg/util/ipconfig pkg/util/iptables pkg/util/ipvs/testing
2020-01-09 16:05:11 +08:00
SataQiu
2a83443782
add error handler of unix.Setrlimit
2020-01-03 10:49:06 +08:00
Aresforchina
bfc4a7a1c5
fix staticcheck of pkg/util/ebtables
2020-01-02 18:16:50 +08:00
SataQiu
2497a1209b
bump k8s.io/utils version
2019-12-21 14:54:44 +08:00
Kubernetes Prow Robot
e1c7112276
Merge pull request #85517 from andrewsykim/ipvs-timeout
...
support configuration of kube-proxy IPVS tcp,tcpfin,udp timeout
2019-12-17 12:00:43 -08:00
Kubernetes Prow Robot
d0e901807d
Merge pull request #85771 from aojea/iptables_lock
...
Be more agressive acquiring the iptables lock
2019-12-17 08:32:02 -08:00
Kubernetes Prow Robot
fb0956c234
Merge pull request #85016 from hvaara/fix-golint-pkg-util-sysctl-testing
...
Fix golint issues in pkg/util/sysctl/testing
2019-12-17 06:18:13 -08:00
Andrew Sy Kim
db2c048db9
support configuration of kube-proxy IPVS tcp,tcpfin,udp timeout
...
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>
2019-12-17 04:35:08 -05:00
Jordan Liggitt
a65d8aeb76
Add UID precondition to kubelet pod status patch updates
2019-12-16 14:27:32 -05:00
Antonio Ojea
51814ae189
Be more agressive acquiring the iptables lock
...
iptables has two options to modify the behaviour trying to
acquire the lock.
--wait -w [seconds] maximum wait to acquire xtables lock
before give up
--wait-interval -W [usecs] wait time to try to acquire xtables
lock
interval to wait for xtables lock
default is 1 second
Kubernetes uses -w 5 that means that wait 5 seconds to try to
acquire the lock. If we are not able to acquire it, kube-proxy
fails and retries in 30 seconds, that is an important penalty
on sensitive applications.
We can be a bit more aggresive and try to acquire the lock every
100 msec, that means that we have to fail 50 times to not being
able to succeed.
2019-12-03 17:38:13 +01:00
Kubernetes Prow Robot
c58b63267c
Merge pull request #85562 from gkarthiks/master
...
golint fixes for /pkg/util/iptables/testing
2019-11-27 10:46:45 -08:00
Kubernetes Prow Robot
7ed5eb6dcc
Merge pull request #81880 from MikeSpreitzer/fix81879
...
Bumped the number of times a node tries to lookup itself
2019-11-27 03:07:20 -08:00
gkarthiks
c38e79e76d
refactor: incorporated the review comments
...
Signed-off-by: gkarthiks <github.gkarthiks@gmail.com>
2019-11-24 11:46:57 -08:00
gkarthiks
a4abc1dd4d
refactor(golint): lint fixes for iptables test file
...
Signed-off-by: gkarthiks <github.gkarthiks@gmail.com>
2019-11-22 19:58:56 -08:00
gkarthiks
b05749c619
chore(gofmt): go format fix
...
Signed-off-by: gkarthiks <github.gkarthiks@gmail.com>
2019-11-19 08:30:16 -08:00
Karthikeyan Govindaraj
a4631c845e
chore(lint): lint fix in /pkg/util/iptables
2019-11-18 23:44:49 -08:00
Karthikeyan Govindaraj
bdc11c2806
chore(lint): fix iptable.go file lint
2019-11-18 23:43:51 -08:00
Travis Rhoden
0c5c3d8bb9
Remove pkg/util/mount (moved out of tree)
...
This patch removes pkg/util/mount completely, and replaces it with the
mount package now located at k8s.io/utils/mount. The code found at
k8s.io/utils/mount was moved there from pkg/util/mount, so the code is
identical, just no longer in-tree to k/k.
2019-11-15 08:29:12 -07:00