Commit Graph

253 Commits

Author SHA1 Message Date
Kubernetes Prow Robot
1c18c3263a
Merge pull request #77386 from SataQiu/fix-shellcheck-20190503
Fix shellcheck failures of cluster/gce/upgrade-aliases.sh
2019-05-10 21:30:24 -07:00
Kubernetes Prow Robot
07e3b7cdca
Merge pull request #74639 from xychu/fix-shellchecks-a
Make test/cmd/a*.sh pass shellcheck
2019-05-10 10:38:12 -07:00
toyoda
bbe4a9fdc5 fix shellcheck failures in /hack/make-rules/clean.sh,test.sh,vet.sh 2019-05-09 13:40:35 +09:00
toyoda
9a5655c915 fix shellcheck failures in /hack/make-rules/update.sh,verify.sh 2019-05-07 14:27:26 +09:00
s-ito-ts
beca6c7c02 fix shellcheck failures in /hack/verify-[a-g]*.sh. 2019-05-07 02:32:54 +00:00
SataQiu
2ba0231670 fix shellcheck failures of cluster/gce/upgrade-aliases.sh 2019-05-03 17:01:15 +08:00
Kubernetes Prow Robot
855c291cb8
Merge pull request #76858 from SataQiu/fix-cluster-clientbin-20190420
Fix shellcheck failures of cluster/clientbin.sh
2019-04-29 07:46:22 -07:00
Kubernetes Prow Robot
2dc3509b6d
Merge pull request #76867 from xichengliudui/fixshellcheckfailures-29
fix shellcheck failures on vet.sh
2019-04-27 16:48:21 -07:00
aaa
a4a4abd428 update pull request
update pull request on vet.sh
2019-04-27 10:56:43 -04:00
SataQiu
aacab2ee75 fix shellcheck failures of cluster/clientbin.sh 2019-04-26 18:43:33 +08:00
Xiangyang Chu
2260cc29b9 Make test/cmd/a*.sh pass shellcheck 2019-04-26 11:39:11 +08:00
Kubernetes Prow Robot
5ab36f8cee
Merge pull request #77055 from SataQiu/fix-shell-20190426
Fix shellcheck failures of hack/verify-no-vendor-cycles.sh
2019-04-25 16:11:02 -07:00
SataQiu
e25e5a63e7 fix shellcheck failures of hack/verify-no-vendor-cycles.sh 2019-04-26 00:19:07 +08:00
Kubernetes Prow Robot
78190f0758
Merge pull request #76881 from xichengliudui/fixshellcheckfailures-30
fix shellcheck failures list-resources.sh
2019-04-25 02:00:47 -07:00
Kubernetes Prow Robot
6c664746e4
Merge pull request #76840 from xichengliudui/fixshellcheckfailures-26
Fix shellcheck failures on clean.sh and cache_go_dirs.sh
2019-04-24 23:04:56 -07:00
aaa
c4898d6f56 fix shellcheck failures list-resources.sh
update pull request

update pull request

update pull request
2019-04-21 18:17:44 -04:00
aaa
2fb859db42 Fix shellcheck failures on
update pull request

update pull request
2019-04-21 12:40:12 -04:00
Kubernetes Prow Robot
c7cd03cc38
Merge pull request #76900 from SataQiu/fix-shellcheck-test-20190422
Fix shellcheck failures of test/e2e_node/environment/setup_host.sh
2019-04-23 23:50:39 -07:00
Kubernetes Prow Robot
a73980e1e6
Merge pull request #76855 from SataQiu/fix-hack-shell-20190420
fix bug of hack/verify-test-featuregates.sh
2019-04-23 23:50:27 -07:00
Kubernetes Prow Robot
19b96c968c
Merge pull request #76812 from SataQiu/fix-hack-shellcheck-2019041904
Fix shellcheck failures of hack/grab-profiles.sh
2019-04-23 23:50:16 -07:00
Kubernetes Prow Robot
2c2e7a01bb
Merge pull request #76655 from SataQiu/fix-shell-cluster-20190417
Fix shellcheck failures of cluster/gce/gci/shutdown.sh
2019-04-23 23:50:04 -07:00
SataQiu
58caa7474f fix bug of hack/verify-test-featuregates.sh 2019-04-24 11:30:28 +08:00
Kubernetes Prow Robot
e6390ce3ff
Merge pull request #76835 from SataQiu/fix-shellcheck-hack-20190420
Fix shellcheck failures of hack/verify-boilerplate.sh verify-cli-conventions.sh verify-codegen.sh
2019-04-23 03:14:12 -07:00
SataQiu
2704abf844 fix shellcheck failures of hack/verify-boilerplate.sh verify-cli-conventions.sh verify-codegen.sh 2019-04-23 13:39:00 +08:00
Kubernetes Prow Robot
b57387b333
Merge pull request #76767 from SataQiu/fix-shellcheck-20190418
Fix shellcheck failures of hack/verify-openapi-spec.sh
2019-04-22 13:17:46 -07:00
Kubernetes Prow Robot
dc395391bc
Merge pull request #76834 from SataQiu/fix-hack-shell-2019041905
Fix bug and golint failures of hack/verify-api-groups.sh
2019-04-22 10:44:00 -07:00
SataQiu
741caa4475 fix bug and golint failures of hack/verify-api-groups.sh 2019-04-22 22:20:04 +08:00
SataQiu
c892beca8b fix shellcheck failures of test/e2e_node/environment/setup_host.sh 2019-04-22 22:08:26 +08:00
SataQiu
903c5a53b3 fix shellcheck failures of cluster/gce/gci/shutdown.sh 2019-04-22 11:46:45 +08:00
SataQiu
b4bc5cb4fe
Merge branch 'master' into fix-shellcheck-20190418 2019-04-22 11:32:17 +08:00
Kubernetes Prow Robot
75d45bdfc9
Merge pull request #76856 from SataQiu/fix-hack-cherrypick-20190420
Fix shellcheck failures of hack/cherry_pick_pull.sh
2019-04-21 09:25:44 -07:00
aaa
5f719707f2 Fix shellcheck failures on clean.sh and cache_go_dirs.sh
update pull request
2019-04-21 06:24:08 -04:00
aaa
5c8ec1ce9c fix shellcheck failures
update pull request

update pull request
2019-04-20 05:08:00 -04:00
SataQiu
e7e517434b fix shellcheck failures of hack/cherry_pick_pull.sh 2019-04-20 15:49:34 +08:00
aaa
ad5bccc510 fix shellcheck in test-smoke.sh and test-network.sh
update pull request

update pull request

update pull request

update pull request
2019-04-19 16:15:10 -04:00
aaa
e05f85a611 Fix shellcheck failures on verify-readonly-packages.sh 2019-04-19 14:59:50 -04:00
Kubernetes Prow Robot
e4f9d8fe3f
Merge pull request #76331 from xichengliudui/fixshellcheckfailures-17
Fix shellcheck failures in stage-upload.sh
2019-04-19 09:47:55 -07:00
SataQiu
a20aec8d2d fix shellcheck failures of hack/verify-openapi-spec.sh 2019-04-19 23:28:34 +08:00
SataQiu
14775c4057 fix shellcheck failures of hack/grab-profiles.sh 2019-04-19 22:19:41 +08:00
Kubernetes Prow Robot
3b12266c06
Merge pull request #76803 from cblecker/goldflags-fix
Fix shellcheck in hack/lib/golang.sh
2019-04-19 05:53:56 -07:00
Kubernetes Prow Robot
b54053924e
Merge pull request #76810 from SataQiu/fix-hack-shellcheck-2019041903
Fix shellcheck failures of hack/test-update-storage-objects.sh
2019-04-19 01:06:13 -07:00
SataQiu
4d6319b9b2 fix shellcheck failures of hack/test-update-storage-objects.sh 2019-04-19 20:00:58 +08:00
Kubernetes Prow Robot
3cbb20c694
Merge pull request #76809 from SataQiu/fix-hack-shellcheck-2019041902
Fix shellcheck failures of hack/verify-description.sh and hack/verify-import-boss.sh
2019-04-18 23:40:26 -07:00
SataQiu
04ab994cc3 fix shellcheck failures of hack/verify-description.sh and hack/verify-import-boss.sh 2019-04-19 18:59:24 +08:00
Kubernetes Prow Robot
f0022d87e5
Merge pull request #76744 from xichengliudui/fixshellcheckfailures-25
Fix shellcheck failures on test-e2e-node.sh and test-integration.sh
2019-04-18 23:40:10 -07:00
Christoph Blecker
4543e68ae5
Fix shellcheck in hack/lib/golang.sh 2019-04-18 18:53:13 -07:00
Kubernetes Prow Robot
d308368b2d
Merge pull request #76417 from SataQiu/fix-shell-update-generated-runtime-dockerized-20190411
Fix shellcheck failures of hack/update-generated-runtime-dockerized.sh
2019-04-18 14:27:54 -07:00
SataQiu
bd7f7fefae fix shellcheck failures of hack/update-generated-runtime-dockerized.sh 2019-04-18 22:36:22 +08:00
Davanum Srinivas
7e01702a88
Move "-s -w" flags to GOLDFLAGS as an overridable default.
If GOLDFLAGS is set, whether it is empty or not, we should honor it.
Only if the GOLDFLAGS is totally not set, then we use "-s -w"

See Parameter Expansion section in the urls below:

https://stackoverflow.com/questions/3601515/how-to-check-if-a-variable-is-set-in-bash/16753536
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_02

Change-Id: I826c34efc63c77f0e3e9677fff30a3eb2219a377
2019-04-17 21:55:13 -04:00
Kubernetes Prow Robot
f625bef870
Merge pull request #76478 from SataQiu/fix-shell-hack-20190412
Fix shellcheck failures of hack/update-generated-kms-dockerized.sh and hack/update-generated-protobuf-dockerized.sh
2019-04-17 12:16:36 -07:00
Kubernetes Prow Robot
c3bec0bae4
Merge pull request #74601 from mrbobbytables/fix-test-image-shellcheck
Fix shellcheck lint errors in test/images/* scripts
2019-04-17 02:22:03 -07:00
Kubernetes Prow Robot
123b9c9e10
Merge pull request #76313 from SataQiu/fix-hack-2019040902
Fix shellcheck failures of hack/update-openapi-spec.sh
2019-04-16 10:27:10 -07:00
Bob Killen
5518defffc
Fix shellcheck lint errors in test/images/volume/nfs/run_nfs.sh 2019-04-15 20:02:03 -04:00
Bob Killen
f795e22932
Fix shellcheck lint errors in test/images/volume/iscsi/create_block.sh 2019-04-15 20:01:25 -04:00
Bob Killen
346bcdaa27
Fix shellcheck lint errors in test/images/volume/gluster/run_gluster.sh 2019-04-15 20:01:25 -04:00
Kubernetes Prow Robot
8d38f3f2cf
Merge pull request #75795 from mrbobbytables/shellcheck-ignore-third-party
Update hack/verify-shellcheck.sh to ignore ./third_party/*
2019-04-15 13:11:08 -07:00
SataQiu
142e458a97 fix shellcheck failures of hack/update-openapi-spec.sh 2019-04-16 03:40:56 +08:00
Jordan Liggitt
77690137a9 propagate pinned versions to staging repos, output cleanup commands 2019-04-15 11:30:07 -04:00
SataQiu
db8bc68946 fix shellcheck failures of hack/update-generated-kms-dockerized.sh hack/update-generated-protobuf-dockerized.sh 2019-04-15 01:57:36 +08:00
SataQiu
d735aaadd6 fix shellcheck failures of zookeeper-installer/install.sh zookeeper-installer/on-start.sh 2019-04-14 07:07:50 +08:00
Bob Killen
db01d68d05
Update hack/verify-shellcheck.sh to ignore ./third_party/*
The ./third_party/* directory contains scripts, libraries and
other components from external sources. These should be omitted
from lints and checks with the exception of things that are
forked and modified (located in ./third_party/forked/*) for
project related reasons.
2019-04-13 16:58:20 -04:00
Kubernetes Prow Robot
a08107fe99
Merge pull request #76482 from SataQiu/fix-shell-hack-2019041202
Fix shellcheck failures of hack/update-codegen.sh
2019-04-12 18:08:18 -07:00
Kubernetes Prow Robot
90a939ec33
Merge pull request #76131 from SataQiu/fix-hack-20190404
Fix shellcheck failures of hack/lib/logging.sh hack/lib/protoc.sh
2019-04-12 15:56:45 -07:00
Kubernetes Prow Robot
969c1106f1
Merge pull request #76084 from SataQiu/fix-shell-20190403
Fix shellcheck failures of test/images/pets/redis-installer/on-start.sh
2019-04-12 15:56:32 -07:00
Kubernetes Prow Robot
5b434eefc3
Merge pull request #74180 from mrbobbytables/fix-third-party-shellcheck
Fix shellcheck lint errors in third_party/* scripts
2019-04-12 06:14:46 -07:00
SataQiu
9863f26706 fix shellcheck failures of hack/update-codegen.sh 2019-04-12 19:15:56 +08:00
SataQiu
4231fa0980 fix shellcheck failures of hack/lib/logging.sh hack/lib/protoc.sh 2019-04-12 16:00:23 +08:00
aaa
9768ba9eb3 Fix shellcheck failures in stage-upload.sh
update pull request

update pull request

update pull request

update pull request
2019-04-12 02:42:48 -04:00
aaa
7a39c99297 Fix shellcheck failures on test-e2e-node.sh and test-integration.sh 2019-04-11 13:47:34 -04:00
Bob Killen
9e719d8d9c
Fix shellcheck lint errors in third_party/forked/shell2junit/sh2ju.sh 2019-04-11 10:25:41 -07:00
SataQiu
10b52bae28
Merge branch 'master' into fix-hack-2019040903 2019-04-11 23:29:10 +08:00
Kubernetes Prow Robot
ef830e2bcf
Merge pull request #76311 from SataQiu/fix-hack-20190409
Fix shellcheck failures of hack/update-vendor-licenses.sh
2019-04-10 22:42:21 -07:00
SataQiu
67509020ca fix shellcheck failures of hack/update-vendor-licenses.sh 2019-04-09 13:47:30 +08:00
SataQiu
0f09703c48 fix shellcheck failures of hack/update-gofmt.sh hack/update-translations.sh 2019-04-09 12:30:58 +08:00
Kubernetes Prow Robot
fbc28fd15f
Merge pull request #76280 from xichengliudui/fixshellcheck0409
Fix shellcheck failures in update-workspace-mirror.sh
2019-04-08 20:29:18 -07:00
aaa
961f1621aa Fix shellcheck failures in update-workspace-mirror.sh 2019-04-08 14:40:26 -04:00
aaa
e544da8aae Fix shellcheck failures in test-dockerized.sh and upload-to-gcs.sh
update pull request

update pull request
2019-04-08 14:14:47 -04:00
Kubernetes Prow Robot
f873d2a056
Merge pull request #75862 from xichengliudui/fixshellcheckfailures
Fix shellcheck failures in bootstrap.sh and create_block.sh
2019-04-07 21:52:24 -07:00
Kubernetes Prow Robot
87247f5357
Merge pull request #75915 from xichengliudui/fixshellcheckfailures-05
fix shellcheck failures in ./hack/jenkins/...
2019-04-04 22:31:19 -07:00
Jordan Liggitt
2ea3cbdcbc Update hack scripts to use go mod 2019-04-03 10:19:39 -04:00
SataQiu
b732a53c6b fix shellcheck failures of test/images/pets/redis-installer/on-start.sh 2019-04-03 21:55:05 +08:00
Kubernetes Prow Robot
997d5182d0
Merge pull request #75662 from s-ito-ts/shellcheck_local-up-cluster.sh
fix shellcheck failures in hack/local-up-cluster.sh
2019-03-31 18:24:32 -07:00
s-ito-ts
8cc3718e69 fix eliminate shellcheck failures in hack/local-up-cluster.sh 2019-03-25 07:17:06 +00:00
Kubernetes Prow Robot
fcb102b2a4
Merge pull request #75158 from k-toyoda-pi/fix_shellcheck_failure_golang_sh
fix eliminate shellcheck failures in hack/lib/golang.sh
2019-03-22 14:09:37 -07:00
Kubernetes Prow Robot
51b5d28c15
Merge pull request #74333 from SataQiu/fix-shell-20190221
Fix some shellcheck failures in hack
2019-03-21 22:50:18 -07:00
Kubernetes Prow Robot
4c16fb78b3
Merge pull request #74242 from xichengliudui/fixshellcheck19021903
fix shellcheck in hack/make-rules/...
2019-03-21 21:36:17 -07:00
toyoda
a52af3a9d5 fix shellcheck failure golang.sh 2019-03-22 13:29:26 +09:00
aaa
64f8f30c07 fix shellcheck failures in ./hack/jenkins/... 2019-03-21 05:30:11 -04:00
aaa
f82870291f Fix shellcheck failures in godep-save.sh and godep-restore.sh
update pull request

update pull request
2019-03-21 05:02:47 -04:00
aaa
46799b6dd4 Fix shellcheck failures in bootstrap.sh and create_block.sh 2019-03-20 17:37:50 -04:00
Kubernetes Prow Robot
b4e692b68f
Merge pull request #74854 from neolit123/conformance-nodes
conformace/run_e2e.sh: pass shellcheck and autodetect ginkgo nodes
2019-03-05 09:50:12 -08:00
Lubomir I. Ivanov
fe2301f17d conformace/run_e2e.sh: pass shellcheck and autodetect ginkgo nodes
- for ginkgo parallel mode pass -p to autodetect ginkgo nodes.
- disable parallel mode by default (false).
- use provider "skeleton" instead of "local".
- make run_e2e.sh pass shellcheck.
2019-03-05 01:32:57 +02:00
Ismo Puustinen
f7e1058c98 shellcheck failures: remove hack/lib/util.sh 2019-03-04 23:23:20 +02:00
Kubernetes Prow Robot
8acb522c03
Merge pull request #74488 from xichengliudui/fixshellcheck19022502
fix shellcheck in test/e2e_node/jenkins/...
2019-03-01 12:49:08 -08:00
Xiangyang Chu
53c1fcf2c6 Fix shellchecks follow the ${var:?} pattern 2019-02-27 09:27:13 +08:00
Kubernetes Prow Robot
736baa5e33
Merge pull request #73593 from danielqsj/etcd
fix shellcheck failure in etcd shell
2019-02-25 23:11:50 -08:00
xichengliudui
4b38978329 fix shellcheck in test/e2e_node/jenkins/...
update pull request
2019-02-26 01:01:48 -05:00
xichengliudui
ec5fddfe4f fix shellcheck in hack/make-rules/...
update pull request

update pull request

update pull request

update pull request

update pull request

update pull request

update pull request

update pull request
2019-02-26 00:56:36 -05:00
SataQiu
c6ae694b79 fix some shellcheck failures in hack 2019-02-26 12:45:38 +08:00
Kubernetes Prow Robot
483d19ccc4
Merge pull request #74420 from mattjmcnaughton/mattjmcnaughton/fix-shellcheck-for-more-scripts-in-hack
Fix shellcheck for more scripts in hack
2019-02-25 17:25:23 -08:00