Commit Graph

11188 Commits

Author SHA1 Message Date
David Eads
d503cba375 improve e2e namespace dumping on failure 2019-05-10 10:11:24 -04:00
W. Trevor King
96b04bfeac test/e2e/upgrades/apps/job: List Pods in failure message
Currently, this test can fail with the not-very-helpful [1,2]:

  fail [k8s.io/kubernetes/test/e2e/upgrades/apps/job.go:58]: Expected
      <bool>: false
  to be true

Since this test is the only CheckForAllJobPodsRunning consumer, and
has been since CheckForAllJobPodsRunning landed in 116eda0909
(Implements an upgrade test for Job, 2017-02-22, #41271), this commit
refactors the function to EnsureJobPodsRunning, dropping the opaque
boolean, and constructing a useful error summarizing the divergence
from the expected parallelism and the status of listed Pods.

Thanks to Maciej Szulik for the fixups [3] :).

[1]: https://storage.googleapis.com/origin-ci-test/logs/release-openshift-origin-installer-e2e-aws-upgrade/1434/build-log.txt
[2]: https://bugzilla.redhat.com/show_bug.cgi?id=1708454#c0
[3]: https://github.com/wking/kubernetes/pull/1
2019-05-10 06:09:36 -07:00
loic le dru
61731dd1d1 e2e-test logf instead framework.logf 2019-05-10 14:18:55 +02:00
danielqsj
629ec7e113 replace test error checking with more readable way 2019-05-10 13:58:09 +08:00
danielqsj
1058877fbf remove dot imports in e2e/storage 2019-05-10 13:56:26 +08:00
danielqsj
8a6fede9e6 remove dot imports in e2e/storage/vsphere 2019-05-10 13:56:16 +08:00
danielqsj
f3ea5e5c94 replace test error checking with more readable way 2019-05-10 10:15:45 +08:00
draveness
c045046e5b feat: use framework.ExpectNoError instead in e2e test 2019-05-10 09:53:10 +08:00
Akihito INOH
be4af8f83f Use framework.ExpectNoError() for e2e/lifecycle
The e2e test framework has ExpectNoError() for readable test code.
This replaces Expect(err).NotTo(HaveOccurred()) with it for e2e/lifecycle.
2019-05-10 10:45:32 +09:00
Kubernetes Prow Robot
69b52633cc Merge pull request #77605 from pohly/multivolume-storage-class-fix
Multivolume storage class fix
2019-05-09 15:48:22 -07:00
Kubernetes Prow Robot
b27fe7f4b9 Merge pull request #74314 from oomichi/add-ExpectError
Add ExpectError() to e2e test framework
2019-05-09 15:47:57 -07:00
Kenichi Omichi
2a7202b71f Use framework.ExpectNoError() for e2e/
The e2e test framework has ExpectNoError() for readable test code.
This replaces Expect(err).NotTo(HaveOccurred()) with it.
2019-05-09 19:26:16 +00:00
Kubernetes Prow Robot
524169fe1c Merge pull request #77005 from k-toyoda-pi/e2e_add_check_pod_in_job
[e2e] add pod status check after job completes in job test
2019-05-09 06:20:48 -07:00
Patrick Ohly
093027c891 e2e/storage: ensure that also external storage classes are unique
One previously undocumented expectation is that
GetDynamicProvisionStorageClass can be called more than once per test
and then each time returns a new, unique storage class. The in-memory
implementation in driveroperations.go:GetStorageClass ensured that,
but loading from a .yaml file didn't. This caused the multivolume tests
to fail when applied to an already installed GCE driver with the
-storage.testdriver parameter.
2019-05-09 08:53:25 +02:00
Kubernetes Prow Robot
ee0038adaa Merge pull request #77425 from figo/e2e
Modify apimachinery,apps,instrumentation tests to import framework/log
2019-05-08 21:48:47 -07:00
Kubernetes Prow Robot
b6887e3915 Merge pull request #77530 from seans3/unexport-print-table
Unexport PrintTable function
2019-05-08 17:15:26 -07:00
hui luo
4d4e4f4056 Modify apimachinery,apps,instrumentation tests to import framework/log
This is part of the transition to using framework/log instead
of the Logf inside the framework package. This will help with
import size/cycles when importing the framework or subpackages
2019-05-08 16:46:39 -07:00
Kubernetes Prow Robot
71bbabc36b Merge pull request #77486 from jiatongw/logf/kubectl
Modify e2e/kubectl tests to import e2elog.Logf
2019-05-08 14:32:45 -07:00
Kubernetes Prow Robot
b3875556b0 Merge pull request #77336 from johnSchnake/refactorFrameworkSSH
Move ssh code to new package
2019-05-08 13:06:47 -07:00
Kenichi Omichi
436544488b Add ExpectError() to e2e test framework
There is a lot of gomega.Expect(err).To(gomega.HaveOccurred()) callers
which expect an error happens in e2e tests.
However these test code seems confusing because the code readers
need to take care of To() or NotTo() on each test scenario.
This adds ExpectError() for more readable test code.
In addition, this applies ExpectError() to e2e provisioning.go as a
sample.
2019-05-08 17:40:12 +00:00
Daniel (Shijun) Qian
5268f69405 fix duplicated imports of k8s code (#77484)
* fix duplicated imports of api/core/v1

* fix duplicated imports of client-go/kubernetes

* fix duplicated imports of rest code

* change import name to more reasonable
2019-05-08 10:12:47 -07:00
Kubernetes Prow Robot
f7d92fb963 Merge pull request #77427 from draveness/feature/use-logf-in-log-pkg
refactor: use e2elog.Logf instead of framework.Logf
2019-05-08 10:12:34 -07:00
John Schnake
338bc3ce42 Move framework ssh code to new package
The framework/ssh.go code was heavily used throughout the framework
and could be useful elsewhere but reusing those methods requires
importing all of the framework.

Extracting these methods to their own package for reuse.

Only a few methods had to be copied into this package from the
rest of the framework to avoid an import cycle.
2019-05-08 11:00:36 -05:00
Patrick Ohly
62c5c6345e Revert "Make external driver storage class name generation contain a more random suffix in case of double generation in the same framework context (twice in the same test)"
This reverts commit c50e7fd301 because
it included API changes that shouldn't have been in that PR and
fixing the storage class conflict inside the framework is probably the
wrong place.
2019-05-08 17:28:13 +02:00
Kubernetes Prow Robot
086a86b9e2 Merge pull request #77525 from davidz627/fix/externalMulti
Make external driver name generation contain a more random suffix in case of double generation in the same framework context (twice in the same test)
2019-05-08 04:54:48 -07:00
Kubernetes Prow Robot
873e7a3259 Merge pull request #77533 from jiatongw/logf/lifecycle
Modify e2e/lifecycle tests to import e2elog.Logf
2019-05-07 22:14:58 -07:00
Kubernetes Prow Robot
11a46d2515 Merge pull request #77479 from danielqsj/id
fix increment-decrement lint error
2019-05-07 22:14:45 -07:00
Kubernetes Prow Robot
7aa57df279 Merge pull request #77374 from cheftako/gce-staging
Staging the GCE Cloud Provider
2019-05-07 17:52:32 -07:00
Kubernetes Prow Robot
b4262e9a22 Merge pull request #77408 from johnSchnake/frameworkLogRefactoringCommonScaleUpgrades
Move scalability, upgrade, and common packages to framework/log
2019-05-07 15:54:46 -07:00
David Zhu
c50e7fd301 Make external driver storage class name generation contain a more random suffix in case of double generation in the same framework context (twice in the same test) 2019-05-07 14:37:06 -07:00
Kubernetes Prow Robot
eacae8540a Merge pull request #76508 from bclau/tests/agnhost-custom-dns-test
tests: Adds configurable pod DNS nameservers and search list test
2019-05-07 14:30:49 -07:00
Walter Fender
796097ae40 Staging the GCE Cloud Provider
**What type of PR is this?**
/kind cleanup

**What this PR does / why we need it**:
Staging the GCE Cloud Provider as part of KEP [20190125-removing-in-tree-providers](https://github.com/kubernetes/enhancements/blob/master/keps/sig-cloud-provider/20190125-removing-in-tree-providers.md). Staging repo setup here https://github.com/kubernetes/legacy-cloud-providers
Moves the GCE cloud provider implementation to staging.
This is in preparation for moving the cloud provider code out of tree entirely.
However we need it in staging while the code needs to be consumed both in/out of tree.

**Which issue(s) this PR fixes**:
Fixes #

**Special notes for your reviewer**:

**Does this PR introduce a user-facing change?**:

```
NONE
```

Updated import dependency tracking.
Factored in the cleanup from #77412
Minor fix to go.mod.
2019-05-07 13:17:52 -07:00
Kubernetes Prow Robot
19ed7fa731 Merge pull request #77113 from s-ito-ts/77103_autoscaling
Use framework.ExpectNoError() for e2e/autoscaling
2019-05-07 08:16:09 -07:00
Kubernetes Prow Robot
8fa775e546 Merge pull request #75187 from subramanian-neelakantan/host_to_create_volume
Use any host that mounts the datastore to create Volume
2019-05-07 08:15:54 -07:00
Kubernetes Prow Robot
db44f31bff Merge pull request #74705 from johscheuer/remove-dead-csi-e2e-code
Remove unused code from CSI e2e tests
2019-05-07 00:23:41 -07:00
Jiatong Wang
b26b6f0d5c Modify e2e/lifecycle tests to import e2elog.Logf
Signed-off-by: Jiatong Wang <wangjiatong@vmware.com>
2019-05-07 00:23:13 -07:00
Kubernetes Prow Robot
1fb8ed12a2 Merge pull request #75993 from caesarxuchao/add-count
Adding RemainingItemCount to ListMeta
2019-05-06 22:53:40 -07:00
Sean Sullivan
41b84b7f6e Unexport PrintTable function 2019-05-06 22:16:45 -07:00
toyoda
8afecb8c30 add pod status check after job completes in job e2e test 2019-05-07 11:47:56 +09:00
Kubernetes Prow Robot
d2b8f3e145 Merge pull request #77034 from atoato88/fix-golint-e2e-framework-providers-gce
Fix golint failures of e2e/framework/providers/gce/recreate_node.go
2019-05-06 19:17:40 -07:00
draveness
da7507500f refactor: use e2elog.Logf instead of framework.Logf 2019-05-07 08:15:31 +08:00
Kubernetes Prow Robot
a9fc9754bb Merge pull request #77413 from johnSchnake/frameworkLogRefactoringnodeWindowsAutoscale
Move node, windows, and autoscaling tests to framework/log
2019-05-06 17:07:53 -07:00
Kubernetes Prow Robot
c9dda348e3 Merge pull request #77016 from jiatongw/e2e/framework/upgrade
[e2e] Move framework/upgrade_util.go to framework/lifecycle/upgrade.go
2019-05-06 17:07:41 -07:00
Johannes M. Scheuermann
d59c67871c Remove unused code from CSI e2e tests 2019-05-06 21:59:09 +02:00
Chao Xu
58c18309a8 Add RemainingItemCount to ListMeta 2019-05-06 12:58:51 -07:00
Mike Crute
6f5cf1a6e0 Staging legacy AWS cloud provider 2019-05-06 09:34:13 -07:00
Kubernetes Prow Robot
ad57e7408d Merge pull request #77481 from danielqsj/fu
remove redundant else block
2019-05-06 06:53:53 -07:00
Mayank Gaikwad
831939b65e Add subdomain to verify dns resolution by subdomain 2019-05-06 16:47:02 +05:30
Jiatong Wang
3b5bedd7cf Modify e2e/kubectl tests to import e2elog.Log
Signed-off-by: Jiatong Wang <wangjiatong@vmware.com>
2019-05-06 00:23:59 -07:00
danielqsj
6fc04b696c remove redundant else block 2019-05-06 13:43:33 +08:00