/* Copyright 2016 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package rbac import ( "fmt" "strings" "testing" "k8s.io/kubernetes/pkg/api" "k8s.io/kubernetes/pkg/apis/rbac" "k8s.io/kubernetes/pkg/apis/rbac/validation" "k8s.io/kubernetes/pkg/auth/authorizer" "k8s.io/kubernetes/pkg/auth/user" ) func newRule(verbs, apiGroups, resources, nonResourceURLs string) rbac.PolicyRule { return rbac.PolicyRule{ Verbs: strings.Split(verbs, ","), APIGroups: strings.Split(apiGroups, ","), Resources: strings.Split(resources, ","), NonResourceURLs: strings.Split(nonResourceURLs, ","), } } func newRole(name, namespace string, rules ...rbac.PolicyRule) rbac.Role { return rbac.Role{ObjectMeta: api.ObjectMeta{Namespace: namespace, Name: name}, Rules: rules} } func newClusterRole(name string, rules ...rbac.PolicyRule) rbac.ClusterRole { return rbac.ClusterRole{ObjectMeta: api.ObjectMeta{Name: name}, Rules: rules} } const ( bindToRole uint16 = 0x0 bindToClusterRole uint16 = 0x1 ) func newClusterRoleBinding(roleName string, subjects ...string) rbac.ClusterRoleBinding { r := rbac.ClusterRoleBinding{ ObjectMeta: api.ObjectMeta{}, RoleRef: api.ObjectReference{ Kind: "ClusterRole", // ClusterRoleBindings can only refer to ClusterRole Name: roleName, }, } r.Subjects = make([]rbac.Subject, len(subjects)) for i, subject := range subjects { split := strings.SplitN(subject, ":", 2) r.Subjects[i].Kind, r.Subjects[i].Name = split[0], split[1] } return r } func newRoleBinding(namespace, roleName string, bindType uint16, subjects ...string) rbac.RoleBinding { r := rbac.RoleBinding{ObjectMeta: api.ObjectMeta{Namespace: namespace}} switch bindType { case bindToRole: r.RoleRef = api.ObjectReference{Kind: "Role", Namespace: namespace, Name: roleName} case bindToClusterRole: r.RoleRef = api.ObjectReference{Kind: "ClusterRole", Name: roleName} } r.Subjects = make([]rbac.Subject, len(subjects)) for i, subject := range subjects { split := strings.SplitN(subject, ":", 2) r.Subjects[i].Kind, r.Subjects[i].Name = split[0], split[1] } return r } type defaultAttributes struct { user string groups string verb string resource string namespace string apiGroup string } func (d *defaultAttributes) String() string { return fmt.Sprintf("user=(%s), groups=(%s), verb=(%s), resource=(%s), namespace=(%s), apiGroup=(%s)", d.user, strings.Split(d.groups, ","), d.verb, d.resource, d.namespace, d.apiGroup) } func (d *defaultAttributes) GetUser() user.Info { return &user.DefaultInfo{Name: d.user, Groups: strings.Split(d.groups, ",")} } func (d *defaultAttributes) GetVerb() string { return d.verb } func (d *defaultAttributes) IsReadOnly() bool { return d.verb == "get" || d.verb == "watch" } func (d *defaultAttributes) GetNamespace() string { return d.namespace } func (d *defaultAttributes) GetResource() string { return d.resource } func (d *defaultAttributes) GetSubresource() string { return "" } func (d *defaultAttributes) GetName() string { return "" } func (d *defaultAttributes) GetAPIGroup() string { return d.apiGroup } func (d *defaultAttributes) GetAPIVersion() string { return "" } func (d *defaultAttributes) IsResourceRequest() bool { return true } func (d *defaultAttributes) GetPath() string { return "" } func TestAuthorizer(t *testing.T) { tests := []struct { roles []rbac.Role roleBindings []rbac.RoleBinding clusterRoles []rbac.ClusterRole clusterRoleBindings []rbac.ClusterRoleBinding superUser string shouldPass []authorizer.Attributes shouldFail []authorizer.Attributes }{ { clusterRoles: []rbac.ClusterRole{ newClusterRole("admin", newRule("*", "*", "*", "*")), }, roleBindings: []rbac.RoleBinding{ newRoleBinding("ns1", "admin", bindToClusterRole, "User:admin", "Group:admins"), }, shouldPass: []authorizer.Attributes{ &defaultAttributes{"admin", "", "get", "Pods", "ns1", ""}, &defaultAttributes{"admin", "", "watch", "Pods", "ns1", ""}, &defaultAttributes{"admin", "group1", "watch", "Foobar", "ns1", ""}, &defaultAttributes{"joe", "admins", "watch", "Foobar", "ns1", ""}, &defaultAttributes{"joe", "group1,admins", "watch", "Foobar", "ns1", ""}, }, shouldFail: []authorizer.Attributes{ &defaultAttributes{"admin", "", "GET", "Pods", "ns2", ""}, &defaultAttributes{"admin", "", "GET", "Nodes", "", ""}, &defaultAttributes{"admin", "admins", "GET", "Pods", "ns2", ""}, &defaultAttributes{"admin", "admins", "GET", "Nodes", "", ""}, }, }, { // Non-resource-url tests clusterRoles: []rbac.ClusterRole{ newClusterRole("non-resource-url-getter", newRule("get", "", "", "/apis")), newClusterRole("non-resource-url", newRule("*", "", "", "/apis")), newClusterRole("non-resource-url-prefix", newRule("get", "", "", "/apis/*")), }, clusterRoleBindings: []rbac.ClusterRoleBinding{ newClusterRoleBinding("non-resource-url-getter", "User:foo", "Group:bar"), newClusterRoleBinding("non-resource-url", "User:admin", "Group:admin"), newClusterRoleBinding("non-resource-url-prefix", "User:prefixed", "Group:prefixed"), }, shouldPass: []authorizer.Attributes{ authorizer.AttributesRecord{User: &user.DefaultInfo{Name: "foo"}, Verb: "get", Path: "/apis"}, authorizer.AttributesRecord{User: &user.DefaultInfo{Groups: []string{"bar"}}, Verb: "get", Path: "/apis"}, authorizer.AttributesRecord{User: &user.DefaultInfo{Name: "admin"}, Verb: "get", Path: "/apis"}, authorizer.AttributesRecord{User: &user.DefaultInfo{Groups: []string{"admin"}}, Verb: "get", Path: "/apis"}, authorizer.AttributesRecord{User: &user.DefaultInfo{Name: "admin"}, Verb: "watch", Path: "/apis"}, authorizer.AttributesRecord{User: &user.DefaultInfo{Groups: []string{"admin"}}, Verb: "watch", Path: "/apis"}, authorizer.AttributesRecord{User: &user.DefaultInfo{Name: "prefixed"}, Verb: "get", Path: "/apis/v1"}, authorizer.AttributesRecord{User: &user.DefaultInfo{Groups: []string{"prefixed"}}, Verb: "get", Path: "/apis/v1"}, authorizer.AttributesRecord{User: &user.DefaultInfo{Name: "prefixed"}, Verb: "get", Path: "/apis/v1/foobar"}, authorizer.AttributesRecord{User: &user.DefaultInfo{Groups: []string{"prefixed"}}, Verb: "get", Path: "/apis/v1/foorbar"}, }, shouldFail: []authorizer.Attributes{ // wrong verb authorizer.AttributesRecord{User: &user.DefaultInfo{Name: "foo"}, Verb: "watch", Path: "/apis"}, authorizer.AttributesRecord{User: &user.DefaultInfo{Groups: []string{"bar"}}, Verb: "watch", Path: "/apis"}, // wrong path authorizer.AttributesRecord{User: &user.DefaultInfo{Name: "foo"}, Verb: "get", Path: "/api/v1"}, authorizer.AttributesRecord{User: &user.DefaultInfo{Groups: []string{"bar"}}, Verb: "get", Path: "/api/v1"}, authorizer.AttributesRecord{User: &user.DefaultInfo{Name: "admin"}, Verb: "get", Path: "/api/v1"}, authorizer.AttributesRecord{User: &user.DefaultInfo{Groups: []string{"admin"}}, Verb: "get", Path: "/api/v1"}, // not covered by prefix authorizer.AttributesRecord{User: &user.DefaultInfo{Name: "prefixed"}, Verb: "get", Path: "/api/v1"}, authorizer.AttributesRecord{User: &user.DefaultInfo{Groups: []string{"prefixed"}}, Verb: "get", Path: "/api/v1"}, }, }, } for i, tt := range tests { ruleResolver := validation.NewTestRuleResolver(tt.roles, tt.roleBindings, tt.clusterRoles, tt.clusterRoleBindings) a := RBACAuthorizer{tt.superUser, ruleResolver} for _, attr := range tt.shouldPass { if authorized, _, _ := a.Authorize(attr); !authorized { t.Errorf("case %d: incorrectly restricted %s", i, attr) } } for _, attr := range tt.shouldFail { if authorized, _, _ := a.Authorize(attr); authorized { t.Errorf("case %d: incorrectly passed %s", i, attr) } } } }