
Leverage the usedPVCSet in snapshot to determine whether a PVC with ReadWriteOncePod access mode is being used by another scheduled pod to achieve O(1) look up in PreFilter and avoid needing to parallel process all nodes. Signed-off-by: Yibo Zhuang <yibzhuang@gmail.com>
216 lines
8.5 KiB
Go
216 lines
8.5 KiB
Go
/*
|
|
Copyright 2019 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package volumerestrictions
|
|
|
|
import (
|
|
"context"
|
|
|
|
v1 "k8s.io/api/core/v1"
|
|
apierrors "k8s.io/apimachinery/pkg/api/errors"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
"k8s.io/apimachinery/pkg/util/sets"
|
|
corelisters "k8s.io/client-go/listers/core/v1"
|
|
v1helper "k8s.io/kubernetes/pkg/apis/core/v1/helper"
|
|
"k8s.io/kubernetes/pkg/scheduler/framework"
|
|
"k8s.io/kubernetes/pkg/scheduler/framework/plugins/feature"
|
|
"k8s.io/kubernetes/pkg/scheduler/framework/plugins/names"
|
|
)
|
|
|
|
// VolumeRestrictions is a plugin that checks volume restrictions.
|
|
type VolumeRestrictions struct {
|
|
pvcLister corelisters.PersistentVolumeClaimLister
|
|
sharedLister framework.SharedLister
|
|
enableReadWriteOncePod bool
|
|
}
|
|
|
|
var _ framework.PreFilterPlugin = &VolumeRestrictions{}
|
|
var _ framework.FilterPlugin = &VolumeRestrictions{}
|
|
var _ framework.EnqueueExtensions = &VolumeRestrictions{}
|
|
|
|
// Name is the name of the plugin used in the plugin registry and configurations.
|
|
const Name = names.VolumeRestrictions
|
|
|
|
const (
|
|
// ErrReasonDiskConflict is used for NoDiskConflict predicate error.
|
|
ErrReasonDiskConflict = "node(s) had no available disk"
|
|
// ErrReasonReadWriteOncePodConflict is used when a pod is found using the same PVC with the ReadWriteOncePod access mode.
|
|
ErrReasonReadWriteOncePodConflict = "node has pod using PersistentVolumeClaim with the same name and ReadWriteOncePod access mode"
|
|
)
|
|
|
|
// Name returns name of the plugin. It is used in logs, etc.
|
|
func (pl *VolumeRestrictions) Name() string {
|
|
return Name
|
|
}
|
|
|
|
func isVolumeConflict(volume *v1.Volume, pod *v1.Pod) bool {
|
|
for _, existingVolume := range pod.Spec.Volumes {
|
|
// Same GCE disk mounted by multiple pods conflicts unless all pods mount it read-only.
|
|
if volume.GCEPersistentDisk != nil && existingVolume.GCEPersistentDisk != nil {
|
|
disk, existingDisk := volume.GCEPersistentDisk, existingVolume.GCEPersistentDisk
|
|
if disk.PDName == existingDisk.PDName && !(disk.ReadOnly && existingDisk.ReadOnly) {
|
|
return true
|
|
}
|
|
}
|
|
|
|
if volume.AWSElasticBlockStore != nil && existingVolume.AWSElasticBlockStore != nil {
|
|
if volume.AWSElasticBlockStore.VolumeID == existingVolume.AWSElasticBlockStore.VolumeID {
|
|
return true
|
|
}
|
|
}
|
|
|
|
if volume.ISCSI != nil && existingVolume.ISCSI != nil {
|
|
iqn := volume.ISCSI.IQN
|
|
eiqn := existingVolume.ISCSI.IQN
|
|
// two ISCSI volumes are same, if they share the same iqn. As iscsi volumes are of type
|
|
// RWO or ROX, we could permit only one RW mount. Same iscsi volume mounted by multiple Pods
|
|
// conflict unless all other pods mount as read only.
|
|
if iqn == eiqn && !(volume.ISCSI.ReadOnly && existingVolume.ISCSI.ReadOnly) {
|
|
return true
|
|
}
|
|
}
|
|
|
|
if volume.RBD != nil && existingVolume.RBD != nil {
|
|
mon, pool, image := volume.RBD.CephMonitors, volume.RBD.RBDPool, volume.RBD.RBDImage
|
|
emon, epool, eimage := existingVolume.RBD.CephMonitors, existingVolume.RBD.RBDPool, existingVolume.RBD.RBDImage
|
|
// two RBDs images are the same if they share the same Ceph monitor, are in the same RADOS Pool, and have the same image name
|
|
// only one read-write mount is permitted for the same RBD image.
|
|
// same RBD image mounted by multiple Pods conflicts unless all Pods mount the image read-only
|
|
if haveOverlap(mon, emon) && pool == epool && image == eimage && !(volume.RBD.ReadOnly && existingVolume.RBD.ReadOnly) {
|
|
return true
|
|
}
|
|
}
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
// haveOverlap searches two arrays and returns true if they have at least one common element; returns false otherwise.
|
|
func haveOverlap(a1, a2 []string) bool {
|
|
if len(a1) > len(a2) {
|
|
a1, a2 = a2, a1
|
|
}
|
|
m := make(sets.String)
|
|
|
|
for _, val := range a1 {
|
|
m.Insert(val)
|
|
}
|
|
for _, val := range a2 {
|
|
if _, ok := m[val]; ok {
|
|
return true
|
|
}
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
func (pl *VolumeRestrictions) PreFilter(ctx context.Context, cycleState *framework.CycleState, pod *v1.Pod) (*framework.PreFilterResult, *framework.Status) {
|
|
if pl.enableReadWriteOncePod {
|
|
return nil, pl.isReadWriteOncePodAccessModeConflict(ctx, pod)
|
|
}
|
|
return nil, framework.NewStatus(framework.Success)
|
|
}
|
|
|
|
// isReadWriteOncePodAccessModeConflict checks if a pod uses a PVC with the ReadWriteOncePod access mode.
|
|
// This access mode restricts volume access to a single pod on a single node. Since only a single pod can
|
|
// use a ReadWriteOncePod PVC, mark any other pods attempting to use this PVC as UnschedulableAndUnresolvable.
|
|
// TODO(#103132): Mark pod as Unschedulable and add preemption logic.
|
|
func (pl *VolumeRestrictions) isReadWriteOncePodAccessModeConflict(ctx context.Context, pod *v1.Pod) *framework.Status {
|
|
for _, volume := range pod.Spec.Volumes {
|
|
if volume.PersistentVolumeClaim == nil {
|
|
continue
|
|
}
|
|
|
|
pvc, err := pl.pvcLister.PersistentVolumeClaims(pod.Namespace).Get(volume.PersistentVolumeClaim.ClaimName)
|
|
if err != nil {
|
|
if apierrors.IsNotFound(err) {
|
|
return framework.NewStatus(framework.UnschedulableAndUnresolvable, err.Error())
|
|
}
|
|
return framework.AsStatus(err)
|
|
}
|
|
|
|
if !v1helper.ContainsAccessMode(pvc.Spec.AccessModes, v1.ReadWriteOncePod) {
|
|
continue
|
|
}
|
|
|
|
key := framework.GetNamespacedName(pod.Namespace, volume.PersistentVolumeClaim.ClaimName)
|
|
if pl.sharedLister.StorageInfos().IsPVCUsedByPods(key) {
|
|
return framework.NewStatus(framework.UnschedulableAndUnresolvable, ErrReasonReadWriteOncePodConflict)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (pl *VolumeRestrictions) PreFilterExtensions() framework.PreFilterExtensions {
|
|
return nil
|
|
}
|
|
|
|
// Filter invoked at the filter extension point.
|
|
// It evaluates if a pod can fit due to the volumes it requests, and those that
|
|
// are already mounted. If there is already a volume mounted on that node, another pod that uses the same volume
|
|
// can't be scheduled there.
|
|
// This is GCE, Amazon EBS, ISCSI and Ceph RBD specific for now:
|
|
// - GCE PD allows multiple mounts as long as they're all read-only
|
|
// - AWS EBS forbids any two pods mounting the same volume ID
|
|
// - Ceph RBD forbids if any two pods share at least same monitor, and match pool and image, and the image is read-only
|
|
// - ISCSI forbids if any two pods share at least same IQN and ISCSI volume is read-only
|
|
func (pl *VolumeRestrictions) Filter(ctx context.Context, _ *framework.CycleState, pod *v1.Pod, nodeInfo *framework.NodeInfo) *framework.Status {
|
|
for i := range pod.Spec.Volumes {
|
|
v := &pod.Spec.Volumes[i]
|
|
// fast path if there is no conflict checking targets.
|
|
if v.GCEPersistentDisk == nil && v.AWSElasticBlockStore == nil && v.RBD == nil && v.ISCSI == nil {
|
|
continue
|
|
}
|
|
|
|
for _, ev := range nodeInfo.Pods {
|
|
if isVolumeConflict(v, ev.Pod) {
|
|
return framework.NewStatus(framework.Unschedulable, ErrReasonDiskConflict)
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// EventsToRegister returns the possible events that may make a Pod
|
|
// failed by this plugin schedulable.
|
|
func (pl *VolumeRestrictions) EventsToRegister() []framework.ClusterEvent {
|
|
return []framework.ClusterEvent{
|
|
// Pods may fail to schedule because of volumes conflicting with other pods on same node.
|
|
// Once running pods are deleted and volumes have been released, the unschedulable pod will be schedulable.
|
|
// Due to immutable fields `spec.volumes`, pod update events are ignored.
|
|
{Resource: framework.Pod, ActionType: framework.Delete},
|
|
// A new Node may make a pod schedulable.
|
|
{Resource: framework.Node, ActionType: framework.Add},
|
|
// Pods may fail to schedule because the PVC it uses has not yet been created.
|
|
// This PVC is required to exist to check its access modes.
|
|
{Resource: framework.PersistentVolumeClaim, ActionType: framework.Add | framework.Update},
|
|
}
|
|
}
|
|
|
|
// New initializes a new plugin and returns it.
|
|
func New(_ runtime.Object, handle framework.Handle, fts feature.Features) (framework.Plugin, error) {
|
|
informerFactory := handle.SharedInformerFactory()
|
|
pvcLister := informerFactory.Core().V1().PersistentVolumeClaims().Lister()
|
|
sharedLister := handle.SnapshotSharedLister()
|
|
|
|
return &VolumeRestrictions{
|
|
pvcLister: pvcLister,
|
|
sharedLister: sharedLister,
|
|
enableReadWriteOncePod: fts.EnableReadWriteOncePod,
|
|
}, nil
|
|
}
|